kitodo / kitodo-publication

Classes/Domain/Model/ProcessNumber.php

Spacing +1 added lines, -1 removed lines

@@ -106,6 +106,6 @@
     }
 
     public function getProcessNumberString() {
-        return strtoupper($this->getOwnerId()).'-'. $this->getYear().'-'.$this->getCounter();
+        return strtoupper($this->getOwnerId()) . '-' . $this->getYear() . '-' . $this->getCounter();
     }
 }
\ No newline at end of file

Braces +6 added lines, -12 removed lines

@@ -47,8 +47,7 @@ 
      *
      * @return string $ownerId
      */
-    public function getOwnerId()
-    {
+    public function getOwnerId() {
         return $this->ownerId;
     }
 
@@ -58,8 +57,7 @@ 
      * @param string $ownerId
      * @return void
      */
-    public function setOwnerId($ownerId)
-    {
+    public function setOwnerId($ownerId) {
         $this->ownerId = $ownerId;
     }
 
@@ -68,8 +66,7 @@ 
      *
      * @return int $year
      */
-    public function getYear()
-    {
+    public function getYear() {
         return $this->year;
     }
 
@@ -79,8 +76,7 @@ 
      * @param int $year
      * @return void
      */
-    public function setYear($year)
-    {
+    public function setYear($year) {
         $this->year = $year;
     }
 
@@ -89,8 +85,7 @@ 
      *
      * @return int $counter
      */
-    public function getCounter()
-    {
+    public function getCounter() {
         return $this->counter;
     }
 
@@ -100,8 +95,7 @@ 
      * @param int $counter
      * @return void
      */
-    public function setCounter($counter)
-    {
+    public function setCounter($counter) {
         $this->counter = $counter;
     }
 

Classes/Plugins/DownloadTool/DownloadTool.php

Indentation -1 removed lines

@@ -107,7 +107,6 @@
 
     /**
      * Get PDF document list
-
      * @return array of attachments
      */
     protected function getAttachments()

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -46,7 +46,7 @@ 
 
         if (is_array($dpfTSconfig['settings.'])) {
 
-            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, true, false);
+            \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($dpfTSconfig['settings.'], $this->conf, TRUE, FALSE);
             $this->conf = $dpfTSconfig['settings.'];
 
         }
@@ -54,7 +54,7 @@ 
         // Load current document.
         $this->loadDocument();
 
-        if ($this->doc === null || empty($this->conf['fileGrpDownload'])) {
+        if ($this->doc === NULL || empty($this->conf['fileGrpDownload'])) {
 
             // Quit without doing anything if required variables are not set.
             return $content;
@@ -87,7 +87,7 @@ 
                     'useCacheHash'     => 0,
                     'parameter'        => $this->conf['apiPid'] . ' - piwik_download',
                     'additionalParams' => '&tx_dpf[qid]=' . $this->doc->recordId . '&tx_dpf[action]=attachment' . '&tx_dpf[attachment]=' . $file['ID'],
-                    'forceAbsoluteUrl' => true,
+                    'forceAbsoluteUrl' => TRUE,
                 );
 
                 $title = $file['LABEL'] ? $file['LABEL'] : $file['ID'];
@@ -101,7 +101,7 @@ 
 
         }
 
-        return $this->cObj->substituteSubpart($this->template, '###DOWNLOADS###', $content, true);
+        return $this->cObj->substituteSubpart($this->template, '###DOWNLOADS###', $content, TRUE);
 
     }
 

Spacing +6 added lines, -6 removed lines

@@ -87,7 +87,7 @@ 
 
             foreach ($attachments as $id => $file) {
 
-                $conf = array(
+                $conf = array (
                     'useCacheHash'     => 0,
                     'parameter'        => $this->conf['apiPid'] . ' - piwik_download',
                     'additionalParams' => '&tx_dpf[qid]=' . $this->doc->recordId . '&tx_dpf[action]=attachment' . '&tx_dpf[attachment]=' . $file['ID'],
@@ -103,11 +103,11 @@ 
                     $markerArray['###FILE###'] = $this->cObj->typoLink($title, $conf);
 
                     // Create a-tag with VG-Wort Redirect
-                } elseif(!empty($vgwort)) {
+                } elseif (!empty($vgwort)) {
 
                     $qucosaUrl = urlencode($this->cObj->typoLink_URL($conf));
 
-                    $confVgwort = array(
+                    $confVgwort = array (
                         'useCacheHash'     => 0,
                         'parameter'        => $vgwort . $qucosaUrl . ' - piwik_download',
                     );
@@ -141,13 +141,13 @@ 
 
         if (!is_array($files)) {
 
-            return array();
+            return array ();
 
         }
 
         foreach ($files as $key => $file) {
 
-            $singleFile = array();
+            $singleFile = array ();
 
             foreach ($file->attributes('mext', 1) as $attribute => $value) {
 
@@ -182,7 +182,7 @@ 
         $xPath = '//slub:info/slub:vgwortOpenKey';
         $vgwortOpenKey = $this->doc->mets->xpath($xPath)[0];
 
-        if (!empty($vgwortOpenKey) or $vgwortOpenKey != FALSE ) {
+        if (!empty($vgwortOpenKey) or $vgwortOpenKey != FALSE) {
 
             if (GeneralUtility::getIndpEnv('TYPO3_SSL')) {
 

Braces +4 added lines, -8 removed lines

@@ -24,8 +24,7 @@ 
  * @subpackage    tx_dpf
  * @access    public
  */
-class DownloadTool extends \tx_dlf_plugin
-{
+class DownloadTool extends \tx_dlf_plugin {
 
     /**
      * The main method of the PlugIn
@@ -37,8 +36,7 @@ 
      *
      * @return    string        The content that is displayed on the website
      */
-    public function main($content, $conf)
-    {
+    public function main($content, $conf) {
 
         $this->init($conf);
 
@@ -131,8 +129,7 @@ 
 
      * @return array of attachments
      */
-    protected function getAttachments()
-    {
+    protected function getAttachments() {
 
         // Get pdf documents
         $xPath = 'mets:fileSec/mets:fileGrp[@USE="' . $this->conf['fileGrpDownload'] . '"]/mets:file';
@@ -174,8 +171,7 @@ 
         return $attachments;
     }
 
-    protected function getVGWortUrl()
-    {
+    protected function getVGWortUrl() {
 
         // Get VG-Wort-OpenKey for document
         $this->doc->mets->registerXPathNamespace("slub", 'http://slub-dresden.de/');

Classes/Services/ProcessNumber/ProcessNumberGenerator.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
             $datetime = new \DateTime();
             $currentYear = $datetime->format('y');
 
-            $processNumber = $processNumberRepository->getHighestProcessNumberByOwnerIdAndYear(strtolower($ownerId),$currentYear);
+            $processNumber = $processNumberRepository->getHighestProcessNumberByOwnerIdAndYear(strtolower($ownerId), $currentYear);
 
             if ($processNumber) {
                 $counter = $processNumber->getCounter() + 1;

Braces +1 added lines, -2 removed lines

@@ -20,8 +20,7 @@
 use EWW\Dpf\Domain\Model\ProcessNumber;
 use EWW\Dpf\Domain\Repository\ClientRepository;
 
-class ProcessNumberGenerator
-{
+class ProcessNumberGenerator {
     public function getProcessNumber($ownerId = NULL) {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $processNumberRepository = $objectManager->get(ProcessNumberRepository::class);

Classes/Services/Transfer/FedoraRepository.php

Indentation +5 added lines, -5 removed lines

@@ -35,11 +35,11 @@
     protected $documentTransferLogRepository;
 
     /**
-    * clientConfigurationManager
-    *
-    * @var \EWW\Dpf\Configuration\ClientConfigurationManager
-    * @inject
-    */
+     * clientConfigurationManager
+     *
+     * @var \EWW\Dpf\Configuration\ClientConfigurationManager
+     * @inject
+     */
     protected $clientConfigurationManager;
 
     /**

Braces +10 added lines, -20 removed lines

@@ -22,8 +22,7 @@ 
 use \EWW\Dpf\Services\Logger\TransferLogger;
 use \Httpful\Request;
 
-class FedoraRepository implements Repository
-{
+class FedoraRepository implements Repository {
 
     /**
      * documentTransferLogRepository
@@ -64,8 +63,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function ingest($document, $metsXml)
-    {
+    public function ingest($document, $metsXml) {
         try {
 
             $response = Request::post($this->clientConfigurationManager->getSwordHost() . "/sword/" . $this->getSWORDCollection())
@@ -84,8 +82,7 @@ 
                 TransferLogger::Log('INGEST', $document->getUid(), null, $response);
                 throw new \EWW\Dpf\Exceptions\IngestDocumentErrorException("Fedora error while ingest document.");
             }
-        }
-        catch (\Exception $exception) {
+        } catch (\Exception $exception) {
             TransferLogger::Log('INGEST', $document->getUid(), null, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
@@ -111,8 +108,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function update($document, $metsXml)
-    {
+    public function update($document, $metsXml) {
 
         $remoteId = $document->getObjectIdentifier();
 
@@ -157,8 +153,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function retrieve($remoteId)
-    {
+    public function retrieve($remoteId) {
 
         try {
             $response = Request::get($this->clientConfigurationManager->getFedoraHost() . "/fedora/objects/" . $remoteId . "/methods/qucosa:SDef/getMETSDissemination")
@@ -198,8 +193,7 @@ 
      * @return string
      * @throws \Exception
      */
-    public function getNextDocumentId()
-    {
+    public function getNextDocumentId() {
         try {
             $response = Request::get($this->clientConfigurationManager->getFedoraHost() . "/fedora/management/getNextPID?numPIDs=1&namespace=qucosa&xml=true")
                 ->authenticateWith($this->clientConfigurationManager->getFedoraUser(), $this->clientConfigurationManager->getFedoraPassword())
@@ -240,8 +234,7 @@ 
      * @return boolean
      * @throws \Exception
      */
-    public function delete($document, $state)
-    {
+    public function delete($document, $state) {
 
         $remoteId = $document->getObjectIdentifier();
 
@@ -294,8 +287,7 @@ 
      * @param  \Httpful\Response $response
      * @return string
      */
-    protected function getRemoteDocumentId($response)
-    {
+    protected function getRemoteDocumentId($response) {
 
         // Get repository ID and write into document
         $responseDom = new \DOMDocument();
@@ -312,8 +304,7 @@ 
         return null;
     }
 
-    protected function getOwnerId()
-    {
+    protected function getOwnerId() {
         $ownerId = $this->clientConfigurationManager->getOwnerId();
         if (empty($ownerId)) {
             throw new \Exception('Owner id can not be empty or null!');
@@ -322,8 +313,7 @@ 
         return $ownerId;
     }
 
-    protected function getSWORDCollection()
-    {
+    protected function getSWORDCollection() {
         return $this->clientConfigurationManager->getSwordCollectionNamespace();
     }
 }

Upper-Lower-Casing +15 added lines, -15 removed lines

@@ -81,12 +81,12 @@ 
             if (!$response->hasErrors() && $response->code == 201) {
                 return $this->getRemoteDocumentId($response);
             } else {
-                TransferLogger::Log('INGEST', $document->getUid(), null, $response);
+                TransferLogger::Log('INGEST', $document->getUid(), NULL, $response);
                 throw new \EWW\Dpf\Exceptions\IngestDocumentErrorException("Fedora error while ingest document.");
             }
         }
         catch (\Exception $exception) {
-            TransferLogger::Log('INGEST', $document->getUid(), null, $exception->getMessage());
+            TransferLogger::Log('INGEST', $document->getUid(), NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -100,7 +100,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -133,7 +133,7 @@ 
                 throw new \EWW\Dpf\Exceptions\UpdateDocumentErrorException("Fedora error while update document.");
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('UPDATE', $document->getUid(), null, $exception->getMessage());
+            TransferLogger::Log('UPDATE', $document->getUid(), NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -147,7 +147,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -170,11 +170,11 @@ 
             if (!$response->hasErrors() && $response->code == 200) {
                 return $response->__toString();
             } else {
-                TransferLogger::Log('RETRIEVE', null, $remoteId, $response);
+                TransferLogger::Log('RETRIEVE', NULL, $remoteId, $response);
                 throw new \EWW\Dpf\Exceptions\RetrieveDocumentErrorException("Fedora has returned an error.");
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('RETRIEVE', null, $remoteId, $exception->getMessage());
+            TransferLogger::Log('RETRIEVE', NULL, $remoteId, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -188,7 +188,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -211,11 +211,11 @@ 
             if (!$response->hasErrors() && $response->code == 200) {
                 return $response->__toString();
             } else {
-                TransferLogger::Log('GET_NEXT_DOCUMENT_ID', null, null, $response);
+                TransferLogger::Log('GET_NEXT_DOCUMENT_ID', NULL, NULL, $response);
                 throw new \EWW\Dpf\Exceptions\NextDocumentIdErrorException("Fedora error while getting a document id.");
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('GET_NEXT_DOCUMENT_ID', null, null, $exception->getMessage());
+            TransferLogger::Log('GET_NEXT_DOCUMENT_ID', NULL, NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -229,7 +229,7 @@ 
             }
         }
 
-        return null;
+        return NULL;
     }
 
     /**
@@ -255,7 +255,7 @@ 
 
             // if transfer successful
             if (!$response->hasErrors() && $response->code == 204) {
-                return true;
+                return TRUE;
             } else {
                 TransferLogger::Log('DELETE', $document->getUid(), $remoteId, $response);
                 switch ($state) {
@@ -271,7 +271,7 @@ 
                 }
             }
         } catch (\Exception $exception) {
-            TransferLogger::Log('DELETE', $document->getUid(), null, $exception->getMessage());
+            TransferLogger::Log('DELETE', $document->getUid(), NULL, $exception->getMessage());
 
             if ($exception instanceof \Httpful\Exception\ConnectionErrorException) {
                 $message = $exception->getMessage();
@@ -285,7 +285,7 @@ 
             }
         }
 
-        return false;
+        return FALSE;
     }
 
     /**
@@ -309,7 +309,7 @@ 
             return $objectIdentifier;
         }
 
-        return null;
+        return NULL;
     }
 
     protected function getOwnerId()

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
 
     protected $response;
 
-    protected $errors = array();
+    protected $errors = array ();
 
     const X_ON_BEHALF_OF = 'X-On-Behalf-Of';
     const QUCOSA_TYPE    = 'application/vnd.qucosa.mets+xml';
@@ -229,7 +229,7 @@ 
 
         $remoteId = $document->getObjectIdentifier();
 
-        $stateParam = ($state)? "?" . $state : "";
+        $stateParam = ($state) ? "?" . $state : "";
 
         try {
             $response = Request::delete($this->clientConfigurationManager->getSwordHost() . "/sword/" . $this->getSWORDCollection() . "/" . $remoteId . $stateParam)

Classes/Services/MetsExporter.php

Indentation +1 added lines, -1 removed lines

@@ -439,7 +439,7 @@
 
                 $domXPath2 = \EWW\Dpf\Helper\XPath::create($doc2);
 
-                  // second part nested xpath
+                    // second part nested xpath
                 if ($match[2] && $secondMatch[2]) {
                     // import node from nested
                     $docXMLNested = new \DOMDocument();

Spacing +4 added lines, -4 removed lines

@@ -24,13 +24,13 @@ 
      *
      * @var array
      */
-    protected $formData = array();
+    protected $formData = array ();
 
     /**
      * files from form
      * @var array
      */
-    protected $files = array();
+    protected $files = array ();
 
     /**
      * metsData
@@ -368,7 +368,7 @@ 
                     $nestedXml = $this->parseXPath($nested);
 
                     // object xpath without nested element []
-                    $newPath[1] = str_replace('['.$match[2].']', '', $newPath[1]);
+                    $newPath[1] = str_replace('[' . $match[2] . ']', '', $newPath[1]);
 
                     $xml = $this->parseXPath($newPath[1]);
 
@@ -429,7 +429,7 @@ 
                     $nestedXml = $this->parseXPath($nested);
 
                     // object xpath without nested element []
-                    $newPath[1] = str_replace('['.$match[2].']', '', $newPath[1]);
+                    $newPath[1] = str_replace('[' . $match[2] . ']', '', $newPath[1]);
 
                     $xml2 = $this->parseXPath($path . $newPath[1]);
                 }

Upper-Lower-Casing +35 added lines, -35 removed lines

@@ -72,13 +72,13 @@ 
     /**
      * simpleXMLElement
      */
-    protected $sxe = null;
+    protected $sxe = NULL;
 
     /**
      * xPathXMLGenerator
      * @var object
      */
-    protected $parser = null;
+    protected $parser = NULL;
 
     /**
      * ref id counter
@@ -172,26 +172,26 @@ 
         $xmlData = $modsWrap->firstChild->firstChild->firstChild->firstChild;
 
         // import mods into mets
-        $nodeAppendModsData = $modsWrap->importNode($this->modsData->firstChild, true);
+        $nodeAppendModsData = $modsWrap->importNode($this->modsData->firstChild, TRUE);
         $xmlData->appendChild($nodeAppendModsData);
 
         // add SLUB data
-        $nodeAppendModsData = $modsWrap->importNode($this->buildMetsSlub()->firstChild, true);
+        $nodeAppendModsData = $modsWrap->importNode($this->buildMetsSlub()->firstChild, TRUE);
         $modsWrap->firstChild->appendChild($nodeAppendModsData);
 
         if ($fileSection) {
             // add filesection
-            $nodeAppendModsData = $modsWrap->importNode($fileSection->firstChild->firstChild, true);
+            $nodeAppendModsData = $modsWrap->importNode($fileSection->firstChild->firstChild, TRUE);
             $modsWrap->firstChild->appendChild($nodeAppendModsData);
         }
 
         if ($structureMap) {
             // add structure map
-            $nodeAppendModsData = $modsWrap->importNode($structureMap->firstChild->firstChild, true);
+            $nodeAppendModsData = $modsWrap->importNode($structureMap->firstChild->firstChild, TRUE);
             $modsWrap->firstChild->appendChild($nodeAppendModsData);
         }
 
-        $modsWrap->formatOutput = true;
+        $modsWrap->formatOutput = TRUE;
         $modsWrap->encoding     = 'UTF-8';
 
         $this->metsData = $modsWrap;
@@ -253,28 +253,28 @@ 
                 $attributeXPath .= '[@ID="QUCOSA_' . $counter . '"]';
             }
 
-            $existsExtensionFlag = false;
+            $existsExtensionFlag = FALSE;
             $i                   = 0;
             // loop each object
             if (!empty($values)) {
                 foreach ($values as $value) {
 
                     if ($value['modsExtension']) {
-                        $existsExtensionFlag = true;
+                        $existsExtensionFlag = TRUE;
                         // mods extension
                         $counter            = sprintf("%'03d", $this->counter);
                         $referenceAttribute = $extensionAttribute . '[@' . $group['modsExtensionReference'] . '="QUCOSA_' . $counter . '"]';
 
                         $path = $group['modsExtensionMapping'] . $referenceAttribute . '%/' . $value['mapping'];
 
-                        $xml = $this->customXPath($path, false, $value['value']);
+                        $xml = $this->customXPath($path, FALSE, $value['value']);
                     } else {
                         $path = $mapping . $attributeXPath . '%/' . $value['mapping'];
 
                         if ($i == 0) {
-                            $newGroupFlag = true;
+                            $newGroupFlag = TRUE;
                         } else {
-                            $newGroupFlag = false;
+                            $newGroupFlag = FALSE;
                         }
 
                         $xml = $this->customXPath($path, $newGroupFlag, $value['value']);
@@ -286,12 +286,12 @@ 
             } else {
                 if (!empty($attributeXPath)) {
                     $path = $mapping . $attributeXPath;
-                    $xml  = $this->customXPath($path, true, '', true);
+                    $xml  = $this->customXPath($path, TRUE, '', TRUE);
                 }
             }
             if (!$existsExtensionFlag && $group['modsExtensionMapping']) {
                 $xPath = $group['modsExtensionMapping'] . $extensionAttribute . '[@' . $group['modsExtensionReference'] . '="QUCOSA_' . $counter . '"]';
-                $xml   = $this->customXPath($xPath, true, '', true);
+                $xml   = $this->customXPath($xPath, TRUE, '', TRUE);
             }
             if ($group['modsExtensionMapping']) {
                 $this->counter++;
@@ -321,13 +321,13 @@ 
      * @param  string $value form value
      * @return xml    created xml
      */
-    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
+    public function customXPath($xPath, $newGroupFlag = FALSE, $value = '', $attributeOnly = FALSE)
     {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
 
-            $praedicateFlag = false;
+            $praedicateFlag = FALSE;
             $explodedXPath  = explode('[', $newPath[0]);
             if (count($explodedXPath) > 1) {
                 // praedicate is given
@@ -339,7 +339,7 @@ 
                     $path = $explodedXPath[0];
                 }
 
-                $praedicateFlag = true;
+                $praedicateFlag = TRUE;
             } else {
                 $path = $newPath[0];
             }
@@ -389,7 +389,7 @@ 
                     $nodeList = $xPath->query('/mods:mods' . $match[1]);
                     $node = $nodeList->item(0);
 
-                    $importNode = $docXML->importNode($docXMLNested->getElementsByTagName("mods")->item(0)->firstChild, true);
+                    $importNode = $docXML->importNode($docXMLNested->getElementsByTagName("mods")->item(0)->firstChild, TRUE);
 
                     $node->appendChild($importNode);
                 }
@@ -400,7 +400,7 @@ 
 
                 $node = $domNodeList->item(0)->firstChild;
 
-                $nodeAppendModsData = $this->xmlData->importNode($node, true);
+                $nodeAppendModsData = $this->xmlData->importNode($node, TRUE);
                 $domNode->item($domNode->length - 1)->appendChild($nodeAppendModsData);
             } else {
                 // first xpath doesn't exist
@@ -448,7 +448,7 @@ 
                     $nodeList = $xPath->query('/mods:mods/' . $path . $match[1]);
                     $node = $nodeList->item(0);
 
-                    $importNode = $doc2->importNode($docXMLNested->getElementsByTagName("mods")->item(0)->firstChild, true);
+                    $importNode = $doc2->importNode($docXMLNested->getElementsByTagName("mods")->item(0)->firstChild, TRUE);
 
                     $node->appendChild($importNode);
                 }
@@ -456,7 +456,7 @@ 
                 $domNode2 = $domXPath2->query('/mods:mods/' . $path)->item(0)->childNodes->item(0);
 
                 // merge xml nodes
-                $nodeToBeAppended = $doc1->importNode($domNode2, true);
+                $nodeToBeAppended = $doc1->importNode($domNode2, TRUE);
 
                 $domNode->item(0)->appendChild($nodeToBeAppended);
 
@@ -465,7 +465,7 @@ 
                 $firstChild = $this->xmlData->firstChild;
                 $firstItem  = $doc1->getElementsByTagName('mods')->item(0)->firstChild;
 
-                $nodeAppendModsData = $this->xmlData->importNode($firstItem, true);
+                $nodeAppendModsData = $this->xmlData->importNode($firstItem, TRUE);
                 $firstChild->appendChild($nodeAppendModsData);
 
                 return $doc1->saveXML();
@@ -484,7 +484,7 @@ 
 
             $node = $domNodeList->item(0)->firstChild;
 
-            $nodeAppendModsData = $this->xmlData->importNode($node, true);
+            $nodeAppendModsData = $this->xmlData->importNode($node, TRUE);
             $domNode->item($domNode->length - 1)->appendChild($nodeAppendModsData);
 
             return $docXML->saveXML();
@@ -493,13 +493,13 @@ 
         return $this->xmlData->saveXML();
     }
 
-    public function customXPathSlub($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
+    public function customXPathSlub($xPath, $newGroupFlag = FALSE, $value = '', $attributeOnly = FALSE)
     {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
 
-            $praedicateFlag = false;
+            $praedicateFlag = FALSE;
             $explodedXPath  = explode('[', $newPath[0]);
             if (count($explodedXPath) > 1) {
                 // praedicate is given
@@ -511,7 +511,7 @@ 
                     $path = $explodedXPath[0];
                 }
 
-                $praedicateFlag = true;
+                $praedicateFlag = TRUE;
             } else {
                 $path = $newPath[0];
             }
@@ -538,7 +538,7 @@ 
 
                 $node = $domNodeList->item(0)->firstChild;
 
-                $nodeAppendModsData = $this->xmlData->importNode($node, true);
+                $nodeAppendModsData = $this->xmlData->importNode($node, TRUE);
                 $domNode->item($domNode->length - 1)->appendChild($nodeAppendModsData);
             } else {
                 // first xpath doesn't exist
@@ -567,7 +567,7 @@ 
                 $domNode2 = $domXPath2->query('/slub:info/' . $path)->item(0)->childNodes->item(0);
 
                 // merge xml nodes
-                $nodeToBeAppended = $doc1->importNode($domNode2, true);
+                $nodeToBeAppended = $doc1->importNode($domNode2, TRUE);
 
                 $domNode->item(0)->appendChild($nodeToBeAppended);
 
@@ -577,7 +577,7 @@ 
                 $firstChild = $this->xmlData->firstChild;
                 $firstItem  = $doc1->getElementsByTagName('info')->item(0)->firstChild;
 
-                $nodeAppendModsData = $this->xmlData->importNode($firstItem, true);
+                $nodeAppendModsData = $this->xmlData->importNode($firstItem, TRUE);
                 $firstChild->appendChild($nodeAppendModsData);
 
                 return $doc1->saveXML();
@@ -596,7 +596,7 @@ 
 
             $node = $domNodeList->item(0)->firstChild;
 
-            $nodeAppendModsData = $this->xmlData->importNode($node, true);
+            $nodeAppendModsData = $this->xmlData->importNode($node, TRUE);
             $domNode->item($domNode->length - 1)->appendChild($nodeAppendModsData);
 
             return $docXML->saveXML();
@@ -846,7 +846,7 @@ 
         $second = $this->slubData;
 
         foreach ($second->childNodes as $node) {
-            $importNode = $domDocument->importNode($node, true);
+            $importNode = $domDocument->importNode($node, TRUE);
             $domWrapElement->appendChild($importNode);
         }
 
@@ -902,14 +902,14 @@ 
 
                             $path = $group['modsExtensionMapping'] . $referenceAttribute . '%/' . $value['mapping'];
 
-                            $xml = $this->customXPathSlub($path, false, $value['value']);
+                            $xml = $this->customXPathSlub($path, FALSE, $value['value']);
                         } else {
                             $path = $mapping . $attributeXPath . '%/' . $value['mapping'];
 
                             if ($i == 0) {
-                                $newGroupFlag = true;
+                                $newGroupFlag = TRUE;
                             } else {
-                                $newGroupFlag = false;
+                                $newGroupFlag = FALSE;
                             }
 
                             $xml = $this->customXPathSlub($path, $newGroupFlag, $value['value']);
@@ -922,7 +922,7 @@ 
                 } else {
                     if (!empty($attributeXPath)) {
                         $path = $mapping . $attributeXPath;
-                        $xml  = $this->customXPathSlub($path, true, '', true);
+                        $xml  = $this->customXPathSlub($path, TRUE, '', TRUE);
                     }
                 }
 

Braces +24 added lines, -48 removed lines

@@ -17,8 +17,7 @@ 
 /**
  * MetsExporter
  */
-class MetsExporter
-{
+class MetsExporter {
     /**
      * formData
      *
@@ -96,8 +95,7 @@ 
     /**
      * Constructor
      */
-    public function __construct()
-    {
+    public function __construct() {
         // mets data beginning
         $this->metsHeader = '<mets:mets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                             xmlns:mets="http://www.loc.gov/METS/" xmlns:xlink="http://www.w3.org/1999/xlink"
@@ -138,8 +136,7 @@ 
      * returns the mets xml string
      * @return string mets xml
      */
-    public function getMetsData()
-    {
+    public function getMetsData() {
         $xml = $this->metsData->saveXML();
 
         $xml = preg_replace("/eww=\"\d-\d-\d\"/", '${1}${2}${3}', $xml);
@@ -152,8 +149,7 @@ 
      * returns the mods xml string
      * @return string mods xml
      */
-    public function getModsData()
-    {
+    public function getModsData() {
         return $this->modsData->saveXML();
     }
 
@@ -161,8 +157,7 @@ 
      * Build mets data structure
      * @return string mets xml
      */
-    public function buildMets()
-    {
+    public function buildMets() {
         // get mods domDocument
         $modsWrap = $this->buildModsWrap();
         // get mets filesection
@@ -203,8 +198,7 @@ 
      * @param  xml $xml xml data which should be wrapped with mods
      * @return xml wrapped xml
      */
-    public function wrapMods($xml)
-    {
+    public function wrapMods($xml) {
         $newXML = $this->modsHeader;
 
         $newXML = str_replace("</mods:mods>", $xml . "</mods:mods>", $newXML);
@@ -212,8 +206,7 @@ 
         return $newXML;
     }
 
-    public function wrapSlub($xml)
-    {
+    public function wrapSlub($xml) {
         $newXML = $this->slubHeader;
 
         $newXML = str_replace("</slub:info>", $xml . "</slub:info>", $newXML);
@@ -225,8 +218,7 @@ 
      * build mods from form array
      * @param array $array structured form data array
      */
-    public function buildModsFromForm($array)
-    {
+    public function buildModsFromForm($array) {
         $this->xmlData = $this->modsData;
         // Build xml mods from form fields
         // loop each group
@@ -308,8 +300,7 @@ 
      * @param  xpath $xPath xPath expression
      * @return xml
      */
-    public function parseXPath($xPath)
-    {
+    public function parseXPath($xPath) {
 
         $this->parser->generateXmlFromXPath($xPath);
         $xml = $this->parser->getXML();
@@ -323,8 +314,7 @@ 
      * @param  string $value form value
      * @return xml    created xml
      */
-    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
-    {
+    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false) {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
@@ -495,8 +485,7 @@ 
         return $this->xmlData->saveXML();
     }
 
-    public function customXPathSlub($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
-    {
+    public function customXPathSlub($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false) {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
@@ -610,8 +599,7 @@ 
      * Builds the xml wrapping part for mods
      * @return xml
      */
-    public function buildModsWrap()
-    {
+    public function buildModsWrap() {
         // Build wrap for mod
 
         $domDocument = new \DOMDocument();
@@ -649,8 +637,7 @@ 
      * Builds xml amdSection
      * @return xml
      */
-    public function buildAmdSection()
-    {
+    public function buildAmdSection() {
         // Build xml amd:sec
 
         $domDocument = new \DOMDocument();
@@ -661,8 +648,7 @@ 
         $amdSec = $domDocument->createElement('mets:amdSec');
     }
 
-    public function setMods($value = '')
-    {
+    public function setMods($value = '') {
         $domDocument = new \DOMDocument();
         if (is_null(@$domDocument->loadXML($value))) {
             throw new \Exception("Couldn't load MODS data");
@@ -670,13 +656,11 @@ 
         $this->modsData = $domDocument;
     }
 
-    public function setFileData($value = '')
-    {
+    public function setFileData($value = '') {
         $this->files = $value;
     }
 
-    public function loopFiles($array, $domElement, $domDocument)
-    {
+    public function loopFiles($array, $domElement, $domDocument) {
         $i = 0;
         // set xml for uploded files
         foreach ($array as $key => $value) {
@@ -721,8 +705,7 @@ 
      * Builds the xml fileSection part if files are uploaded
      * @return xml
      */
-    public function buildFileSection()
-    {
+    public function buildFileSection() {
         if (empty($this->files['original']) && empty($this->files['download'])) {
             return;
         }
@@ -769,8 +752,7 @@ 
      * Builds the xml structMap part if files are uploaded
      * @return xml
      */
-    public function buildStructureMap()
-    {
+    public function buildStructureMap() {
         // Build xml Mets:structMap
 
         $domDocument = new \DOMDocument();
@@ -809,8 +791,7 @@ 
         return $domDocument;
     }
 
-    public function setSlubInfo($value = '')
-    {
+    public function setSlubInfo($value = '') {
         // build DOMDocument with slub xml
         $domDocument = new \DOMDocument();
         $domDocument->loadXML($value);
@@ -822,8 +803,7 @@ 
      * @param  Array $array Array with slub information
      * @return xml        xml slubInfo
      */
-    public function buildMetsSlub()
-    {
+    public function buildMetsSlub() {
         $domDocument = new \DOMDocument();
         $domDocument->loadXML('<mets:amdSec ID="AMD_000" xmlns:mets="http://www.loc.gov/METS/"></mets:amdSec>');
         $domWrapElement = $domDocument->firstChild;
@@ -864,8 +844,7 @@ 
      * returns the mods xml string
      * @return string mods xml
      */
-    public function getSlubData()
-    {
+    public function getSlubData() {
         return $this->slubData->saveXML();
     }
 
@@ -873,8 +852,7 @@ 
      *
      * @param string $slubInfoData
      */
-    public function buildSlubInfoFromForm($slubInfoData, $documentType, $processNumber)
-    {
+    public function buildSlubInfoFromForm($slubInfoData, $documentType, $processNumber) {
         $this->xmlData = $this->slubData;
         if (is_array($slubInfoData['metadata'])) {
             foreach ($slubInfoData['metadata'] as $key => $group) {
@@ -957,8 +935,7 @@ 
      *
      * @return string slub info xml
      */
-    public function getSlubInfoData()
-    {
+    public function getSlubInfoData() {
         return $this->slubData->saveXML();
     }
 
@@ -967,8 +944,7 @@ 
      * @param string $objId
      * @return void
      */
-    public function setObjId($objId)
-    {
+    public function setObjId($objId) {
         $this->objId = $objId;
     }
 }

Classes/Controller/SearchFEController.php

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
             $this->currentPage = 1;
         } else {
             // restore query
-            $this->query = (!empty($session[$this->action]['query'])) ? $session[$this->action]['query'] : array();
+            $this->query = (!empty($session[$this->action]['query'])) ? $session[$this->action]['query'] : array ();
             // set current page
             if ((!empty($currentPage))) {
                 $this->currentPage = MathUtility::forceIntegerInRange($currentPage, 1);
@@ -197,8 +197,8 @@ 
      */
     private function viewAssign()
     {
-        $this->view->assign('query',       $this->query);
-        $this->view->assign('resultList',  $this->resultList);
+        $this->view->assign('query', $this->query);
+        $this->view->assign('resultList', $this->resultList);
         $this->view->assign('currentPage', $this->currentPage);
     }
 }

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -124,7 +124,7 @@ 
                 $message,
                 '',
                 $severity,
-                true
+                TRUE
             );
         }
     }
@@ -155,7 +155,7 @@ 
                 $message,
                 '',
                 $severity,
-                true
+                TRUE
             );
         }
     }

Braces +11 added lines, -22 removed lines

@@ -19,8 +19,7 @@ 
 /**
  * SearchFEController
  */
-class SearchFEController extends \EWW\Dpf\Controller\AbstractSearchController
-{
+class SearchFEController extends \EWW\Dpf\Controller\AbstractSearchController {
 
     /**
      * action
@@ -63,8 +62,7 @@ 
     /**
      * __construct
      */
-    public function __construct()
-    {
+    public function __construct() {
         // get session data
         $session = $this->getSessionData('tx_dpf_frontendsearch');
         // get action
@@ -105,8 +103,7 @@ 
      * @return void
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException
      */
-    public function initializeSearchAction()
-    {
+    public function initializeSearchAction() {
         if ($this->action == 'extendedSearch') {
             $this->forward('extendedSearch');
         }
@@ -116,8 +113,7 @@ 
      * action search
      * @return void
      */
-    public function searchAction()
-    {
+    public function searchAction() {
         try {
             if (!empty($this->query['fulltext'])) {
                 $query = $this->searchFulltext($this->query['fulltext']);
@@ -145,8 +141,7 @@ 
      * @return void
      * @throws \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException
      */
-    public function initializeExtendedSearchAction()
-    {
+    public function initializeExtendedSearchAction() {
         if ($this->action == 'search') {
             $this->forward('search');
         }
@@ -156,8 +151,7 @@ 
      * action extendedSearch
      * @return void
      */
-    public function extendedSearchAction()
-    {
+    public function extendedSearchAction() {
         try {
             $this->docTypes();
             if (!empty(implode('', $this->query))) {
@@ -185,8 +179,7 @@ 
      * @param  array $query
      * @return array $results
      */
-    private function getResults($query)
-    {
+    private function getResults($query) {
         $size = $this->settings['list']['paginate']['itemsPerPage'];
 
         $query['body']['from'] = ($this->currentPage - 1) * $size;
@@ -202,8 +195,7 @@ 
      * dummy action for showSearchForm Action used in sidebar
      * @return void
      */
-    public static function showSearchFormAction()
-    {
+    public static function showSearchFormAction() {
 
     }
 
@@ -211,8 +203,7 @@ 
      * set session data
      * @return void
      */
-    private function setSession()
-    {
+    private function setSession() {
         $session[$this->action] = array (
                 'query'       => $this->query,
                 'currentPage' => $this->currentPage
@@ -224,8 +215,7 @@ 
      * create docTypes
      * @return void
      */
-    private function docTypes()
-    {
+    private function docTypes() {
         // get document types
         $allTypes = $this->documentTypeRepository->findAll();
         // add empty field
@@ -241,8 +231,7 @@ 
      * create view
      * @return void
      */
-    private function viewAssign()
-    {
+    private function viewAssign() {
         $this->view->assign('query',       $this->query);
         $this->view->assign('resultList',  $this->resultList);
         $this->view->assign('currentPage', $this->currentPage);

Classes/Controller/GetFileController.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -179,20 +179,20 @@
             return 'Error while fetching headers';
         }
 
-        $contentDispFlag = false;
-        $contentTypeFlag = false;
+        $contentDispFlag = FALSE;
+        $contentTypeFlag = FALSE;
 
         foreach ($headers as $value) {
 
             if (FALSE !== stripos($value, 'Content-Disposition')) {
                 header($value);
-                $contentDispFlag = true;
+                $contentDispFlag = TRUE;
                 continue;
             }
 
             if (FALSE !== stripos($value, 'Content-Type')) {
                 header($value);
-                $contentTypeFlag = true;
+                $contentTypeFlag = TRUE;
                 continue;
             }
 

Braces +5 added lines, -10 removed lines

@@ -46,8 +46,7 @@ 
 /**
  * GetFileController
  */
-class GetFileController extends \EWW\Dpf\Controller\AbstractController
-{
+class GetFileController extends \EWW\Dpf\Controller\AbstractController {
 
     /**
      * documentRepository
@@ -65,8 +64,7 @@ 
      */
     protected $clientConfigurationManager;
 
-    public function attachmentAction()
-    {
+    public function attachmentAction() {
 
         $piVars = GeneralUtility::_GP('tx_dpf'); // get GET params from powermail
 
@@ -237,8 +235,7 @@ 
 
     }
 
-    private static function sanitizeFilename($filename)
-    {
+    private static function sanitizeFilename($filename) {
         // remove anything which isn't a word, whitespace, number or any of the following caracters -_~,;[]().
         $filename = mb_ereg_replace("([^\w\s\d\-_~,;\[\]\(\).])", '', $filename);
         // turn diacritical characters to ASCII
@@ -250,8 +247,7 @@ 
         return $filename;
     }
 
-    private function buildMetsXml($document)
-    {
+    private function buildMetsXml($document) {
 
         $exporter = new \EWW\Dpf\Services\MetsExporter();
         $fileData = $document->getCurrentFileData();
@@ -275,8 +271,7 @@ 
         return $metsXml;
     }
 
-    private function isForbidden($action)
-    {
+    private function isForbidden($action) {
         $allowed =
             array_key_exists('allowedActions', $this->settings)
             && is_array($this->settings['allowedActions'])

Spacing +3 added lines, -3 removed lines

@@ -81,7 +81,7 @@ 
 
         switch ($piVars['action']) {
             case 'mets':
-                $path = rtrim('http://' . $fedoraHost,"/").'/fedora/objects/'.$piVars['qid'].'/methods/qucosa:SDef/getMETSDissemination?supplement=yes';
+                $path = rtrim('http://' . $fedoraHost, "/") . '/fedora/objects/' . $piVars['qid'] . '/methods/qucosa:SDef/getMETSDissemination?supplement=yes';
                 break;
 
             case 'preview':
@@ -146,7 +146,7 @@ 
                 $source = explode(':', $qid);
                 if ($source[0] == 'qucosa') {
 
-                    $path = rtrim('http://' . $fedoraHost, "/").'/fedora/objects/'.$piVars['qid'].'/methods/qucosa:SDef/getMETSDissemination?supplement=yes';
+                    $path = rtrim('http://' . $fedoraHost, "/") . '/fedora/objects/' . $piVars['qid'] . '/methods/qucosa:SDef/getMETSDissemination?supplement=yes';
                     $metsXml = str_replace('&', '&', file_get_contents($path));
                     $dataCiteXml = \EWW\Dpf\Helper\DataCiteXml::convertFromMetsXml($metsXml);
 
@@ -199,7 +199,7 @@ 
         if (TRUE === $isRepositoryObject) {
             if (TRUE === $restrictToActiveDocuments) {
                 // if restriction applies, check object state before dissemination
-                $objectProfileURI = rtrim('http://' . $fedoraHost,"/").'/fedora/objects/'.$piVars['qid'].'?format=XML';
+                $objectProfileURI = rtrim('http://' . $fedoraHost, "/") . '/fedora/objects/' . $piVars['qid'] . '?format=XML';
                 $objectProfileXML = file_get_contents($objectProfileURI);
                 if (FALSE !== $objectProfileXML) {
                     $objectProfileDOM = new \DOMDocument('1.0', 'UTF-8');

Classes/Services/Transfer/Repository.php

Braces +1 added lines, -2 removed lines

@@ -14,8 +14,7 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-interface Repository
-{
+interface Repository {
 
     public function ingest($document, $metsXml);
 

Classes/Services/Transfer/FileId.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     public function __construct($document)
     {
 
-        $idList   = array();
+        $idList   = array ();
         $this->id = 0;
 
         if (is_a($document->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {

Braces +3 added lines, -6 removed lines

@@ -14,13 +14,11 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class FileId
-{
+class FileId {
 
     protected $id = 0;
 
-    public function __construct($document)
-    {
+    public function __construct($document) {
 
         $idList   = array();
         $this->id = 0;
@@ -42,8 +40,7 @@ 
 
     }
 
-    public function getId($file)
-    {
+    public function getId($file) {
 
         $fileId = $file->getDatastreamIdentifier();
         if (empty($fileId)) {