Issues in IsArrayViewHelper.php (master) - Issues in master - kitodo/kitodo-presentation - Measure and Improve Code Quality continuously with Scrutinizer

Issues (210)

Classes/ViewHelpers/IsArrayViewHelper.php (1 issue)

Labels

Severity

Major 1

<?php

/**
 * (c) Kitodo. Key to digital objects e.V. <[email protected]>
 *
 * This file is part of the Kitodo and TYPO3 projects.
 *
 * @license GNU General Public License version 3 or later.
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Kitodo\Dlf\ViewHelpers;

use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;

/**
 * Checks if the given subject is an array.
 */
class IsArrayViewHelper extends AbstractViewHelper
{
    public function initializeArguments()
    {
        parent::initializeArguments();
        $this->registerArgument('subject', 'string', 'The subject');
    }

    /**
     * @return bool
     */
    public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
    {
        $subject = $arguments['subject'];
        if ($subject === null) {
            $subject = $renderChildrenClosure();
        }

        return \is_array($subject);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			/**
4			* (c) Kitodo. Key to digital objects e.V. <[email protected]>
5			*
6			* This file is part of the Kitodo and TYPO3 projects.
7			*
8			* @license GNU General Public License version 3 or later.
9			* For the full copyright and license information, please read the
10			* LICENSE.txt file that was distributed with this source code.
11			*/
12
13			namespace Kitodo\Dlf\ViewHelpers;
14
15			use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
16			use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
17
18			/**
19			* Checks if the given subject is an array.
20			*/
21			class IsArrayViewHelper extends AbstractViewHelper
22			{
23			public function initializeArguments()
24			{
25			parent::initializeArguments();
26			$this->registerArgument('subject', 'string', 'The subject');
27			}
28
29			/**
30			* @return bool
31			*/
32			public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
33			{
34			$subject = $arguments['subject'];
35			if ($subject === null) {
36			$subject = $renderChildrenClosure();
37			}
38
39			return \is_array($subject);
			0 ignored issues – show Bug Best Practice introduced 2022-07-20 09:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return is_array($subject)` returns the type `boolean` which is incompatible with the return type mandated by `TYPO3Fluid\Fluid\Core\Vi...terface::renderStatic()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
40			}
41			}
42

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Issues (210)

Classes/ViewHelpers/IsArrayViewHelper.php (1 issue)

Labels

Severity

Introduced By

kitodo / kitodo-presentation

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Issues (210)

Classes/ViewHelpers/IsArrayViewHelper.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like