IsArrayViewHelper::renderStatic() - Code Metrics - Inspection of "Fix deprecation code for Typo3 v10" - kitodo/kitodo-presentation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — dev-extbase-fluid (#744)

unknown

created 2021-11-25 10:26 UTC

IsArrayViewHelper::renderStatic() A

↳ Parent: IsArrayViewHelper

Complexity

Conditions	3
Paths	4

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	4
nop	3
dl	0
loc	14
rs	10

<?php
/**
 * (c) Kitodo. Key to digital objects e.V. <[email protected]>
 *
 * This file is part of the Kitodo and TYPO3 projects.
 *
 * @license GNU General Public License version 3 or later.
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Kitodo\Dlf\ViewHelpers;

use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
use TYPO3Fluid\Fluid\RenderingContextInterface;
filter:
    dependency_paths: ["lib/*"]

class IsArrayViewHelper extends AbstractViewHelper
{
    /**
     * Register arguments.
     */
    public function initializeArguments()
    {
        parent::initializeArguments();
        $this->registerArgument('variable', 'mixed', 'The variable to check', false, null);
    }

    /**
     * @return bool
     */
    public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
    {
        $result = false;

        $variable = $arguments['variable'];
        if (null === $variable) {
            $variable = $renderChildrenClosure();
        }

        if (null !== $variable) {
            $result = is_array($variable);
        }

        return $result;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Pull Request — dev-extbase-fluid (#744)

IsArrayViewHelper::renderStatic() A

Complexity

Size

Duplication

Importance

1			<?php
2			/**
3			* (c) Kitodo. Key to digital objects e.V. <[email protected]>
4			*
5			* This file is part of the Kitodo and TYPO3 projects.
6			*
7			* @license GNU General Public License version 3 or later.
8			* For the full copyright and license information, please read the
9			* LICENSE.txt file that was distributed with this source code.
10			*/
11
12			namespace Kitodo\Dlf\ViewHelpers;
13
14			use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
15			use TYPO3Fluid\Fluid\RenderingContextInterface;
			0 ignored issues – show Bug introduced 2021-11-25 08:54 UTC by Report Bug Copy Issue Report The type `TYPO3Fluid\Fluid\RenderingContextInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16
17			class IsArrayViewHelper extends AbstractViewHelper
18			{
19			/**
20			* Register arguments.
21			*/
22			public function initializeArguments()
23			{
24			parent::initializeArguments();
25			$this->registerArgument('variable', 'mixed', 'The variable to check', false, null);
26			}
27
28			/**
29			* @return bool
30			*/
31			public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
32			{
33			$result = false;
34
35			$variable = $arguments['variable'];
36			if (null === $variable) {
37			$variable = $renderChildrenClosure();
38			}
39
40			if (null !== $variable) {
41			$result = is_array($variable);
42			}
43
44			return $result;
			0 ignored issues – show Bug Best Practice introduced 2021-11-25 08:54 UTC by Report Bug Copy Issue Report The expression `return $result` returns the type `boolean` which is incompatible with the return type mandated by `TYPO3Fluid\Fluid\Core\Vi...terface::renderStatic()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
45			}
46			}
47

kitodo / kitodo-presentation

Scrutinizer GitHub App not installed

GitHub Access Token became invalid

Pull Request — dev-extbase-fluid (#744)

IsArrayViewHelper::renderStatic() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like