We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -48,7 +48,7 @@ |
||
48 | 48 | |
49 | 49 | $settingsParts = explode("/", $model); |
50 | 50 | $fileName = end($settingsParts); |
51 | - $path = substr($model, 0, strrpos($model, $fileName)); |
|
51 | + $path = substr($model, 0, strrpos($model, $fileName)); |
|
52 | 52 | $modelSettings = $path . "metadata/" . $fileName . "_viewer"; |
53 | 53 | |
54 | 54 | if (!empty($modelConverted)) { |
@@ -30,7 +30,8 @@ |
||
30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
31 | 31 | * @return void |
32 | 32 | */ |
33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) |
|
34 | + { |
|
34 | 35 | if ($pageSelectForm) { |
35 | 36 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
36 | 37 | $uri = $uriBuilder->reset() |
@@ -30,7 +30,7 @@ |
||
30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
31 | 31 | * @return void |
32 | 32 | */ |
33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = null) { |
|
34 | 34 | if ($pageSelectForm) { |
35 | 35 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
36 | 36 | $uri = $uriBuilder->reset() |
@@ -75,7 +75,7 @@ |
||
75 | 75 | // extract collection(s) from collection parameter |
76 | 76 | $collection = null; |
77 | 77 | if ($this->searchParams['collection']) { |
78 | - foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) { |
|
78 | + foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) { |
|
79 | 79 | $collection[] = $this->collectionRepository->findByUid($collectionEntry); |
80 | 80 | } |
81 | 81 | } |
@@ -71,7 +71,8 @@ discard block |
||
71 | 71 | * |
72 | 72 | * @return void |
73 | 73 | */ |
74 | - private function getAuthors() { |
|
74 | + private function getAuthors() |
|
75 | + { |
|
75 | 76 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
76 | 77 | |
77 | 78 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -93,7 +94,8 @@ discard block |
||
93 | 94 | } |
94 | 95 | } |
95 | 96 | |
96 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
97 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
98 | + { |
|
97 | 99 | $profile = new OrcidProfile($orcidId); |
98 | 100 | $name = $profile->getFullName(); |
99 | 101 | if (!empty($name)) { |
@@ -107,7 +109,8 @@ discard block |
||
107 | 109 | } |
108 | 110 | } |
109 | 111 | |
110 | - private function getAuthorFromXml($authors, $i) { |
|
112 | + private function getAuthorFromXml($authors, $i) |
|
113 | + { |
|
111 | 114 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
112 | 115 | |
113 | 116 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -150,7 +153,8 @@ discard block |
||
150 | 153 | } |
151 | 154 | } |
152 | 155 | |
153 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
156 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
157 | + { |
|
154 | 158 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
155 | 159 | if ($displayForm) { |
156 | 160 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -164,7 +168,8 @@ discard block |
||
164 | 168 | * |
165 | 169 | * @return void |
166 | 170 | */ |
167 | - private function getHolders() { |
|
171 | + private function getHolders() |
|
172 | + { |
|
168 | 173 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
169 | 174 | |
170 | 175 | if (!empty($holders)) { |
@@ -181,7 +186,8 @@ discard block |
||
181 | 186 | } |
182 | 187 | } |
183 | 188 | |
184 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
189 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
190 | + { |
|
185 | 191 | $profile = new ViafProfile($viafId); |
186 | 192 | $name = $profile->getFullName(); |
187 | 193 | if (!empty($name)) { |
@@ -195,7 +201,8 @@ discard block |
||
195 | 201 | } |
196 | 202 | } |
197 | 203 | |
198 | - private function getHolderFromXml($holders, $i) { |
|
204 | + private function getHolderFromXml($holders, $i) |
|
205 | + { |
|
199 | 206 | $this->getHolderFromXmlDisplayForm($holders, $i); |
200 | 207 | // Append "valueURI" to name using Unicode unit separator. |
201 | 208 | if (isset($holders[$i]['valueURI'])) { |
@@ -203,7 +210,8 @@ discard block |
||
203 | 210 | } |
204 | 211 | } |
205 | 212 | |
206 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
213 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
214 | + { |
|
207 | 215 | // Check if there is a display form. |
208 | 216 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
209 | 217 | if ($displayForm) { |
@@ -218,7 +226,8 @@ discard block |
||
218 | 226 | * |
219 | 227 | * @return void |
220 | 228 | */ |
221 | - private function getPlaces() { |
|
229 | + private function getPlaces() |
|
230 | + { |
|
222 | 231 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
223 | 232 | // Get "place" and "place_sorting" again if that was to sophisticated. |
224 | 233 | if (empty($places)) { |
@@ -242,7 +251,8 @@ discard block |
||
242 | 251 | * |
243 | 252 | * @return void |
244 | 253 | */ |
245 | - private function getYears() { |
|
254 | + private function getYears() |
|
255 | + { |
|
246 | 256 | // Get "year_sorting". |
247 | 257 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
248 | 258 | foreach ($years_sorting as $year_sorting) { |
@@ -77,7 +77,8 @@ |
||
77 | 77 | * |
78 | 78 | * @return void |
79 | 79 | */ |
80 | - public function setEndpoint($endpoint) { |
|
80 | + public function setEndpoint($endpoint) |
|
81 | + { |
|
81 | 82 | $this->endpoint = $endpoint; |
82 | 83 | } |
83 | 84 |
@@ -77,7 +77,8 @@ |
||
77 | 77 | * |
78 | 78 | * @return void |
79 | 79 | */ |
80 | - public function setEndpoint($endpoint) { |
|
80 | + public function setEndpoint($endpoint) |
|
81 | + { |
|
81 | 82 | $this->endpoint = $endpoint; |
82 | 83 | } |
83 | 84 |
@@ -127,7 +127,7 @@ discard block |
||
127 | 127 | foreach ($year['children'] as $month) { |
128 | 128 | foreach ($month['children'] as $day) { |
129 | 129 | foreach ($day['children'] as $issue) { |
130 | - $title = $issue['label'] ?: $issue['orderlabel']; |
|
130 | + $title = $issue['label'] ? : $issue['orderlabel']; |
|
131 | 131 | if (strtotime($title) !== false) { |
132 | 132 | $title = strftime('%x', strtotime($title)); |
133 | 133 | } |
@@ -218,8 +218,8 @@ discard block |
||
218 | 218 | $this->view->assign('calendarData', $calendarData); |
219 | 219 | $this->view->assign('documentId', $this->document->getUid()); |
220 | 220 | $this->view->assign('yearLinkTitle', $yearLinkTitle); |
221 | - $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']); |
|
222 | - $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']); |
|
221 | + $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']); |
|
222 | + $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']); |
|
223 | 223 | } |
224 | 224 | |
225 | 225 | /** |
@@ -255,7 +255,7 @@ discard block |
||
255 | 255 | |
256 | 256 | if (empty($yearLabel)) { |
257 | 257 | // if neither order nor orderlabel is set, use the id... |
258 | - $yearLabel = (string)$id; |
|
258 | + $yearLabel = (string) $id; |
|
259 | 259 | } |
260 | 260 | |
261 | 261 | $years[] = [ |
@@ -294,7 +294,7 @@ discard block |
||
294 | 294 | if (is_int($key)) { |
295 | 295 | $yearFilled[] = $yearArray[$key]; |
296 | 296 | } else { |
297 | - $yearFilled[] = ['title' => $min+$i, 'documentId' => '']; |
|
297 | + $yearFilled[] = ['title' => $min + $i, 'documentId' => '']; |
|
298 | 298 | } |
299 | 299 | } |
300 | 300 | $yearArray = $yearFilled; |
@@ -205,7 +205,8 @@ |
||
205 | 205 | * |
206 | 206 | * @return void |
207 | 207 | */ |
208 | - private function addDcData(&$metadata, $key, $value) { |
|
208 | + private function addDcData(&$metadata, $key, $value) |
|
209 | + { |
|
209 | 210 | if (!empty($value)) { |
210 | 211 | $metadata[] = [$key => $value]; |
211 | 212 | } |
@@ -278,7 +278,7 @@ |
||
278 | 278 | |
279 | 279 | if ($this->solrCoreRepository->findOneByPid($this->pid) === null) { |
280 | 280 | $newRecord = GeneralUtility::makeInstance(SolrCore::class); |
281 | - $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels). ' (PID ' . $this->pid . ')'); |
|
281 | + $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels) . ' (PID ' . $this->pid . ')'); |
|
282 | 282 | $indexName = Solr::createCore(''); |
283 | 283 | if (!empty($indexName)) { |
284 | 284 | $newRecord->setIndexName($indexName); |