tx_dlf_basket::main()

Complexity

Conditions	25
Paths	> 20000

Size

Total Lines	283
Code Lines	121

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function main($content, $conf) {

        $this->init($conf);

        // Don't cache the output.
        $this->setCache(FALSE);

        // Load template file.
        if (!empty($this->conf['templateFile'])) {

            $this->template = $this->cObj->getSubpart($this->cObj->fileResource($this->conf['templateFile']), '###TEMPLATE###');

        } else {

            $this->template = $this->cObj->getSubpart($this->cObj->fileResource('EXT:dlf/plugins/basket/template.tmpl'), '###TEMPLATE###');

        }

        $subpartArray['entry'] = $this->cObj->getSubpart($this->template, '###ENTRY###');

$subpartArray was never initialized. Although not strictly required by PHP, it is generally a good practice to add $subpartArray = array(); before regardless.

        $markerArray['###JS###'] = '';

$markerArray was never initialized. Although not strictly required by PHP, it is generally a good practice to add $markerArray = array(); before regardless.

        // get user session
        $sessionId = $GLOBALS['TSFE']->fe_user->id;

        if ($GLOBALS['TSFE']->loginUser) {

            $insertArray['fe_user_id'] = $GLOBALS['TSFE']->fe_user->user['uid'];

$insertArray was never initialized. Although not strictly required by PHP, it is generally a good practice to add $insertArray = array(); before regardless.

            $query = $GLOBALS['TYPO3_DB']->SELECTquery(
                '*',
                'tx_dlf_basket',
                'tx_dlf_basket.fe_user_id='.intval($insertArray['fe_user_id']).tx_dlf_helper::whereClause('tx_dlf_basket'),
                '',
                '',
                '1'
            );

        } else {

            $GLOBALS['TSFE']->fe_user->setKey('ses', 'tx_dlf_basket', '');

            $GLOBALS['TSFE']->fe_user->sesData_change = TRUE;

            $GLOBALS['TSFE']->fe_user->storeSessionData();

            $query = $GLOBALS['TYPO3_DB']->SELECTquery(
                '*',
                'tx_dlf_basket',
                'tx_dlf_basket.session_id='.$GLOBALS['TYPO3_DB']->fullQuoteStr($sessionId, 'tx_dlf_basket').tx_dlf_helper::whereClause('tx_dlf_basket'),
                '',
                '',
                '1'
            );

        }

        $result = $GLOBALS['TYPO3_DB']->sql_query($query);

        // session already exists
        if ($GLOBALS['TYPO3_DB']->sql_num_rows($result) == 0) {

            // create new basket in db
            $insertArray['session_id'] = $sessionId;
            $insertArray['doc_ids'] = '';
            $insertArray['label'] = '';
            $insertArray['l18n_diffsource'] = '';

            $GLOBALS['TYPO3_DB']->exec_INSERTquery('tx_dlf_basket', $insertArray);

            $result = $GLOBALS['TYPO3_DB']->sql_query($query);

        }

        $basketData = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($result);

        $piVars = $this->piVars;

        // action add to basket
        if (!empty($this->piVars['id']) && $this->piVars['addToBasket']) {

            $returnData = $this->addToBasket($this->piVars, $basketData);

            $basketData = $returnData['basketData'];

            $markerArray['###JS###'] = $returnData['jsOutput'];

        } else {

            $basketData['doc_ids'] = json_decode($basketData['doc_ids']);

        }

        // action remove from basket
        if ($this->piVars['basket_action'] == 'remove') {

            // remove entry from list
            unset($piVars['basket_action']);

            if (isset($this->piVars['selected'])) {

                $basketData = $this->removeFromBasket($piVars, $basketData);

            }

        }

        // action remove from basket
        if ($this->piVars['basket_action'] == 'open') {

            // open selected documents
            unset($piVars['basket_action']);

            if (isset($this->piVars['selected'])) {

                $basketData = $this->openFromBasket($piVars, $basketData);

            }

        }

        // action print from basket
        if ($this->piVars['print_action']) {

            // open selected documents
            unset($piVars['print_action']);

            if (isset($this->piVars['selected'])) {

                $basketData = $this->printDocument($piVars, $basketData);

Are you sure the assignment to $basketData is correct as $this->printDocument($piVars, $basketData) targeting tx_dlf_basket::printDocument() seems to always return null.

The call to tx_dlf_basket::printDocument() has too many arguments starting with $piVars.

            }

        }

        // action send mail
        if ($this->piVars['mail_action']) {

            if (isset($this->piVars['selected'])) {

                $this->sendMail($this->piVars);

The call to tx_dlf_basket::sendMail() has too many arguments starting with $this->piVars.

            }

        }

        // set marker
        $markerArray['###ACTION###'] = $this->pi_getPageLink($GLOBALS['TSFE']->id);

        $markerArray['###LISTTITLE###'] = $this->pi_getLL('basket', '', TRUE);

        if ($basketData['doc_ids']) {

            if (is_object($basketData['doc_ids'])) {

                $basketData['doc_ids'] = get_object_vars($basketData['doc_ids']);

            }

            $markerArray['###COUNT###'] = sprintf($this->pi_getLL('count'), count($basketData['doc_ids']));

        } else {

            $markerArray['###COUNT###'] = sprintf($this->pi_getLL('count'), 0);

        }

        // get mail addresses
        $resultMail = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
            '*',
            'tx_dlf_mail',
            '1'.tx_dlf_helper::whereClause('tx_dlf_mail'),
            '',
            'tx_dlf_mail.sorting',
            ''
        );

        if ($GLOBALS['TYPO3_DB']->sql_num_rows($resultMail) > 0) {

            $mails = array ();

            $mailForm = '<select name="tx_dlf[mail_action]">';

            $mailForm .= '<option value="">'.$this->pi_getLL('chooseMail', '', TRUE).'</option>';

            while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($resultMail)) {

                $mails[] = $row;

                $mailForm .= '<option value="'.$row['uid'].'">'.$row['name'].' ('.$row['mail'].')</option>';

            }

            $mailForm .= '</select><input type="submit">';

        }

        // mail action form
        $markerArray['###MAILACTION###'] = $mailForm;

The variable $mailForm does not seem to be defined for all execution paths leading up to this point.

        // remove action form
        $markerArray['###REMOVEACTION###'] = '
			<select name="tx_dlf[basket_action]">
				<option value="">'.$this->pi_getLL('chooseAction', '', TRUE).'</option>
				<option value="open">'.$this->pi_getLL('download', '', TRUE).'</option>
				<option value="remove">'.$this->pi_getLL('remove', '', TRUE).'</option>
			</select>
			<input type="submit">
		';

        // get mail addresses
        $resultPrinter = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
            '*',
            'tx_dlf_printer',
            '1'.tx_dlf_helper::whereClause('tx_dlf_printer'),
            '',
            '',
            ''
        );

        $printForm = '';

        if ($GLOBALS['TYPO3_DB']->sql_num_rows($resultPrinter) > 0) {

            $printers = array ();

            $printForm = '<select name="tx_dlf[print_action]">';

            $printForm .= '<option value="">'.$this->pi_getLL('choosePrinter', '', TRUE).'</option>';

            while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($resultPrinter)) {

                $printers[] = $row;

                $printForm .= '<option value="'.$row['uid'].'">'.$row['label'].'</option>';

            }

            $printForm .= '</select><input type="submit" />';

        }

        // print action form
        $markerArray['###PRINTACTION###'] = $printForm;

        $entries = '';

        if (isset($basketData['doc_ids'])) {

            // get each entry
            foreach ($basketData['doc_ids'] as $key => $value) {

                $entries .= $this->getEntry($value, $subpartArray);

            }

        } else {

            $entries = '';

        }

        // basket go to
        if ($this->conf['targetBasket'] && $this->conf['basketGoToButton'] && $this->piVars['id']) {

            $label = $this->pi_getLL('goBasket', '', TRUE);

            $basketConf = array (
                'parameter' => $this->conf['targetBasket'],
                'title' => $label
            );

            $markerArray['###BASKET###'] = $this->cObj->typoLink($label, $basketConf);

        } else {

            $markerArray['###BASKET###'] = '';

        }

        $content = $this->cObj->substituteMarkerArray($this->cObj->substituteSubpart($this->template, '###ENTRY###', $entries, TRUE), $markerArray);

        return $this->pi_wrapInBaseClass($content);

}