kitodo /
kitodo-presentation
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 29 |
| Paths | 5377 |
| Total Lines | 95 |
| Code Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | public function mainAction() |
||
| 63 | { |
||
| 64 | $this->cObj = $this->configurationManager->getContentObject(); |
||
|
Bug
Best Practice
introduced
by
|
|||
| 65 | |||
| 66 | // Load current document. |
||
| 67 | $this->loadDocument($this->requestData); |
||
| 68 | if ( |
||
| 69 | $this->document === null |
||
| 70 | || $this->document->getDoc() === null |
||
| 71 | ) { |
||
| 72 | // Quit without doing anything if required variables are not set. |
||
| 73 | return ''; |
||
| 74 | } else { |
||
| 75 | // Set default values if not set. |
||
| 76 | if (!isset($this->settings['rootline'])) { |
||
| 77 | $this->settings['rootline'] = 0; |
||
| 78 | } |
||
| 79 | if (!isset($this->settings['originalIiifMetadata'])) { |
||
| 80 | $this->settings['originalIiifMetadata'] = 0; |
||
| 81 | } |
||
| 82 | if (!isset($this->settings['displayIiifDescription'])) { |
||
| 83 | $this->settings['displayIiifDescription'] = 1; |
||
| 84 | } |
||
| 85 | if (!isset($this->settings['displayIiifRights'])) { |
||
| 86 | $this->settings['displayIiifRights'] = 1; |
||
| 87 | } |
||
| 88 | if (!isset($this->settings['displayIiifLinks'])) { |
||
| 89 | $this->settings['displayIiifLinks'] = 1; |
||
| 90 | } |
||
| 91 | } |
||
| 92 | $useOriginalIiifManifestMetadata = $this->settings['originalIiifMetadata'] == 1 && $this->document->getDoc() instanceof IiifManifest; |
||
| 93 | $metadata = []; |
||
| 94 | if ($this->settings['rootline'] < 2) { |
||
| 95 | // Get current structure's @ID. |
||
| 96 | $ids = []; |
||
| 97 | if (!empty($this->document->getDoc()->physicalStructure[$this->requestData['page']]) && !empty($this->document->getDoc()->smLinks['p2l'][$this->document->getDoc()->physicalStructure[$this->requestData['page']]])) { |
||
| 98 | foreach ($this->document->getDoc()->smLinks['p2l'][$this->document->getDoc()->physicalStructure[$this->requestData['page']]] as $logId) { |
||
| 99 | $count = $this->document->getDoc()->getStructureDepth($logId); |
||
| 100 | $ids[$count][] = $logId; |
||
| 101 | } |
||
| 102 | } |
||
| 103 | ksort($ids); |
||
| 104 | reset($ids); |
||
| 105 | // Check if we should display all metadata up to the root. |
||
| 106 | if ($this->settings['rootline'] == 1) { |
||
| 107 | foreach ($ids as $id) { |
||
| 108 | foreach ($id as $sid) { |
||
| 109 | if ($useOriginalIiifManifestMetadata) { |
||
| 110 | $data = $this->document->getDoc()->getManifestMetadata($sid, $this->settings['storagePid']); |
||
| 111 | } else { |
||
| 112 | $data = $this->document->getDoc()->getMetadata($sid, $this->settings['storagePid']); |
||
| 113 | } |
||
| 114 | if (!empty($data)) { |
||
| 115 | $data['_id'] = $sid; |
||
| 116 | $metadata[] = $data; |
||
| 117 | } |
||
| 118 | } |
||
| 119 | } |
||
| 120 | } else { |
||
| 121 | $id = array_pop($ids); |
||
| 122 | if (is_array($id)) { |
||
| 123 | foreach ($id as $sid) { |
||
| 124 | if ($useOriginalIiifManifestMetadata) { |
||
| 125 | $data = $this->document->getDoc()->getManifestMetadata($sid, $this->settings['storagePid']); |
||
| 126 | } else { |
||
| 127 | $data = $this->document->getDoc()->getMetadata($sid, $this->settings['storagePid']); |
||
| 128 | } |
||
| 129 | if (!empty($data)) { |
||
| 130 | $data['_id'] = $sid; |
||
| 131 | $metadata[] = $data; |
||
| 132 | } |
||
| 133 | } |
||
| 134 | } |
||
| 135 | } |
||
| 136 | } |
||
| 137 | // Get titledata? |
||
| 138 | if (empty($metadata) || ($this->settings['rootline'] == 1 && $metadata[0]['_id'] != $this->document->getDoc()->toplevelId)) { |
||
| 139 | $data = $useOriginalIiifManifestMetadata ? $this->document->getDoc()->getManifestMetadata($this->document->getDoc()->toplevelId, $this->settings['storagePid']) : $this->document->getDoc()->getTitleData($this->settings['storagePid']); |
||
| 140 | $data['_id'] = $this->document->getDoc()->toplevelId; |
||
| 141 | array_unshift($metadata, $data); |
||
| 142 | } |
||
| 143 | if (empty($metadata)) { |
||
| 144 | $this->logger->warning('No metadata found for document with UID ' . $this->document->getUid()); |
||
| 145 | return ''; |
||
| 146 | } |
||
| 147 | ksort($metadata); |
||
| 148 | // Get hook objects. |
||
| 149 | $this->hookObjects = Helper::getHookObjects($this->scriptRelPath); |
||
| 150 | // Hook for getting a customized title bar (requested by SBB). |
||
| 151 | foreach ($this->hookObjects as $hookObj) { |
||
| 152 | if (method_exists($hookObj, 'main_customizeTitleBarGetCustomTemplate')) { |
||
| 153 | $hookObj->main_customizeTitleBarGetCustomTemplate($this, $metadata); |
||
| 154 | } |
||
| 155 | } |
||
| 156 | $this->printMetadata($metadata, $useOriginalIiifManifestMetadata); |
||
| 157 | } |
||
| 311 |
Loading history...
