We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -73,7 +73,8 @@ |
||
73 | 73 | /** |
74 | 74 | * @param string $endpoint the shortname of the endpoint |
75 | 75 | */ |
76 | - public function setEndpoint($endpoint) { |
|
76 | + public function setEndpoint($endpoint) |
|
77 | + { |
|
77 | 78 | $this->endpoint = $endpoint; |
78 | 79 | } |
79 | 80 |
@@ -73,7 +73,8 @@ |
||
73 | 73 | /** |
74 | 74 | * @param string $endpoint the shortname of the endpoint |
75 | 75 | */ |
76 | - public function setEndpoint($endpoint) { |
|
76 | + public function setEndpoint($endpoint) |
|
77 | + { |
|
77 | 78 | $this->endpoint = $endpoint; |
78 | 79 | } |
79 | 80 |
@@ -20,7 +20,9 @@ discard block |
||
20 | 20 | $this->limit = count($solrSearch); |
21 | 21 | } |
22 | 22 | |
23 | - public function getSource() {} |
|
23 | + public function getSource() |
|
24 | + { |
|
25 | +} |
|
24 | 26 | |
25 | 27 | public function execute($returnRawQueryResult = false) |
26 | 28 | { |
@@ -35,7 +37,9 @@ discard block |
||
35 | 37 | return $result; |
36 | 38 | } |
37 | 39 | |
38 | - public function setOrderings(array $orderings) {} |
|
40 | + public function setOrderings(array $orderings) |
|
41 | + { |
|
42 | +} |
|
39 | 43 | |
40 | 44 | public function setLimit($limit) |
41 | 45 | { |
@@ -49,28 +53,60 @@ discard block |
||
49 | 53 | return $this; |
50 | 54 | } |
51 | 55 | |
52 | - public function matching($constraint) {} |
|
53 | - public function logicalAnd($constraint1) {} |
|
54 | - public function logicalOr($constraint1) {} |
|
55 | - public function logicalNot(ConstraintInterface $constraint) {} |
|
56 | - public function equals($propertyName, $operand, $caseSensitive = true) {} |
|
57 | - public function like($propertyName, $operand) {} |
|
58 | - public function contains($propertyName, $operand) {} |
|
59 | - public function in($propertyName, $operand) {} |
|
60 | - public function lessThan($propertyName, $operand) {} |
|
61 | - public function lessThanOrEqual($propertyName, $operand) {} |
|
62 | - public function greaterThan($propertyName, $operand) {} |
|
63 | - public function greaterThanOrEqual($propertyName, $operand) {} |
|
64 | - public function getType() {} |
|
65 | - public function setQuerySettings(QuerySettingsInterface $querySettings) {} |
|
66 | - public function getQuerySettings() {} |
|
56 | + public function matching($constraint) |
|
57 | + { |
|
58 | +} |
|
59 | + public function logicalAnd($constraint1) |
|
60 | + { |
|
61 | +} |
|
62 | + public function logicalOr($constraint1) |
|
63 | + { |
|
64 | +} |
|
65 | + public function logicalNot(ConstraintInterface $constraint) |
|
66 | + { |
|
67 | +} |
|
68 | + public function equals($propertyName, $operand, $caseSensitive = true) |
|
69 | + { |
|
70 | +} |
|
71 | + public function like($propertyName, $operand) |
|
72 | + { |
|
73 | +} |
|
74 | + public function contains($propertyName, $operand) |
|
75 | + { |
|
76 | +} |
|
77 | + public function in($propertyName, $operand) |
|
78 | + { |
|
79 | +} |
|
80 | + public function lessThan($propertyName, $operand) |
|
81 | + { |
|
82 | +} |
|
83 | + public function lessThanOrEqual($propertyName, $operand) |
|
84 | + { |
|
85 | +} |
|
86 | + public function greaterThan($propertyName, $operand) |
|
87 | + { |
|
88 | +} |
|
89 | + public function greaterThanOrEqual($propertyName, $operand) |
|
90 | + { |
|
91 | +} |
|
92 | + public function getType() |
|
93 | + { |
|
94 | +} |
|
95 | + public function setQuerySettings(QuerySettingsInterface $querySettings) |
|
96 | + { |
|
97 | +} |
|
98 | + public function getQuerySettings() |
|
99 | + { |
|
100 | +} |
|
67 | 101 | |
68 | 102 | public function count() |
69 | 103 | { |
70 | 104 | // TODO? |
71 | 105 | } |
72 | 106 | |
73 | - public function getOrderings() {} |
|
107 | + public function getOrderings() |
|
108 | + { |
|
109 | +} |
|
74 | 110 | |
75 | 111 | public function getLimit() |
76 | 112 | { |
@@ -82,8 +118,16 @@ discard block |
||
82 | 118 | return $this->offset; |
83 | 119 | } |
84 | 120 | |
85 | - public function getConstraint() {} |
|
86 | - public function isEmpty($propertyName) {} |
|
87 | - public function setSource(SourceInterface $source) {} |
|
88 | - public function getStatement() {} |
|
121 | + public function getConstraint() |
|
122 | + { |
|
123 | +} |
|
124 | + public function isEmpty($propertyName) |
|
125 | + { |
|
126 | +} |
|
127 | + public function setSource(SourceInterface $source) |
|
128 | + { |
|
129 | +} |
|
130 | + public function getStatement() |
|
131 | + { |
|
132 | +} |
|
89 | 133 | } |
@@ -129,7 +129,7 @@ discard block |
||
129 | 129 | foreach ($year['children'] as $month) { |
130 | 130 | foreach ($month['children'] as $day) { |
131 | 131 | foreach ($day['children'] as $issue) { |
132 | - $title = $issue['label'] ?: $issue['orderlabel']; |
|
132 | + $title = $issue['label'] ? : $issue['orderlabel']; |
|
133 | 133 | if (strtotime($title) !== false) { |
134 | 134 | $title = strftime('%x', strtotime($title)); |
135 | 135 | } |
@@ -220,8 +220,8 @@ discard block |
||
220 | 220 | $this->view->assign('calendarData', $calendarData); |
221 | 221 | $this->view->assign('documentId', $this->document->getUid()); |
222 | 222 | $this->view->assign('yearLinkTitle', $yearLinkTitle); |
223 | - $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']); |
|
224 | - $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']); |
|
223 | + $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']); |
|
224 | + $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']); |
|
225 | 225 | } |
226 | 226 | |
227 | 227 | /** |
@@ -257,7 +257,7 @@ discard block |
||
257 | 257 | |
258 | 258 | if (empty($yearLabel)) { |
259 | 259 | // if neither order nor orderlabel is set, use the id... |
260 | - $yearLabel = (string)$id; |
|
260 | + $yearLabel = (string) $id; |
|
261 | 261 | } |
262 | 262 | |
263 | 263 | $years[] = [ |
@@ -58,7 +58,8 @@ |
||
58 | 58 | * |
59 | 59 | * @return void |
60 | 60 | */ |
61 | - public function getTyposcriptConfigFromPluginSiteRoot($params) { |
|
61 | + public function getTyposcriptConfigFromPluginSiteRoot($params) |
|
62 | + { |
|
62 | 63 | $objectManager = GeneralUtility::makeInstance(ObjectManager::class); |
63 | 64 | $pid = $params['flexParentDatabaseRow']['pid']; |
64 | 65 | $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid); |
@@ -48,7 +48,7 @@ |
||
48 | 48 | |
49 | 49 | $settingsParts = explode("/", $model); |
50 | 50 | $fileName = end($settingsParts); |
51 | - $path = substr($model, 0, strrpos($model, $fileName)); |
|
51 | + $path = substr($model, 0, strrpos($model, $fileName)); |
|
52 | 52 | $modelSettings = $path . "metadata/" . $fileName . "_viewer"; |
53 | 53 | |
54 | 54 | if (!empty($modelConverted)) { |
@@ -71,7 +71,8 @@ discard block |
||
71 | 71 | * |
72 | 72 | * @return void |
73 | 73 | */ |
74 | - private function getAuthors() { |
|
74 | + private function getAuthors() |
|
75 | + { |
|
75 | 76 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
76 | 77 | |
77 | 78 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -93,7 +94,8 @@ discard block |
||
93 | 94 | } |
94 | 95 | } |
95 | 96 | |
96 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
97 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
98 | + { |
|
97 | 99 | $profile = new OrcidProfile($orcidId); |
98 | 100 | $name = $profile->getFullName(); |
99 | 101 | if (!empty($name)) { |
@@ -107,7 +109,8 @@ discard block |
||
107 | 109 | } |
108 | 110 | } |
109 | 111 | |
110 | - private function getAuthorFromXml($authors, $i) { |
|
112 | + private function getAuthorFromXml($authors, $i) |
|
113 | + { |
|
111 | 114 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
112 | 115 | |
113 | 116 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -150,7 +153,8 @@ discard block |
||
150 | 153 | } |
151 | 154 | } |
152 | 155 | |
153 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
156 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
157 | + { |
|
154 | 158 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
155 | 159 | if ($displayForm) { |
156 | 160 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -164,7 +168,8 @@ discard block |
||
164 | 168 | * |
165 | 169 | * @return void |
166 | 170 | */ |
167 | - private function getHolders() { |
|
171 | + private function getHolders() |
|
172 | + { |
|
168 | 173 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
169 | 174 | |
170 | 175 | if (!empty($holders)) { |
@@ -181,7 +186,8 @@ discard block |
||
181 | 186 | } |
182 | 187 | } |
183 | 188 | |
184 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
189 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
190 | + { |
|
185 | 191 | $profile = new ViafProfile($viafId); |
186 | 192 | $name = $profile->getFullName(); |
187 | 193 | if (!empty($name)) { |
@@ -195,7 +201,8 @@ discard block |
||
195 | 201 | } |
196 | 202 | } |
197 | 203 | |
198 | - private function getHolderFromXml($holders, $i) { |
|
204 | + private function getHolderFromXml($holders, $i) |
|
205 | + { |
|
199 | 206 | $this->getHolderFromXmlDisplayForm($holders, $i); |
200 | 207 | // Append "valueURI" to name using Unicode unit separator. |
201 | 208 | if (isset($holders[$i]['valueURI'])) { |
@@ -203,7 +210,8 @@ discard block |
||
203 | 210 | } |
204 | 211 | } |
205 | 212 | |
206 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
213 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
214 | + { |
|
207 | 215 | // Check if there is a display form. |
208 | 216 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
209 | 217 | if ($displayForm) { |
@@ -218,7 +226,8 @@ discard block |
||
218 | 226 | * |
219 | 227 | * @return void |
220 | 228 | */ |
221 | - private function getPlaces() { |
|
229 | + private function getPlaces() |
|
230 | + { |
|
222 | 231 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
223 | 232 | // Get "place" and "place_sorting" again if that was to sophisticated. |
224 | 233 | if (empty($places)) { |
@@ -242,7 +251,8 @@ discard block |
||
242 | 251 | * |
243 | 252 | * @return void |
244 | 253 | */ |
245 | - private function getYears() { |
|
254 | + private function getYears() |
|
255 | + { |
|
246 | 256 | // Get "year_sorting". |
247 | 257 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
248 | 258 | foreach ($years_sorting as $year_sorting) { |