kitodo / kitodo-presentation

plugins/search/class.tx_dlf_search.php

Spacing +59 added lines, -59 removed lines

@@ -36,7 +36,7 @@ 
         $result = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
             'tx_dlf_metadata.*',
             'tx_dlf_metadata',
-            'tx_dlf_metadata.index_autocomplete=1 AND tx_dlf_metadata.pid='.intval($this->conf['pages']).tx_dlf_helper::whereClause('tx_dlf_metadata'),
+            'tx_dlf_metadata.index_autocomplete=1 AND tx_dlf_metadata.pid=' . intval($this->conf['pages']) . tx_dlf_helper::whereClause('tx_dlf_metadata'),
             '',
             '',
             '1'
@@ -44,7 +44,7 @@ 
 
         if ($GLOBALS['TYPO3_DB']->sql_num_rows($result)) {
 
-            $GLOBALS['TSFE']->additionalHeaderData[$this->prefixId.'_search_suggest'] = '<script type="text/javascript" src="'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'plugins/search/tx_dlf_search_suggest.js"></script>';
+            $GLOBALS['TSFE']->additionalHeaderData[$this->prefixId . '_search_suggest'] = '<script type="text/javascript" src="' . \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey) . 'plugins/search/tx_dlf_search_suggest.js"></script>';
 
         } else {
 
@@ -73,7 +73,7 @@ 
         if (!empty($list->metadata['options']['source']) && $list->metadata['options']['source'] == 'collection') {
 
             // Get collection's UID.
-            return '<input type="hidden" name="'.$this->prefixId.'[collection]" value="'.$list->metadata['options']['select'].'" />';
+            return '<input type="hidden" name="' . $this->prefixId . '[collection]" value="' . $list->metadata['options']['select'] . '" />';
 
         } elseif (!empty($list->metadata['options']['params']['filterquery'])) {
 
@@ -90,7 +90,7 @@ 
 
             }
 
-            return '<input type="hidden" name="'.$this->prefixId.'[collection]" value="'.$collectionId.'" />';
+            return '<input type="hidden" name="' . $this->prefixId . '[collection]" value="' . $collectionId . '" />';
 
         }
 
@@ -118,7 +118,7 @@ 
             // Get document's UID or parent ID.
             if ($this->doc->ready) {
 
-                return '<input type="hidden" name="'.$this->prefixId.'[id]" value="'.($this->doc->parentId > 0 ? $this->doc->parentId : $this->doc->uid).'" />';
+                return '<input type="hidden" name="' . $this->prefixId . '[id]" value="' . ($this->doc->parentId > 0 ? $this->doc->parentId : $this->doc->uid) . '" />';
 
             }
 
@@ -137,7 +137,7 @@ 
 
             }
 
-            return '<input type="hidden" name="'.$this->prefixId.'[id]" value="'.$documentId.'" />';
+            return '<input type="hidden" name="' . $this->prefixId . '[id]" value="' . $documentId . '" />';
 
         }
 
@@ -167,7 +167,7 @@ 
         // Add encrypted fields to search form.
         if (is_array($name)) {
 
-            return '<input type="hidden" name="'.$this->prefixId.'[encrypted]" value="'.$name['encrypted'].'" /><input type="hidden" name="'.$this->prefixId.'[hashed]" value="'.$name['hash'].'" />';
+            return '<input type="hidden" name="' . $this->prefixId . '[encrypted]" value="' . $name['encrypted'] . '" /><input type="hidden" name="' . $this->prefixId . '[hashed]" value="' . $name['hash'] . '" />';
 
         } else {
 
@@ -198,9 +198,9 @@ 
         // Get operator options.
         $operatorOptions = '';
 
-        foreach (array ('AND', 'OR', 'NOT') as $operator) {
+        foreach (array('AND', 'OR', 'NOT') as $operator) {
 
-            $operatorOptions .= '<option class="tx-dlf-search-operator-option tx-dlf-search-operator-'.$operator.'" value="'.$operator.'">'.$this->pi_getLL($operator, '', TRUE).'</option>';
+            $operatorOptions .= '<option class="tx-dlf-search-operator-option tx-dlf-search-operator-' . $operator . '" value="' . $operator . '">' . $this->pi_getLL($operator, '', TRUE) . '</option>';
 
         }
 
@@ -211,16 +211,16 @@ 
 
         foreach ($searchFields as $searchField) {
 
-            $fieldSelectorOptions .= '<option class="tx-dlf-search-field-option tx-dlf-search-field-'.$searchField.'" value="'.$searchField.'">'.tx_dlf_helper::translate($searchField, 'tx_dlf_metadata', $this->conf['pages']).'</option>';
+            $fieldSelectorOptions .= '<option class="tx-dlf-search-field-option tx-dlf-search-field-' . $searchField . '" value="' . $searchField . '">' . tx_dlf_helper::translate($searchField, 'tx_dlf_metadata', $this->conf['pages']) . '</option>';
 
         }
 
         for ($i = 0; $i < $this->conf['extendedSlotCount']; $i++) {
 
-            $markerArray = array (
-                '###EXT_SEARCH_OPERATOR###' => '<select class="tx-dlf-search-operator tx-dlf-search-operator-'.$i.'" name="'.$this->prefixId.'[extOperator]['.$i.']">'.$operatorOptions.'</select>',
-                '###EXT_SEARCH_FIELDSELECTOR###' => '<select class="tx-dlf-search-field tx-dlf-search-field-'.$i.'" name="'.$this->prefixId.'[extField]['.$i.']">'.$fieldSelectorOptions.'</select>',
-                '###EXT_SEARCH_FIELDQUERY###' => '<input class="tx-dlf-search-query tx-dlf-search-query-'.$i.'" type="text" name="'.$this->prefixId.'[extQuery]['.$i.']" />'
+            $markerArray = array(
+                '###EXT_SEARCH_OPERATOR###' => '<select class="tx-dlf-search-operator tx-dlf-search-operator-' . $i . '" name="' . $this->prefixId . '[extOperator][' . $i . ']">' . $operatorOptions . '</select>',
+                '###EXT_SEARCH_FIELDSELECTOR###' => '<select class="tx-dlf-search-field tx-dlf-search-field-' . $i . '" name="' . $this->prefixId . '[extField][' . $i . ']">' . $fieldSelectorOptions . '</select>',
+                '###EXT_SEARCH_FIELDQUERY###' => '<input class="tx-dlf-search-query tx-dlf-search-query-' . $i . '" type="text" name="' . $this->prefixId . '[extQuery][' . $i . ']" />'
             );
 
             $extendedSearch .= $this->cObj->substituteMarkerArray($this->cObj->getSubpart($this->template, '###EXT_SEARCH_ENTRY###'), $markerArray);
@@ -261,16 +261,16 @@ 
         }
 
         // Get facets from plugin configuration.
-        $facets = array ();
+        $facets = array();
 
         foreach (\TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['facets'], TRUE) as $facet) {
 
-            $facets[$facet.'_faceting'] = tx_dlf_helper::translate($facet, 'tx_dlf_metadata', $this->conf['pages']);
+            $facets[$facet . '_faceting'] = tx_dlf_helper::translate($facet, 'tx_dlf_metadata', $this->conf['pages']);
 
         }
 
         // Render facets menu.
-        $TSconfig = array ();
+        $TSconfig = array();
 
         $TSconfig['special'] = 'userfunction';
 
@@ -302,13 +302,13 @@ 
         // Check for plugin configuration.
         if (!empty($this->conf['fulltext'])) {
 
-            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-no" type="radio" name="'.$this->prefixId.'[fulltext]" value="0" '.($isFulltextSearch == 0 ? 'checked="checked"' : '').' />';
+            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-no" type="radio" name="' . $this->prefixId . '[fulltext]" value="0" ' . ($isFulltextSearch == 0 ? 'checked="checked"' : '') . ' />';
 
-            $output .= ' <label for="tx-dlf-search-fulltext-no">'.$this->pi_getLL('label.inMetadata', '').'</label>';
+            $output .= ' <label for="tx-dlf-search-fulltext-no">' . $this->pi_getLL('label.inMetadata', '') . '</label>';
 
-            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-yes" type="radio" name="'.$this->prefixId.'[fulltext]" value="1" '.($isFulltextSearch == 1 ? 'checked="checked"' : '').'/>';
+            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-yes" type="radio" name="' . $this->prefixId . '[fulltext]" value="1" ' . ($isFulltextSearch == 1 ? 'checked="checked"' : '') . '/>';
 
-            $output .= ' <label for="tx-dlf-search-fulltext-yes">'.$this->pi_getLL('label.inFulltext', '').'</label>';
+            $output .= ' <label for="tx-dlf-search-fulltext-yes">' . $this->pi_getLL('label.inFulltext', '') . '</label>';
 
         }
 
@@ -330,9 +330,9 @@ 
         // Check for plugin configuration.
         if (!empty($this->conf['showLogicalPageField'])) {
 
-            $output .= ' <label for="tx-dlf-search-logical-page">'.$this->pi_getLL('label.logicalPage', '').': </label>';
+            $output .= ' <label for="tx-dlf-search-logical-page">' . $this->pi_getLL('label.logicalPage', '') . ': </label>';
 
-            $output .= ' <input class="tx-dlf-search-logical-page" id="tx-dlf-search-logical-page" type="text" name="'.$this->prefixId.'[logicalPage]" />';
+            $output .= ' <input class="tx-dlf-search-logical-page" id="tx-dlf-search-logical-page" type="text" name="' . $this->prefixId . '[logicalPage]" />';
 
         }
 
@@ -353,7 +353,7 @@ 
      */
     protected function getFacetsMenuEntry($field, $value, $count, $search, &$state) {
 
-        $entryArray = array ();
+        $entryArray = array();
 
         // Translate value.
         if ($field == 'owner_faceting') {
@@ -388,7 +388,7 @@ 
 
         // Check if facet is already selected.
         $queryColumn = array_column($search['params']['filterquery'], 'query');
-        $index = array_search($field.':("'.tx_dlf_solr::escapeQuery($value).'")', $queryColumn);
+        $index = array_search($field . ':("' . tx_dlf_solr::escapeQuery($value) . '")', $queryColumn);
 
         if ($index !== FALSE) {
 
@@ -406,20 +406,20 @@ 
                 //remove ($count) for selected facet in template
                 $entryArray['count'] = FALSE;
                 //build link to delete selected facet
-                $entryArray['_OVERRIDE_HREF'] = $this->pi_linkTP_keepPIvars_url(array ('query' => $search['query'], 'fq' => $queryColumn));
+                $entryArray['_OVERRIDE_HREF'] = $this->pi_linkTP_keepPIvars_url(array('query' => $search['query'], 'fq' => $queryColumn));
                 $entryArray['title'] = sprintf($this->pi_getLL('resetFacet', ''), $entryArray['title']);
             }
 
         } else {
 
             // Facet is not selected, thus add it to filter.
-            $queryColumn[] = $field.':("'.tx_dlf_solr::escapeQuery($value).'")';
+            $queryColumn[] = $field . ':("' . tx_dlf_solr::escapeQuery($value) . '")';
 
             $entryArray['ITEM_STATE'] = 'NO';
 
         }
 
-        $entryArray['_OVERRIDE_HREF'] = $this->pi_linkTP_keepPIvars_url(array ('query' => $search['query'], 'fq' => $queryColumn));
+        $entryArray['_OVERRIDE_HREF'] = $this->pi_linkTP_keepPIvars_url(array('query' => $search['query'], 'fq' => $queryColumn));
 
         return $entryArray;
 
@@ -447,7 +447,7 @@ 
 
             if (TYPO3_DLOG) {
 
-                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->main('.$content.', [data])] Incomplete plugin configuration', $this->extKey, SYSLOG_SEVERITY_WARNING, $conf);
+                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->main(' . $content . ', [data])] Incomplete plugin configuration', $this->extKey, SYSLOG_SEVERITY_WARNING, $conf);
 
             }
 
@@ -491,16 +491,16 @@ 
             }
 
             // Configure @action URL for form.
-            $linkConf = array (
+            $linkConf = array(
                 'parameter' => $GLOBALS['TSFE']->id
             );
 
             // Fill markers.
-            $markerArray = array (
+            $markerArray = array(
                 '###ACTION_URL###' => $this->cObj->typoLink_URL($linkConf),
                 '###LABEL_QUERY###' => (!empty($search['query']) ? htmlspecialchars($search['query']) : $this->pi_getLL('label.query')),
                 '###LABEL_SUBMIT###' => $this->pi_getLL('label.submit'),
-                '###FIELD_QUERY###' => $this->prefixId.'[query]',
+                '###FIELD_QUERY###' => $this->prefixId . '[query]',
                 '###QUERY###' => (!empty($search['query']) ? $search['query'] : ''),
                 '###FULLTEXTSWITCH###' => $this->addFulltextSwitch($list->metadata['fulltextSearch']),
                 '###FIELD_DOC###' => ($this->conf['searchIn'] == 'document' || $this->conf['searchIn'] == 'all' ? $this->addCurrentDocument() : ''),
@@ -527,7 +527,7 @@ 
 
                 if (TYPO3_DLOG) {
 
-                    \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->main('.$content.', [data])] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR, $conf);
+                    \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->main(' . $content . ', [data])] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR, $conf);
 
                 }
 
@@ -545,9 +545,9 @@ 
             }
 
             // Prepare query parameters.
-            $params = array ();
+            $params = array();
 
-            $matches = array ();
+            $matches = array();
 
             // Set search query.
             if ((!empty($this->conf['fulltext']) && !empty($this->piVars['fulltext'])) || preg_match('/fulltext:\((.*)\)/', $this->piVars['query'], $matches)) {
@@ -558,7 +558,7 @@ 
                 // Search in fulltext field if applicable. Query must not be empty!
                 if (!empty($this->piVars['query'])) {
 
-                    $query = 'fulltext:('.tx_dlf_solr::escapeQuery($this->piVars['query']).')';
+                    $query = 'fulltext:(' . tx_dlf_solr::escapeQuery($this->piVars['query']) . ')';
 
                 }
 
@@ -571,7 +571,7 @@ 
             // Add extended search query.
             if (!empty($this->piVars['extQuery']) && is_array($this->piVars['extQuery'])) {
 
-                $allowedOperators = array ('AND', 'OR', 'NOT');
+                $allowedOperators = array('AND', 'OR', 'NOT');
 
                 $allowedFields = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['extendedFields'], TRUE);
 
@@ -583,11 +583,11 @@ 
 
                             if (!empty($query)) {
 
-                                $query .= ' '.$this->piVars['extOperator'][$i].' ';
+                                $query .= ' ' . $this->piVars['extOperator'][$i] . ' ';
 
                             }
 
-                            $query .= tx_dlf_indexing::getIndexFieldName($this->piVars['extField'][$i], $this->conf['pages']).':('.tx_dlf_solr::escapeQuery($this->piVars['extQuery'][$i]).')';
+                            $query .= tx_dlf_indexing::getIndexFieldName($this->piVars['extField'][$i], $this->conf['pages']) . ':(' . tx_dlf_solr::escapeQuery($this->piVars['extQuery'][$i]) . ')';
 
                         }
 
@@ -613,7 +613,7 @@ 
 
                 if (!empty($this->piVars['id']) && \TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->piVars['id'])) {
 
-                    $params['filterquery'][]['query'] = 'uid:('.$this->piVars['id'].') OR partof:('.$this->piVars['id'].')';
+                    $params['filterquery'][]['query'] = 'uid:(' . $this->piVars['id'] . ') OR partof:(' . $this->piVars['id'] . ')';
 
                     $label .= htmlspecialchars(sprintf($this->pi_getLL('in', ''), tx_dlf_document::getTitle($this->piVars['id'])));
 
@@ -628,7 +628,7 @@ 
 
                     $index_name = tx_dlf_helper::getIndexName($this->piVars['collection'], 'tx_dlf_collections', $this->conf['pages']);
 
-                    $params['filterquery'][]['query'] = 'collection_faceting:("'.tx_dlf_solr::escapeQuery($index_name).'")';
+                    $params['filterquery'][]['query'] = 'collection_faceting:("' . tx_dlf_solr::escapeQuery($index_name) . '")';
 
                     $label .= sprintf($this->pi_getLL('in', '', TRUE), tx_dlf_helper::translate($index_name, 'tx_dlf_collections', $this->conf['pages']));
 
@@ -641,7 +641,7 @@ 
 
                 $collIds = explode(',', $this->conf['collections']);
 
-                $collIndexNames = array ();
+                $collIndexNames = array();
 
                 foreach ($collIds as $collId) {
 
@@ -650,7 +650,7 @@ 
                 }
 
                 // Last value is fake and used for distinction in $this->addCurrentCollection()
-                $params['filterquery'][]['query'] = 'collection_faceting:("'.implode('" OR "', $collIndexNames).'" OR "FakeValueForDistinction")';
+                $params['filterquery'][]['query'] = 'collection_faceting:("' . implode('" OR "', $collIndexNames) . '" OR "FakeValueForDistinction")';
 
             }
 
@@ -658,7 +658,7 @@ 
             $params['query'] = !empty($query) ? $query : '*';
             $params['start'] = 0;
             $params['rows'] = 0;
-            $params['sort'] = array ('score' => 'desc');
+            $params['sort'] = array('score' => 'desc');
 
             // Instantiate search object.
             $solr = tx_dlf_solr::getInstance($this->conf['solrcore']);
@@ -667,7 +667,7 @@ 
 
                 if (TYPO3_DLOG) {
 
-                    \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->main('.$content.', [data])] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR, $conf);
+                    \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->main(' . $content . ', [data])] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR, $conf);
 
                 }
 
@@ -682,7 +682,7 @@ 
             // Perform search.
             $list = $solr->search();
 
-            $list->metadata = array (
+            $list->metadata = array(
                 'label' => $label,
                 'thumbnail' => '',
                 'searchString' => $this->piVars['query'],
@@ -695,7 +695,7 @@ 
             // Clean output buffer.
             \TYPO3\CMS\Core\Utility\GeneralUtility::cleanOutputBuffers();
 
-            $additionalParams = array ();
+            $additionalParams = array();
 
             if (!empty($this->piVars['logicalPage'])) {
 
@@ -729,7 +729,7 @@ 
             $linkConf['additionalParams'] = \TYPO3\CMS\Core\Utility\GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE);
 
             // Send headers.
-            header('Location: '.\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));
+            header('Location: ' . \TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));
 
             // Flush output buffer and end script processing.
             ob_end_flush();
@@ -754,15 +754,15 @@ 
 
         $this->init($conf);
 
-        $menuArray = array ();
+        $menuArray = array();
 
         // Set default value for facet search.
-        $search = array (
+        $search = array(
             'query' => '*',
-            'params' => array (
-                'component' => array (
-                    'facetset' => array (
-                        'facet' => array ()
+            'params' => array(
+                'component' => array(
+                    'facetset' => array(
+                        'facet' => array()
                     )
                 )
             )
@@ -790,24 +790,24 @@ 
 
             if (TYPO3_DLOG) {
 
-                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->makeFacetsMenuArray('.$content.', [data])] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR, $conf);
+                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_search->makeFacetsMenuArray(' . $content . ', [data])] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR, $conf);
 
             }
 
-            return array ();
+            return array();
 
         }
 
         // Set needed parameters for facet search.
         if (empty($search['params']['filterquery'])) {
 
-            $search['params']['filterquery'] = array ();
+            $search['params']['filterquery'] = array();
 
         }
 
         foreach ($this->conf['facets'] as $field => $name) {
 
-            $search['params']['component']['facetset']['facet'][] = array (
+            $search['params']['component']['facetset']['facet'][] = array(
                 'type' => 'field',
                 'key' => $field,
                 'field' => $field,
@@ -832,7 +832,7 @@ 
         // Process results.
         foreach ($facet as $field => $values) {
 
-            $entryArray = array ();
+            $entryArray = array();
 
             $entryArray['title'] = htmlspecialchars($this->conf['facets'][$field]);
 

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -200,14 +200,14 @@ 
 
         foreach (array ('AND', 'OR', 'NOT') as $operator) {
 
-            $operatorOptions .= '<option class="tx-dlf-search-operator-option tx-dlf-search-operator-'.$operator.'" value="'.$operator.'">'.$this->pi_getLL($operator, '', TRUE).'</option>';
+            $operatorOptions .= '<option class="tx-dlf-search-operator-option tx-dlf-search-operator-'.$operator.'" value="'.$operator.'">'.$this->pi_getLL($operator, '', true).'</option>';
 
         }
 
         // Get field selector options.
         $fieldSelectorOptions = '';
 
-        $searchFields = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['extendedFields'], TRUE);
+        $searchFields = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['extendedFields'], true);
 
         foreach ($searchFields as $searchField) {
 
@@ -263,7 +263,7 @@ 
         // Get facets from plugin configuration.
         $facets = array ();
 
-        foreach (\TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['facets'], TRUE) as $facet) {
+        foreach (\TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['facets'], true) as $facet) {
 
             $facets[$facet.'_faceting'] = tx_dlf_helper::translate($facet, 'tx_dlf_metadata', $this->conf['pages']);
 
@@ -390,7 +390,7 @@ 
         $queryColumn = array_column($search['params']['filterquery'], 'query');
         $index = array_search($field.':("'.tx_dlf_solr::escapeQuery($value).'")', $queryColumn);
 
-        if ($index !== FALSE) {
+        if ($index !== false) {
 
             // Facet is selected, thus remove it from filter.
             unset($queryColumn[$index]);
@@ -404,7 +404,7 @@ 
             //Reset facets
             if ($this->conf['resetFacets']) {
                 //remove ($count) for selected facet in template
-                $entryArray['count'] = FALSE;
+                $entryArray['count'] = false;
                 //build link to delete selected facet
                 $entryArray['_OVERRIDE_HREF'] = $this->pi_linkTP_keepPIvars_url(array ('query' => $search['query'], 'fq' => $queryColumn));
                 $entryArray['title'] = sprintf($this->pi_getLL('resetFacet', ''), $entryArray['title']);
@@ -440,7 +440,7 @@ 
         $this->init($conf);
 
         // Disable caching for this plugin.
-        $this->setCache(FALSE);
+        $this->setCache(false);
 
         // Quit without doing anything if required variables are not set.
         if (empty($this->conf['solrcore'])) {
@@ -536,7 +536,7 @@ 
             }
 
             // Build label for result list.
-            $label = $this->pi_getLL('search', '', TRUE);
+            $label = $this->pi_getLL('search', '', true);
 
             if (!empty($this->piVars['query'])) {
 
@@ -573,7 +573,7 @@ 
 
                 $allowedOperators = array ('AND', 'OR', 'NOT');
 
-                $allowedFields = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['extendedFields'], TRUE);
+                $allowedFields = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->conf['extendedFields'], true);
 
                 for ($i = 0; $i < count($this->piVars['extQuery']); $i++) {
 
@@ -630,7 +630,7 @@ 
 
                     $params['filterquery'][]['query'] = 'collection_faceting:("'.tx_dlf_solr::escapeQuery($index_name).'")';
 
-                    $label .= sprintf($this->pi_getLL('in', '', TRUE), tx_dlf_helper::translate($index_name, 'tx_dlf_collections', $this->conf['pages']));
+                    $label .= sprintf($this->pi_getLL('in', '', true), tx_dlf_helper::translate($index_name, 'tx_dlf_collections', $this->conf['pages']));
 
                 }
 
@@ -726,7 +726,7 @@ 
 
             }
 
-            $linkConf['additionalParams'] = \TYPO3\CMS\Core\Utility\GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE);
+            $linkConf['additionalParams'] = \TYPO3\CMS\Core\Utility\GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false);
 
             // Send headers.
             header('Location: '.\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));

common/class.tx_dlf_solr.php

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -74,7 +74,7 @@ 
      * @var	boolean
      * @access protected
      */
-    protected $ready = FALSE;
+    protected $ready = false;
 
     /**
      * This holds the singleton search objects with their core as array key
@@ -329,7 +329,7 @@ 
         $start = max(intval($start), 0);
 
         // Check if core already exists.
-        if (self::getInstance('dlfCore'.$start) === NULL) {
+        if (self::getInstance('dlfCore'.$start) === null) {
 
             return $start;
 
@@ -430,7 +430,7 @@ 
                 'core' => $this->core,
                 'pid' => $this->cPid,
                 'order' => 'score',
-                'order.asc' => TRUE,
+                'order.asc' => true,
                 'numberOfHits' => $this->numberOfHits,
                 'numberOfToplevelHits' => $numberOfToplevelHits
             )
@@ -465,7 +465,7 @@ 
 
         $resultSet = [];
 
-        if (($entry = $cache->get($cacheIdentifier)) === FALSE) {
+        if (($entry = $cache->get($cacheIdentifier)) === false) {
 
             $selectQuery = $this->service->createSelect(array_merge($this->params, $parameters));
             $result = $this->service->select($selectQuery);
@@ -690,7 +690,7 @@ 
             $this->core = $core;
 
             // Instantiation successful!
-            $this->ready = TRUE;
+            $this->ready = true;
 
         } catch (Exception $e) {