Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Push — master ( 82b7d7...c9e6b0 )
by Sebastian
02:23
created
plugins/basket/class.tx_dlf_basket.php 2 patches
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
             $GLOBALS['TSFE']->fe_user->setKey('ses', 'tx_dlf_basket', '');
75 75
 
76
-            $GLOBALS['TSFE']->fe_user->sesData_change = true;
76
+            $GLOBALS['TSFE']->fe_user->sesData_change = TRUE;
77 77
 
78 78
             $GLOBALS['TSFE']->fe_user->storeSessionData();
79 79
 
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 
413 413
         }
414 414
 
415
-        if ($page != null || $_piVars['addToBasket'] == 'list') {
415
+        if ($page != NULL || $_piVars['addToBasket'] == 'list') {
416 416
 
417 417
             $documentItem = array(
418 418
                 'id' => intval($_piVars['id']),
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
             $document = tx_dlf_document::getInstance($documentItem['id'],0);
443 443
 
444 444
             // set endpage for toc and subentry based on logid
445
-            if (($_piVars['addToBasket'] == 'subentry') OR ($_piVars['addToBasket'] == 'toc')) {
445
+            if (($_piVars['addToBasket'] == 'subentry') or ($_piVars['addToBasket'] == 'toc')) {
446 446
 
447 447
                 $smLinks = $document->smLinks;
448 448
 
@@ -724,7 +724,7 @@  discard block
 block discarded – undo
724 724
 
725 725
         }
726 726
 
727
-        return false;
727
+        return FALSE;
728 728
 
729 729
     }
730 730
 
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -210,13 +210,13 @@  discard block
 block discarded – undo
210 210
 
211 211
         if ($GLOBALS['TYPO3_DB']->sql_num_rows($resultMail) > 0) {
212 212
 
213
-            $mails = array();
213
+            $mails = array ();
214 214
 
215 215
             $mailForm = '<select name="tx_dlf[mail_action]">';
216 216
 
217 217
             $mailForm .= '<option value="">'.$this->pi_getLL('chooseMail', '', TRUE).'</option>';
218 218
 
219
-            while($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($resultMail)) {
219
+            while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($resultMail)) {
220 220
 
221 221
                 $mails[] = $row;
222 222
 
@@ -255,13 +255,13 @@  discard block
 block discarded – undo
255 255
 
256 256
         if ($GLOBALS['TYPO3_DB']->sql_num_rows($resultPrinter) > 0) {
257 257
 
258
-            $printers = array();
258
+            $printers = array ();
259 259
 
260 260
             $printForm = '<select name="tx_dlf[print_action]">';
261 261
 
262 262
             $printForm .= '<option value="">'.$this->pi_getLL('choosePrinter', '', TRUE).'</option>';
263 263
 
264
-            while($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($resultPrinter)) {
264
+            while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($resultPrinter)) {
265 265
 
266 266
                 $printers[] = $row;
267 267
 
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 
415 415
         if ($page != null || $_piVars['addToBasket'] == 'list') {
416 416
 
417
-            $documentItem = array(
417
+            $documentItem = array (
418 418
                 'id' => intval($_piVars['id']),
419 419
                 'startpage' => intval($_piVars['startpage']),
420 420
                 'endpage' => intval($_piVars['endpage']),
@@ -434,12 +434,12 @@  discard block
 block discarded – undo
434 434
 
435 435
             } else {
436 436
 
437
-                $items = array();
437
+                $items = array ();
438 438
 
439 439
             }
440 440
 
441 441
             // get document instance to load further information
442
-            $document = tx_dlf_document::getInstance($documentItem['id'],0);
442
+            $document = tx_dlf_document::getInstance($documentItem['id'], 0);
443 443
 
444 444
             // set endpage for toc and subentry based on logid
445 445
             if (($_piVars['addToBasket'] == 'subentry') OR ($_piVars['addToBasket'] == 'toc')) {
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
 
524 524
             }
525 525
 
526
-            $update = array('doc_ids' => json_encode($items));
526
+            $update = array ('doc_ids' => json_encode($items));
527 527
 
528 528
             $GLOBALS['TYPO3_DB']->exec_UPDATEquery('tx_dlf_basket', 'uid='.intval($basketData['uid']), $update);
529 529
 
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
 
532 532
         }
533 533
 
534
-        return array('basketData' => $basketData, 'jsOutput' => $output);
534
+        return array ('basketData' => $basketData, 'jsOutput' => $output);
535 535
 
536 536
     }
537 537
 
@@ -581,11 +581,11 @@  discard block
 block discarded – undo
581 581
 
582 582
         if (empty($items)) {
583 583
 
584
-            $update = array('doc_ids' => '');
584
+            $update = array ('doc_ids' => '');
585 585
 
586 586
         } else {
587 587
 
588
-            $update = array('doc_ids' => json_encode($items));
588
+            $update = array ('doc_ids' => json_encode($items));
589 589
 
590 590
         }
591 591
 
@@ -639,7 +639,7 @@  discard block
 block discarded – undo
639 639
     public function getDocumentData($id, $data) {
640 640
 
641 641
         // get document instance to load further information
642
-        $document = tx_dlf_document::getInstance($id,0);
642
+        $document = tx_dlf_document::getInstance($id, 0);
643 643
 
644 644
         if ($document) {
645 645
 
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
 
715 715
             }
716 716
 
717
-            return array(
717
+            return array (
718 718
                 'downloadUrl' => $downloadUrl,
719 719
                 'downloadLink' => $downloadLink,
720 720
                 'pageNums'	=> $pageNums,
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
             ->setFrom($from)
801 801
 
802 802
             // Set the To addresses with an associative array
803
-            ->setTo(array($mailData['mail'] => $mailData['name']))
803
+            ->setTo(array ($mailData['mail'] => $mailData['name']))
804 804
 
805 805
             ->setBody($body, 'text/html')
806 806
 
@@ -808,7 +808,7 @@  discard block
 block discarded – undo
808 808
         ;
809 809
 
810 810
         // protocol
811
-        $insertArray = array(
811
+        $insertArray = array (
812 812
             'pid' => $this->conf['pages'],
813 813
             'file_name' => $pdfUrl,
814 814
             'count_pages' => $numberOfPages,
@@ -908,7 +908,7 @@  discard block
 block discarded – undo
908 908
         }
909 909
 
910 910
         // protocol
911
-        $insertArray = array(
911
+        $insertArray = array (
912 912
             'pid' => $this->conf['pages'],
913 913
             'file_name' => $pdfUrl,
914 914
             'count_pages' => $numberOfPages,
Please login to merge, or discard this patch.
plugins/audioplayer/class.tx_dlf_audioplayer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@
 block discarded – undo
55 55
 			$(document).ready(function() {
56 56
 				tx_dlf_audioplayer = new dlfAudioPlayer({
57 57
 					audio: {
58
-						mimeType: "' . $this->audio['mimetype'] . '",
59
-						title: "' . $this->audio['label'] . '",
60
-						url:  "' . $this->audio['url'] . '"
58
+						mimeType: "' . $this->audio['mimetype'].'",
59
+						title: "' . $this->audio['label'].'",
60
+						url:  "' . $this->audio['url'].'"
61 61
 					},
62 62
 					parentElId: "tx-dlf-audio",
63 63
 					swfPath: "'.\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::siteRelPath($this->extKey).'lib/jPlayer/jquery.jplayer.swf"
Please login to merge, or discard this patch.
plugins/pageview/class.tx_dlf_pageview.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
 
167 167
             $params = array(
168 168
                 'id' => $this->piVars['id'],
169
-                'addToBasket' => true
169
+                'addToBasket' => TRUE
170 170
             );
171 171
 
172 172
             if (empty($this->piVars['page'])) {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -86,11 +86,11 @@  discard block
 block discarded – undo
86 86
 			window.onload = function() {
87 87
 				if (dlfUtils.exists(dlfViewer)) {
88 88
 					tx_dlf_viewer = new dlfViewer({
89
-						controls: ["' . implode('", "', $this->controls) . '"],
90
-						div: "' . $this->conf['elementId'] . '",
91
-						images: ' . json_encode($this->images) . ',
92
-						fulltexts: '. json_encode($this->fulltexts) . ',
93
-						useInternalProxy: ' . ($this->conf['useInternalProxy'] ? 1 : 0) .'
89
+						controls: ["' . implode('", "', $this->controls).'"],
90
+						div: "' . $this->conf['elementId'].'",
91
+						images: ' . json_encode($this->images).',
92
+						fulltexts: '. json_encode($this->fulltexts).',
93
+						useInternalProxy: ' . ($this->conf['useInternalProxy'] ? 1 : 0).'
94 94
 					})
95 95
 				}
96 96
 			}
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
      */
110 110
     protected function addInteraction() {
111 111
 
112
-        $markerArray = array();
112
+        $markerArray = array ();
113 113
 
114 114
         if ($this->piVars['id']) {
115 115
 
@@ -157,14 +157,14 @@  discard block
 block discarded – undo
157 157
      */
158 158
     protected function addBasketForm() {
159 159
 
160
-        $markerArray = array();
160
+        $markerArray = array ();
161 161
 
162 162
         // Add basket button
163 163
         if ($this->conf['basketButton'] && $this->conf['targetBasket'] && $this->piVars['id']) {
164 164
 
165 165
             $label = $this->pi_getLL('addBasket', '', TRUE);
166 166
 
167
-            $params = array(
167
+            $params = array (
168 168
                 'id' => $this->piVars['id'],
169 169
                 'addToBasket' => true
170 170
             );
@@ -352,9 +352,9 @@  discard block
 block discarded – undo
352 352
 
353 353
             // Set default values if not set.
354 354
             // $this->piVars['page'] may be integer or string (physical structure @ID)
355
-            if ( (int)$this->piVars['page'] > 0 || empty($this->piVars['page'])) {
355
+            if ((int) $this->piVars['page'] > 0 || empty($this->piVars['page'])) {
356 356
 
357
-                $this->piVars['page'] = \TYPO3\CMS\Core\Utility\MathUtility::forceIntegerInRange((int)$this->piVars['page'], 1, $this->doc->numPages, 1);
357
+                $this->piVars['page'] = \TYPO3\CMS\Core\Utility\MathUtility::forceIntegerInRange((int) $this->piVars['page'], 1, $this->doc->numPages, 1);
358 358
 
359 359
             } else {
360 360
 
Please login to merge, or discard this patch.
hooks/class.tx_dlf_em.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
                     $usergroup = array_unique(array_merge(array ($groupUid), $resArray['usergroup']));
174 174
 
175 175
                     // Try to configure user.
176
-                    $data = array();
176
+                    $data = array ();
177 177
                     $data['be_users'][$resArray['uid']] = array (
178 178
                         'admin' => 0,
179 179
                         'usergroup' => implode(',', $usergroup),
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
                 // Try to create user.
231 231
                 $tempUid = uniqid('NEW');
232 232
 
233
-                $data = array();
233
+                $data = array ();
234 234
                 $data['be_users'][$tempUid] = array (
235 235
                     'pid' => 0,
236 236
                     'username' => '_cli_dlf',
@@ -342,10 +342,10 @@  discard block
 block discarded – undo
342 342
 
343 343
         // Check if group "_cli_dlf" exists and is not disabled.
344 344
         $result = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
345
-            'uid,non_exclude_fields,tables_select,tables_modify,' .
345
+            'uid,non_exclude_fields,tables_select,tables_modify,'.
346 346
                 $GLOBALS['TCA']['be_groups']['ctrl']['enablecolumns']['disabled'],
347 347
             'be_groups',
348
-            'title=' . $GLOBALS['TYPO3_DB']->fullQuoteStr('_cli_dlf', 'be_groups') .
348
+            'title='.$GLOBALS['TYPO3_DB']->fullQuoteStr('_cli_dlf', 'be_groups').
349 349
                 \TYPO3\CMS\Backend\Utility\BackendUtility::deleteClause('be_groups')
350 350
         );
351 351
 
@@ -388,8 +388,8 @@  discard block
 block discarded – undo
388 388
                     $tables_modify = array_unique(array_merge($settings['tables_modify'], $resArray['tables_modify']));
389 389
 
390 390
                     // Try to configure usergroup.
391
-                    $data = array();
392
-                    $data['be_groups'][$resArray['uid']] = array(
391
+                    $data = array ();
392
+                    $data['be_groups'][$resArray['uid']] = array (
393 393
                         'non_exclude_fields' => implode(',', $non_exclude_fields),
394 394
                         'tables_select' => implode(',', $tables_select),
395 395
                         'tables_modify' => implode(',', $tables_modify),
@@ -444,8 +444,8 @@  discard block
 block discarded – undo
444 444
                 // Try to create usergroup.
445 445
                 $tempUid = uniqid('NEW');
446 446
 
447
-                $data = array();
448
-                $data['be_groups'][$tempUid] = array(
447
+                $data = array ();
448
+                $data['be_groups'][$tempUid] = array (
449 449
                     'pid' => 0,
450 450
                     'title' => '_cli_dlf',
451 451
                     'description' => $GLOBALS['LANG']->getLL('cliUserGroup.grpDescription'),
Please login to merge, or discard this patch.
hooks/class.tx_dlf_hacks.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
      *
32 32
      * @return	void
33 33
      */
34
-    public function construct_postProcessRecordId(SimpleXMLElement &$xml, &$record_id) {
34
+    public function construct_postProcessRecordId(SimpleXMLElement & $xml, &$record_id) {
35 35
 
36 36
         if (!$record_id) {
37 37
 
Please login to merge, or discard this patch.
hooks/class.tx_dlf_tcemain.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
                             } else {
338 338
 
339 339
                                 // Reindex document.
340
-                                $doc =& tx_dlf_document::getInstance($id);
340
+                                $doc = & tx_dlf_document::getInstance($id);
341 341
 
342 342
                                 if ($doc->ready) {
343 343
 
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
                     case 'undelete':
423 423
 
424 424
                         // Reindex document.
425
-                        $doc =& tx_dlf_document::getInstance($id);
425
+                        $doc = & tx_dlf_document::getInstance($id);
426 426
 
427 427
                         if ($doc->ready) {
428 428
 
Please login to merge, or discard this patch.
hooks/class.tx_dlf_doctype.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -161,7 +161,7 @@
 block discarded – undo
161 161
         if (!empty($this->piVars['id'])) {
162 162
 
163 163
             // Get instance of tx_dlf_document.
164
-            $this->doc =& tx_dlf_document::getInstance($this->piVars['id']);
164
+            $this->doc = & tx_dlf_document::getInstance($this->piVars['id']);
165 165
 
166 166
             if (!$this->doc->ready) {
167 167
 
Please login to merge, or discard this patch.
ext_emconf.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * LICENSE.txt file that was distributed with this source code.
10 10
  */
11 11
 
12
-$EM_CONF[$_EXTKEY] = array(
12
+$EM_CONF[$_EXTKEY] = array (
13 13
     'title' => 'Kitodo.Presentation',
14 14
     'description' => 'Base plugins, modules, services and API of the Digital Library Framework. It is part of the community-based Kitodo Digitization Suite.',
15 15
     'category' => 'fe',
@@ -27,14 +27,14 @@  discard block
 block discarded – undo
27 27
     'clearCacheOnLoad' => FALSE,
28 28
     'lockType' => '',
29 29
     'version' => '2.1.0',
30
-    'constraints' => array(
31
-        'depends' => array(
30
+    'constraints' => array (
31
+        'depends' => array (
32 32
             'php' => '5.3.7-',
33 33
             'typo3' => '6.2.0-7.9.99',
34 34
         ),
35
-        'conflicts' => array(
35
+        'conflicts' => array (
36 36
         ),
37
-        'suggests' => array(
37
+        'suggests' => array (
38 38
         ),
39 39
     ),
40 40
     '_md5_values_when_last_written' => '',
Please login to merge, or discard this patch.
plugins/listview/class.tx_dlf_listview.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
                         'page' => $this->list[$number]['page']
194 194
                     );
195 195
 
196
-                    if(!empty($this->piVars['logicalPage'])) {
196
+                    if (!empty($this->piVars['logicalPage'])) {
197 197
 
198 198
                         $additionalParams['logicalPage'] = $this->piVars['logicalPage'];
199 199
 
@@ -318,9 +318,9 @@  discard block
 block discarded – undo
318 318
             'forceAbsoluteUrl' => 1
319 319
         );
320 320
 
321
-        if(!empty($this->piVars['logicalPage'])) {
321
+        if (!empty($this->piVars['logicalPage'])) {
322 322
 
323
-            $linkConf['additionalParams'] = \TYPO3\CMS\Core\Utility\GeneralUtility::implodeArrayForUrl($this->prefixId,array('logicalPage' => $this->piVars['logicalPage']), '', TRUE, FALSE);
323
+            $linkConf['additionalParams'] = \TYPO3\CMS\Core\Utility\GeneralUtility::implodeArrayForUrl($this->prefixId, array ('logicalPage' => $this->piVars['logicalPage']), '', TRUE, FALSE);
324 324
 
325 325
         }
326 326
 
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
                             'highlight_word' => preg_replace('/\s\s+/', ';', $this->list->metadata['searchString'])
438 438
                         );
439 439
 
440
-                        if(!empty($this->piVars['logicalPage'])) {
440
+                        if (!empty($this->piVars['logicalPage'])) {
441 441
 
442 442
                             $additionalParams['logicalPage'] = $this->piVars['logicalPage'];
443 443
 
Please login to merge, or discard this patch.