We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -46,7 +46,8 @@ |
||
| 46 | 46 | |
| 47 | 47 | public static function paragraphs(array $paragraphs) |
| 48 | 48 | { |
| 49 | - $paragraphs = array_values(array_filter($paragraphs, function ($entry) { |
|
| 49 | + $paragraphs = array_values(array_filter($paragraphs, function ($entry) |
|
| 50 | + { |
|
| 50 | 51 | return !empty($entry); |
| 51 | 52 | })); |
| 52 | 53 | |
@@ -670,7 +670,8 @@ |
||
| 670 | 670 | } |
| 671 | 671 | } |
| 672 | 672 | |
| 673 | - return array_filter($allMdIds, function ($element) { |
|
| 673 | + return array_filter($allMdIds, function ($element) |
|
| 674 | + { |
|
| 674 | 675 | return !empty($element); |
| 675 | 676 | }); |
| 676 | 677 | } |
@@ -204,7 +204,8 @@ discard block |
||
| 204 | 204 | RST); |
| 205 | 205 | |
| 206 | 206 | // Sort tables alphabetically |
| 207 | - usort($tables, function ($lhs, $rhs) { |
|
| 207 | + usort($tables, function ($lhs, $rhs) |
|
| 208 | + { |
|
| 208 | 209 | return $lhs->name <=> $rhs->name; |
| 209 | 210 | }); |
| 210 | 211 | |
@@ -231,7 +232,8 @@ discard block |
||
| 231 | 232 | 'description' => 'Description', |
| 232 | 233 | ]]; |
| 233 | 234 | |
| 234 | - $rows = array_map(function ($column) use ($page) { |
|
| 235 | + $rows = array_map(function ($column) use ($page) |
|
| 236 | + { |
|
| 235 | 237 | return [ |
| 236 | 238 | 'field' => ( |
| 237 | 239 | $page->format($column->name, ['bold' => $column->isPrimary]) |
@@ -71,7 +71,8 @@ discard block |
||
| 71 | 71 | $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration(); |
| 72 | 72 | |
| 73 | 73 | if ($this->disableJsonWrappedResponse) { |
| 74 | - $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) { |
|
| 74 | + $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) |
|
| 75 | + { |
|
| 75 | 76 | return $ext !== 'Resources/Core/Functional/Extensions/json_response'; |
| 76 | 77 | }); |
| 77 | 78 | } |
@@ -152,7 +153,8 @@ discard block |
||
| 152 | 153 | $jsonDocuments = json_decode(file_get_contents($path), true); |
| 153 | 154 | |
| 154 | 155 | $updateQuery = $solr->service->createUpdate(); |
| 155 | - $documents = array_map(function ($jsonDoc) use ($updateQuery) { |
|
| 156 | + $documents = array_map(function ($jsonDoc) use ($updateQuery) |
|
| 157 | + { |
|
| 156 | 158 | $document = $updateQuery->createDocument(); |
| 157 | 159 | foreach ($jsonDoc as $key => $value) { |
| 158 | 160 | $document->setField($key, $value); |
@@ -400,7 +400,8 @@ |
||
| 400 | 400 | return ''; |
| 401 | 401 | } |
| 402 | 402 | |
| 403 | - $makeCacheKey = function ($pid, $uid) { |
|
| 403 | + $makeCacheKey = function ($pid, $uid) |
|
| 404 | + { |
|
| 404 | 405 | return $pid . '.' . $uid; |
| 405 | 406 | }; |
| 406 | 407 | |
@@ -20,7 +20,9 @@ discard block |
||
| 20 | 20 | $this->limit = count($solrSearch); |
| 21 | 21 | } |
| 22 | 22 | |
| 23 | - public function getSource() {} |
|
| 23 | + public function getSource() |
|
| 24 | + { |
|
| 25 | +} |
|
| 24 | 26 | |
| 25 | 27 | public function execute($returnRawQueryResult = false) |
| 26 | 28 | { |
@@ -35,7 +37,9 @@ discard block |
||
| 35 | 37 | return $result; |
| 36 | 38 | } |
| 37 | 39 | |
| 38 | - public function setOrderings(array $orderings) {} |
|
| 40 | + public function setOrderings(array $orderings) |
|
| 41 | + { |
|
| 42 | +} |
|
| 39 | 43 | |
| 40 | 44 | public function setLimit($limit) |
| 41 | 45 | { |
@@ -49,28 +53,60 @@ discard block |
||
| 49 | 53 | return $this; |
| 50 | 54 | } |
| 51 | 55 | |
| 52 | - public function matching($constraint) {} |
|
| 53 | - public function logicalAnd($constraint1) {} |
|
| 54 | - public function logicalOr($constraint1) {} |
|
| 55 | - public function logicalNot(ConstraintInterface $constraint) {} |
|
| 56 | - public function equals($propertyName, $operand, $caseSensitive = true) {} |
|
| 57 | - public function like($propertyName, $operand) {} |
|
| 58 | - public function contains($propertyName, $operand) {} |
|
| 59 | - public function in($propertyName, $operand) {} |
|
| 60 | - public function lessThan($propertyName, $operand) {} |
|
| 61 | - public function lessThanOrEqual($propertyName, $operand) {} |
|
| 62 | - public function greaterThan($propertyName, $operand) {} |
|
| 63 | - public function greaterThanOrEqual($propertyName, $operand) {} |
|
| 64 | - public function getType() {} |
|
| 65 | - public function setQuerySettings(QuerySettingsInterface $querySettings) {} |
|
| 66 | - public function getQuerySettings() {} |
|
| 56 | + public function matching($constraint) |
|
| 57 | + { |
|
| 58 | +} |
|
| 59 | + public function logicalAnd($constraint1) |
|
| 60 | + { |
|
| 61 | +} |
|
| 62 | + public function logicalOr($constraint1) |
|
| 63 | + { |
|
| 64 | +} |
|
| 65 | + public function logicalNot(ConstraintInterface $constraint) |
|
| 66 | + { |
|
| 67 | +} |
|
| 68 | + public function equals($propertyName, $operand, $caseSensitive = true) |
|
| 69 | + { |
|
| 70 | +} |
|
| 71 | + public function like($propertyName, $operand) |
|
| 72 | + { |
|
| 73 | +} |
|
| 74 | + public function contains($propertyName, $operand) |
|
| 75 | + { |
|
| 76 | +} |
|
| 77 | + public function in($propertyName, $operand) |
|
| 78 | + { |
|
| 79 | +} |
|
| 80 | + public function lessThan($propertyName, $operand) |
|
| 81 | + { |
|
| 82 | +} |
|
| 83 | + public function lessThanOrEqual($propertyName, $operand) |
|
| 84 | + { |
|
| 85 | +} |
|
| 86 | + public function greaterThan($propertyName, $operand) |
|
| 87 | + { |
|
| 88 | +} |
|
| 89 | + public function greaterThanOrEqual($propertyName, $operand) |
|
| 90 | + { |
|
| 91 | +} |
|
| 92 | + public function getType() |
|
| 93 | + { |
|
| 94 | +} |
|
| 95 | + public function setQuerySettings(QuerySettingsInterface $querySettings) |
|
| 96 | + { |
|
| 97 | +} |
|
| 98 | + public function getQuerySettings() |
|
| 99 | + { |
|
| 100 | +} |
|
| 67 | 101 | |
| 68 | 102 | public function count() |
| 69 | 103 | { |
| 70 | 104 | // TODO? |
| 71 | 105 | } |
| 72 | 106 | |
| 73 | - public function getOrderings() {} |
|
| 107 | + public function getOrderings() |
|
| 108 | + { |
|
| 109 | +} |
|
| 74 | 110 | |
| 75 | 111 | public function getLimit() |
| 76 | 112 | { |
@@ -82,8 +118,16 @@ discard block |
||
| 82 | 118 | return $this->offset; |
| 83 | 119 | } |
| 84 | 120 | |
| 85 | - public function getConstraint() {} |
|
| 86 | - public function isEmpty($propertyName) {} |
|
| 87 | - public function setSource(SourceInterface $source) {} |
|
| 88 | - public function getStatement() {} |
|
| 121 | + public function getConstraint() |
|
| 122 | + { |
|
| 123 | +} |
|
| 124 | + public function isEmpty($propertyName) |
|
| 125 | + { |
|
| 126 | +} |
|
| 127 | + public function setSource(SourceInterface $source) |
|
| 128 | + { |
|
| 129 | +} |
|
| 130 | + public function getStatement() |
|
| 131 | + { |
|
| 132 | +} |
|
| 89 | 133 | } |
@@ -58,7 +58,8 @@ |
||
| 58 | 58 | * |
| 59 | 59 | * @return void |
| 60 | 60 | */ |
| 61 | - public function getTyposcriptConfigFromPluginSiteRoot($params) { |
|
| 61 | + public function getTyposcriptConfigFromPluginSiteRoot($params) |
|
| 62 | + { |
|
| 62 | 63 | $objectManager = GeneralUtility::makeInstance(ObjectManager::class); |
| 63 | 64 | $pid = $params['flexParentDatabaseRow']['pid']; |
| 64 | 65 | $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid); |
@@ -30,7 +30,8 @@ |
||
| 30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
| 31 | 31 | * @return void |
| 32 | 32 | */ |
| 33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
| 33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) |
|
| 34 | + { |
|
| 34 | 35 | if ($pageSelectForm) { |
| 35 | 36 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
| 36 | 37 | $uri = $uriBuilder->reset() |
@@ -71,7 +71,8 @@ discard block |
||
| 71 | 71 | * |
| 72 | 72 | * @return void |
| 73 | 73 | */ |
| 74 | - private function getAuthors() { |
|
| 74 | + private function getAuthors() |
|
| 75 | + { |
|
| 75 | 76 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
| 76 | 77 | |
| 77 | 78 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -93,7 +94,8 @@ discard block |
||
| 93 | 94 | } |
| 94 | 95 | } |
| 95 | 96 | |
| 96 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
| 97 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
| 98 | + { |
|
| 97 | 99 | $profile = new OrcidProfile($orcidId); |
| 98 | 100 | $name = $profile->getFullName(); |
| 99 | 101 | if (!empty($name)) { |
@@ -107,7 +109,8 @@ discard block |
||
| 107 | 109 | } |
| 108 | 110 | } |
| 109 | 111 | |
| 110 | - private function getAuthorFromXml($authors, $i) { |
|
| 112 | + private function getAuthorFromXml($authors, $i) |
|
| 113 | + { |
|
| 111 | 114 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
| 112 | 115 | |
| 113 | 116 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -150,7 +153,8 @@ discard block |
||
| 150 | 153 | } |
| 151 | 154 | } |
| 152 | 155 | |
| 153 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
| 156 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
| 157 | + { |
|
| 154 | 158 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
| 155 | 159 | if ($displayForm) { |
| 156 | 160 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -164,7 +168,8 @@ discard block |
||
| 164 | 168 | * |
| 165 | 169 | * @return void |
| 166 | 170 | */ |
| 167 | - private function getHolders() { |
|
| 171 | + private function getHolders() |
|
| 172 | + { |
|
| 168 | 173 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
| 169 | 174 | |
| 170 | 175 | if (!empty($holders)) { |
@@ -181,7 +186,8 @@ discard block |
||
| 181 | 186 | } |
| 182 | 187 | } |
| 183 | 188 | |
| 184 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
| 189 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
| 190 | + { |
|
| 185 | 191 | $profile = new ViafProfile($viafId); |
| 186 | 192 | $name = $profile->getFullName(); |
| 187 | 193 | if (!empty($name)) { |
@@ -195,7 +201,8 @@ discard block |
||
| 195 | 201 | } |
| 196 | 202 | } |
| 197 | 203 | |
| 198 | - private function getHolderFromXml($holders, $i) { |
|
| 204 | + private function getHolderFromXml($holders, $i) |
|
| 205 | + { |
|
| 199 | 206 | $this->getHolderFromXmlDisplayForm($holders, $i); |
| 200 | 207 | // Append "valueURI" to name using Unicode unit separator. |
| 201 | 208 | if (isset($holders[$i]['valueURI'])) { |
@@ -203,7 +210,8 @@ discard block |
||
| 203 | 210 | } |
| 204 | 211 | } |
| 205 | 212 | |
| 206 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
| 213 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
| 214 | + { |
|
| 207 | 215 | // Check if there is a display form. |
| 208 | 216 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
| 209 | 217 | if ($displayForm) { |
@@ -218,7 +226,8 @@ discard block |
||
| 218 | 226 | * |
| 219 | 227 | * @return void |
| 220 | 228 | */ |
| 221 | - private function getPlaces() { |
|
| 229 | + private function getPlaces() |
|
| 230 | + { |
|
| 222 | 231 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
| 223 | 232 | // Get "place" and "place_sorting" again if that was to sophisticated. |
| 224 | 233 | if (empty($places)) { |
@@ -242,7 +251,8 @@ discard block |
||
| 242 | 251 | * |
| 243 | 252 | * @return void |
| 244 | 253 | */ |
| 245 | - private function getYears() { |
|
| 254 | + private function getYears() |
|
| 255 | + { |
|
| 246 | 256 | // Get "year_sorting". |
| 247 | 257 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
| 248 | 258 | foreach ($years_sorting as $year_sorting) { |