We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -77,7 +77,8 @@ |
||
77 | 77 | * |
78 | 78 | * @return void |
79 | 79 | */ |
80 | - public function setEndpoint($endpoint) { |
|
80 | + public function setEndpoint($endpoint) |
|
81 | + { |
|
81 | 82 | $this->endpoint = $endpoint; |
82 | 83 | } |
83 | 84 |
@@ -77,7 +77,8 @@ |
||
77 | 77 | * |
78 | 78 | * @return void |
79 | 79 | */ |
80 | - public function setEndpoint($endpoint) { |
|
80 | + public function setEndpoint($endpoint) |
|
81 | + { |
|
81 | 82 | $this->endpoint = $endpoint; |
82 | 83 | } |
83 | 84 |
@@ -31,12 +31,12 @@ |
||
31 | 31 | /** |
32 | 32 | * @var string constant for API hostname |
33 | 33 | **/ |
34 | - const HOSTNAME = 'orcid.org'; |
|
34 | + const HOSTNAME = 'orcid.org'; |
|
35 | 35 | |
36 | 36 | /** |
37 | 37 | * @var string constant for API version |
38 | 38 | **/ |
39 | - const VERSION = '3.0'; |
|
39 | + const VERSION = '3.0'; |
|
40 | 40 | |
41 | 41 | /** |
42 | 42 | * @access protected |
@@ -74,7 +74,7 @@ discard block |
||
74 | 74 | // extract collection(s) from collection parameter |
75 | 75 | $collection = null; |
76 | 76 | if ($this->searchParams['collection']) { |
77 | - foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) { |
|
77 | + foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) { |
|
78 | 78 | $collection[] = $this->collectionRepository->findByUid($collectionEntry); |
79 | 79 | } |
80 | 80 | } |
@@ -106,7 +106,7 @@ discard block |
||
106 | 106 | $simplePagination = new SimplePagination($solrPaginator); |
107 | 107 | |
108 | 108 | $pagination = $this->buildSimplePagination($simplePagination, $solrPaginator); |
109 | - $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $solrPaginator ]); |
|
109 | + $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $solrPaginator]); |
|
110 | 110 | } |
111 | 111 | |
112 | 112 | $this->view->assign('viewData', $this->viewData); |
@@ -205,7 +205,8 @@ |
||
205 | 205 | * |
206 | 206 | * @return void |
207 | 207 | */ |
208 | - private function addDcData(&$metadata, $key, $value) { |
|
208 | + private function addDcData(&$metadata, $key, $value) |
|
209 | + { |
|
209 | 210 | if (!empty($value)) { |
210 | 211 | $metadata[] = [$key => $value]; |
211 | 212 | } |
@@ -278,7 +278,7 @@ |
||
278 | 278 | |
279 | 279 | if ($this->solrCoreRepository->findOneByPid($this->pid) === null) { |
280 | 280 | $newRecord = GeneralUtility::makeInstance(SolrCore::class); |
281 | - $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels). ' (PID ' . $this->pid . ')'); |
|
281 | + $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels) . ' (PID ' . $this->pid . ')'); |
|
282 | 282 | $indexName = Solr::createCore(''); |
283 | 283 | if (!empty($indexName)) { |
284 | 284 | $newRecord->setIndexName($indexName); |
@@ -345,7 +345,8 @@ |
||
345 | 345 | * |
346 | 346 | * @return void |
347 | 347 | */ |
348 | - private function setDefault($setting, $value) { |
|
348 | + private function setDefault($setting, $value) |
|
349 | + { |
|
349 | 350 | if (!isset($this->settings[$setting])) { |
350 | 351 | $this->settings[$setting] = $value; |
351 | 352 | } |
@@ -337,7 +337,7 @@ discard block |
||
337 | 337 | $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']); |
338 | 338 | $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']); |
339 | 339 | // verify date formatting |
340 | - if(strtotime($metadata['date'][0])) { |
|
340 | + if (strtotime($metadata['date'][0])) { |
|
341 | 341 | // do not alter dates YYYY or YYYY-MM or YYYY-MM-DD |
342 | 342 | if ( |
343 | 343 | preg_match("/^[\d]{4}$/", $metadata['date'][0]) |
@@ -346,7 +346,7 @@ discard block |
||
346 | 346 | ) { |
347 | 347 | $solrDoc->setField('date', $metadata['date'][0]); |
348 | 348 | // change date YYYYMMDD to YYYY-MM-DD |
349 | - } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){ |
|
349 | + } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) { |
|
350 | 350 | $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0]))); |
351 | 351 | // convert any datetime to proper ISO extended datetime format and timezone for SOLR |
352 | 352 | } elseif (preg_match("/^[0-9]{4}-[0-9]{2}-[0-9]{2}T.*$/", $metadata['date'][0])) { |
@@ -483,7 +483,7 @@ discard block |
||
483 | 483 | !empty($data) |
484 | 484 | && substr($index_name, -8) == '_sorting' |
485 | 485 | ) { |
486 | - $solrDoc->setField($index_name , $doc->metadataArray[$doc->toplevelId][$index_name]); |
|
486 | + $solrDoc->setField($index_name, $doc->metadataArray[$doc->toplevelId][$index_name]); |
|
487 | 487 | } |
488 | 488 | } |
489 | 489 | } |
@@ -341,7 +341,7 @@ discard block |
||
341 | 341 | ) { |
342 | 342 | $solrDoc->setField('date', $metadata['date'][0]); |
343 | 343 | // change date YYYYMMDD to YYYY-MM-DD |
344 | - } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){ |
|
344 | + } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) { |
|
345 | 345 | $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0]))); |
346 | 346 | // convert any datetime to proper ISO extended datetime format and timezone for SOLR |
347 | 347 | } elseif (preg_match("/^[0-9]{4}-[0-9]{2}-[0-9]{2}T.*$/", $metadata['date'][0])) { |
@@ -550,7 +550,8 @@ discard block |
||
550 | 550 | * |
551 | 551 | * @return DocumentInterface |
552 | 552 | */ |
553 | - private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') { |
|
553 | + private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') |
|
554 | + { |
|
554 | 555 | $solrDoc = $updateQuery->createDocument(); |
555 | 556 | // Create unique identifier from document's UID and unit's XML ID. |
556 | 557 | $solrDoc->setField('id', $document->getUid() . $unit['id']); |
@@ -574,7 +575,8 @@ discard block |
||
574 | 575 | * |
575 | 576 | * @return array|string |
576 | 577 | */ |
577 | - private static function removeAppendsFromAuthor($authors) { |
|
578 | + private static function removeAppendsFromAuthor($authors) |
|
579 | + { |
|
578 | 580 | if (is_array($authors)) { |
579 | 581 | foreach ($authors as $i => $author) { |
580 | 582 | $splitName = explode(chr(31), $author); |
@@ -102,7 +102,7 @@ |
||
102 | 102 | $listRequestData = GeneralUtility::_GPmerged('tx_dlf_listview'); |
103 | 103 | |
104 | 104 | if (isset($listRequestData['searchParameter']) && is_array($listRequestData['searchParameter'])) { |
105 | - $this->searchParams = array_merge($this->searchParams ?: [], $listRequestData['searchParameter']); |
|
105 | + $this->searchParams = array_merge($this->searchParams ? : [], $listRequestData['searchParameter']); |
|
106 | 106 | $listViewSearch = true; |
107 | 107 | $GLOBALS['TSFE']->fe_user->setKey('ses', 'search', $this->searchParams); |
108 | 108 | } |
@@ -358,7 +358,8 @@ discard block |
||
358 | 358 | * |
359 | 359 | * @return string The collection query string |
360 | 360 | */ |
361 | - private function addCollectionsQuery($query) { |
|
361 | + private function addCollectionsQuery($query) |
|
362 | + { |
|
362 | 363 | // if collections are given, we prepare the collections query string |
363 | 364 | // extract collections from collection parameter |
364 | 365 | $collections = null; |
@@ -453,7 +454,8 @@ discard block |
||
453 | 454 | * |
454 | 455 | * @return array menu array |
455 | 456 | */ |
456 | - private function processResults($facet, $facetCollectionArray, $search) { |
|
457 | + private function processResults($facet, $facetCollectionArray, $search) |
|
458 | + { |
|
457 | 459 | $menuArray = []; |
458 | 460 | |
459 | 461 | if ($facet) { |
@@ -20,7 +20,9 @@ discard block |
||
20 | 20 | $this->limit = count($solrSearch); |
21 | 21 | } |
22 | 22 | |
23 | - public function getSource() {} |
|
23 | + public function getSource() |
|
24 | + { |
|
25 | +} |
|
24 | 26 | |
25 | 27 | public function execute($returnRawQueryResult = false) |
26 | 28 | { |
@@ -35,7 +37,9 @@ discard block |
||
35 | 37 | return $result; |
36 | 38 | } |
37 | 39 | |
38 | - public function setOrderings(array $orderings) {} |
|
40 | + public function setOrderings(array $orderings) |
|
41 | + { |
|
42 | +} |
|
39 | 43 | |
40 | 44 | public function setLimit($limit) |
41 | 45 | { |
@@ -49,28 +53,60 @@ discard block |
||
49 | 53 | return $this; |
50 | 54 | } |
51 | 55 | |
52 | - public function matching($constraint) {} |
|
53 | - public function logicalAnd($constraint1) {} |
|
54 | - public function logicalOr($constraint1) {} |
|
55 | - public function logicalNot(ConstraintInterface $constraint) {} |
|
56 | - public function equals($propertyName, $operand, $caseSensitive = true) {} |
|
57 | - public function like($propertyName, $operand) {} |
|
58 | - public function contains($propertyName, $operand) {} |
|
59 | - public function in($propertyName, $operand) {} |
|
60 | - public function lessThan($propertyName, $operand) {} |
|
61 | - public function lessThanOrEqual($propertyName, $operand) {} |
|
62 | - public function greaterThan($propertyName, $operand) {} |
|
63 | - public function greaterThanOrEqual($propertyName, $operand) {} |
|
64 | - public function getType() {} |
|
65 | - public function setQuerySettings(QuerySettingsInterface $querySettings) {} |
|
66 | - public function getQuerySettings() {} |
|
56 | + public function matching($constraint) |
|
57 | + { |
|
58 | +} |
|
59 | + public function logicalAnd($constraint1) |
|
60 | + { |
|
61 | +} |
|
62 | + public function logicalOr($constraint1) |
|
63 | + { |
|
64 | +} |
|
65 | + public function logicalNot(ConstraintInterface $constraint) |
|
66 | + { |
|
67 | +} |
|
68 | + public function equals($propertyName, $operand, $caseSensitive = true) |
|
69 | + { |
|
70 | +} |
|
71 | + public function like($propertyName, $operand) |
|
72 | + { |
|
73 | +} |
|
74 | + public function contains($propertyName, $operand) |
|
75 | + { |
|
76 | +} |
|
77 | + public function in($propertyName, $operand) |
|
78 | + { |
|
79 | +} |
|
80 | + public function lessThan($propertyName, $operand) |
|
81 | + { |
|
82 | +} |
|
83 | + public function lessThanOrEqual($propertyName, $operand) |
|
84 | + { |
|
85 | +} |
|
86 | + public function greaterThan($propertyName, $operand) |
|
87 | + { |
|
88 | +} |
|
89 | + public function greaterThanOrEqual($propertyName, $operand) |
|
90 | + { |
|
91 | +} |
|
92 | + public function getType() |
|
93 | + { |
|
94 | +} |
|
95 | + public function setQuerySettings(QuerySettingsInterface $querySettings) |
|
96 | + { |
|
97 | +} |
|
98 | + public function getQuerySettings() |
|
99 | + { |
|
100 | +} |
|
67 | 101 | |
68 | 102 | public function count() |
69 | 103 | { |
70 | 104 | // TODO? |
71 | 105 | } |
72 | 106 | |
73 | - public function getOrderings() {} |
|
107 | + public function getOrderings() |
|
108 | + { |
|
109 | +} |
|
74 | 110 | |
75 | 111 | public function getLimit() |
76 | 112 | { |
@@ -82,8 +118,16 @@ discard block |
||
82 | 118 | return $this->offset; |
83 | 119 | } |
84 | 120 | |
85 | - public function getConstraint() {} |
|
86 | - public function isEmpty($propertyName) {} |
|
87 | - public function setSource(SourceInterface $source) {} |
|
88 | - public function getStatement() {} |
|
121 | + public function getConstraint() |
|
122 | + { |
|
123 | +} |
|
124 | + public function isEmpty($propertyName) |
|
125 | + { |
|
126 | +} |
|
127 | + public function setSource(SourceInterface $source) |
|
128 | + { |
|
129 | +} |
|
130 | + public function getStatement() |
|
131 | + { |
|
132 | +} |
|
89 | 133 | } |