We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -129,7 +129,7 @@ discard block |
||
| 129 | 129 | foreach ($year['children'] as $month) { |
| 130 | 130 | foreach ($month['children'] as $day) { |
| 131 | 131 | foreach ($day['children'] as $issue) { |
| 132 | - $title = $issue['label'] ?: $issue['orderlabel']; |
|
| 132 | + $title = $issue['label'] ? : $issue['orderlabel']; |
|
| 133 | 133 | if (strtotime($title) !== false) { |
| 134 | 134 | $title = strftime('%x', strtotime($title)); |
| 135 | 135 | } |
@@ -220,8 +220,8 @@ discard block |
||
| 220 | 220 | $this->view->assign('calendarData', $calendarData); |
| 221 | 221 | $this->view->assign('documentId', $this->document->getUid()); |
| 222 | 222 | $this->view->assign('yearLinkTitle', $yearLinkTitle); |
| 223 | - $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']); |
|
| 224 | - $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']); |
|
| 223 | + $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']); |
|
| 224 | + $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']); |
|
| 225 | 225 | } |
| 226 | 226 | |
| 227 | 227 | /** |
@@ -257,7 +257,7 @@ discard block |
||
| 257 | 257 | |
| 258 | 258 | if (empty($yearLabel)) { |
| 259 | 259 | // if neither order nor orderlabel is set, use the id... |
| 260 | - $yearLabel = (string)$id; |
|
| 260 | + $yearLabel = (string) $id; |
|
| 261 | 261 | } |
| 262 | 262 | |
| 263 | 263 | $years[] = [ |
@@ -58,7 +58,8 @@ |
||
| 58 | 58 | * |
| 59 | 59 | * @return void |
| 60 | 60 | */ |
| 61 | - public function getTyposcriptConfigFromPluginSiteRoot($params) { |
|
| 61 | + public function getTyposcriptConfigFromPluginSiteRoot($params) |
|
| 62 | + { |
|
| 62 | 63 | $objectManager = GeneralUtility::makeInstance(ObjectManager::class); |
| 63 | 64 | $pid = $params['flexParentDatabaseRow']['pid']; |
| 64 | 65 | $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid); |
@@ -48,7 +48,7 @@ |
||
| 48 | 48 | |
| 49 | 49 | $settingsParts = explode("/", $model); |
| 50 | 50 | $fileName = end($settingsParts); |
| 51 | - $path = substr($model, 0, strrpos($model, $fileName)); |
|
| 51 | + $path = substr($model, 0, strrpos($model, $fileName)); |
|
| 52 | 52 | $modelSettings = $path . "metadata/" . $fileName . "_viewer"; |
| 53 | 53 | |
| 54 | 54 | if (!empty($modelConverted)) { |
@@ -30,7 +30,8 @@ |
||
| 30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
| 31 | 31 | * @return void |
| 32 | 32 | */ |
| 33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
| 33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) |
|
| 34 | + { |
|
| 34 | 35 | if ($pageSelectForm) { |
| 35 | 36 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
| 36 | 37 | $uri = $uriBuilder->reset() |
@@ -30,7 +30,7 @@ |
||
| 30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
| 31 | 31 | * @return void |
| 32 | 32 | */ |
| 33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
| 33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = null) { |
|
| 34 | 34 | if ($pageSelectForm) { |
| 35 | 35 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
| 36 | 36 | $uri = $uriBuilder->reset() |
@@ -66,7 +66,7 @@ |
||
| 66 | 66 | } |
| 67 | 67 | |
| 68 | 68 | // Steps for X pages backward / forward. Double page view uses double steps. |
| 69 | - $basePageSteps = $this->settings['pageStep'] ?: 10; |
|
| 69 | + $basePageSteps = $this->settings['pageStep'] ? : 10; |
|
| 70 | 70 | $pageSteps = $basePageSteps * ($this->requestData['double'] + 1); |
| 71 | 71 | |
| 72 | 72 | $this->view->assign('basePageSteps', $basePageSteps); |
@@ -52,7 +52,7 @@ |
||
| 52 | 52 | * |
| 53 | 53 | * @return void |
| 54 | 54 | */ |
| 55 | - // TODO(client-side) |
|
| 55 | + // TODO(client-side) |
|
| 56 | 56 | public function annotationtool() |
| 57 | 57 | { |
| 58 | 58 | if ( |
@@ -299,7 +299,8 @@ |
||
| 299 | 299 | // Collect IDs of all logical structures. This is a flattened tree, so the |
| 300 | 300 | // order also works for rootline configurations. |
| 301 | 301 | $allIds = []; |
| 302 | - function getIds($toc, &$output) { |
|
| 302 | + function getIds($toc, &$output) |
|
| 303 | + { |
|
| 303 | 304 | foreach ($toc as $entry) { |
| 304 | 305 | $output[$entry['id']] = true; |
| 305 | 306 | if (is_array($entry['children'])) { |
@@ -24,7 +24,7 @@ |
||
| 24 | 24 | */ |
| 25 | 25 | class DocumentController extends AbstractController |
| 26 | 26 | { |
| 27 | - /** |
|
| 27 | + /** |
|
| 28 | 28 | * The main method of the PlugIn |
| 29 | 29 | * |
| 30 | 30 | * @access public |
@@ -135,7 +135,7 @@ |
||
| 135 | 135 | // page: \d+ |
| 136 | 136 | // double: 0|1 |
| 137 | 137 | |
| 138 | - $make = function ($page, $double, $pagegrid) { |
|
| 138 | + $make = function($page, $double, $pagegrid) { |
|
| 139 | 139 | $result = $this->uriBuilder->reset() |
| 140 | 140 | ->setTargetPageUid($GLOBALS['TSFE']->id) |
| 141 | 141 | ->setCreateAbsoluteUri(!empty($this->settings['forceAbsoluteUrl']) ? true : false) |
@@ -135,7 +135,8 @@ |
||
| 135 | 135 | // page: \d+ |
| 136 | 136 | // double: 0|1 |
| 137 | 137 | |
| 138 | - $make = function ($page, $double, $pagegrid) { |
|
| 138 | + $make = function ($page, $double, $pagegrid) |
|
| 139 | + { |
|
| 139 | 140 | $result = $this->uriBuilder->reset() |
| 140 | 141 | ->setTargetPageUid($GLOBALS['TSFE']->id) |
| 141 | 142 | ->setCreateAbsoluteUri(!empty($this->settings['forceAbsoluteUrl']) ? true : false) |
@@ -107,13 +107,13 @@ |
||
| 107 | 107 | } |
| 108 | 108 | |
| 109 | 109 | // sanitize date search input |
| 110 | - if(empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { |
|
| 110 | + if (empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { |
|
| 111 | 111 | $this->searchParams['dateFrom'] = '*'; |
| 112 | 112 | } |
| 113 | - if(empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) { |
|
| 113 | + if (empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) { |
|
| 114 | 114 | $this->searchParams['dateTo'] = 'NOW'; |
| 115 | 115 | } |
| 116 | - if($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) { |
|
| 116 | + if ($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) { |
|
| 117 | 117 | $tmpDate = $this->searchParams['dateFrom']; |
| 118 | 118 | $this->searchParams['dateFrom'] = $this->searchParams['dateTo']; |
| 119 | 119 | $this->searchParams['dateTo'] = $tmpDate; |
@@ -71,7 +71,8 @@ discard block |
||
| 71 | 71 | * |
| 72 | 72 | * @return void |
| 73 | 73 | */ |
| 74 | - private function getAuthors() { |
|
| 74 | + private function getAuthors() |
|
| 75 | + { |
|
| 75 | 76 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
| 76 | 77 | |
| 77 | 78 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -93,7 +94,8 @@ discard block |
||
| 93 | 94 | } |
| 94 | 95 | } |
| 95 | 96 | |
| 96 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
| 97 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
| 98 | + { |
|
| 97 | 99 | $profile = new OrcidProfile($orcidId); |
| 98 | 100 | $name = $profile->getFullName(); |
| 99 | 101 | if (!empty($name)) { |
@@ -107,7 +109,8 @@ discard block |
||
| 107 | 109 | } |
| 108 | 110 | } |
| 109 | 111 | |
| 110 | - private function getAuthorFromXml($authors, $i) { |
|
| 112 | + private function getAuthorFromXml($authors, $i) |
|
| 113 | + { |
|
| 111 | 114 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
| 112 | 115 | |
| 113 | 116 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -150,7 +153,8 @@ discard block |
||
| 150 | 153 | } |
| 151 | 154 | } |
| 152 | 155 | |
| 153 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
| 156 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
| 157 | + { |
|
| 154 | 158 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
| 155 | 159 | if ($displayForm) { |
| 156 | 160 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -164,7 +168,8 @@ discard block |
||
| 164 | 168 | * |
| 165 | 169 | * @return void |
| 166 | 170 | */ |
| 167 | - private function getHolders() { |
|
| 171 | + private function getHolders() |
|
| 172 | + { |
|
| 168 | 173 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
| 169 | 174 | |
| 170 | 175 | if (!empty($holders)) { |
@@ -181,7 +186,8 @@ discard block |
||
| 181 | 186 | } |
| 182 | 187 | } |
| 183 | 188 | |
| 184 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
| 189 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
| 190 | + { |
|
| 185 | 191 | $profile = new ViafProfile($viafId); |
| 186 | 192 | $name = $profile->getFullName(); |
| 187 | 193 | if (!empty($name)) { |
@@ -195,7 +201,8 @@ discard block |
||
| 195 | 201 | } |
| 196 | 202 | } |
| 197 | 203 | |
| 198 | - private function getHolderFromXml($holders, $i) { |
|
| 204 | + private function getHolderFromXml($holders, $i) |
|
| 205 | + { |
|
| 199 | 206 | $this->getHolderFromXmlDisplayForm($holders, $i); |
| 200 | 207 | // Append "valueURI" to name using Unicode unit separator. |
| 201 | 208 | if (isset($holders[$i]['valueURI'])) { |
@@ -203,7 +210,8 @@ discard block |
||
| 203 | 210 | } |
| 204 | 211 | } |
| 205 | 212 | |
| 206 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
| 213 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
| 214 | + { |
|
| 207 | 215 | // Check if there is a display form. |
| 208 | 216 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
| 209 | 217 | if ($displayForm) { |
@@ -218,7 +226,8 @@ discard block |
||
| 218 | 226 | * |
| 219 | 227 | * @return void |
| 220 | 228 | */ |
| 221 | - private function getPlaces() { |
|
| 229 | + private function getPlaces() |
|
| 230 | + { |
|
| 222 | 231 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
| 223 | 232 | // Get "place" and "place_sorting" again if that was to sophisticated. |
| 224 | 233 | if (empty($places)) { |
@@ -242,7 +251,8 @@ discard block |
||
| 242 | 251 | * |
| 243 | 252 | * @return void |
| 244 | 253 | */ |
| 245 | - private function getYears() { |
|
| 254 | + private function getYears() |
|
| 255 | + { |
|
| 246 | 256 | // Get "year_sorting". |
| 247 | 257 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
| 248 | 258 | foreach ($years_sorting as $year_sorting) { |