We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -365,8 +365,8 @@ |
||
365 | 365 | $searchResult['snippet'] = $doc['snippet']; |
366 | 366 | $searchResult['highlight'] = $doc['highlight']; |
367 | 367 | $searchResult['highlight_word'] = preg_replace('/^;|;$/', '', // remove ; at beginning or end |
368 | - preg_replace('/;+/', ';', // replace any multiple of ; with a single ; |
|
369 | - preg_replace('/[{~\d*}{\s+}{^=*\d+.*\d*}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']))); // replace search operators and special characters with ; |
|
368 | + preg_replace('/;+/', ';', // replace any multiple of ; with a single ; |
|
369 | + preg_replace('/[{~\d*}{\s+}{^=*\d+.*\d*}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']))); // replace search operators and special characters with ; |
|
370 | 370 | } |
371 | 371 | $documents[$doc['uid']]['searchResults'][] = $searchResult; |
372 | 372 | } |
@@ -247,7 +247,7 @@ discard block |
||
247 | 247 | // Add filter query for date search |
248 | 248 | if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { |
249 | 249 | // combine dateFrom and dateTo into range search |
250 | - $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']'; |
|
250 | + $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}' . $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']'; |
|
251 | 251 | } |
252 | 252 | |
253 | 253 | // Add filter query for faceting. |
@@ -279,7 +279,7 @@ discard block |
||
279 | 279 | foreach ($this->collection as $collectionEntry) { |
280 | 280 | // check for virtual collections query string |
281 | 281 | if ($collectionEntry->getIndexSearch()) { |
282 | - $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ; |
|
282 | + $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR (' . $collectionEntry->getIndexSearch() . ')'; |
|
283 | 283 | } else { |
284 | 284 | $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"'; |
285 | 285 | } |
@@ -399,8 +399,8 @@ discard block |
||
399 | 399 | if ($this->searchParams['fulltext'] == '1') { |
400 | 400 | $searchResult['snippet'] = $doc['snippet']; |
401 | 401 | $searchResult['highlight'] = $doc['highlight']; |
402 | - $searchResult['highlight_word'] = preg_replace('/^;|;$/', '', // remove ; at beginning or end |
|
403 | - preg_replace('/;+/', ';', // replace any multiple of ; with a single ; |
|
402 | + $searchResult['highlight_word'] = preg_replace('/^;|;$/', '', // remove ; at beginning or end |
|
403 | + preg_replace('/;+/', ';', // replace any multiple of ; with a single ; |
|
404 | 404 | preg_replace('/[{~\d*}{\s+}{^=*\d+.*\d*}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']))); // replace search operators and special characters with ; |
405 | 405 | } |
406 | 406 | $documents[$doc['uid']]['searchResults'][] = $searchResult; |
@@ -478,8 +478,8 @@ discard block |
||
478 | 478 | |
479 | 479 | foreach ($result['documents'] as $doc) { |
480 | 480 | // translate language code if applicable |
481 | - if($doc['metadata']['language']) { |
|
482 | - foreach($doc['metadata']['language'] as $indexName => $language) { |
|
481 | + if ($doc['metadata']['language']) { |
|
482 | + foreach ($doc['metadata']['language'] as $indexName => $language) { |
|
483 | 483 | $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]); |
484 | 484 | } |
485 | 485 | } |
@@ -590,7 +590,8 @@ |
||
590 | 590 | return $resultSet; |
591 | 591 | } |
592 | 592 | |
593 | - private function getDocument($record, $highlighting, $fields, $parameters) { |
|
593 | + private function getDocument($record, $highlighting, $fields, $parameters) |
|
594 | + { |
|
594 | 595 | $resultDocument = new ResultDocument($record, $highlighting, $fields); |
595 | 596 | |
596 | 597 | $document = [ |
@@ -60,7 +60,8 @@ discard block |
||
60 | 60 | * |
61 | 61 | * @return void |
62 | 62 | */ |
63 | - private function renderTool() { |
|
63 | + private function renderTool() |
|
64 | + { |
|
64 | 65 | if (!empty($this->settings['tool'])) { |
65 | 66 | switch ($this->settings['tool']) { |
66 | 67 | case 'tx_dlf_annotationtool': |
@@ -104,7 +105,8 @@ discard block |
||
104 | 105 | * |
105 | 106 | * @return void |
106 | 107 | */ |
107 | - private function renderToolByName(string $tool) { |
|
108 | + private function renderToolByName(string $tool) |
|
109 | + { |
|
108 | 110 | $this->$tool(); |
109 | 111 | $this->view->assign($tool, true); |
110 | 112 | } |
@@ -474,7 +476,8 @@ discard block |
||
474 | 476 | * |
475 | 477 | * @return bool true if empty, false otherwise |
476 | 478 | */ |
477 | - private function isFullTextEmpty() { |
|
479 | + private function isFullTextEmpty() |
|
480 | + { |
|
478 | 481 | $fileGrpsFulltext = GeneralUtility::trimExplode(',', $this->extConf['fileGrpFulltext']); |
479 | 482 | while ($fileGrpFulltext = array_shift($fileGrpsFulltext)) { |
480 | 483 | $fullTextFile = $this->doc->physicalStructureInfo[$this->doc->physicalStructure[$this->requestData['page']]]['files'][$fileGrpFulltext]; |
@@ -315,7 +315,7 @@ discard block |
||
315 | 315 | } |
316 | 316 | } |
317 | 317 | } |
318 | - return $entry['label'] ?: $entry['orderlabel']; |
|
318 | + return $entry['label'] ? : $entry['orderlabel']; |
|
319 | 319 | } |
320 | 320 | |
321 | 321 | /** |
@@ -346,7 +346,7 @@ discard block |
||
346 | 346 | * @return void |
347 | 347 | */ |
348 | 348 | private function sortSubMenu(&$menu) { |
349 | - usort($menu[0]['_SUB_MENU'], function ($firstElement, $secondElement) { |
|
349 | + usort($menu[0]['_SUB_MENU'], function($firstElement, $secondElement) { |
|
350 | 350 | if (!empty($firstElement['orderlabel'])) { |
351 | 351 | return $firstElement['orderlabel'] <=> $secondElement['orderlabel']; |
352 | 352 | } |
@@ -239,7 +239,8 @@ discard block |
||
239 | 239 | * |
240 | 240 | * @return void |
241 | 241 | */ |
242 | - private function getAllLogicalUnits() { |
|
242 | + private function getAllLogicalUnits() |
|
243 | + { |
|
243 | 244 | if ( |
244 | 245 | !empty($this->requestData['page']) |
245 | 246 | && !empty($this->document->getCurrentDocument()->physicalStructure) |
@@ -265,7 +266,8 @@ discard block |
||
265 | 266 | * |
266 | 267 | * @return string |
267 | 268 | */ |
268 | - private function getTranslatedType($type) { |
|
269 | + private function getTranslatedType($type) |
|
270 | + { |
|
269 | 271 | return Helper::translate($type, 'tx_dlf_structures', $this->settings['storagePid']); |
270 | 272 | } |
271 | 273 | |
@@ -285,7 +287,8 @@ discard block |
||
285 | 287 | * |
286 | 288 | * @return bool |
287 | 289 | */ |
288 | - private function isMultiElement($type) { |
|
290 | + private function isMultiElement($type) |
|
291 | + { |
|
289 | 292 | return $type === 'multivolume_work' || $type === 'multipart_manuscript'; |
290 | 293 | } |
291 | 294 | /** |
@@ -297,7 +300,8 @@ discard block |
||
297 | 300 | * |
298 | 301 | * @return string |
299 | 302 | */ |
300 | - private function setTitle($entry) { |
|
303 | + private function setTitle($entry) |
|
304 | + { |
|
301 | 305 | if (empty($entry['label']) && empty($entry['orderlabel'])) { |
302 | 306 | foreach ($this->settings['titleReplacements'] as $titleReplacement) { |
303 | 307 | if ($entry['type'] == $titleReplacement['type']) { |
@@ -327,7 +331,8 @@ discard block |
||
327 | 331 | * |
328 | 332 | * @return void |
329 | 333 | */ |
330 | - private function sortMenu(&$menu) { |
|
334 | + private function sortMenu(&$menu) |
|
335 | + { |
|
331 | 336 | if ($menu[0]['type'] == $this->getTranslatedType("newspaper")) { |
332 | 337 | $this->sortSubMenu($menu); |
333 | 338 | } |
@@ -345,8 +350,10 @@ discard block |
||
345 | 350 | * |
346 | 351 | * @return void |
347 | 352 | */ |
348 | - private function sortSubMenu(&$menu) { |
|
349 | - usort($menu[0]['_SUB_MENU'], function ($firstElement, $secondElement) { |
|
353 | + private function sortSubMenu(&$menu) |
|
354 | + { |
|
355 | + usort($menu[0]['_SUB_MENU'], function ($firstElement, $secondElement) |
|
356 | + { |
|
350 | 357 | if (!empty($firstElement['orderlabel'])) { |
351 | 358 | return $firstElement['orderlabel'] <=> $secondElement['orderlabel']; |
352 | 359 | } |
@@ -28,7 +28,8 @@ |
||
28 | 28 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
29 | 29 | * @return void |
30 | 30 | */ |
31 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
31 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) |
|
32 | + { |
|
32 | 33 | if ($pageSelectForm) { |
33 | 34 | $uri = $this->uriBuilder->reset() |
34 | 35 | ->setArguments( |
@@ -28,7 +28,7 @@ |
||
28 | 28 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
29 | 29 | * @return void |
30 | 30 | */ |
31 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
31 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = null) { |
|
32 | 32 | if ($pageSelectForm) { |
33 | 33 | $uri = $this->uriBuilder->reset() |
34 | 34 | ->setArguments( |
@@ -898,7 +898,8 @@ |
||
898 | 898 | * |
899 | 899 | * @return array |
900 | 900 | */ |
901 | - protected function initializeMetadata($format) { |
|
901 | + protected function initializeMetadata($format) |
|
902 | + { |
|
902 | 903 | return [ |
903 | 904 | 'title' => [], |
904 | 905 | 'title_sorting' => [], |
@@ -186,7 +186,8 @@ discard block |
||
186 | 186 | * |
187 | 187 | * @return void |
188 | 188 | */ |
189 | - protected function configureProxyUrl(&$url) { |
|
189 | + protected function configureProxyUrl(&$url) |
|
190 | + { |
|
190 | 191 | $this->uriBuilder->reset() |
191 | 192 | ->setTargetPageUid($GLOBALS['TSFE']->id) |
192 | 193 | ->setCreateAbsoluteUri(!empty($this->settings['forceAbsoluteUrl'])) |
@@ -283,7 +284,8 @@ discard block |
||
283 | 284 | * |
284 | 285 | * @return void |
285 | 286 | */ |
286 | - protected function setPage() { |
|
287 | + protected function setPage() |
|
288 | + { |
|
287 | 289 | if (!empty($this->requestData['logicalPage'])) { |
288 | 290 | $this->requestData['page'] = $this->document->getCurrentDocument()->getPhysicalPage($this->requestData['logicalPage']); |
289 | 291 | // The logical page parameter should not appear again |
@@ -300,7 +302,8 @@ discard block |
||
300 | 302 | * |
301 | 303 | * @return void |
302 | 304 | */ |
303 | - protected function setDefaultPage() { |
|
305 | + protected function setDefaultPage() |
|
306 | + { |
|
304 | 307 | // Set default values if not set. |
305 | 308 | // $this->requestData['page'] may be integer or string (physical structure @ID) |
306 | 309 | if ( |
@@ -125,7 +125,7 @@ discard block |
||
125 | 125 | foreach ($year['children'] as $month) { |
126 | 126 | foreach ($month['children'] as $day) { |
127 | 127 | foreach ($day['children'] as $issue) { |
128 | - $title = $issue['label'] ?: $issue['orderlabel']; |
|
128 | + $title = $issue['label'] ? : $issue['orderlabel']; |
|
129 | 129 | if (strtotime($title) !== false) { |
130 | 130 | $title = strftime('%x', strtotime($title)); |
131 | 131 | } |
@@ -216,8 +216,8 @@ discard block |
||
216 | 216 | $this->view->assign('calendarData', $calendarData); |
217 | 217 | $this->view->assign('documentId', $this->document->getUid()); |
218 | 218 | $this->view->assign('yearLinkTitle', $yearLinkTitle); |
219 | - $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getCurrentDocument()->tableOfContents[0]['points']); |
|
220 | - $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle($this->document->getPartof()) ?: $this->document->getCurrentDocument()->tableOfContents[0]['label']); |
|
219 | + $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getCurrentDocument()->tableOfContents[0]['points']); |
|
220 | + $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle($this->document->getPartof()) ? : $this->document->getCurrentDocument()->tableOfContents[0]['label']); |
|
221 | 221 | } |
222 | 222 | |
223 | 223 | /** |
@@ -253,7 +253,7 @@ discard block |
||
253 | 253 | |
254 | 254 | if (empty($yearLabel)) { |
255 | 255 | // if neither order nor orderlabel is set, use the id... |
256 | - $yearLabel = (string)$id; |
|
256 | + $yearLabel = (string) $id; |
|
257 | 257 | } |
258 | 258 | |
259 | 259 | $years[] = [ |
@@ -292,7 +292,7 @@ discard block |
||
292 | 292 | if (is_int($key)) { |
293 | 293 | $yearFilled[] = $yearArray[$key]; |
294 | 294 | } else { |
295 | - $yearFilled[] = ['title' => $min+$i, 'documentId' => '']; |
|
295 | + $yearFilled[] = ['title' => $min + $i, 'documentId' => '']; |
|
296 | 296 | } |
297 | 297 | } |
298 | 298 | $yearArray = $yearFilled; |
@@ -152,7 +152,7 @@ |
||
152 | 152 | // field for which highlighting is going to be performed, |
153 | 153 | // is required if you want to have OCR highlighting |
154 | 154 | $solrRequest->addParam('hl.ocr.fl', $this->fields['fulltext']); |
155 | - // return the coordinates of highlighted search as absolute coordinates |
|
155 | + // return the coordinates of highlighted search as absolute coordinates |
|
156 | 156 | $solrRequest->addParam('hl.ocr.absoluteHighlights', 'on'); |
157 | 157 | // max amount of snippets for a single page |
158 | 158 | $solrRequest->addParam('hl.snippets', 40); |