kitodo /
kitodo-presentation
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 26 |
| Paths | 67 |
| Total Lines | 113 |
| Code Lines | 83 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 248 | protected function getCalendarYear($calendarIssuesByMonth, $year, $firstMonth = 1, $lastMonth = 12) |
||
| 249 | { |
||
| 250 | $calendarData = []; |
||
| 251 | for ($i = $firstMonth; $i <= $lastMonth; $i++) { |
||
| 252 | $calendarData[$i] = [ |
||
| 253 | 'DAYMON_NAME' => strftime('%a', strtotime('last Monday')), |
||
| 254 | 'DAYTUE_NAME' => strftime('%a', strtotime('last Tuesday')), |
||
| 255 | 'DAYWED_NAME' => strftime('%a', strtotime('last Wednesday')), |
||
| 256 | 'DAYTHU_NAME' => strftime('%a', strtotime('last Thursday')), |
||
| 257 | 'DAYFRI_NAME' => strftime('%a', strtotime('last Friday')), |
||
| 258 | 'DAYSAT_NAME' => strftime('%a', strtotime('last Saturday')), |
||
| 259 | 'DAYSUN_NAME' => strftime('%a', strtotime('last Sunday')), |
||
| 260 | 'MONTHNAME' => strftime('%B', strtotime($year . '-' . $i . '-1')) . ' ' . $year, |
||
| 261 | 'CALYEAR' => ($i == $firstMonth) ? $year : '' |
||
| 262 | ]; |
||
| 263 | |||
| 264 | $firstOfMonth = strtotime($year . '-' . $i . '-1'); |
||
| 265 | $lastOfMonth = strtotime('last day of', ($firstOfMonth)); |
||
| 266 | $firstOfMonthStart = strtotime('last Monday', $firstOfMonth); |
||
| 267 | // There are never more than 6 weeks in a month. |
||
| 268 | for ($j = 0; $j <= 5; $j++) { |
||
| 269 | $firstDayOfWeek = strtotime('+ ' . $j . ' Week', $firstOfMonthStart); |
||
| 270 | |||
| 271 | $calendarData[$i]['week'][$j] = [ |
||
| 272 | 'DAYMON' => ['dayValue' => ' '], |
||
| 273 | 'DAYTUE' => ['dayValue' => ' '], |
||
| 274 | 'DAYWED' => ['dayValue' => ' '], |
||
| 275 | 'DAYTHU' => ['dayValue' => ' '], |
||
| 276 | 'DAYFRI' => ['dayValue' => ' '], |
||
| 277 | 'DAYSAT' => ['dayValue' => ' '], |
||
| 278 | 'DAYSUN' => ['dayValue' => ' '], |
||
| 279 | ]; |
||
| 280 | // Every week has seven days. ;-) |
||
| 281 | for ($k = 0; $k <= 6; $k++) { |
||
| 282 | $currentDayTime = strtotime('+ ' . $k . ' Day', $firstDayOfWeek); |
||
| 283 | if ( |
||
| 284 | $currentDayTime >= $firstOfMonth |
||
| 285 | && $currentDayTime <= $lastOfMonth |
||
| 286 | ) { |
||
| 287 | $dayLinks = ''; |
||
| 288 | $dayLinksText = []; |
||
| 289 | $currentMonth = date('n', $currentDayTime); |
||
| 290 | if (is_array($calendarIssuesByMonth[$currentMonth])) { |
||
| 291 | foreach ($calendarIssuesByMonth[$currentMonth] as $id => $day) { |
||
| 292 | if ($id == date('j', $currentDayTime)) { |
||
| 293 | $dayLinks = $id; |
||
| 294 | foreach ($day as $issue) { |
||
| 295 | $dayLinkLabel = empty($issue['title']) ? strftime('%x', $currentDayTime) : $issue['title']; |
||
| 296 | |||
| 297 | $dayLinksText[] = [ |
||
| 298 | 'documentId' => $issue['uid'], |
||
| 299 | 'text' => $dayLinkLabel |
||
| 300 | ]; |
||
| 301 | |||
| 302 | // Save issue for list view. |
||
| 303 | $this->allIssues[$currentDayTime][] = [ |
||
| 304 | 'documentId' => $issue['uid'], |
||
| 305 | 'text' => $dayLinkLabel |
||
| 306 | ]; |
||
| 307 | } |
||
| 308 | } |
||
| 309 | } |
||
| 310 | $dayLinkDiv = $dayLinksText; |
||
| 311 | } |
||
| 312 | switch (strftime('%w', strtotime('+ ' . $k . ' Day', $firstDayOfWeek))) { |
||
| 313 | case '0': |
||
| 314 | $calendarData[$i]['week'][$j]['DAYSUN']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 315 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 316 | $calendarData[$i]['week'][$j]['DAYSUN']['issues'] = $dayLinkDiv; |
||
| 317 | } |
||
| 318 | break; |
||
| 319 | case '1': |
||
| 320 | $calendarData[$i]['week'][$j]['DAYMON']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 321 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 322 | $calendarData[$i]['week'][$j]['DAYMON']['issues'] = $dayLinkDiv; |
||
| 323 | } |
||
| 324 | break; |
||
| 325 | case '2': |
||
| 326 | $calendarData[$i]['week'][$j]['DAYTUE']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 327 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 328 | $calendarData[$i]['week'][$j]['DAYTUE']['issues'] = $dayLinkDiv; |
||
| 329 | } |
||
| 330 | break; |
||
| 331 | case '3': |
||
| 332 | $calendarData[$i]['week'][$j]['DAYWED']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 333 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 334 | $calendarData[$i]['week'][$j]['DAYWED']['issues'] = $dayLinkDiv; |
||
| 335 | } |
||
| 336 | break; |
||
| 337 | case '4': |
||
| 338 | $calendarData[$i]['week'][$j]['DAYTHU']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 339 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 340 | $calendarData[$i]['week'][$j]['DAYTHU']['issues'] = $dayLinkDiv; |
||
| 341 | } |
||
| 342 | break; |
||
| 343 | case '5': |
||
| 344 | $calendarData[$i]['week'][$j]['DAYFRI']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 345 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 346 | $calendarData[$i]['week'][$j]['DAYFRI']['issues'] = $dayLinkDiv; |
||
| 347 | } |
||
| 348 | break; |
||
| 349 | case '6': |
||
| 350 | $calendarData[$i]['week'][$j]['DAYSAT']['dayValue'] = strftime('%d', $currentDayTime); |
||
| 351 | if ((int) $dayLinks === (int) date('j', $currentDayTime)) { |
||
| 352 | $calendarData[$i]['week'][$j]['DAYSAT']['issues'] = $dayLinkDiv; |
||
| 353 | } |
||
| 354 | break; |
||
| 355 | } |
||
| 356 | } |
||
| 357 | } |
||
| 358 | } |
||
| 359 | } |
||
| 360 | $this->view->assign('calendarData', $calendarData); |
||
| 361 | } |
||
| 363 |
Loading history...
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.