We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -129,7 +129,7 @@ discard block |
||
| 129 | 129 | foreach ($year['children'] as $month) { |
| 130 | 130 | foreach ($month['children'] as $day) { |
| 131 | 131 | foreach ($day['children'] as $issue) { |
| 132 | - $title = $issue['label'] ?: $issue['orderlabel']; |
|
| 132 | + $title = $issue['label'] ? : $issue['orderlabel']; |
|
| 133 | 133 | if (strtotime($title) !== false) { |
| 134 | 134 | $title = strftime('%x', strtotime($title)); |
| 135 | 135 | } |
@@ -220,8 +220,8 @@ discard block |
||
| 220 | 220 | $this->view->assign('calendarData', $calendarData); |
| 221 | 221 | $this->view->assign('documentId', $this->document->getUid()); |
| 222 | 222 | $this->view->assign('yearLinkTitle', $yearLinkTitle); |
| 223 | - $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']); |
|
| 224 | - $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']); |
|
| 223 | + $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']); |
|
| 224 | + $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']); |
|
| 225 | 225 | } |
| 226 | 226 | |
| 227 | 227 | /** |
@@ -257,7 +257,7 @@ discard block |
||
| 257 | 257 | |
| 258 | 258 | if (empty($yearLabel)) { |
| 259 | 259 | // if neither order nor orderlabel is set, use the id... |
| 260 | - $yearLabel = (string)$id; |
|
| 260 | + $yearLabel = (string) $id; |
|
| 261 | 261 | } |
| 262 | 262 | |
| 263 | 263 | $years[] = [ |
@@ -58,7 +58,8 @@ |
||
| 58 | 58 | * |
| 59 | 59 | * @return void |
| 60 | 60 | */ |
| 61 | - public function getTyposcriptConfigFromPluginSiteRoot($params) { |
|
| 61 | + public function getTyposcriptConfigFromPluginSiteRoot($params) |
|
| 62 | + { |
|
| 62 | 63 | $objectManager = GeneralUtility::makeInstance(ObjectManager::class); |
| 63 | 64 | $pid = $params['flexParentDatabaseRow']['pid']; |
| 64 | 65 | $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid); |
@@ -68,7 +68,8 @@ discard block |
||
| 68 | 68 | * |
| 69 | 69 | * @return void |
| 70 | 70 | */ |
| 71 | - private function getAuthors() { |
|
| 71 | + private function getAuthors() |
|
| 72 | + { |
|
| 72 | 73 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
| 73 | 74 | |
| 74 | 75 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -130,7 +131,8 @@ discard block |
||
| 130 | 131 | * |
| 131 | 132 | * @return void |
| 132 | 133 | */ |
| 133 | - private function getHolders() { |
|
| 134 | + private function getHolders() |
|
| 135 | + { |
|
| 134 | 136 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
| 135 | 137 | |
| 136 | 138 | if (!empty($holders)) { |
@@ -183,7 +185,8 @@ discard block |
||
| 183 | 185 | * |
| 184 | 186 | * @return void |
| 185 | 187 | */ |
| 186 | - private function getPlaces() { |
|
| 188 | + private function getPlaces() |
|
| 189 | + { |
|
| 187 | 190 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
| 188 | 191 | // Get "place" and "place_sorting" again if that was to sophisticated. |
| 189 | 192 | if (empty($places)) { |
@@ -207,7 +210,8 @@ discard block |
||
| 207 | 210 | * |
| 208 | 211 | * @return void |
| 209 | 212 | */ |
| 210 | - private function getYears() { |
|
| 213 | + private function getYears() |
|
| 214 | + { |
|
| 211 | 215 | // Get "year_sorting". |
| 212 | 216 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
| 213 | 217 | foreach ($years_sorting as $year_sorting) { |
@@ -48,7 +48,7 @@ |
||
| 48 | 48 | |
| 49 | 49 | $settingsParts = explode("/", $model); |
| 50 | 50 | $fileName = end($settingsParts); |
| 51 | - $path = substr($model, 0, strrpos($model, $fileName)); |
|
| 51 | + $path = substr($model, 0, strrpos($model, $fileName)); |
|
| 52 | 52 | $modelSettings = $path . "metadata/" . $fileName . "_viewer"; |
| 53 | 53 | |
| 54 | 54 | if (!empty($modelConverted)) { |
@@ -30,7 +30,8 @@ |
||
| 30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
| 31 | 31 | * @return void |
| 32 | 32 | */ |
| 33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
| 33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) |
|
| 34 | + { |
|
| 34 | 35 | if ($pageSelectForm) { |
| 35 | 36 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
| 36 | 37 | $uri = $uriBuilder->reset() |
@@ -30,7 +30,7 @@ |
||
| 30 | 30 | * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm |
| 31 | 31 | * @return void |
| 32 | 32 | */ |
| 33 | - public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) { |
|
| 33 | + public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = null) { |
|
| 34 | 34 | if ($pageSelectForm) { |
| 35 | 35 | $uriBuilder = $this->getControllerContext()->getUriBuilder(); |
| 36 | 36 | $uri = $uriBuilder->reset() |
@@ -107,13 +107,13 @@ |
||
| 107 | 107 | } |
| 108 | 108 | |
| 109 | 109 | // sanitize date search input |
| 110 | - if(empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { |
|
| 110 | + if (empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { |
|
| 111 | 111 | $this->searchParams['dateFrom'] = '*'; |
| 112 | 112 | } |
| 113 | - if(empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) { |
|
| 113 | + if (empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) { |
|
| 114 | 114 | $this->searchParams['dateTo'] = 'NOW'; |
| 115 | 115 | } |
| 116 | - if($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) { |
|
| 116 | + if ($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) { |
|
| 117 | 117 | $tmpDate = $this->searchParams['dateFrom']; |
| 118 | 118 | $this->searchParams['dateFrom'] = $this->searchParams['dateTo']; |
| 119 | 119 | $this->searchParams['dateTo'] = $tmpDate; |
@@ -337,7 +337,7 @@ discard block |
||
| 337 | 337 | $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']); |
| 338 | 338 | $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']); |
| 339 | 339 | // verify date formatting |
| 340 | - if(strtotime($metadata['date'][0])) { |
|
| 340 | + if (strtotime($metadata['date'][0])) { |
|
| 341 | 341 | // do not alter dates YYYY or YYYY-MM or YYYY-MM-DD |
| 342 | 342 | if ( |
| 343 | 343 | preg_match("/^[\d]{4}$/", $metadata['date'][0]) |
@@ -346,7 +346,7 @@ discard block |
||
| 346 | 346 | ) { |
| 347 | 347 | $solrDoc->setField('date', $metadata['date'][0]); |
| 348 | 348 | // change date YYYYMMDD to YYYY-MM-DD |
| 349 | - } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){ |
|
| 349 | + } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) { |
|
| 350 | 350 | $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0]))); |
| 351 | 351 | // convert any datetime to proper ISO extended datetime format and timezone for SOLR |
| 352 | 352 | } else { |
@@ -346,7 +346,7 @@ discard block |
||
| 346 | 346 | ) { |
| 347 | 347 | $solrDoc->setField('date', $metadata['date'][0]); |
| 348 | 348 | // change date YYYYMMDD to YYYY-MM-DD |
| 349 | - } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){ |
|
| 349 | + } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) { |
|
| 350 | 350 | $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0]))); |
| 351 | 351 | // convert any datetime to proper ISO extended datetime format and timezone for SOLR |
| 352 | 352 | } else { |
@@ -549,7 +549,8 @@ discard block |
||
| 549 | 549 | * |
| 550 | 550 | * @return \Solarium\Core\Query\DocumentInterface |
| 551 | 551 | */ |
| 552 | - private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') { |
|
| 552 | + private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') |
|
| 553 | + { |
|
| 553 | 554 | $solrDoc = $updateQuery->createDocument(); |
| 554 | 555 | // Create unique identifier from document's UID and unit's XML ID. |
| 555 | 556 | $solrDoc->setField('id', $document->getUid() . $unit['id']); |
@@ -573,7 +574,8 @@ discard block |
||
| 573 | 574 | * |
| 574 | 575 | * @return array|string |
| 575 | 576 | */ |
| 576 | - private static function removeAppendsFromAuthor($authors) { |
|
| 577 | + private static function removeAppendsFromAuthor($authors) |
|
| 578 | + { |
|
| 577 | 579 | if (is_array($authors)) { |
| 578 | 580 | foreach ($authors as $i => $author) { |
| 579 | 581 | $splitName = explode(chr(31), $author); |
@@ -212,7 +212,7 @@ discard block |
||
| 212 | 212 | // Add filter query for date search |
| 213 | 213 | if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { |
| 214 | 214 | // combine dateFrom and dateTo into range search |
| 215 | - $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']'; |
|
| 215 | + $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}' . $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']'; |
|
| 216 | 216 | } |
| 217 | 217 | |
| 218 | 218 | // Add filter query for faceting. |
@@ -324,8 +324,8 @@ discard block |
||
| 324 | 324 | } |
| 325 | 325 | if ($documents[$doc['uid']]) { |
| 326 | 326 | // translate language code if applicable |
| 327 | - if($doc['metadata']['language']) { |
|
| 328 | - foreach($doc['metadata']['language'] as $indexName => $language) { |
|
| 327 | + if ($doc['metadata']['language']) { |
|
| 328 | + foreach ($doc['metadata']['language'] as $indexName => $language) { |
|
| 329 | 329 | $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]); |
| 330 | 330 | } |
| 331 | 331 | } |
@@ -425,8 +425,8 @@ discard block |
||
| 425 | 425 | |
| 426 | 426 | foreach ($result['documents'] as $doc) { |
| 427 | 427 | // translate language code if applicable |
| 428 | - if($doc['metadata']['language']) { |
|
| 429 | - foreach($doc['metadata']['language'] as $indexName => $language) { |
|
| 428 | + if ($doc['metadata']['language']) { |
|
| 429 | + foreach ($doc['metadata']['language'] as $indexName => $language) { |
|
| 430 | 430 | $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]); |
| 431 | 431 | } |
| 432 | 432 | } |
@@ -77,7 +77,8 @@ |
||
| 77 | 77 | * |
| 78 | 78 | * @return void |
| 79 | 79 | */ |
| 80 | - public function setEndpoint($endpoint) { |
|
| 80 | + public function setEndpoint($endpoint) |
|
| 81 | + { |
|
| 81 | 82 | $this->endpoint = $endpoint; |
| 82 | 83 | } |
| 83 | 84 | |