We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -64,7 +64,8 @@ |
||
| 64 | 64 | * |
| 65 | 65 | * @return void |
| 66 | 66 | */ |
| 67 | - public function getTyposcriptConfigFromPluginSiteRoot($params) { |
|
| 67 | + public function getTyposcriptConfigFromPluginSiteRoot($params) |
|
| 68 | + { |
|
| 68 | 69 | $objectManager = GeneralUtility::makeInstance(ObjectManager::class); |
| 69 | 70 | $pid = $params['flexParentDatabaseRow']['pid']; |
| 70 | 71 | $rootLine = BackendUtility::BEgetRootLine($pid); |
@@ -33,7 +33,8 @@ |
||
| 33 | 33 | * |
| 34 | 34 | * @return void |
| 35 | 35 | */ |
| 36 | - public function pageSelectAction(PageSelectForm $pageSelectForm = NULL) { |
|
| 36 | + public function pageSelectAction(PageSelectForm $pageSelectForm = NULL) |
|
| 37 | + { |
|
| 37 | 38 | if ($pageSelectForm) { |
| 38 | 39 | $uri = $this->uriBuilder->reset() |
| 39 | 40 | ->setArguments( |
@@ -33,7 +33,7 @@ |
||
| 33 | 33 | * |
| 34 | 34 | * @return void |
| 35 | 35 | */ |
| 36 | - public function pageSelectAction(PageSelectForm $pageSelectForm = NULL) { |
|
| 36 | + public function pageSelectAction(PageSelectForm $pageSelectForm = null) { |
|
| 37 | 37 | if ($pageSelectForm) { |
| 38 | 38 | $uri = $this->uriBuilder->reset() |
| 39 | 39 | ->setArguments( |
@@ -70,7 +70,8 @@ discard block |
||
| 70 | 70 | * |
| 71 | 71 | * @return void |
| 72 | 72 | */ |
| 73 | - private function getAuthors() { |
|
| 73 | + private function getAuthors() |
|
| 74 | + { |
|
| 74 | 75 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
| 75 | 76 | |
| 76 | 77 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -103,7 +104,8 @@ discard block |
||
| 103 | 104 | * |
| 104 | 105 | * @return void |
| 105 | 106 | */ |
| 106 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
| 107 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
| 108 | + { |
|
| 107 | 109 | $profile = new OrcidProfile($orcidId); |
| 108 | 110 | $name = $profile->getFullName(); |
| 109 | 111 | if (!empty($name)) { |
@@ -127,7 +129,8 @@ discard block |
||
| 127 | 129 | * |
| 128 | 130 | * @return void |
| 129 | 131 | */ |
| 130 | - private function getAuthorFromXml($authors, $i) { |
|
| 132 | + private function getAuthorFromXml($authors, $i) |
|
| 133 | + { |
|
| 131 | 134 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
| 132 | 135 | |
| 133 | 136 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -180,7 +183,8 @@ discard block |
||
| 180 | 183 | * |
| 181 | 184 | * @return void |
| 182 | 185 | */ |
| 183 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
| 186 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
| 187 | + { |
|
| 184 | 188 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
| 185 | 189 | if ($displayForm) { |
| 186 | 190 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -194,7 +198,8 @@ discard block |
||
| 194 | 198 | * |
| 195 | 199 | * @return void |
| 196 | 200 | */ |
| 197 | - private function getHolders() { |
|
| 201 | + private function getHolders() |
|
| 202 | + { |
|
| 198 | 203 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
| 199 | 204 | |
| 200 | 205 | if (!empty($holders)) { |
@@ -222,7 +227,8 @@ discard block |
||
| 222 | 227 | * |
| 223 | 228 | * @return void |
| 224 | 229 | */ |
| 225 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
| 230 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
| 231 | + { |
|
| 226 | 232 | $profile = new ViafProfile($viafId); |
| 227 | 233 | $name = $profile->getFullName(); |
| 228 | 234 | if (!empty($name)) { |
@@ -246,7 +252,8 @@ discard block |
||
| 246 | 252 | * |
| 247 | 253 | * @return void |
| 248 | 254 | */ |
| 249 | - private function getHolderFromXml($holders, $i) { |
|
| 255 | + private function getHolderFromXml($holders, $i) |
|
| 256 | + { |
|
| 250 | 257 | $this->getHolderFromXmlDisplayForm($holders, $i); |
| 251 | 258 | // Append "valueURI" to name using Unicode unit separator. |
| 252 | 259 | if (isset($holders[$i]['valueURI'])) { |
@@ -264,7 +271,8 @@ discard block |
||
| 264 | 271 | * |
| 265 | 272 | * @return void |
| 266 | 273 | */ |
| 267 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
| 274 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
| 275 | + { |
|
| 268 | 276 | // Check if there is a display form. |
| 269 | 277 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
| 270 | 278 | if ($displayForm) { |
@@ -279,7 +287,8 @@ discard block |
||
| 279 | 287 | * |
| 280 | 288 | * @return void |
| 281 | 289 | */ |
| 282 | - private function getPlaces() { |
|
| 290 | + private function getPlaces() |
|
| 291 | + { |
|
| 283 | 292 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
| 284 | 293 | // Get "place" and "place_sorting" again if that was to sophisticated. |
| 285 | 294 | if (empty($places)) { |
@@ -303,7 +312,8 @@ discard block |
||
| 303 | 312 | * |
| 304 | 313 | * @return void |
| 305 | 314 | */ |
| 306 | - private function getYears() { |
|
| 315 | + private function getYears() |
|
| 316 | + { |
|
| 307 | 317 | // Get "year_sorting". |
| 308 | 318 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
| 309 | 319 | foreach ($years_sorting as $year_sorting) { |
@@ -38,15 +38,15 @@ |
||
| 38 | 38 | */ |
| 39 | 39 | private $offset; |
| 40 | 40 | |
| 41 | - /** |
|
| 42 | - * Constructs SolrSearchQuery instance. |
|
| 43 | - * |
|
| 44 | - * @access public |
|
| 45 | - * |
|
| 46 | - * @param SolrSearch $solrSearch |
|
| 47 | - * |
|
| 48 | - * @return void |
|
| 49 | - */ |
|
| 41 | + /** |
|
| 42 | + * Constructs SolrSearchQuery instance. |
|
| 43 | + * |
|
| 44 | + * @access public |
|
| 45 | + * |
|
| 46 | + * @param SolrSearch $solrSearch |
|
| 47 | + * |
|
| 48 | + * @return void |
|
| 49 | + */ |
|
| 50 | 50 | public function __construct($solrSearch) |
| 51 | 51 | { |
| 52 | 52 | $this->solrSearch = $solrSearch; |
@@ -55,7 +55,9 @@ discard block |
||
| 55 | 55 | $this->limit = count($solrSearch); |
| 56 | 56 | } |
| 57 | 57 | |
| 58 | - public function getSource() {} |
|
| 58 | + public function getSource() |
|
| 59 | + { |
|
| 60 | +} |
|
| 59 | 61 | |
| 60 | 62 | /** |
| 61 | 63 | * Executes SOLR search query. |
@@ -79,7 +81,9 @@ discard block |
||
| 79 | 81 | return $result; |
| 80 | 82 | } |
| 81 | 83 | |
| 82 | - public function setOrderings(array $orderings) {} |
|
| 84 | + public function setOrderings(array $orderings) |
|
| 85 | + { |
|
| 86 | +} |
|
| 83 | 87 | |
| 84 | 88 | /** |
| 85 | 89 | * Sets limit for SOLR search query. |
@@ -111,28 +115,60 @@ discard block |
||
| 111 | 115 | return $this; |
| 112 | 116 | } |
| 113 | 117 | |
| 114 | - public function matching($constraint) {} |
|
| 115 | - public function logicalAnd($constraint1) {} |
|
| 116 | - public function logicalOr($constraint1) {} |
|
| 117 | - public function logicalNot(ConstraintInterface $constraint) {} |
|
| 118 | - public function equals($propertyName, $operand, $caseSensitive = true) {} |
|
| 119 | - public function like($propertyName, $operand) {} |
|
| 120 | - public function contains($propertyName, $operand) {} |
|
| 121 | - public function in($propertyName, $operand) {} |
|
| 122 | - public function lessThan($propertyName, $operand) {} |
|
| 123 | - public function lessThanOrEqual($propertyName, $operand) {} |
|
| 124 | - public function greaterThan($propertyName, $operand) {} |
|
| 125 | - public function greaterThanOrEqual($propertyName, $operand) {} |
|
| 126 | - public function getType() {} |
|
| 127 | - public function setQuerySettings(QuerySettingsInterface $querySettings) {} |
|
| 128 | - public function getQuerySettings() {} |
|
| 118 | + public function matching($constraint) |
|
| 119 | + { |
|
| 120 | +} |
|
| 121 | + public function logicalAnd($constraint1) |
|
| 122 | + { |
|
| 123 | +} |
|
| 124 | + public function logicalOr($constraint1) |
|
| 125 | + { |
|
| 126 | +} |
|
| 127 | + public function logicalNot(ConstraintInterface $constraint) |
|
| 128 | + { |
|
| 129 | +} |
|
| 130 | + public function equals($propertyName, $operand, $caseSensitive = true) |
|
| 131 | + { |
|
| 132 | +} |
|
| 133 | + public function like($propertyName, $operand) |
|
| 134 | + { |
|
| 135 | +} |
|
| 136 | + public function contains($propertyName, $operand) |
|
| 137 | + { |
|
| 138 | +} |
|
| 139 | + public function in($propertyName, $operand) |
|
| 140 | + { |
|
| 141 | +} |
|
| 142 | + public function lessThan($propertyName, $operand) |
|
| 143 | + { |
|
| 144 | +} |
|
| 145 | + public function lessThanOrEqual($propertyName, $operand) |
|
| 146 | + { |
|
| 147 | +} |
|
| 148 | + public function greaterThan($propertyName, $operand) |
|
| 149 | + { |
|
| 150 | +} |
|
| 151 | + public function greaterThanOrEqual($propertyName, $operand) |
|
| 152 | + { |
|
| 153 | +} |
|
| 154 | + public function getType() |
|
| 155 | + { |
|
| 156 | +} |
|
| 157 | + public function setQuerySettings(QuerySettingsInterface $querySettings) |
|
| 158 | + { |
|
| 159 | +} |
|
| 160 | + public function getQuerySettings() |
|
| 161 | + { |
|
| 162 | +} |
|
| 129 | 163 | |
| 130 | 164 | public function count() |
| 131 | 165 | { |
| 132 | 166 | // TODO? |
| 133 | 167 | } |
| 134 | 168 | |
| 135 | - public function getOrderings() {} |
|
| 169 | + public function getOrderings() |
|
| 170 | + { |
|
| 171 | +} |
|
| 136 | 172 | |
| 137 | 173 | /** |
| 138 | 174 | * Gets limit for SOLR search query. |
@@ -158,8 +194,16 @@ discard block |
||
| 158 | 194 | return $this->offset; |
| 159 | 195 | } |
| 160 | 196 | |
| 161 | - public function getConstraint() {} |
|
| 162 | - public function isEmpty($propertyName) {} |
|
| 163 | - public function setSource(SourceInterface $source) {} |
|
| 164 | - public function getStatement() {} |
|
| 197 | + public function getConstraint() |
|
| 198 | + { |
|
| 199 | +} |
|
| 200 | + public function isEmpty($propertyName) |
|
| 201 | + { |
|
| 202 | +} |
|
| 203 | + public function setSource(SourceInterface $source) |
|
| 204 | + { |
|
| 205 | +} |
|
| 206 | + public function getStatement() |
|
| 207 | + { |
|
| 208 | +} |
|
| 165 | 209 | } |
@@ -775,7 +775,8 @@ |
||
| 775 | 775 | * |
| 776 | 776 | * @return array The Apache Solr Documents that were fetched |
| 777 | 777 | */ |
| 778 | - private function getDocument($record, $highlighting, $fields, $parameters) { |
|
| 778 | + private function getDocument($record, $highlighting, $fields, $parameters) |
|
| 779 | + { |
|
| 779 | 780 | $resultDocument = new ResultDocument($record, $highlighting, $fields); |
| 780 | 781 | |
| 781 | 782 | $document = [ |