We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Total Complexity | 62 |
Total Lines | 651 |
Duplicated Lines | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Complex classes like Document often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Document, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
15 | class Document extends \TYPO3\CMS\Extbase\DomainObject\AbstractValueObject |
||
16 | { |
||
17 | /** |
||
18 | * @var string |
||
19 | */ |
||
20 | protected $title; |
||
21 | |||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | protected $prodId; |
||
26 | |||
27 | /** |
||
28 | * @var string |
||
29 | */ |
||
30 | protected $location; |
||
31 | |||
32 | /** |
||
33 | * @var string |
||
34 | */ |
||
35 | protected $recordId; |
||
36 | |||
37 | /** |
||
38 | * @var string |
||
39 | */ |
||
40 | protected $opacId; |
||
41 | |||
42 | /** |
||
43 | * @var string |
||
44 | */ |
||
45 | protected $unionId; |
||
46 | |||
47 | /** |
||
48 | * @var string |
||
49 | */ |
||
50 | protected $urn; |
||
51 | |||
52 | /** |
||
53 | * @var string |
||
54 | */ |
||
55 | protected $purl; |
||
56 | |||
57 | /** |
||
58 | * @var string |
||
59 | */ |
||
60 | protected $titleSorting; |
||
61 | |||
62 | /** |
||
63 | * @var string |
||
64 | */ |
||
65 | protected $author; |
||
66 | |||
67 | /** |
||
68 | * @var string |
||
69 | */ |
||
70 | protected $year; |
||
71 | |||
72 | /** |
||
73 | * @var string |
||
74 | */ |
||
75 | protected $place; |
||
76 | |||
77 | /** |
||
78 | * @var string |
||
79 | */ |
||
80 | protected $thumbnail; |
||
81 | |||
82 | /** |
||
83 | * @var string |
||
84 | */ |
||
85 | protected $metadata; |
||
86 | |||
87 | /** |
||
88 | * @var string |
||
89 | */ |
||
90 | protected $metadataSorting; |
||
91 | |||
92 | /** |
||
93 | * @var int |
||
94 | */ |
||
95 | protected $structure; |
||
96 | |||
97 | /** |
||
98 | * @var int |
||
99 | */ |
||
100 | protected $partof; |
||
101 | |||
102 | /** |
||
103 | * @var string |
||
104 | */ |
||
105 | protected $volume; |
||
106 | |||
107 | /** |
||
108 | * @var string |
||
109 | */ |
||
110 | protected $volumeSorting; |
||
111 | |||
112 | /** |
||
113 | * @var string |
||
114 | */ |
||
115 | protected $license; |
||
116 | |||
117 | /** |
||
118 | * @var string |
||
119 | */ |
||
120 | protected $terms; |
||
121 | |||
122 | /** |
||
123 | * @var string |
||
124 | */ |
||
125 | protected $restrictions; |
||
126 | |||
127 | /** |
||
128 | * @var string |
||
129 | */ |
||
130 | protected $outOfPrint; |
||
131 | |||
132 | /** |
||
133 | * @var string |
||
134 | */ |
||
135 | protected $rightsInfo; |
||
136 | |||
137 | /** |
||
138 | * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\Kitodo\Dlf\Domain\Model\Collection> |
||
139 | */ |
||
140 | protected $collections = null; |
||
141 | |||
142 | /** |
||
143 | * @var string |
||
144 | */ |
||
145 | protected $metsLabel; |
||
146 | |||
147 | /** |
||
148 | * @var string |
||
149 | */ |
||
150 | protected $metsOrderlabel; |
||
151 | |||
152 | /** |
||
153 | * @var int |
||
154 | */ |
||
155 | protected $owner; |
||
156 | |||
157 | /** |
||
158 | * @var int |
||
159 | */ |
||
160 | protected $solrcore; |
||
161 | |||
162 | /** |
||
163 | * @var int |
||
164 | */ |
||
165 | protected $status; |
||
166 | |||
167 | /** |
||
168 | * @var string |
||
169 | */ |
||
170 | protected $documentFormat; |
||
171 | |||
172 | /** |
||
173 | * @return string |
||
174 | */ |
||
175 | public function getTitle(): string |
||
178 | } |
||
179 | |||
180 | /** |
||
181 | * @param string $title |
||
182 | */ |
||
183 | public function setTitle(string $title): void |
||
184 | { |
||
185 | $this->title = $title; |
||
186 | } |
||
187 | |||
188 | /** |
||
189 | * @return string |
||
190 | */ |
||
191 | public function getProdId(): string |
||
192 | { |
||
193 | return $this->prodId; |
||
194 | } |
||
195 | |||
196 | /** |
||
197 | * @param string $prodId |
||
198 | */ |
||
199 | public function setProdId(string $prodId): void |
||
200 | { |
||
201 | $this->prodId = $prodId; |
||
202 | } |
||
203 | |||
204 | /** |
||
205 | * @return string |
||
206 | */ |
||
207 | public function getLocation(): string |
||
208 | { |
||
209 | return $this->location; |
||
210 | } |
||
211 | |||
212 | /** |
||
213 | * @param string $location |
||
214 | */ |
||
215 | public function setLocation(string $location): void |
||
216 | { |
||
217 | $this->location = $location; |
||
218 | } |
||
219 | |||
220 | /** |
||
221 | * @return string |
||
222 | */ |
||
223 | public function getRecordId(): string |
||
224 | { |
||
225 | return $this->recordId; |
||
226 | } |
||
227 | |||
228 | /** |
||
229 | * @param string $recordId |
||
230 | */ |
||
231 | public function setRecordId(string $recordId): void |
||
232 | { |
||
233 | $this->recordId = $recordId; |
||
234 | } |
||
235 | |||
236 | /** |
||
237 | * @return string |
||
238 | */ |
||
239 | public function getOpacId(): string |
||
240 | { |
||
241 | return $this->opacId; |
||
242 | } |
||
243 | |||
244 | /** |
||
245 | * @param string $opacId |
||
246 | */ |
||
247 | public function setOpacId(string $opacId): void |
||
248 | { |
||
249 | $this->opacId = $opacId; |
||
250 | } |
||
251 | |||
252 | /** |
||
253 | * @return string |
||
254 | */ |
||
255 | public function getUnionId(): string |
||
256 | { |
||
257 | return $this->unionId; |
||
258 | } |
||
259 | |||
260 | /** |
||
261 | * @param string $unionId |
||
262 | */ |
||
263 | public function setUnionId(string $unionId): void |
||
264 | { |
||
265 | $this->unionId = $unionId; |
||
266 | } |
||
267 | |||
268 | /** |
||
269 | * @return string |
||
270 | */ |
||
271 | public function getUrn(): string |
||
272 | { |
||
273 | return $this->urn; |
||
274 | } |
||
275 | |||
276 | /** |
||
277 | * @param string $urn |
||
278 | */ |
||
279 | public function setUrn(string $urn): void |
||
280 | { |
||
281 | $this->urn = $urn; |
||
282 | } |
||
283 | |||
284 | /** |
||
285 | * @return string |
||
286 | */ |
||
287 | public function getPurl(): string |
||
288 | { |
||
289 | return $this->purl; |
||
290 | } |
||
291 | |||
292 | /** |
||
293 | * @param string $purl |
||
294 | */ |
||
295 | public function setPurl(string $purl): void |
||
296 | { |
||
297 | $this->purl = $purl; |
||
298 | } |
||
299 | |||
300 | /** |
||
301 | * @return string |
||
302 | */ |
||
303 | public function getTitleSorting(): string |
||
304 | { |
||
305 | return $this->titleSorting; |
||
306 | } |
||
307 | |||
308 | /** |
||
309 | * @param string $titleSorting |
||
310 | */ |
||
311 | public function setTitleSorting(string $titleSorting): void |
||
312 | { |
||
313 | $this->titleSorting = $titleSorting; |
||
314 | } |
||
315 | |||
316 | /** |
||
317 | * @return string |
||
318 | */ |
||
319 | public function getAuthor(): string |
||
320 | { |
||
321 | return $this->author; |
||
322 | } |
||
323 | |||
324 | /** |
||
325 | * @param string $author |
||
326 | */ |
||
327 | public function setAuthor(string $author): void |
||
328 | { |
||
329 | $this->author = $author; |
||
330 | } |
||
331 | |||
332 | /** |
||
333 | * @return string |
||
334 | */ |
||
335 | public function getYear(): string |
||
336 | { |
||
337 | return $this->year; |
||
338 | } |
||
339 | |||
340 | /** |
||
341 | * @param string $year |
||
342 | */ |
||
343 | public function setYear(string $year): void |
||
344 | { |
||
345 | $this->year = $year; |
||
346 | } |
||
347 | |||
348 | /** |
||
349 | * @return string |
||
350 | */ |
||
351 | public function getPlace(): string |
||
352 | { |
||
353 | return $this->place; |
||
354 | } |
||
355 | |||
356 | /** |
||
357 | * @param string $place |
||
358 | */ |
||
359 | public function setPlace(string $place): void |
||
360 | { |
||
361 | $this->place = $place; |
||
362 | } |
||
363 | |||
364 | /** |
||
365 | * @return string |
||
366 | */ |
||
367 | public function getThumbnail(): string |
||
370 | } |
||
371 | |||
372 | /** |
||
373 | * @param string $thumbnail |
||
374 | */ |
||
375 | public function setThumbnail(string $thumbnail): void |
||
376 | { |
||
377 | $this->thumbnail = $thumbnail; |
||
378 | } |
||
379 | |||
380 | /** |
||
381 | * @return string |
||
382 | */ |
||
383 | public function getMetadata(): string |
||
384 | { |
||
385 | return $this->metadata; |
||
386 | } |
||
387 | |||
388 | /** |
||
389 | * @param string $metadata |
||
390 | */ |
||
391 | public function setMetadata(string $metadata): void |
||
392 | { |
||
393 | $this->metadata = $metadata; |
||
394 | } |
||
395 | |||
396 | /** |
||
397 | * @return string |
||
398 | */ |
||
399 | public function getMetadataSorting(): string |
||
400 | { |
||
401 | return $this->metadataSorting; |
||
402 | } |
||
403 | |||
404 | /** |
||
405 | * @param string $metadataSorting |
||
406 | */ |
||
407 | public function setMetadataSorting(string $metadataSorting): void |
||
408 | { |
||
409 | $this->metadataSorting = $metadataSorting; |
||
410 | } |
||
411 | |||
412 | /** |
||
413 | * @return int |
||
414 | */ |
||
415 | public function getStructure(): int |
||
416 | { |
||
417 | return $this->structure; |
||
418 | } |
||
419 | |||
420 | /** |
||
421 | * @param int $structure |
||
422 | */ |
||
423 | public function setStructure(int $structure): void |
||
424 | { |
||
425 | $this->structure = $structure; |
||
426 | } |
||
427 | |||
428 | /** |
||
429 | * @return int |
||
430 | */ |
||
431 | public function getPartof(): int |
||
432 | { |
||
433 | return $this->partof; |
||
434 | } |
||
435 | |||
436 | /** |
||
437 | * @param int $partof |
||
438 | */ |
||
439 | public function setPartof(int $partof): void |
||
440 | { |
||
441 | $this->partof = $partof; |
||
442 | } |
||
443 | |||
444 | /** |
||
445 | * @return string |
||
446 | */ |
||
447 | public function getVolume(): string |
||
448 | { |
||
449 | return $this->volume; |
||
450 | } |
||
451 | |||
452 | /** |
||
453 | * @param string $volume |
||
454 | */ |
||
455 | public function setVolume(string $volume): void |
||
456 | { |
||
457 | $this->volume = $volume; |
||
458 | } |
||
459 | |||
460 | /** |
||
461 | * @return string |
||
462 | */ |
||
463 | public function getVolumeSorting(): string |
||
464 | { |
||
465 | return $this->volumeSorting; |
||
466 | } |
||
467 | |||
468 | /** |
||
469 | * @param string $volumeSorting |
||
470 | */ |
||
471 | public function setVolumeSorting(string $volumeSorting): void |
||
472 | { |
||
473 | $this->volumeSorting = $volumeSorting; |
||
474 | } |
||
475 | |||
476 | /** |
||
477 | * @return string |
||
478 | */ |
||
479 | public function getLicense(): string |
||
480 | { |
||
481 | return $this->license; |
||
482 | } |
||
483 | |||
484 | /** |
||
485 | * @param string $license |
||
486 | */ |
||
487 | public function setLicense(string $license): void |
||
488 | { |
||
489 | $this->license = $license; |
||
490 | } |
||
491 | |||
492 | /** |
||
493 | * @return string |
||
494 | */ |
||
495 | public function getTerms(): string |
||
496 | { |
||
497 | return $this->terms; |
||
498 | } |
||
499 | |||
500 | /** |
||
501 | * @param string $terms |
||
502 | */ |
||
503 | public function setTerms(string $terms): void |
||
504 | { |
||
505 | $this->terms = $terms; |
||
506 | } |
||
507 | |||
508 | /** |
||
509 | * @return string |
||
510 | */ |
||
511 | public function getRestrictions(): string |
||
512 | { |
||
513 | return $this->restrictions; |
||
514 | } |
||
515 | |||
516 | /** |
||
517 | * @param string $restrictions |
||
518 | */ |
||
519 | public function setRestrictions(string $restrictions): void |
||
520 | { |
||
521 | $this->restrictions = $restrictions; |
||
522 | } |
||
523 | |||
524 | /** |
||
525 | * @return string |
||
526 | */ |
||
527 | public function getOutOfPrint(): string |
||
528 | { |
||
529 | return $this->outOfPrint; |
||
530 | } |
||
531 | |||
532 | /** |
||
533 | * @param string $outOfPrint |
||
534 | */ |
||
535 | public function setOutOfPrint(string $outOfPrint): void |
||
536 | { |
||
537 | $this->outOfPrint = $outOfPrint; |
||
538 | } |
||
539 | |||
540 | /** |
||
541 | * @return string |
||
542 | */ |
||
543 | public function getRightsInfo(): string |
||
544 | { |
||
545 | return $this->rightsInfo; |
||
546 | } |
||
547 | |||
548 | /** |
||
549 | * @param string $rightsInfo |
||
550 | */ |
||
551 | public function setRightsInfo(string $rightsInfo): void |
||
552 | { |
||
553 | $this->rightsInfo = $rightsInfo; |
||
554 | } |
||
555 | |||
556 | /** |
||
557 | * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage |
||
558 | */ |
||
559 | public function getCollections(): ?\TYPO3\CMS\Extbase\Persistence\ObjectStorage |
||
560 | { |
||
561 | return $this->collections; |
||
562 | } |
||
563 | |||
564 | /** |
||
565 | * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage $collections |
||
566 | */ |
||
567 | public function setCollections(?\TYPO3\CMS\Extbase\Persistence\ObjectStorage $collections): void |
||
568 | { |
||
569 | $this->collections = $collections; |
||
570 | } |
||
571 | |||
572 | /** |
||
573 | * @return string |
||
574 | */ |
||
575 | public function getMetsLabel(): string |
||
578 | } |
||
579 | |||
580 | /** |
||
581 | * @param string $metsLabel |
||
582 | */ |
||
583 | public function setMetsLabel(string $metsLabel): void |
||
584 | { |
||
585 | $this->metsLabel = $metsLabel; |
||
586 | } |
||
587 | |||
588 | /** |
||
589 | * @return string |
||
590 | */ |
||
591 | public function getMetsOrderlabel(): string |
||
592 | { |
||
593 | return $this->metsOrderlabel; |
||
594 | } |
||
595 | |||
596 | /** |
||
597 | * @param string $metsOrderlabel |
||
598 | */ |
||
599 | public function setMetsOrderlabel(string $metsOrderlabel): void |
||
600 | { |
||
601 | $this->metsOrderlabel = $metsOrderlabel; |
||
602 | } |
||
603 | |||
604 | /** |
||
605 | * @return int |
||
606 | */ |
||
607 | public function getOwner(): int |
||
608 | { |
||
609 | return $this->owner; |
||
610 | } |
||
611 | |||
612 | /** |
||
613 | * @param int $owner |
||
614 | */ |
||
615 | public function setOwner(int $owner): void |
||
616 | { |
||
617 | $this->owner = $owner; |
||
618 | } |
||
619 | |||
620 | /** |
||
621 | * @return int |
||
622 | */ |
||
623 | public function getSolrcore(): int |
||
624 | { |
||
625 | return $this->solrcore; |
||
626 | } |
||
627 | |||
628 | /** |
||
629 | * @param int $solrcore |
||
630 | */ |
||
631 | public function setSolrcore(int $solrcore): void |
||
632 | { |
||
633 | $this->solrcore = $solrcore; |
||
634 | } |
||
635 | |||
636 | /** |
||
637 | * @return int |
||
638 | */ |
||
639 | public function getStatus(): int |
||
640 | { |
||
641 | return $this->status; |
||
642 | } |
||
643 | |||
644 | /** |
||
645 | * @param int $status |
||
646 | */ |
||
647 | public function setStatus(int $status): void |
||
648 | { |
||
649 | $this->status = $status; |
||
650 | } |
||
651 | |||
652 | /** |
||
653 | * @return string |
||
654 | */ |
||
655 | public function getDocumentFormat(): string |
||
658 | } |
||
659 | |||
660 | /** |
||
661 | * @param string $documentFormat |
||
662 | */ |
||
663 | public function setDocumentFormat(string $documentFormat): void |
||
664 | { |
||
665 | $this->documentFormat = $documentFormat; |
||
666 | } |
||
667 | |||
668 | } |
||
669 |