Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#853)
by Beatrycze
04:05
created
Classes/Controller/CalendarController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
                 foreach ($year['children'] as $month) {
130 130
                     foreach ($month['children'] as $day) {
131 131
                         foreach ($day['children'] as $issue) {
132
-                            $title = $issue['label'] ?: $issue['orderlabel'];
132
+                            $title = $issue['label'] ? : $issue['orderlabel'];
133 133
                             if (strtotime($title) !== false) {
134 134
                                 $title = strftime('%x', strtotime($title));
135 135
                             }
@@ -220,8 +220,8 @@  discard block
 block discarded – undo
220 220
         $this->view->assign('calendarData', $calendarData);
221 221
         $this->view->assign('documentId', $this->document->getUid());
222 222
         $this->view->assign('yearLinkTitle', $yearLinkTitle);
223
-        $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']);
224
-        $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']);
223
+        $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']);
224
+        $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']);
225 225
     }
226 226
 
227 227
     /**
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
                 if (empty($yearLabel)) {
259 259
                     // if neither order nor orderlabel is set, use the id...
260
-                    $yearLabel = (string)$id;
260
+                    $yearLabel = (string) $id;
261 261
                 }
262 262
 
263 263
                 $years[] = [
Please login to merge, or discard this patch.
Classes/Hooks/ItemsProcFunc.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,8 @@
 block discarded – undo
58 58
      *
59 59
      * @return void
60 60
      */
61
-    public function getTyposcriptConfigFromPluginSiteRoot($params) {
61
+    public function getTyposcriptConfigFromPluginSiteRoot($params)
62
+    {
62 63
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
63 64
         $pid = $params['flexParentDatabaseRow']['pid'];
64 65
         $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid);
Please login to merge, or discard this patch.
Classes/Controller/View3DController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
             $settingsParts = explode("/", $model);
50 50
             $fileName = end($settingsParts);
51
-            $path = substr($model, 0,  strrpos($model, $fileName));
51
+            $path = substr($model, 0, strrpos($model, $fileName));
52 52
             $modelSettings = $path . "metadata/" . $fileName . "_viewer";
53 53
 
54 54
             if (!empty($modelConverted)) {
Please login to merge, or discard this patch.
Classes/Controller/NavigationController.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,8 @@
 block discarded – undo
30 30
      * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm
31 31
      * @return void
32 32
      */
33
-    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) {
33
+    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL)
34
+    {
34 35
         if ($pageSelectForm) {
35 36
             $uriBuilder = $this->getControllerContext()->getUriBuilder();
36 37
             $uri = $uriBuilder->reset()
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      * @param \Kitodo\Dlf\Domain\Model\PageSelectForm|NULL $pageSelectForm
31 31
      * @return void
32 32
      */
33
-    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = NULL) {
33
+    public function pageSelectAction(\Kitodo\Dlf\Domain\Model\PageSelectForm $pageSelectForm = null) {
34 34
         if ($pageSelectForm) {
35 35
             $uriBuilder = $this->getControllerContext()->getUriBuilder();
36 36
             $uri = $uriBuilder->reset()
Please login to merge, or discard this patch.
Classes/Controller/SearchController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -107,13 +107,13 @@
 block discarded – undo
107 107
         }
108 108
 
109 109
         // sanitize date search input
110
-        if(empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
110
+        if (empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
111 111
             $this->searchParams['dateFrom'] = '*';
112 112
         }
113
-        if(empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) {
113
+        if (empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) {
114 114
             $this->searchParams['dateTo'] = 'NOW';
115 115
         }
116
-        if($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) {
116
+        if ($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) {
117 117
             $tmpDate = $this->searchParams['dateFrom'];
118 118
             $this->searchParams['dateFrom'] = $this->searchParams['dateTo'];
119 119
             $this->searchParams['dateTo'] = $tmpDate;
Please login to merge, or discard this patch.
Classes/Format/Mods.php 1 patch
Braces   +20 added lines, -10 removed lines patch added patch discarded remove patch
@@ -71,7 +71,8 @@  discard block
 block discarded – undo
71 71
      *
72 72
      * @return void
73 73
      */
74
-    private function getAuthors() {
74
+    private function getAuthors()
75
+    {
75 76
         $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]');
76 77
 
77 78
         // Get "author" and "author_sorting" again if that was too sophisticated.
@@ -93,7 +94,8 @@  discard block
 block discarded – undo
93 94
         }
94 95
     }
95 96
 
96
-    private function getAuthorFromOrcidApi($orcidId, $authors, $i) {
97
+    private function getAuthorFromOrcidApi($orcidId, $authors, $i)
98
+    {
97 99
         $profile = new OrcidProfile($orcidId);
98 100
         $name = $profile->getFullName();
99 101
         if (!empty($name)) {
@@ -107,7 +109,8 @@  discard block
 block discarded – undo
107 109
         }
108 110
     }
109 111
 
110
-    private function getAuthorFromXml($authors, $i) {
112
+    private function getAuthorFromXml($authors, $i)
113
+    {
111 114
         $this->getAuthorFromXmlDisplayForm($authors, $i);
112 115
 
113 116
         $nameParts = $authors[$i]->xpath('./mods:namePart');
@@ -150,7 +153,8 @@  discard block
 block discarded – undo
150 153
         }
151 154
     }
152 155
 
153
-    private function getAuthorFromXmlDisplayForm($authors, $i) {
156
+    private function getAuthorFromXmlDisplayForm($authors, $i)
157
+    {
154 158
         $displayForm = $authors[$i]->xpath('./mods:displayForm');
155 159
         if ($displayForm) {
156 160
             $this->metadata['author'][$i] = (string) $displayForm[0];
@@ -164,7 +168,8 @@  discard block
 block discarded – undo
164 168
      *
165 169
      * @return void
166 170
      */
167
-    private function getHolders() {
171
+    private function getHolders()
172
+    {
168 173
         $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]');
169 174
 
170 175
         if (!empty($holders)) {
@@ -181,7 +186,8 @@  discard block
 block discarded – undo
181 186
         }
182 187
     }
183 188
 
184
-    private function getHolderFromViafApi($viafId, $holders, $i) {
189
+    private function getHolderFromViafApi($viafId, $holders, $i)
190
+    {
185 191
         $profile = new ViafProfile($viafId);
186 192
         $name = $profile->getFullName();
187 193
         if (!empty($name)) {
@@ -195,7 +201,8 @@  discard block
 block discarded – undo
195 201
         }
196 202
     }
197 203
 
198
-    private function getHolderFromXml($holders, $i) {
204
+    private function getHolderFromXml($holders, $i)
205
+    {
199 206
         $this->getHolderFromXmlDisplayForm($holders, $i);
200 207
         // Append "valueURI" to name using Unicode unit separator.
201 208
         if (isset($holders[$i]['valueURI'])) {
@@ -203,7 +210,8 @@  discard block
 block discarded – undo
203 210
         }
204 211
     }
205 212
 
206
-    private function getHolderFromXmlDisplayForm($holders, $i) {
213
+    private function getHolderFromXmlDisplayForm($holders, $i)
214
+    {
207 215
         // Check if there is a display form.
208 216
         $displayForm = $holders[$i]->xpath('./mods:displayForm');
209 217
         if ($displayForm) {
@@ -218,7 +226,8 @@  discard block
 block discarded – undo
218 226
      *
219 227
      * @return void
220 228
      */
221
-    private function getPlaces() {
229
+    private function getPlaces()
230
+    {
222 231
         $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm');
223 232
         // Get "place" and "place_sorting" again if that was to sophisticated.
224 233
         if (empty($places)) {
@@ -242,7 +251,8 @@  discard block
 block discarded – undo
242 251
      *
243 252
      * @return void
244 253
      */
245
-    private function getYears() {
254
+    private function getYears()
255
+    {
246 256
         // Get "year_sorting".
247 257
         if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) {
248 258
             foreach ($years_sorting as $year_sorting) {
Please login to merge, or discard this patch.
Classes/Common/Indexer.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
             $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']);
338 338
             $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']);
339 339
             // verify date formatting
340
-            if(strtotime($metadata['date'][0])) {
340
+            if (strtotime($metadata['date'][0])) {
341 341
                 // do not alter dates YYYY or YYYY-MM or YYYY-MM-DD
342 342
                 if (
343 343
                     preg_match("/^[\d]{4}$/", $metadata['date'][0])
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
                 ) {
347 347
                     $solrDoc->setField('date', $metadata['date'][0]);
348 348
                 // change date YYYYMMDD to YYYY-MM-DD
349
-                } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){
349
+                } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) {
350 350
                     $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0])));
351 351
                 // convert any datetime to proper ISO extended datetime format and timezone for SOLR
352 352
                 } else {
Please login to merge, or discard this patch.
Braces   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
                 ) {
347 347
                     $solrDoc->setField('date', $metadata['date'][0]);
348 348
                 // change date YYYYMMDD to YYYY-MM-DD
349
-                } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){
349
+                } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) {
350 350
                     $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0])));
351 351
                 // convert any datetime to proper ISO extended datetime format and timezone for SOLR
352 352
                 } else {
@@ -549,7 +549,8 @@  discard block
 block discarded – undo
549 549
      *
550 550
      * @return \Solarium\Core\Query\DocumentInterface
551 551
      */
552
-    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') {
552
+    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '')
553
+    {
553 554
         $solrDoc = $updateQuery->createDocument();
554 555
         // Create unique identifier from document's UID and unit's XML ID.
555 556
         $solrDoc->setField('id', $document->getUid() . $unit['id']);
@@ -573,7 +574,8 @@  discard block
 block discarded – undo
573 574
      *
574 575
      * @return array|string
575 576
      */
576
-    private static function removeAppendsFromAuthor($authors) {
577
+    private static function removeAppendsFromAuthor($authors)
578
+    {
577 579
         if (is_array($authors)) {
578 580
             foreach ($authors as $i => $author) {
579 581
                 $splitName = explode(chr(31), $author);
Please login to merge, or discard this patch.
Classes/Common/SolrSearch.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         // Add filter query for date search
213 213
         if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
214 214
             // combine dateFrom and dateTo into range search
215
-            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
215
+            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}' . $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
216 216
         }
217 217
 
218 218
         // Add filter query for faceting.
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
                 }
325 325
                 if ($documents[$doc['uid']]) {
326 326
                     // translate language code if applicable
327
-                    if($doc['metadata']['language']) {
328
-                        foreach($doc['metadata']['language'] as $indexName => $language) {
327
+                    if ($doc['metadata']['language']) {
328
+                        foreach ($doc['metadata']['language'] as $indexName => $language) {
329 329
                             $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
330 330
                         }
331 331
                     }
@@ -425,8 +425,8 @@  discard block
 block discarded – undo
425 425
 
426 426
         foreach ($result['documents'] as $doc) {
427 427
             // translate language code if applicable
428
-            if($doc['metadata']['language']) {
429
-                foreach($doc['metadata']['language'] as $indexName => $language) {
428
+            if ($doc['metadata']['language']) {
429
+                foreach ($doc['metadata']['language'] as $indexName => $language) {
430 430
                     $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
431 431
                 }
432 432
             }
Please login to merge, or discard this patch.
Classes/Api/Viaf/Client.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,8 @@
 block discarded – undo
77 77
      *
78 78
      * @return void
79 79
      */
80
-    public function setEndpoint($endpoint) {
80
+    public function setEndpoint($endpoint)
81
+    {
81 82
         $this->endpoint = $endpoint;
82 83
     }
83 84
 
Please login to merge, or discard this patch.