tx_dlf_collection::showSingleCollection()

Complexity

Conditions	22
Paths	4380

Size

Total Lines	194
Code Lines	87

Duplication

Lines	0
Ratio	0 %

Importance

Changes	14
Bugs	0	Features	1

<?php
    protected function showSingleCollection($id) {

        $additionalWhere = '';

        // Should user-defined collections be shown?
        if (empty($this->conf['show_userdefined'])) {

            $additionalWhere = ' AND tx_dlf_collections.fe_cruser_id=0';

        } elseif ($this->conf['show_userdefined'] > 0) {

            $additionalWhere = ' AND NOT tx_dlf_collections.fe_cruser_id=0';

        }

        // Get collection information from DB
        $collection = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
            'tx_dlf_collections.index_name AS index_name, tx_dlf_collections.index_search as index_query, tx_dlf_collections.label AS collLabel, tx_dlf_collections.description AS collDesc, tx_dlf_collections.thumbnail AS collThumb, tx_dlf_collections.fe_cruser_id',
            'tx_dlf_collections',
            'tx_dlf_collections.pid='.intval($this->conf['pages']).' AND tx_dlf_collections.uid='.intval($id).$additionalWhere.tx_dlf_helper::whereClause('tx_dlf_collections'),
            '',
            '',
            '1'
        );

        // Fetch corresponding document UIDs from Solr.
        $solr_query = '';

        $collectionData = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($collection);

        if ($collectionData['index_query'] != '') {

            $solr_query .= '('.$collectionData['index_query'].')';

        } else {

            $solr_query .= 'collection:("'.$collectionData['index_name'].'")';

        }

        $solr = tx_dlf_solr::getInstance($this->conf['solrcore']);

        if (!$solr->ready) {

The property $ready is declared protected in tx_dlf_solr. Since you implement __get, consider adding a @property or @property-read.

            if (TYPO3_DLOG) {

                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[tx_dlf_collection->showSingleCollection('.intval($id).')] Apache Solr not available', $this->extKey, SYSLOG_SEVERITY_ERROR);

The constant SYSLOG_SEVERITY_ERROR was not found. Maybe you did not declare it correctly or list all dependencies?

            }

            return;

        }

        $params['fields'] = 'uid';

$params was never initialized. Although not strictly required by PHP, it is generally a good practice to add $params = array(); before regardless.

        $params['sort'] = array ('uid' => 'asc');

        $solrResult = $solr->search_raw($solr_query, $params);

        // initialize array
        $documentSet = [];

        foreach ($solrResult as $doc) {

            $documentSet[] = $doc->uid;

        }

        $documentSet = array_unique($documentSet);

        //Fetch document info for UIDs in $documentSet from DB
        $documents = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
            'tx_dlf_documents.uid AS uid, tx_dlf_documents.metadata_sorting AS metadata_sorting, tx_dlf_documents.volume_sorting AS volume_sorting, tx_dlf_documents.partof AS partof',
            'tx_dlf_documents',
            'tx_dlf_documents.pid='.intval($this->conf['pages']).' AND tx_dlf_documents.uid IN ('.implode(',', $documentSet).')'.tx_dlf_helper::whereClause('tx_dlf_documents'),
            '',
            '',
            ''
        );

        $toplevel = array ();

        $subparts = array ();

        $listMetadata = array ();

        // Process results.
        while ($resArray = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($documents)) {

            if (empty($l10nOverlay)) {

                $l10nOverlay = $GLOBALS['TSFE']->sys_page->getRecordOverlay('tx_dlf_collections', $resArray, $GLOBALS['TSFE']->sys_language_content, $GLOBALS['TSFE']->sys_language_contentOL);

            }

            if (empty($listMetadata)) {

                $listMetadata = array (
                    'label' => !empty($l10nOverlay['label']) ? htmlspecialchars($l10nOverlay['label']) : htmlspecialchars($collectionData['collLabel']),
                    'description' => !empty($l10nOverlay['description']) ? $this->pi_RTEcssText($l10nOverlay['description']) : $this->pi_RTEcssText($collectionData['collDesc']),
                    'thumbnail' => htmlspecialchars($collectionData['collThumb']),
                    'options' => array (
                        'source' => 'collection',
                        'select' => $id,
                        'userid' => $collectionData['userid'],
                        'params' => array ('filterquery' => array (array ('query' => 'collection_faceting:("'.$collectionData['index_name'].'")'))),
                        'core' => '',
                        'pid' => $this->conf['pages'],
                        'order' => 'title',
                        'order.asc' => TRUE
                    )
                );

            }

            // Split toplevel documents from volumes.
            if ($resArray['partof'] == 0) {

                // Prepare document's metadata for sorting.
                $sorting = unserialize($resArray['metadata_sorting']);

                if (!empty($sorting['type']) && \TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($sorting['type'])) {

                    $sorting['type'] = tx_dlf_helper::getIndexName($sorting['type'], 'tx_dlf_structures', $this->conf['pages']);

                }

                if (!empty($sorting['owner']) && \TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($sorting['owner'])) {

                    $sorting['owner'] = tx_dlf_helper::getIndexName($sorting['owner'], 'tx_dlf_libraries', $this->conf['pages']);

                }

                if (!empty($sorting['collection']) && \TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($sorting['collection'])) {

                    $sorting['collection'] = tx_dlf_helper::getIndexName($sorting['collection'], 'tx_dlf_collections', $this->conf['pages']);

                }

                $toplevel[$resArray['uid']] = array (
                    'u' => $resArray['uid'],
                    'h' => '',
                    's' => $sorting,
                    'p' => array ()
                );

            } else {

                $subparts[$resArray['partof']][$resArray['volume_sorting']] = $resArray['uid'];

            }

        }

        // Add volumes to the corresponding toplevel documents.
        foreach ($subparts as $partof => $parts) {

            if (!empty($toplevel[$partof])) {

                ksort($parts);

                foreach ($parts as $part) {

                    $toplevel[$partof]['p'][] = array ('u' => $part);

                }

            }

        }

        // Save list of documents.
        $list = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_dlf_list');

        $list->reset();

        $list->add(array_values($toplevel));

        $listMetadata['options']['numberOfToplevelHits'] = count($list);

        $list->metadata = $listMetadata;

        $list->save();

        // Clean output buffer.
        \TYPO3\CMS\Core\Utility\GeneralUtility::cleanOutputBuffers();

The function TYPO3\CMS\Core\Utility\GeneralUtility::cleanOutputBuffers() has been deprecated: since TYPO3 CMS 7, will be removed in CMS 8, use ob_* functions directly or self::flushOutputBuffers

        // Send headers.
        header('Location: '.\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL(array ('parameter' => $this->conf['targetPid']))));

        // Flush output buffer and end script processing.
        ob_end_flush();

        exit;

Using exit here is not recommended.