Kitodo\Dlf\Controller\NavigationController::mainAction()

Complexity

Conditions	11
Paths	33

Size

Total Lines	61
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function mainAction()
    {
        $requestData = GeneralUtility::_GPmerged('tx_dlf');
        unset($requestData['__referrer'], $requestData['__trustedProperties']);

        if (empty($requestData['id'])) {
            return '';

The expression return '' returns the type string which is incompatible with the documented return type void.

        }
        if (empty($requestData['page'])) {
            $requestData['page'] = 1;
        }
        // Load current document.
        $this->loadDocument($requestData);
        if ($this->doc === null) {
            // Quit without doing anything if required variables are not set.
            return;
        } else {
            // Set default values if not set.
            if ($this->doc->numPages > 0) {
                if (!empty($requestData['logicalPage'])) {
                    $requestData['page'] = $this->doc->getPhysicalPage($requestData['logicalPage']);
                    // The logical page parameter should not appear
                    unset($requestData['logicalPage']);
                }
                // Set default values if not set.
                // $requestData['page'] may be integer or string (physical structure @ID)
                if (
                    (int) $requestData['page'] > 0
                    || empty($requestData['page'])
                ) {
                    $requestData['page'] = MathUtility::forceIntegerInRange((int) $requestData['page'], 1, $this->doc->numPages, 1);
                } else {
                    $requestData['page'] = array_search($requestData['page'], $this->doc->physicalStructure);
                }
                $requestData['double'] = MathUtility::forceIntegerInRange($requestData['double'], 0, 1, 0);
            } else {
                $requestData['page'] = 0;
                $requestData['double'] = 0;
            }
        }

        // Steps for X pages backward / forward. Double page view uses double steps.
        $pageSteps = $this->settings['pageStep'] * ($requestData['double'] + 1);

        $this->view->assign('page', $requestData['page']);
        $this->view->assign('docId', $this->doc->uid);
        $this->view->assign('pageId', $GLOBALS['TSFE']->id);
        $this->view->assign('pageSteps', $pageSteps);
        $this->view->assign('double', $requestData['double']);
        $this->view->assign('numPages', $this->doc->numPages);

        // TODO: Check if f:link.action can be used in template Navigation->main
        $this->view->assign('pageToList', $this->settings['targetPid']);
        $this->view->assign('forceAbsoluteUrl', !empty($this->conf['settings.forceAbsoluteUrl']) ? 1 : 0);

The property conf does not exist on Kitodo\Dlf\Controller\NavigationController. Did you maybe forget to declare it?

        $pageOptions = [];
        for ($i = 1; $i <= $this->doc->numPages; $i++) {
            $pageOptions[$i] = ($this->doc->physicalStructureInfo[$this->doc->physicalStructure[$i]]['orderlabel'] ? ' - ' . htmlspecialchars($this->doc->physicalStructureInfo[$this->doc->physicalStructure[$i]]['orderlabel']) : '');
        }
        $this->view->assign('uniqueId', uniqid(Helper::getUnqualifiedClassName(get_class($this)) . '-'));
        $this->view->assign('pageOptions', $pageOptions);