Kitodo\Dlf\Common\Indexer::processLogical()

Complexity

Conditions	21
Paths	171

Size

Total Lines	88
Code Lines	61

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected static function processLogical(Document &$doc, array $logicalUnit) {
        $errors = 0;
        // Get metadata for logical unit.
        $metadata = $doc->metadataArray[$logicalUnit['id']];

The property $metadataArray is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

        if (!empty($metadata)) {
            // Create new Solr document.
            $updateQuery = self::$solr->service->createUpdate();

The property $service is declared protected in Kitodo\Dlf\Common\Solr. Since you implement __get, consider adding a @property or @property-read.

            $solrDoc = $updateQuery->createDocument();
            // Create unique identifier from document's UID and unit's XML ID.
            $solrDoc->setField('id', $doc->uid.$logicalUnit['id']);

The property $uid is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            $solrDoc->setField('uid', $doc->uid);
            $solrDoc->setField('pid', $doc->pid);

The property $pid is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            if (\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($logicalUnit['points'])) {
                $solrDoc->setField('page', $logicalUnit['points']);
            }
            if ($logicalUnit['id'] == $doc->toplevelId) {

The property $toplevelId is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

                $solrDoc->setField('thumbnail', $doc->thumbnail);

The property $thumbnail is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            } elseif (!empty($logicalUnit['thumbnailId'])) {
                $solrDoc->setField('thumbnail', $doc->getFileLocation($logicalUnit['thumbnailId']));
            }
            $solrDoc->setField('partof', $doc->parentId);

The property $parentId is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            $solrDoc->setField('root', $doc->rootId);

The property $rootId is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            $solrDoc->setField('sid', $logicalUnit['id']);
            // There can be only one toplevel unit per UID, independently of backend configuration
            $solrDoc->setField('toplevel', $logicalUnit['id'] == $doc->toplevelId ? TRUE : FALSE);
            $solrDoc->setField('type', $logicalUnit['type'], self::$fields['fieldboost']['type']);
            $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']);
            $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']);
            $solrDoc->setField('record_id', $metadata['record_id'][0]);
            $solrDoc->setField('purl', $metadata['purl'][0]);
            $solrDoc->setField('location', $doc->location);

The property $location is declared protected in Kitodo\Dlf\Common\Document. Since you implement __get, consider adding a @property or @property-read.

            $solrDoc->setField('urn', $metadata['urn']);
            $solrDoc->setField('collection', $doc->metadataArray[$doc->toplevelId]['collection']);
            $autocomplete = [];
            foreach ($metadata as $index_name => $data) {
                if (!empty($data)
                    && substr($index_name, -8) !== '_sorting') {
                    $solrDoc->setField(self::getIndexFieldName($index_name, $doc->pid), $data, self::$fields['fieldboost'][$index_name]);
                    if (in_array($index_name, self::$fields['sortables'])) {
                        // Add sortable fields to index.
                        $solrDoc->setField($index_name.'_sorting', $metadata[$index_name.'_sorting'][0]);
                    }
                    if (in_array($index_name, self::$fields['facets'])) {
                        // Add facets to index.
                        $solrDoc->setField($index_name.'_faceting', $data);
                    }
                    if (in_array($index_name, self::$fields['autocomplete'])) {
                        $autocomplete = array_merge($autocomplete, $data);
                    }
                }
            }
            // Add autocomplete values to index.
            if (!empty($autocomplete)) {
                $solrDoc->setField('autocomplete', $autocomplete);
            }
            // Add collection information to logical sub-elements if applicable.
            if (in_array('collection', self::$fields['facets'])
                && empty($metadata['collection'])
                && !empty($doc->metadataArray[$doc->toplevelId]['collection'])) {
                $solrDoc->setField('collection_faceting', $doc->metadataArray[$doc->toplevelId]['collection']);
            }
            try {
                $updateQuery->addDocument($solrDoc);
                self::$solr->service->update($updateQuery);
            } catch (\Exception $e) {
                if ((TYPO3_REQUESTTYPE & TYPO3_REQUESTTYPE_CLI) == FALSE) {

It seems like you are loosely comparing Kitodo\Dlf\Common\TYPO3_REQUESTTYPE & Kitodo\Dlf\Common\TYPO3_REQUESTTYPE_CLI of type integer to the boolean FALSE. If you are specifically checking for 0, consider using something more explicit like === 0 instead.

                    Helper::addMessage(
                        Helper::getMessage('flash.solrException', TRUE).'<br />'.htmlspecialchars($e->getMessage()),
                        Helper::getMessage('flash.error', TRUE),
                        \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR,
                        TRUE
                    );
                }
                return 1;
            }
        }
        // Check for child elements...
        if (!empty($logicalUnit['children'])) {
            foreach ($logicalUnit['children'] as $child) {
                if (!$errors) {
                    // ...and process them, too.
                    $errors = self::processLogical($doc, $child);
                } else {
                    break;
                }
            }
        }
        return $errors;
    }