Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#829)
by Beatrycze
03:04
created
Classes/Api/Orcid/Client.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,8 @@
 block discarded – undo
73 73
     /**
74 74
      * @param string  $endpoint the shortname of the endpoint
75 75
      */
76
-    public function setEndpoint($endpoint) {
76
+    public function setEndpoint($endpoint)
77
+    {
77 78
         $this->endpoint = $endpoint;
78 79
     }
79 80
 
Please login to merge, or discard this patch.
Classes/Api/Orcid/Profile.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@
 block discarded – undo
35 35
      */
36 36
     protected $logger;
37 37
 
38
-     /**
39
-     * This holds the client
40
-     *
41
-     * @var Client
42
-     * @access protected
43
-     */
38
+        /**
39
+         * This holds the client
40
+         *
41
+         * @var Client
42
+         * @access protected
43
+         */
44 44
     protected $client;
45 45
 
46 46
     /**
Please login to merge, or discard this patch.
Classes/Common/SolrSearchQuery.php 1 patch
Braces   +66 added lines, -22 removed lines patch added patch discarded remove patch
@@ -20,7 +20,9 @@  discard block
 block discarded – undo
20 20
         $this->limit = count($solrSearch);
21 21
     }
22 22
 
23
-    public function getSource() {}
23
+    public function getSource()
24
+    {
25
+}
24 26
 
25 27
     public function execute($returnRawQueryResult = false)
26 28
     {
@@ -35,7 +37,9 @@  discard block
 block discarded – undo
35 37
         return $result;
36 38
     }
37 39
 
38
-    public function setOrderings(array $orderings) {}
40
+    public function setOrderings(array $orderings)
41
+    {
42
+}
39 43
 
40 44
     public function setLimit($limit)
41 45
     {
@@ -49,28 +53,60 @@  discard block
 block discarded – undo
49 53
         return $this;
50 54
     }
51 55
 
52
-    public function matching($constraint) {}
53
-    public function logicalAnd($constraint1) {}
54
-    public function logicalOr($constraint1) {}
55
-    public function logicalNot(ConstraintInterface $constraint) {}
56
-    public function equals($propertyName, $operand, $caseSensitive = true) {}
57
-    public function like($propertyName, $operand) {}
58
-    public function contains($propertyName, $operand) {}
59
-    public function in($propertyName, $operand) {}
60
-    public function lessThan($propertyName, $operand) {}
61
-    public function lessThanOrEqual($propertyName, $operand) {}
62
-    public function greaterThan($propertyName, $operand) {}
63
-    public function greaterThanOrEqual($propertyName, $operand) {}
64
-    public function getType() {}
65
-    public function setQuerySettings(QuerySettingsInterface $querySettings) {}
66
-    public function getQuerySettings() {}
56
+    public function matching($constraint)
57
+    {
58
+}
59
+    public function logicalAnd($constraint1)
60
+    {
61
+}
62
+    public function logicalOr($constraint1)
63
+    {
64
+}
65
+    public function logicalNot(ConstraintInterface $constraint)
66
+    {
67
+}
68
+    public function equals($propertyName, $operand, $caseSensitive = true)
69
+    {
70
+}
71
+    public function like($propertyName, $operand)
72
+    {
73
+}
74
+    public function contains($propertyName, $operand)
75
+    {
76
+}
77
+    public function in($propertyName, $operand)
78
+    {
79
+}
80
+    public function lessThan($propertyName, $operand)
81
+    {
82
+}
83
+    public function lessThanOrEqual($propertyName, $operand)
84
+    {
85
+}
86
+    public function greaterThan($propertyName, $operand)
87
+    {
88
+}
89
+    public function greaterThanOrEqual($propertyName, $operand)
90
+    {
91
+}
92
+    public function getType()
93
+    {
94
+}
95
+    public function setQuerySettings(QuerySettingsInterface $querySettings)
96
+    {
97
+}
98
+    public function getQuerySettings()
99
+    {
100
+}
67 101
 
68 102
     public function count()
69 103
     {
70 104
         // TODO?
71 105
     }
72 106
 
73
-    public function getOrderings() {}
107
+    public function getOrderings()
108
+    {
109
+}
74 110
 
75 111
     public function getLimit()
76 112
     {
@@ -82,8 +118,16 @@  discard block
 block discarded – undo
82 118
         return $this->offset;
83 119
     }
84 120
 
85
-    public function getConstraint() {}
86
-    public function isEmpty($propertyName) {}
87
-    public function setSource(SourceInterface $source) {}
88
-    public function getStatement() {}
121
+    public function getConstraint()
122
+    {
123
+}
124
+    public function isEmpty($propertyName)
125
+    {
126
+}
127
+    public function setSource(SourceInterface $source)
128
+    {
129
+}
130
+    public function getStatement()
131
+    {
132
+}
89 133
 }
Please login to merge, or discard this patch.
Classes/Controller/CalendarController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
                 foreach ($year['children'] as $month) {
130 130
                     foreach ($month['children'] as $day) {
131 131
                         foreach ($day['children'] as $issue) {
132
-                            $title = $issue['label'] ?: $issue['orderlabel'];
132
+                            $title = $issue['label'] ? : $issue['orderlabel'];
133 133
                             if (strtotime($title) !== false) {
134 134
                                 $title = strftime('%x', strtotime($title));
135 135
                             }
@@ -220,8 +220,8 @@  discard block
 block discarded – undo
220 220
         $this->view->assign('calendarData', $calendarData);
221 221
         $this->view->assign('documentId', $this->document->getUid());
222 222
         $this->view->assign('yearLinkTitle', $yearLinkTitle);
223
-        $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getDoc()->tableOfContents[0]['points']);
224
-        $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ?: $this->document->getDoc()->tableOfContents[0]['label']);
223
+        $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getDoc()->tableOfContents[0]['points']);
224
+        $this->view->assign('allYearDocTitle', $this->document->getDoc()->getTitle($this->document->getPartof()) ? : $this->document->getDoc()->tableOfContents[0]['label']);
225 225
     }
226 226
 
227 227
     /**
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
                 if (empty($yearLabel)) {
259 259
                     // if neither order nor orderlabel is set, use the id...
260
-                    $yearLabel = (string)$id;
260
+                    $yearLabel = (string) $id;
261 261
                 }
262 262
 
263 263
                 $years[] = [
Please login to merge, or discard this patch.
Classes/Hooks/ItemsProcFunc.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,8 @@
 block discarded – undo
58 58
      *
59 59
      * @return void
60 60
      */
61
-    public function getTyposcriptConfigFromPluginSiteRoot($params) {
61
+    public function getTyposcriptConfigFromPluginSiteRoot($params)
62
+    {
62 63
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
63 64
         $pid = $params['flexParentDatabaseRow']['pid'];
64 65
         $rootline = \TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine($pid);
Please login to merge, or discard this patch.
Classes/Format/Mods.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -68,7 +68,8 @@  discard block
 block discarded – undo
68 68
      *
69 69
      * @return void
70 70
      */
71
-    private function getAuthors() {
71
+    private function getAuthors()
72
+    {
72 73
         $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]');
73 74
 
74 75
         // Get "author" and "author_sorting" again if that was too sophisticated.
@@ -130,7 +131,8 @@  discard block
 block discarded – undo
130 131
      *
131 132
      * @return void
132 133
      */
133
-    private function getHolders() {
134
+    private function getHolders()
135
+    {
134 136
         $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]');
135 137
 
136 138
         if (!empty($holders)) {
@@ -183,7 +185,8 @@  discard block
 block discarded – undo
183 185
      *
184 186
      * @return void
185 187
      */
186
-    private function getPlaces() {
188
+    private function getPlaces()
189
+    {
187 190
         $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm');
188 191
         // Get "place" and "place_sorting" again if that was to sophisticated.
189 192
         if (empty($places)) {
@@ -207,7 +210,8 @@  discard block
 block discarded – undo
207 210
      *
208 211
      * @return void
209 212
      */
210
-    private function getYears() {
213
+    private function getYears()
214
+    {
211 215
         // Get "year_sorting".
212 216
         if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) {
213 217
             foreach ($years_sorting as $year_sorting) {
Please login to merge, or discard this patch.
Classes/Controller/View3DController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
             $settingsParts = explode("/", $model);
50 50
             $fileName = end($settingsParts);
51
-            $path = substr($model, 0,  strrpos($model, $fileName));
51
+            $path = substr($model, 0, strrpos($model, $fileName));
52 52
             $modelSettings = $path . "metadata/" . $fileName . "_viewer";
53 53
 
54 54
             if (!empty($modelConverted)) {
Please login to merge, or discard this patch.