We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Conditions | 13 |
Paths | 17 |
Total Lines | 66 |
Code Lines | 36 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
59 | public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface |
||
60 | { |
||
61 | $response = $handler->handle($request); |
||
62 | // parameters are sent by POST --> use getParsedBody() instead of getQueryParams() |
||
63 | $parameters = $request->getQueryParams(); |
||
64 | // Return if not this middleware |
||
65 | if (!isset($parameters['middleware']) || ($parameters['middleware'] != 'dlf/embedded3dviewer')) { |
||
66 | return $response; |
||
67 | } |
||
68 | |||
69 | $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(__CLASS__); |
||
70 | |||
71 | if (empty($parameters['model'])) { |
||
72 | return $this->warningResponse('Model url is missing.', $request); |
||
73 | } |
||
74 | |||
75 | $modelInfo = PathUtility::pathinfo($parameters['model']); |
||
76 | $modelFormat = $modelInfo["extension"]; |
||
77 | if (empty($modelFormat)) { |
||
78 | return $this->warningResponse('Model path "' . $parameters['model'] . '" has no extension format', $request); |
||
79 | } |
||
80 | |||
81 | if (empty($parameters['viewer'])) { |
||
82 | // determine viewer from extension configuration |
||
83 | $viewer = $this->getViewerByExtensionConfiguration($modelFormat); |
||
84 | } else { |
||
85 | $viewer = $parameters['viewer']; |
||
86 | } |
||
87 | |||
88 | if (empty($viewer)) { |
||
89 | return $this->renderDefaultViewer($parameters['model']); |
||
90 | } |
||
91 | |||
92 | /** @var StorageRepository $storageRepository */ |
||
93 | $storageRepository = GeneralUtility::makeInstance(StorageRepository::class); |
||
94 | $defaultStorage = $storageRepository->getDefaultStorage(); |
||
95 | |||
96 | if (!$defaultStorage->hasFolder(self::VIEWER_FOLDER)) { |
||
97 | return $this->errorResponse('Required folder "' . self::VIEWER_FOLDER . '" was not found in the default storage "' . $defaultStorage->getName() . '"', $request); |
||
98 | } |
||
99 | |||
100 | $viewerModules = $defaultStorage->getFolder(self::VIEWER_FOLDER); |
||
101 | if (!$viewerModules->hasFolder($viewer)) { |
||
102 | return $this->errorResponse('Viewer folder "' . $viewer . '" was not found under the folder "' . self::VIEWER_FOLDER . '"', $request); |
||
103 | } |
||
104 | |||
105 | $viewerFolder = $viewerModules->getSubfolder($viewer); |
||
106 | if (!$viewerFolder->hasFile(self::VIEWER_CONFIG_YML)) { |
||
107 | return $this->errorResponse('Viewer folder "' . $viewer . '" does not contain a file named "' . self::VIEWER_CONFIG_YML . '"', $request); |
||
108 | } |
||
109 | |||
110 | /** @var YamlFileLoader $yamlFileLoader */ |
||
111 | $yamlFileLoader = GeneralUtility::makeInstance(YamlFileLoader::class); |
||
112 | $viewerConfigPath = $defaultStorage->getName() . "/" . self::VIEWER_FOLDER . "/" . $viewer . "/"; |
||
113 | $config = $yamlFileLoader->load($viewerConfigPath . self::VIEWER_CONFIG_YML)["viewer"]; |
||
114 | |||
115 | if (!isset($config["supportedModelFormats"]) || empty($config["supportedModelFormats"])) { |
||
116 | return $this->errorResponse('Required key "supportedModelFormats" does not exist in the file "' . self::VIEWER_CONFIG_YML . '" of viewer "' . $viewer . '" or has no value', $request); |
||
117 | } |
||
118 | |||
119 | if (array_search(strtolower($modelFormat), array_map('strtolower', $config["supportedModelFormats"])) === false) { |
||
120 | return $this->warningResponse('Viewer "' . $viewer . '" does not support the model format "' . $modelFormat . '"', $request); |
||
121 | } |
||
122 | |||
123 | $html = $this->getViewerHtml($config, $viewerConfigPath, $viewerFolder, $parameters['model'], $modelInfo); |
||
|
|||
124 | return new HtmlResponse($html); |
||
125 | } |
||
245 |