Kitodo\Dlf\Controller\StatisticsController::mainAction()

Complexity

Conditions	4
Paths	2

Size

Total Lines	26
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function mainAction(): ResponseInterface
    {
        $foundNumbers = $this->documentRepository->getStatisticsForSelectedCollection($this->settings);

        // Set replacements.
        $args['###TITLES###'] = $foundNumbers['titles'] . ' ' . htmlspecialchars(
            LocalizationUtility::translate(

It seems like TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate($foundNumbers['titles'] > 1 ? 'titles' : 'title', 'dlf') can also be of type null; however, parameter $string of htmlspecialchars() does only seem to accept string, maybe add an additional type check?

                ($foundNumbers['titles'] > 1 ? 'titles' : 'title'), 'dlf'
            )
        );

        $args['###VOLUMES###'] = $foundNumbers['volumes'] . ' ' . htmlspecialchars(
            LocalizationUtility::translate(
                ($foundNumbers['volumes'] > 1 ? 'volumes' : 'volume'), 'dlf'
            )
        );

        // Apply replacements.
        $content = $this->settings['description'];
        foreach ($args as $key => $value) {
            $content = str_replace($key, $value, $content);
        }

        $this->view->assign('content', $content);

        return $this->htmlResponse();
    }