kint-php / kint

src/Parser/Serialize.php

<?php

class Kint_Parser_Serialize extends Kint_Parser_Plugin

Kint_Parser_Serialize does not seem to conform to the naming convention (^[A-Z][a-zA-Z0-9]*$).

The property $safe_mode is not named in camelCase.

{
    /**
     * Disables automatic unserialization on arrays and objects.
     *
     * As the PHP manual notes:
     *
     * > Unserialization can result in code being loaded and executed due to
     * > object instantiation and autoloading, and a malicious user may be able
     * > to exploit this.
     *
     * The natural way to stop that from happening is to just refuse to unserialize
     * stuff by default. Which is what we're doing for anything that's not scalar.
     *
     * @var bool
     */
    public static $safe_mode = true;

$safe_mode does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    public static $options = array(true);

    public function getTypes()
    {
        return array('string');
    }

    public function getTriggers()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return Kint_Parser::TRIGGER_SUCCESS;
    }

    public function parse(&$var, Kint_Object &$o, $trigger)

Avoid variables with short names like $o. Configured minimum length is 3.

    {
        $trimmed = rtrim($var);

        if ($trimmed !== 'N;' && !preg_match('/^(?:[COabis]:\d+[:;]|d:\d+(?:\.\d+);)/', $trimmed)) {
            return;
        }

        if (!self::$safe_mode || !in_array($trimmed[0], array('C', 'O', 'a'))) {
            $blacklist = false;

            // Second parameter only supported on PHP 7
            if (KINT_PHP70) {
                // Suppress warnings on unserializeable variable
                $data = @unserialize($trimmed, self::$options);
            } else {
                $data = @unserialize($trimmed);
            }

            if ($data === false && substr($trimmed, 0, 4) !== 'b:0;') {
                return;
            }
        } else {
            $blacklist = true;
        }

        $base_obj = new Kint_Object();

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $base_obj->depth = $o->depth + 1;

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $base_obj->name = 'unserialize('.$o->name.')';

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($o->access_path) {

The expression $o->access_path of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $base_obj->access_path = 'unserialize('.$o->access_path;

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (!KINT_PHP70 || self::$options === array(true)) {
                $base_obj->access_path .= ')';

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } elseif (self::$options === array(false)) {
                $base_obj->access_path .= ', false)';

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } else {
                $base_obj->access_path .= ', Kint_Parser_Serialize::$options)';

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
        }

        $r = new Kint_Object_Representation('Serialized');

Avoid variables with short names like $r. Configured minimum length is 3.

        if ($blacklist) {
            $base_obj->hints[] = 'blacklist';

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $r->contents = $base_obj;

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like $base_obj of type object<Kint_Object> is incompatible with the declared type array of property $contents.

        } else {
            $r->contents = $this->parser->parse($data, $base_obj);

$base_obj does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It seems like $this->parser->parse($data, $base_obj) of type object<Kint_Object> is incompatible with the declared type array of property $contents.

        }

        $o->addRepresentation($r, 0);
    }
}