Kint_Parser_Serialize::getTriggers() - Code Metrics - kint-php/kint - Measure and Improve Code Quality continuously with Scrutinizer

Kint_Parser_Serialize::getTriggers() A
last analyzed 2018-01-09 18:54 UTC

↳ Parent: Kint_Parser_Serialize

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

class Kint_Parser_Serialize extends Kint_Parser_Plugin

{
    /**
     * Disables automatic unserialization on arrays and objects.
     *
     * As the PHP manual notes:
     *
     * > Unserialization can result in code being loaded and executed due to
     * > object instantiation and autoloading, and a malicious user may be able
     * > to exploit this.
     *
     * The natural way to stop that from happening is to just refuse to unserialize
     * stuff by default. Which is what we're doing for anything that's not scalar.
     *
     * @var bool
     */
    public static $safe_mode = true;

    public static $options = array(true);

    public function getTypes()
    {
        return array('string');
    }

    public function getTriggers()

    {
        return Kint_Parser::TRIGGER_SUCCESS;
    }

    public function parse(&$var, Kint_Object &$o, $trigger)

    {
        $trimmed = rtrim($var);

        if ($trimmed !== 'N;' && !preg_match('/^(?:[COabis]:\d+[:;]|d:\d+(?:\.\d+);)/', $trimmed)) {
            return;
        }

        if (!self::$safe_mode || !in_array($trimmed[0], array('C', 'O', 'a'))) {
            $blacklist = false;

            // Second parameter only supported on PHP 7
            if (KINT_PHP70) {
                // Suppress warnings on unserializeable variable
                $data = @unserialize($trimmed, self::$options);
            } else {
                $data = @unserialize($trimmed);
            }

            if ($data === false && substr($trimmed, 0, 4) !== 'b:0;') {
                return;
            }
        } else {
            $blacklist = true;
        }

        $base_obj = new Kint_Object();

        $base_obj->depth = $o->depth + 1;

        $base_obj->name = 'unserialize('.$o->name.')';


        if ($o->access_path) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $base_obj->access_path = 'unserialize('.$o->access_path;

            if (!KINT_PHP70 || self::$options === array(true)) {
                $base_obj->access_path .= ')';

            } elseif (self::$options === array(false)) {
                $base_obj->access_path .= ', false)';

            } else {
                $base_obj->access_path .= ', Kint_Parser_Serialize::$options)';

            }
        }

        $r = new Kint_Object_Representation('Serialized');


        if ($blacklist) {
            $base_obj->hints[] = 'blacklist';

            $r->contents = $base_obj;

        } else {
            $r->contents = $this->parser->parse($data, $base_obj);

        }

        $o->addRepresentation($r, 0);
    }
}


1			<?php
2
3			class Kint_Parser_Serialize extends Kint_Parser_Plugin
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `Kint_Parser_Serialize` does not seem to conform to the naming convention (`^[A-Z][a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report The property $safe_mode is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string* becomes `databaseConnectionString`. Loading history...
4			{
5			/**
6			* Disables automatic unserialization on arrays and objects.
7			*
8			* As the PHP manual notes:
9			*
10			* > Unserialization can result in code being loaded and executed due to
11			* > object instantiation and autoloading, and a malicious user may be able
12			* > to exploit this.
13			*
14			* The natural way to stop that from happening is to just refuse to unserialize
15			* stuff by default. Which is what we're doing for anything that's not scalar.
16			*
17			* @var bool
18			*/
19			public static $safe_mode = true;
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$safe_mode` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
20			public static $options = array(true);
21
22			public function getTypes()
23			{
24			return array('string');
25			}
26
27			public function getTriggers()
			0 ignored issues – show Documentation introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
28			{
29			return Kint_Parser::TRIGGER_SUCCESS;
30			}
31
32			public function parse(&$var, Kint_Object &$o, $trigger)
			0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Avoid variables with short names like $o. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
33			{
34			$trimmed = rtrim($var);
35
36			if ($trimmed !== 'N;' && !preg_match('/^(?:[COabis]:\d+[:;]\|d:\d+(?:\.\d+);)/', $trimmed)) {
37			return;
38			}
39
40			if (!self::$safe_mode \|\| !in_array($trimmed[0], array('C', 'O', 'a'))) {
41			$blacklist = false;
42
43			// Second parameter only supported on PHP 7
44			if (KINT_PHP70) {
45			// Suppress warnings on unserializeable variable
46			$data = @unserialize($trimmed, self::$options);
47			} else {
48			$data = @unserialize($trimmed);
49			}
50
51			if ($data === false && substr($trimmed, 0, 4) !== 'b:0;') {
52			return;
53			}
54			} else {
55			$blacklist = true;
56			}
57
58			$base_obj = new Kint_Object();
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
59			$base_obj->depth = $o->depth + 1;
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
60			$base_obj->name = 'unserialize('.$o->name.')';
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
61
62			if ($o->access_path) {
			0 ignored issues – show Bug Best Practice introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report The expression `$o->access_path` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
63			$base_obj->access_path = 'unserialize('.$o->access_path;
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
64			if (!KINT_PHP70 \|\| self::$options === array(true)) {
65			$base_obj->access_path .= ')';
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
66			} elseif (self::$options === array(false)) {
67			$base_obj->access_path .= ', false)';
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
68			} else {
69			$base_obj->access_path .= ', Kint_Parser_Serialize::$options)';
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
70			}
71			}
72
73			$r = new Kint_Object_Representation('Serialized');
			0 ignored issues – show Comprehensibility introduced 2018-01-09 18:54 UTC by Report Bug Copy Issue Report Avoid variables with short names like $r. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
74
75			if ($blacklist) {
76			$base_obj->hints[] = 'blacklist';
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
77			$r->contents = $base_obj;
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Documentation Bug introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report It seems like `$base_obj` of type `object<Kint_Object>` is incompatible with the declared type `array` of property `$contents`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
78			} else {
79			$r->contents = $this->parser->parse($data, $base_obj);
			0 ignored issues – show Coding Style introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report `$base_obj` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Documentation Bug introduced 2018-01-09 18:53 UTC by Report Bug Copy Issue Report It seems like `$this->parser->parse($data, $base_obj)` of type `object<Kint_Object>` is incompatible with the declared type `array` of property `$contents`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
80			}
81
82			$o->addRepresentation($r, 0);
83			}
84			}
85

kint-php / kint

Kint_Parser_Serialize::getTriggers() A last analyzed 2018-01-09 18:54 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Kint_Parser_Serialize::getTriggers() A
last analyzed 2018-01-09 18:54 UTC