@@ -331,19 +331,16 @@ discard block |
||
331 | 331 | if ($reflection->hasMethod('set_'.$key)) |
332 | 332 | { |
333 | 333 | $this->{'set_'.$key}($config[$key]); |
334 | - } |
|
335 | - else |
|
334 | + } else |
|
336 | 335 | { |
337 | 336 | $this->$key = $config[$key]; |
338 | 337 | } |
339 | - } |
|
340 | - else |
|
338 | + } else |
|
341 | 339 | { |
342 | 340 | $this->$key = $defaults[$key]; |
343 | 341 | } |
344 | 342 | } |
345 | - } |
|
346 | - else |
|
343 | + } else |
|
347 | 344 | { |
348 | 345 | foreach ($config as $key => &$value) |
349 | 346 | { |
@@ -352,8 +349,7 @@ discard block |
||
352 | 349 | if ($reflection->hasMethod('set_'.$key)) |
353 | 350 | { |
354 | 351 | $this->{'set_'.$key}($value); |
355 | - } |
|
356 | - else |
|
352 | + } else |
|
357 | 353 | { |
358 | 354 | $this->$key = $value; |
359 | 355 | } |
@@ -415,9 +411,11 @@ discard block |
||
415 | 411 | } |
416 | 412 | |
417 | 413 | // Was the file able to be uploaded? If not, determine the reason why. |
418 | - if ( ! file_exists($_file['tmp_name'])) // modified by ci-phpunit-test |
|
414 | + if ( ! file_exists($_file['tmp_name'])) { |
|
415 | + // modified by ci-phpunit-test |
|
419 | 416 | { |
420 | 417 | $error = isset($_file['error']) ? $_file['error'] : 4; |
418 | + } |
|
421 | 419 | |
422 | 420 | switch ($error) |
423 | 421 | { |
@@ -482,8 +480,7 @@ discard block |
||
482 | 480 | if (strpos($this->_file_name_override, '.') === FALSE) |
483 | 481 | { |
484 | 482 | $this->file_name .= $this->file_ext; |
485 | - } |
|
486 | - else |
|
483 | + } else |
|
487 | 484 | { |
488 | 485 | // An extension was provided, let's have it! |
489 | 486 | $this->file_ext = $this->get_extension($this->_file_name_override); |
@@ -687,8 +684,7 @@ discard block |
||
687 | 684 | { |
688 | 685 | $this->set_error('upload_bad_filename', 'debug'); |
689 | 686 | return FALSE; |
690 | - } |
|
691 | - else |
|
687 | + } else |
|
692 | 688 | { |
693 | 689 | return $new_filename; |
694 | 690 | } |
@@ -883,8 +879,7 @@ discard block |
||
883 | 879 | if (in_array($this->file_type, $png_mimes)) |
884 | 880 | { |
885 | 881 | $this->file_type = 'image/png'; |
886 | - } |
|
887 | - elseif (in_array($this->file_type, $jpeg_mimes)) |
|
882 | + } elseif (in_array($this->file_type, $jpeg_mimes)) |
|
888 | 883 | { |
889 | 884 | $this->file_type = 'image/jpeg'; |
890 | 885 | } |
@@ -1150,9 +1145,12 @@ discard block |
||
1150 | 1145 | |
1151 | 1146 | if (function_exists('getimagesize') && @getimagesize($file) !== FALSE) |
1152 | 1147 | { |
1153 | - if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary |
|
1148 | + if (($file = @fopen($file, 'rb')) === FALSE) { |
|
1149 | + // "b" to force binary |
|
1154 | 1150 | { |
1155 | - return FALSE; // Couldn't open the file, return FALSE |
|
1151 | + return FALSE; |
|
1152 | + } |
|
1153 | + // Couldn't open the file, return FALSE |
|
1156 | 1154 | } |
1157 | 1155 | |
1158 | 1156 | $opening_bytes = fread($file, 256); |
@@ -1271,9 +1269,11 @@ discard block |
||
1271 | 1269 | if (function_exists('finfo_file')) |
1272 | 1270 | { |
1273 | 1271 | $finfo = @finfo_open(FILEINFO_MIME); |
1274 | - if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system |
|
1272 | + if (is_resource($finfo)) { |
|
1273 | + // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system |
|
1275 | 1274 | { |
1276 | 1275 | $mime = @finfo_file($finfo, $file['tmp_name']); |
1276 | + } |
|
1277 | 1277 | finfo_close($finfo); |
1278 | 1278 | |
1279 | 1279 | /* According to the comments section of the PHP manual page, |
@@ -1358,10 +1358,12 @@ discard block |
||
1358 | 1358 | if (function_exists('mime_content_type')) |
1359 | 1359 | { |
1360 | 1360 | $this->file_type = @mime_content_type($file['tmp_name']); |
1361 | - if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string |
|
1361 | + if (strlen($this->file_type) > 0) { |
|
1362 | + // It's possible that mime_content_type() returns FALSE or an empty string |
|
1362 | 1363 | { |
1363 | 1364 | return; |
1364 | 1365 | } |
1366 | + } |
|
1365 | 1367 | } |
1366 | 1368 | |
1367 | 1369 | $this->file_type = $file['type']; |
@@ -200,16 +200,14 @@ discard block |
||
200 | 200 | if (empty($library)) |
201 | 201 | { |
202 | 202 | return $this; |
203 | - } |
|
204 | - elseif (is_array($library)) |
|
203 | + } elseif (is_array($library)) |
|
205 | 204 | { |
206 | 205 | foreach ($library as $key => $value) |
207 | 206 | { |
208 | 207 | if (is_int($key)) |
209 | 208 | { |
210 | 209 | $this->library($value, $params); |
211 | - } |
|
212 | - else |
|
210 | + } else |
|
213 | 211 | { |
214 | 212 | $this->library($key, $params, $value); |
215 | 213 | } |
@@ -246,8 +244,7 @@ discard block |
||
246 | 244 | if (empty($model)) |
247 | 245 | { |
248 | 246 | return $this; |
249 | - } |
|
250 | - elseif (is_array($model)) |
|
247 | + } elseif (is_array($model)) |
|
251 | 248 | { |
252 | 249 | foreach ($model as $key => $value) |
253 | 250 | { |
@@ -313,8 +310,7 @@ discard block |
||
313 | 310 | { |
314 | 311 | throw new RuntimeException($app_path."Model.php exists, but doesn't declare class CI_Model"); |
315 | 312 | } |
316 | - } |
|
317 | - elseif ( ! class_exists('CI_Model', FALSE)) |
|
313 | + } elseif ( ! class_exists('CI_Model', FALSE)) |
|
318 | 314 | { |
319 | 315 | require_once(BASEPATH.'core'.DIRECTORY_SEPARATOR.'Model.php'); |
320 | 316 | } |
@@ -471,8 +467,7 @@ discard block |
||
471 | 467 | require_once($driver_path); |
472 | 468 | $class = 'CI_DB_'.$db->dbdriver.'_'.$db->subdriver.'_forge'; |
473 | 469 | } |
474 | - } |
|
475 | - else |
|
470 | + } else |
|
476 | 471 | { |
477 | 472 | $class = 'CI_DB_'.$db->dbdriver.'_forge'; |
478 | 473 | } |
@@ -761,16 +756,14 @@ discard block |
||
761 | 756 | if (is_int($key)) |
762 | 757 | { |
763 | 758 | $this->driver($value, $params); |
764 | - } |
|
765 | - else |
|
759 | + } else |
|
766 | 760 | { |
767 | 761 | $this->driver($key, $params, $value); |
768 | 762 | } |
769 | 763 | } |
770 | 764 | |
771 | 765 | return $this; |
772 | - } |
|
773 | - elseif (empty($library)) |
|
766 | + } elseif (empty($library)) |
|
774 | 767 | { |
775 | 768 | return FALSE; |
776 | 769 | } |
@@ -869,8 +862,7 @@ discard block |
||
869 | 862 | array_shift($this->_ci_helper_paths); |
870 | 863 | array_shift($this->_ci_view_paths); |
871 | 864 | array_pop($config->_config_paths); |
872 | - } |
|
873 | - else |
|
865 | + } else |
|
874 | 866 | { |
875 | 867 | $path = rtrim($path, '/').'/'; |
876 | 868 | foreach (array('_ci_library_paths', '_ci_model_paths', '_ci_helper_paths') as $var) |
@@ -934,8 +926,7 @@ discard block |
||
934 | 926 | { |
935 | 927 | $_ci_x = explode('/', $_ci_path); |
936 | 928 | $_ci_file = end($_ci_x); |
937 | - } |
|
938 | - else |
|
929 | + } else |
|
939 | 930 | { |
940 | 931 | $_ci_ext = pathinfo($_ci_view, PATHINFO_EXTENSION); |
941 | 932 | $_ci_file = ($_ci_ext === '') ? $_ci_view.'.php' : $_ci_view; |
@@ -1002,8 +993,7 @@ discard block |
||
1002 | 993 | if ( ! is_php('5.4') && ! ini_get('short_open_tag') && config_item('rewrite_short_tags') === TRUE) |
1003 | 994 | { |
1004 | 995 | echo eval('?>'.preg_replace('/;*\s*\?>/', '; ?>', str_replace('<?=', '<?php echo ', file_get_contents($_ci_path)))); |
1005 | - } |
|
1006 | - else |
|
996 | + } else |
|
1007 | 997 | { |
1008 | 998 | include($_ci_path); // include() vs include_once() allows for multiple views with the same name |
1009 | 999 | } |
@@ -1030,8 +1020,7 @@ discard block |
||
1030 | 1020 | if (ob_get_level() > $this->_ci_ob_level + 1) |
1031 | 1021 | { |
1032 | 1022 | ob_end_flush(); |
1033 | - } |
|
1034 | - else |
|
1023 | + } else |
|
1035 | 1024 | { |
1036 | 1025 | $_ci_CI->output->append_output(ob_get_contents()); |
1037 | 1026 | @ob_end_clean(); |
@@ -1071,8 +1060,7 @@ discard block |
||
1071 | 1060 | |
1072 | 1061 | // Get the filename from the path |
1073 | 1062 | $class = substr($class, $last_slash); |
1074 | - } |
|
1075 | - else |
|
1063 | + } else |
|
1076 | 1064 | { |
1077 | 1065 | $subdir = ''; |
1078 | 1066 | } |
@@ -1210,8 +1198,7 @@ discard block |
||
1210 | 1198 | if (file_exists(APPPATH.'tests/_ci_phpunit_test/replacing/libraries/'.$file_path.$library_name.'.php')) |
1211 | 1199 | { |
1212 | 1200 | include_once(APPPATH.'tests/_ci_phpunit_test/replacing/libraries/'.$file_path.$library_name.'.php'); |
1213 | - } |
|
1214 | - else |
|
1201 | + } else |
|
1215 | 1202 | { |
1216 | 1203 | include_once(BASEPATH.'libraries/'.$file_path.$library_name.'.php'); |
1217 | 1204 | } |
@@ -1227,8 +1214,7 @@ discard block |
||
1227 | 1214 | { |
1228 | 1215 | $prefix = config_item('subclass_prefix'); |
1229 | 1216 | break; |
1230 | - } |
|
1231 | - else |
|
1217 | + } else |
|
1232 | 1218 | { |
1233 | 1219 | log_message('debug', $path.' exists, but does not declare '.$subclass); |
1234 | 1220 | } |
@@ -1277,8 +1263,7 @@ discard block |
||
1277 | 1263 | { |
1278 | 1264 | include($path.'config/'.strtolower($class).'.php'); |
1279 | 1265 | $found = TRUE; |
1280 | - } |
|
1281 | - elseif (file_exists($path.'config/'.ucfirst(strtolower($class)).'.php')) |
|
1266 | + } elseif (file_exists($path.'config/'.ucfirst(strtolower($class)).'.php')) |
|
1282 | 1267 | { |
1283 | 1268 | include($path.'config/'.ucfirst(strtolower($class)).'.php'); |
1284 | 1269 | $found = TRUE; |
@@ -1288,8 +1273,7 @@ discard block |
||
1288 | 1273 | { |
1289 | 1274 | include($path.'config/'.ENVIRONMENT.'/'.strtolower($class).'.php'); |
1290 | 1275 | $found = TRUE; |
1291 | - } |
|
1292 | - elseif (file_exists($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php')) |
|
1276 | + } elseif (file_exists($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php')) |
|
1293 | 1277 | { |
1294 | 1278 | include($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php'); |
1295 | 1279 | $found = TRUE; |