Completed
Push — master ( 5204ad...e27a57 )
by Kenji
03:55 queued 56s
created
application/tests/_ci_phpunit_test/replacing/libraries/3.1.2-Upload.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -293,8 +293,8 @@  discard block
 block discarded – undo
293 293
 	{
294 294
 		empty($config) OR $this->initialize($config, FALSE);
295 295
 
296
-		$this->_mimes =& get_mimes();
297
-		$this->_CI =& get_instance();
296
+		$this->_mimes = & get_mimes();
297
+		$this->_CI = & get_instance();
298 298
 
299 299
 		log_message('info', 'Upload Class Initialized');
300 300
 	}
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
 			else
481 481
 			{
482 482
 				// An extension was provided, let's have it!
483
-				$this->file_ext	= $this->get_extension($this->_file_name_override);
483
+				$this->file_ext = $this->get_extension($this->_file_name_override);
484 484
 			}
485 485
 
486 486
 			if ( ! $this->is_allowed_filetype(TRUE))
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 		// Convert the file size to kilobytes
494 494
 		if ($this->file_size > 0)
495 495
 		{
496
-			$this->file_size = round($this->file_size/1024, 2);
496
+			$this->file_size = round($this->file_size / 1024, 2);
497 497
 		}
498 498
 
499 499
 		// Is the file size within the allowed maximum?
@@ -818,10 +818,10 @@  discard block
 block discarded – undo
818 818
 			{
819 819
 				$types = array(1 => 'gif', 2 => 'jpeg', 3 => 'png');
820 820
 
821
-				$this->image_width	= $D[0];
822
-				$this->image_height	= $D[1];
823
-				$this->image_type	= isset($types[$D[2]]) ? $types[$D[2]] : 'unknown';
824
-				$this->image_size_str	= $D[3]; // string containing height and width
821
+				$this->image_width = $D[0];
822
+				$this->image_height = $D[1];
823
+				$this->image_type = isset($types[$D[2]]) ? $types[$D[2]] : 'unknown';
824
+				$this->image_size_str = $D[3]; // string containing height and width
825 825
 			}
826 826
 		}
827 827
 
@@ -869,7 +869,7 @@  discard block
 block discarded – undo
869 869
 			$this->file_type = 'image/jpeg';
870 870
 		}
871 871
 
872
-		$img_mimes = array('image/gif',	'image/jpeg', 'image/png');
872
+		$img_mimes = array('image/gif', 'image/jpeg', 'image/png');
873 873
 
874 874
 		return in_array($this->file_type, $img_mimes, TRUE);
875 875
 	}
@@ -1011,7 +1011,7 @@  discard block
 block discarded – undo
1011 1011
 			return FALSE;
1012 1012
 		}
1013 1013
 
1014
-		$this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/',  $this->upload_path);
1014
+		$this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/', $this->upload_path);
1015 1015
 		return TRUE;
1016 1016
 	}
1017 1017
 
@@ -1055,9 +1055,9 @@  discard block
 block discarded – undo
1055 1055
 		$ext = '';
1056 1056
 		if (strpos($filename, '.') !== FALSE)
1057 1057
 		{
1058
-			$parts		= explode('.', $filename);
1059
-			$ext		= '.'.array_pop($parts);
1060
-			$filename	= implode('.', $parts);
1058
+			$parts = explode('.', $filename);
1059
+			$ext = '.'.array_pop($parts);
1060
+			$filename = implode('.', $parts);
1061 1061
 		}
1062 1062
 
1063 1063
 		return substr($filename, 0, ($length - strlen($ext))).$ext;
Please login to merge, or discard this patch.
Braces   +21 added lines, -19 removed lines patch added patch discarded remove patch
@@ -327,19 +327,16 @@  discard block
 block discarded – undo
327 327
 					if ($reflection->hasMethod('set_'.$key))
328 328
 					{
329 329
 						$this->{'set_'.$key}($config[$key]);
330
-					}
331
-					else
330
+					} else
332 331
 					{
333 332
 						$this->$key = $config[$key];
334 333
 					}
335
-				}
336
-				else
334
+				} else
337 335
 				{
338 336
 					$this->$key = $defaults[$key];
339 337
 				}
340 338
 			}
341
-		}
342
-		else
339
+		} else
343 340
 		{
344 341
 			foreach ($config as $key => &$value)
345 342
 			{
@@ -348,8 +345,7 @@  discard block
 block discarded – undo
348 345
 					if ($reflection->hasMethod('set_'.$key))
349 346
 					{
350 347
 						$this->{'set_'.$key}($value);
351
-					}
352
-					else
348
+					} else
353 349
 					{
354 350
 						$this->$key = $value;
355 351
 					}
@@ -409,9 +405,11 @@  discard block
 block discarded – undo
409 405
 		}
410 406
 
411 407
 		// Was the file able to be uploaded? If not, determine the reason why.
412
-		if ( ! file_exists($_file['tmp_name']))	// modified by ci-phpunit-test
408
+		if ( ! file_exists($_file['tmp_name'])) {
409
+			// modified by ci-phpunit-test
413 410
 		{
414 411
 			$error = isset($_file['error']) ? $_file['error'] : 4;
412
+		}
415 413
 
416 414
 			switch ($error)
417 415
 			{
@@ -476,8 +474,7 @@  discard block
 block discarded – undo
476 474
 			if (strpos($this->_file_name_override, '.') === FALSE)
477 475
 			{
478 476
 				$this->file_name .= $this->file_ext;
479
-			}
480
-			else
477
+			} else
481 478
 			{
482 479
 				// An extension was provided, let's have it!
483 480
 				$this->file_ext	= $this->get_extension($this->_file_name_override);
@@ -677,8 +674,7 @@  discard block
 block discarded – undo
677 674
 		{
678 675
 			$this->set_error('upload_bad_filename', 'debug');
679 676
 			return FALSE;
680
-		}
681
-		else
677
+		} else
682 678
 		{
683 679
 			return $new_filename;
684 680
 		}
@@ -863,8 +859,7 @@  discard block
 block discarded – undo
863 859
 		if (in_array($this->file_type, $png_mimes))
864 860
 		{
865 861
 			$this->file_type = 'image/png';
866
-		}
867
-		elseif (in_array($this->file_type, $jpeg_mimes))
862
+		} elseif (in_array($this->file_type, $jpeg_mimes))
868 863
 		{
869 864
 			$this->file_type = 'image/jpeg';
870 865
 		}
@@ -1116,9 +1111,12 @@  discard block
 block discarded – undo
1116 1111
 
1117 1112
 		if (function_exists('getimagesize') && @getimagesize($file) !== FALSE)
1118 1113
 		{
1119
-			if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary
1114
+			if (($file = @fopen($file, 'rb')) === FALSE) {
1115
+				// "b" to force binary
1120 1116
 			{
1121
-				return FALSE; // Couldn't open the file, return FALSE
1117
+				return FALSE;
1118
+			}
1119
+			// Couldn't open the file, return FALSE
1122 1120
 			}
1123 1121
 
1124 1122
 			$opening_bytes = fread($file, 256);
@@ -1220,9 +1218,11 @@  discard block
 block discarded – undo
1220 1218
 
1221 1219
 		// Fileinfo extension - most reliable method
1222 1220
 		$finfo = @finfo_open(FILEINFO_MIME);
1223
-		if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1221
+		if (is_resource($finfo)) {
1222
+			// It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1224 1223
 		{
1225 1224
 			$mime = @finfo_file($finfo, $file['tmp_name']);
1225
+		}
1226 1226
 			finfo_close($finfo);
1227 1227
 
1228 1228
 			/* According to the comments section of the PHP manual page,
@@ -1306,10 +1306,12 @@  discard block
 block discarded – undo
1306 1306
 		if (function_exists('mime_content_type'))
1307 1307
 		{
1308 1308
 			$this->file_type = @mime_content_type($file['tmp_name']);
1309
-			if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string
1309
+			if (strlen($this->file_type) > 0) {
1310
+				// It's possible that mime_content_type() returns FALSE or an empty string
1310 1311
 			{
1311 1312
 				return;
1312 1313
 			}
1314
+			}
1313 1315
 		}
1314 1316
 
1315 1317
 		$this->file_type = $file['type'];
Please login to merge, or discard this patch.