Inspection of "Made MonkeyPatchManager's file path configurable." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#243)

by lucky

created 2018-03-26 11:39 UTC

Status

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 
 	public static function log($message)
 	{
-		if (! self::$debug)
+		if ( ! self::$debug)
 		{
 			return;
 		}
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
 		}
 		if (self::$debug && is_null(self::$log_file))
 		{
-			self::$log_file = __DIR__ . '/debug.log';
+			self::$log_file = __DIR__.'/debug.log';
 		}
 	}
 
@@ -93,10 +93,10 @@  discard block
 block discarded – undo
 		else
 		{
 			// APPPATH is constant in CodeIgniter
-			Cache::setProjectRootDir(APPPATH . '../');
+			Cache::setProjectRootDir(APPPATH.'../');
 		}
 
-		if (! isset($config['cache_dir']))
+		if ( ! isset($config['cache_dir']))
 		{
 			throw new LogicException('You have to set "cache_dir"');
 		}
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
 
 	protected static function setPaths(array $config)
 	{
-		if (! isset($config['include_paths']))
+		if ( ! isset($config['include_paths']))
 		{
 			throw new LogicException('You have to set "include_paths"');
 		}
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpIncludePaths($current);
 		}
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpExcludePaths($current);
 		}
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== self::$patcher_list)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpPatcherList(self::$patcher_list);
 		}
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpFunctionWhitelist($current);
 		}
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
 	 */
 	public static function patch($path)
 	{
-		if (! is_readable($path))
+		if ( ! is_readable($path))
 		{
 			throw new LogicException("Can't read '$path'");
 		}
@@ -274,17 +274,17 @@  discard block
 block discarded – undo
 		// Check cache file
 		if ($cache_file = Cache::getValidSrcCachePath($path))
 		{
-			self::log('cache_hit: ' . $path);
+			self::log('cache_hit: '.$path);
 			return fopen($cache_file, 'r');
 		}
 
-		self::log('cache_miss: ' . $path);
+		self::log('cache_miss: '.$path);
 		$source = file_get_contents($path);
 
 		list($new_source, $patched) = self::execPatchers($source);
 
 		// Write to cache file
-		self::log('write_cache: ' . $path);
+		self::log('write_cache: '.$path);
 		Cache::writeSrcCacheFile($path, $new_source);
 
 		$resource = fopen('php://memory', 'rb+');
@@ -300,12 +300,12 @@  discard block
 block discarded – undo
 			return;
 		}
 
-		require __DIR__ . '/Patcher/AbstractPatcher.php';
-		require __DIR__ . '/Patcher/Backtrace.php';
+		require __DIR__.'/Patcher/AbstractPatcher.php';
+		require __DIR__.'/Patcher/Backtrace.php';
 
 		foreach (self::$patcher_list as $classname)
 		{
-			require __DIR__ . '/Patcher/' . $classname . '.php';
+			require __DIR__.'/Patcher/'.$classname.'.php';
 		}
 
 		self::$load_patchers = true;
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
 		$patched = false;
 		foreach (self::$patcher_list as $classname)
 		{
-			$classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
+			$classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
 			$patcher = new $classname;
 			list($source, $patched_this) = $patcher->patch($source);
 			$patched = $patched || $patched_this;

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/2.x/MonkeyPatchManager.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 
 	public static function log($message)
 	{
-		if (! self::$debug)
+		if ( ! self::$debug)
 		{
 			return;
 		}
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
 		}
 		if (is_null(self::$log_file))
 		{
-			self::$log_file = __DIR__ . '/debug.log';
+			self::$log_file = __DIR__.'/debug.log';
 		}
 	}
 
@@ -93,10 +93,10 @@  discard block
 block discarded – undo
 		else
 		{
 			// APPPATH is constant in CodeIgniter
-			Cache::setProjectRootDir(APPPATH . '../');
+			Cache::setProjectRootDir(APPPATH.'../');
 		}
 
-		if (! isset($config['cache_dir']))
+		if ( ! isset($config['cache_dir']))
 		{
 			throw new LogicException('You have to set "cache_dir"');
 		}
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
 
 	protected static function setPaths(array $config)
 	{
-		if (! isset($config['include_paths']))
+		if ( ! isset($config['include_paths']))
 		{
 			throw new LogicException('You have to set "include_paths"');
 		}
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpIncludePaths($current);
 		}
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpExcludePaths($current);
 		}
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== self::$patcher_list)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpPatcherList(self::$patcher_list);
 		}
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpFunctionWhitelist($current);
 		}
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
 	 */
 	public static function patch($path)
 	{
-		if (! is_readable($path))
+		if ( ! is_readable($path))
 		{
 			throw new LogicException("Can't read '$path'");
 		}
@@ -274,17 +274,17 @@  discard block
 block discarded – undo
 		// Check cache file
 		if ($cache_file = Cache::getValidSrcCachePath($path))
 		{
-			self::log('cache_hit: ' . $path);
+			self::log('cache_hit: '.$path);
 			return fopen($cache_file, 'r');
 		}
 
-		self::log('cache_miss: ' . $path);
+		self::log('cache_miss: '.$path);
 		$source = file_get_contents($path);
 
 		list($new_source, $patched) = self::execPatchers($source);
 
 		// Write to cache file
-		self::log('write_cache: ' . $path);
+		self::log('write_cache: '.$path);
 		Cache::writeSrcCacheFile($path, $new_source);
 
 		$resource = fopen('php://memory', 'rb+');
@@ -300,12 +300,12 @@  discard block
 block discarded – undo
 			return;
 		}
 
-		require __DIR__ . '/Patcher/AbstractPatcher.php';
-		require __DIR__ . '/Patcher/Backtrace.php';
+		require __DIR__.'/Patcher/AbstractPatcher.php';
+		require __DIR__.'/Patcher/Backtrace.php';
 
 		foreach (self::$patcher_list as $classname)
 		{
-			require __DIR__ . '/Patcher/' . $classname . '.php';
+			require __DIR__.'/Patcher/'.$classname.'.php';
 		}
 
 		self::$load_patchers = true;
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
 		$patched = false;
 		foreach (self::$patcher_list as $classname)
 		{
-			$classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
+			$classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
 			$patcher = new $classname;
 			list($source, $patched_this) = $patcher->patch($source);
 			$patched = $patched || $patched_this;

Please login to merge, or discard this patch.

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41
42	42	public static function log($message)
43	43	{
44		- if (! self::$debug)
	44	+ if ( ! self::$debug)
45	45	{
46	46	return;
47	47	}
		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	}
81	81	if (self::$debug && is_null(self::$log_file))
82	82	{
83		- self::$log_file = __DIR__ . '/debug.log';
	83	+ self::$log_file = __DIR__.'/debug.log';
84	84	}
85	85	}
86	86
		@@ -93,10 +93,10 @@ discard block
		block discarded – undo
93	93	else
94	94	{
95	95	// APPPATH is constant in CodeIgniter
96		- Cache::setProjectRootDir(APPPATH . '../');
	96	+ Cache::setProjectRootDir(APPPATH.'../');
97	97	}
98	98
99		- if (! isset($config['cache_dir']))
	99	+ if ( ! isset($config['cache_dir']))
100	100	{
101	101	throw new LogicException('You have to set "cache_dir"');
102	102	}
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105
106	106	protected static function setPaths(array $config)
107	107	{
108		- if (! isset($config['include_paths']))
	108	+ if ( ! isset($config['include_paths']))
109	109	{
110	110	throw new LogicException('You have to set "include_paths"');
111	111	}
		@@ -166,7 +166,7 @@ discard block
		block discarded – undo
166	166	// Updated?
167	167	if ($cached !== $current)
168	168	{
169		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	169	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
170	170	Cache::clearSrcCache();
171	171	Cache::writeTmpIncludePaths($current);
172	172	}
		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	// Updated?
178	178	if ($cached !== $current)
179	179	{
180		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	180	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
181	181	Cache::clearSrcCache();
182	182	Cache::writeTmpExcludePaths($current);
183	183	}
		@@ -190,7 +190,7 @@ discard block
		block discarded – undo
190	190	// Updated?
191	191	if ($cached !== self::$patcher_list)
192	192	{
193		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	193	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
194	194	Cache::clearSrcCache();
195	195	Cache::writeTmpPatcherList(self::$patcher_list);
196	196	}
		@@ -204,7 +204,7 @@ discard block
		block discarded – undo
204	204	// Updated?
205	205	if ($cached !== $current)
206	206	{
207		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	207	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
208	208	Cache::clearSrcCache();
209	209	Cache::writeTmpFunctionWhitelist($current);
210	210	}
		@@ -266,7 +266,7 @@ discard block
		block discarded – undo
266	266	*/
267	267	public static function patch($path)
268	268	{
269		- if (! is_readable($path))
	269	+ if ( ! is_readable($path))
270	270	{
271	271	throw new LogicException("Can't read '$path'");
272	272	}
		@@ -274,17 +274,17 @@ discard block
		block discarded – undo
274	274	// Check cache file
275	275	if ($cache_file = Cache::getValidSrcCachePath($path))
276	276	{
277		- self::log('cache_hit: ' . $path);
	277	+ self::log('cache_hit: '.$path);
278	278	return fopen($cache_file, 'r');
279	279	}
280	280
281		- self::log('cache_miss: ' . $path);
	281	+ self::log('cache_miss: '.$path);
282	282	$source = file_get_contents($path);
283	283
284	284	list($new_source, $patched) = self::execPatchers($source);
285	285
286	286	// Write to cache file
287		- self::log('write_cache: ' . $path);
	287	+ self::log('write_cache: '.$path);
288	288	Cache::writeSrcCacheFile($path, $new_source);
289	289
290	290	$resource = fopen('php://memory', 'rb+');
		@@ -300,12 +300,12 @@ discard block
		block discarded – undo
300	300	return;
301	301	}
302	302
303		- require __DIR__ . '/Patcher/AbstractPatcher.php';
304		- require __DIR__ . '/Patcher/Backtrace.php';
	303	+ require __DIR__.'/Patcher/AbstractPatcher.php';
	304	+ require __DIR__.'/Patcher/Backtrace.php';
305	305
306	306	foreach (self::$patcher_list as $classname)
307	307	{
308		- require __DIR__ . '/Patcher/' . $classname . '.php';
	308	+ require __DIR__.'/Patcher/'.$classname.'.php';
309	309	}
310	310
311	311	self::$load_patchers = true;
		@@ -316,7 +316,7 @@ discard block
		block discarded – undo
316	316	$patched = false;
317	317	foreach (self::$patcher_list as $classname)
318	318	{
319		- $classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
	319	+ $classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
320	320	$patcher = new $classname;
321	321	list($source, $patched_this) = $patcher->patch($source);
322	322	$patched = $patched \|\| $patched_this;

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41
42	42	public static function log($message)
43	43	{
44		- if (! self::$debug)
	44	+ if ( ! self::$debug)
45	45	{
46	46	return;
47	47	}
		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	}
81	81	if (is_null(self::$log_file))
82	82	{
83		- self::$log_file = __DIR__ . '/debug.log';
	83	+ self::$log_file = __DIR__.'/debug.log';
84	84	}
85	85	}
86	86
		@@ -93,10 +93,10 @@ discard block
		block discarded – undo
93	93	else
94	94	{
95	95	// APPPATH is constant in CodeIgniter
96		- Cache::setProjectRootDir(APPPATH . '../');
	96	+ Cache::setProjectRootDir(APPPATH.'../');
97	97	}
98	98
99		- if (! isset($config['cache_dir']))
	99	+ if ( ! isset($config['cache_dir']))
100	100	{
101	101	throw new LogicException('You have to set "cache_dir"');
102	102	}
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105
106	106	protected static function setPaths(array $config)
107	107	{
108		- if (! isset($config['include_paths']))
	108	+ if ( ! isset($config['include_paths']))
109	109	{
110	110	throw new LogicException('You have to set "include_paths"');
111	111	}
		@@ -166,7 +166,7 @@ discard block
		block discarded – undo
166	166	// Updated?
167	167	if ($cached !== $current)
168	168	{
169		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	169	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
170	170	Cache::clearSrcCache();
171	171	Cache::writeTmpIncludePaths($current);
172	172	}
		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	// Updated?
178	178	if ($cached !== $current)
179	179	{
180		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	180	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
181	181	Cache::clearSrcCache();
182	182	Cache::writeTmpExcludePaths($current);
183	183	}
		@@ -190,7 +190,7 @@ discard block
		block discarded – undo
190	190	// Updated?
191	191	if ($cached !== self::$patcher_list)
192	192	{
193		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	193	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
194	194	Cache::clearSrcCache();
195	195	Cache::writeTmpPatcherList(self::$patcher_list);
196	196	}
		@@ -204,7 +204,7 @@ discard block
		block discarded – undo
204	204	// Updated?
205	205	if ($cached !== $current)
206	206	{
207		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	207	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
208	208	Cache::clearSrcCache();
209	209	Cache::writeTmpFunctionWhitelist($current);
210	210	}
		@@ -266,7 +266,7 @@ discard block
		block discarded – undo
266	266	*/
267	267	public static function patch($path)
268	268	{
269		- if (! is_readable($path))
	269	+ if ( ! is_readable($path))
270	270	{
271	271	throw new LogicException("Can't read '$path'");
272	272	}
		@@ -274,17 +274,17 @@ discard block
		block discarded – undo
274	274	// Check cache file
275	275	if ($cache_file = Cache::getValidSrcCachePath($path))
276	276	{
277		- self::log('cache_hit: ' . $path);
	277	+ self::log('cache_hit: '.$path);
278	278	return fopen($cache_file, 'r');
279	279	}
280	280
281		- self::log('cache_miss: ' . $path);
	281	+ self::log('cache_miss: '.$path);
282	282	$source = file_get_contents($path);
283	283
284	284	list($new_source, $patched) = self::execPatchers($source);
285	285
286	286	// Write to cache file
287		- self::log('write_cache: ' . $path);
	287	+ self::log('write_cache: '.$path);
288	288	Cache::writeSrcCacheFile($path, $new_source);
289	289
290	290	$resource = fopen('php://memory', 'rb+');
		@@ -300,12 +300,12 @@ discard block
		block discarded – undo
300	300	return;
301	301	}
302	302
303		- require __DIR__ . '/Patcher/AbstractPatcher.php';
304		- require __DIR__ . '/Patcher/Backtrace.php';
	303	+ require __DIR__.'/Patcher/AbstractPatcher.php';
	304	+ require __DIR__.'/Patcher/Backtrace.php';
305	305
306	306	foreach (self::$patcher_list as $classname)
307	307	{
308		- require __DIR__ . '/Patcher/' . $classname . '.php';
	308	+ require __DIR__.'/Patcher/'.$classname.'.php';
309	309	}
310	310
311	311	self::$load_patchers = true;
		@@ -316,7 +316,7 @@ discard block
		block discarded – undo
316	316	$patched = false;
317	317	foreach (self::$patcher_list as $classname)
318	318	{
319		- $classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
	319	+ $classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
320	320	$patcher = new $classname;
321	321	list($source, $patched_this) = $patcher->patch($source);
322	322	$patched = $patched \|\| $patched_this;

kenjis / ci-phpunit-test

Pull Request — master (#243)

Status

Category

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch