Completed
Push — master ( ad269d...d7334d )
by Kenji
12s
created
application/tests/_ci_phpunit_test/replacing/core/Loader.php 3 patches
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 	 * @param	mixed	$library	Library name
192 192
 	 * @param	array	$params		Optional parameters to pass to the library class constructor
193 193
 	 * @param	string	$object_name	An optional object name to assign to
194
-	 * @return	object
194
+	 * @return	CI_Loader
195 195
 	 *
196 196
 	 * @codeCoverageIgnore
197 197
 	 */
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 	 * @param	string	$model		Model name
238 238
 	 * @param	string	$name		An optional object name to assign to
239 239
 	 * @param	bool	$db_conn	An optional database connection configuration to initialize
240
-	 * @return	object
240
+	 * @return	CI_Loader
241 241
 	 *
242 242
 	 * modified by ci-phpunit-test
243 243
 	 */
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 	/**
370 370
 	 * Database Loader
371 371
 	 *
372
-	 * @param	mixed	$params		Database configuration options
372
+	 * @param	string|boolean	$params		Database configuration options
373 373
 	 * @param	bool	$return 	Whether to return the database object
374 374
 	 * @param	bool	$query_builder	Whether to enable Query Builder
375 375
 	 *					(overrides the configuration setting)
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 	 *					An associative array or object containing values
534 534
 	 *					to be set, or a value's name if string
535 535
 	 * @param 	string	$val	Value to set, only used if $vars is a string
536
-	 * @return	object
536
+	 * @return	CI_Loader
537 537
 	 *
538 538
 	 * @codeCoverageIgnore
539 539
 	 */
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
 	 * Helper Loader
608 608
 	 *
609 609
 	 * @param	string|string[]	$helpers	Helper name(s)
610
-	 * @return	object
610
+	 * @return	CI_Loader
611 611
 	 *
612 612
 	 * @codeCoverageIgnore
613 613
 	 */
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
 	 *
687 687
 	 * @uses	CI_Loader::helper()
688 688
 	 * @param	string|string[]	$helpers	Helper name(s)
689
-	 * @return	object
689
+	 * @return	CI_Loader
690 690
 	 *
691 691
 	 * @codeCoverageIgnore
692 692
 	 */
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
 	 *
705 705
 	 * @param	string|string[]	$files	List of language file names to load
706 706
 	 * @param	string		Language name
707
-	 * @return	object
707
+	 * @return	CI_Loader
708 708
 	 *
709 709
 	 * @codeCoverageIgnore
710 710
 	 */
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
 	 *
805 805
 	 * @param	string	$path		Path to add
806 806
 	 * @param 	bool	$view_cascade	(default: TRUE)
807
-	 * @return	object
807
+	 * @return	CI_Loader
808 808
 	 *
809 809
 	 * @codeCoverageIgnore
810 810
 	 */
@@ -852,7 +852,7 @@  discard block
 block discarded – undo
852 852
 	 * added path will be removed removed.
853 853
 	 *
854 854
 	 * @param	string	$path	Path to remove
855
-	 * @return	object
855
+	 * @return	CI_Loader
856 856
 	 *
857 857
 	 * @codeCoverageIgnore
858 858
 	 */
Please login to merge, or discard this patch.
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -63,63 +63,63 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @var	array
65 65
 	 */
66
-	protected $_ci_view_paths =	array(VIEWPATH	=> TRUE);
66
+	protected $_ci_view_paths = array(VIEWPATH	=> TRUE);
67 67
 
68 68
 	/**
69 69
 	 * List of paths to load libraries from
70 70
 	 *
71 71
 	 * @var	array
72 72
 	 */
73
-	protected $_ci_library_paths =	array(APPPATH, BASEPATH);
73
+	protected $_ci_library_paths = array(APPPATH, BASEPATH);
74 74
 
75 75
 	/**
76 76
 	 * List of paths to load models from
77 77
 	 *
78 78
 	 * @var	array
79 79
 	 */
80
-	protected $_ci_model_paths =	array(APPPATH);
80
+	protected $_ci_model_paths = array(APPPATH);
81 81
 
82 82
 	/**
83 83
 	 * List of paths to load helpers from
84 84
 	 *
85 85
 	 * @var	array
86 86
 	 */
87
-	protected $_ci_helper_paths =	array(APPPATH, BASEPATH);
87
+	protected $_ci_helper_paths = array(APPPATH, BASEPATH);
88 88
 
89 89
 	/**
90 90
 	 * List of cached variables
91 91
 	 *
92 92
 	 * @var	array
93 93
 	 */
94
-	protected $_ci_cached_vars =	array();
94
+	protected $_ci_cached_vars = array();
95 95
 
96 96
 	/**
97 97
 	 * List of loaded classes
98 98
 	 *
99 99
 	 * @var	array
100 100
 	 */
101
-	protected $_ci_classes =	array();
101
+	protected $_ci_classes = array();
102 102
 
103 103
 	/**
104 104
 	 * List of loaded models
105 105
 	 *
106 106
 	 * @var	array
107 107
 	 */
108
-	protected $_ci_models =	array();
108
+	protected $_ci_models = array();
109 109
 
110 110
 	/**
111 111
 	 * List of loaded helpers
112 112
 	 *
113 113
 	 * @var	array
114 114
 	 */
115
-	protected $_ci_helpers =	array();
115
+	protected $_ci_helpers = array();
116 116
 
117 117
 	/**
118 118
 	 * List of class name mappings
119 119
 	 *
120 120
 	 * @var	array
121 121
 	 */
122
-	protected $_ci_varmap =	array(
122
+	protected $_ci_varmap = array(
123 123
 		'unit_test' => 'unit',
124 124
 		'user_agent' => 'agent'
125 125
 	);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 	public function __construct()
139 139
 	{
140 140
 		$this->_ci_ob_level = ob_get_level();
141
-		$this->_ci_classes =& is_loaded();
141
+		$this->_ci_classes = & is_loaded();
142 142
 
143 143
 		log_message('info', 'Loader Class Initialized');
144 144
 	}
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 			return $this;
280 280
 		}
281 281
 
282
-		$CI =& get_instance();
282
+		$CI = & get_instance();
283 283
 		if (isset($CI->$name))
284 284
 		{
285 285
 			throw new RuntimeException('The model name you are loading is the name of a resource that is already being used: '.$name);
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
 	public function database($params = '', $return = FALSE, $query_builder = NULL)
383 383
 	{
384 384
 		// Grab the super object
385
-		$CI =& get_instance();
385
+		$CI = & get_instance();
386 386
 
387 387
 		// Do we even need to load the database class?
388 388
 		if ($return === FALSE && $query_builder === NULL && isset($CI->db) && is_object($CI->db) && ! empty($CI->db->conn_id))
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
 		$CI->db = '';
403 403
 
404 404
 		// Load the DB class
405
-		$CI->db =& DB($params, $query_builder);
405
+		$CI->db = & DB($params, $query_builder);
406 406
 		return $this;
407 407
 	}
408 408
 
@@ -419,12 +419,12 @@  discard block
 block discarded – undo
419 419
 	 */
420 420
 	public function dbutil($db = NULL, $return = FALSE)
421 421
 	{
422
-		$CI =& get_instance();
422
+		$CI = & get_instance();
423 423
 
424 424
 		if ( ! is_object($db) OR ! ($db instanceof CI_DB))
425 425
 		{
426 426
 			class_exists('CI_DB', FALSE) OR $this->database();
427
-			$db =& $CI->db;
427
+			$db = & $CI->db;
428 428
 		}
429 429
 
430 430
 		require_once(BASEPATH.'database/DB_utility.php');
@@ -453,11 +453,11 @@  discard block
 block discarded – undo
453 453
 	 */
454 454
 	public function dbforge($db = NULL, $return = FALSE)
455 455
 	{
456
-		$CI =& get_instance();
456
+		$CI = & get_instance();
457 457
 		if ( ! is_object($db) OR ! ($db instanceof CI_DB))
458 458
 		{
459 459
 			class_exists('CI_DB', FALSE) OR $this->database();
460
-			$db =& $CI->db;
460
+			$db = & $CI->db;
461 461
 		}
462 462
 
463 463
 		require_once(BASEPATH.'database/DB_forge.php');
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 		$this->_ci_view_paths = array($path.'views/' => $view_cascade) + $this->_ci_view_paths;
820 820
 
821 821
 		// Add config file path
822
-		$config =& $this->_ci_get_component('config');
822
+		$config = & $this->_ci_get_component('config');
823 823
 		$config->_config_paths[] = $path;
824 824
 
825 825
 		return $this;
@@ -858,7 +858,7 @@  discard block
 block discarded – undo
858 858
 	 */
859 859
 	public function remove_package_path($path = '')
860 860
 	{
861
-		$config =& $this->_ci_get_component('config');
861
+		$config = & $this->_ci_get_component('config');
862 862
 
863 863
 		if ($path === '')
864 864
 		{
@@ -961,12 +961,12 @@  discard block
 block discarded – undo
961 961
 
962 962
 		// This allows anything loaded using $this->load (views, files, etc.)
963 963
 		// to become accessible from within the Controller and Model functions.
964
-		$_ci_CI =& get_instance();
964
+		$_ci_CI = & get_instance();
965 965
 		foreach (get_object_vars($_ci_CI) as $_ci_key => $_ci_var)
966 966
 		{
967 967
 			if ( ! isset($this->$_ci_key))
968 968
 			{
969
-				$this->$_ci_key =& $_ci_CI->$_ci_key;
969
+				$this->$_ci_key = & $_ci_CI->$_ci_key;
970 970
 			}
971 971
 		}
972 972
 
@@ -1099,7 +1099,7 @@  discard block
 block discarded – undo
1099 1099
 				isset($this->_ci_varmap[$property]) && $property = $this->_ci_varmap[$property];
1100 1100
 			}
1101 1101
 
1102
-			$CI =& get_instance();
1102
+			$CI = & get_instance();
1103 1103
 			if (isset($CI->$property))
1104 1104
 			{
1105 1105
 //				log_message('debug', $class.' class already loaded. Second attempt ignored.');
@@ -1174,7 +1174,7 @@  discard block
 block discarded – undo
1174 1174
 				isset($this->_ci_varmap[$property]) && $property = $this->_ci_varmap[$property];
1175 1175
 			}
1176 1176
 
1177
-			$CI =& get_instance();
1177
+			$CI = & get_instance();
1178 1178
 			if ( ! isset($CI->$property))
1179 1179
 			{
1180 1180
 				return $this->_ci_init_library($library_name, $prefix, $params, $object_name);
@@ -1322,7 +1322,7 @@  discard block
 block discarded – undo
1322 1322
 		}
1323 1323
 
1324 1324
 		// Don't overwrite existing properties
1325
-		$CI =& get_instance();
1325
+		$CI = & get_instance();
1326 1326
 		if (isset($CI->$object_name))
1327 1327
 		{
1328 1328
 			if ($CI->$object_name instanceof $class_name)
@@ -1473,7 +1473,7 @@  discard block
 block discarded – undo
1473 1473
 	 */
1474 1474
 	protected function &_ci_get_component($component)
1475 1475
 	{
1476
-		$CI =& get_instance();
1476
+		$CI = & get_instance();
1477 1477
 		return $CI->$component;
1478 1478
 	}
1479 1479
 }
Please login to merge, or discard this patch.
Braces   +15 added lines, -30 removed lines patch added patch discarded remove patch
@@ -200,16 +200,14 @@  discard block
 block discarded – undo
200 200
 		if (empty($library))
201 201
 		{
202 202
 			return $this;
203
-		}
204
-		elseif (is_array($library))
203
+		} elseif (is_array($library))
205 204
 		{
206 205
 			foreach ($library as $key => $value)
207 206
 			{
208 207
 				if (is_int($key))
209 208
 				{
210 209
 					$this->library($value, $params);
211
-				}
212
-				else
210
+				} else
213 211
 				{
214 212
 					$this->library($key, $params, $value);
215 213
 				}
@@ -246,8 +244,7 @@  discard block
 block discarded – undo
246 244
 		if (empty($model))
247 245
 		{
248 246
 			return $this;
249
-		}
250
-		elseif (is_array($model))
247
+		} elseif (is_array($model))
251 248
 		{
252 249
 			foreach ($model as $key => $value)
253 250
 			{
@@ -313,8 +310,7 @@  discard block
 block discarded – undo
313 310
 				{
314 311
 					throw new RuntimeException($app_path."Model.php exists, but doesn't declare class CI_Model");
315 312
 				}
316
-			}
317
-			elseif ( ! class_exists('CI_Model', FALSE))
313
+			} elseif ( ! class_exists('CI_Model', FALSE))
318 314
 			{
319 315
 				require_once(BASEPATH.'core'.DIRECTORY_SEPARATOR.'Model.php');
320 316
 			}
@@ -471,8 +467,7 @@  discard block
 block discarded – undo
471 467
 				require_once($driver_path);
472 468
 				$class = 'CI_DB_'.$db->dbdriver.'_'.$db->subdriver.'_forge';
473 469
 			}
474
-		}
475
-		else
470
+		} else
476 471
 		{
477 472
 			$class = 'CI_DB_'.$db->dbdriver.'_forge';
478 473
 		}
@@ -759,16 +754,14 @@  discard block
 block discarded – undo
759 754
 				if (is_int($key))
760 755
 				{
761 756
 					$this->driver($value, $params);
762
-				}
763
-				else
757
+				} else
764 758
 				{
765 759
 					$this->driver($key, $params, $value);
766 760
 				}
767 761
 			}
768 762
 
769 763
 			return $this;
770
-		}
771
-		elseif (empty($library))
764
+		} elseif (empty($library))
772 765
 		{
773 766
 			return FALSE;
774 767
 		}
@@ -867,8 +860,7 @@  discard block
 block discarded – undo
867 860
 			array_shift($this->_ci_helper_paths);
868 861
 			array_shift($this->_ci_view_paths);
869 862
 			array_pop($config->_config_paths);
870
-		}
871
-		else
863
+		} else
872 864
 		{
873 865
 			$path = rtrim($path, '/').'/';
874 866
 			foreach (array('_ci_library_paths', '_ci_model_paths', '_ci_helper_paths') as $var)
@@ -932,8 +924,7 @@  discard block
 block discarded – undo
932 924
 		{
933 925
 			$_ci_x = explode('/', $_ci_path);
934 926
 			$_ci_file = end($_ci_x);
935
-		}
936
-		else
927
+		} else
937 928
 		{
938 929
 			$_ci_ext = pathinfo($_ci_view, PATHINFO_EXTENSION);
939 930
 			$_ci_file = ($_ci_ext === '') ? $_ci_view.'.php' : $_ci_view;
@@ -1000,8 +991,7 @@  discard block
 block discarded – undo
1000 991
 		if ( ! is_php('5.4') && ! ini_get('short_open_tag') && config_item('rewrite_short_tags') === TRUE)
1001 992
 		{
1002 993
 			echo eval('?>'.preg_replace('/;*\s*\?>/', '; ?>', str_replace('<?=', '<?php echo ', file_get_contents($_ci_path))));
1003
-		}
1004
-		else
994
+		} else
1005 995
 		{
1006 996
 			include($_ci_path); // include() vs include_once() allows for multiple views with the same name
1007 997
 		}
@@ -1028,8 +1018,7 @@  discard block
 block discarded – undo
1028 1018
 		if (ob_get_level() > $this->_ci_ob_level + 1)
1029 1019
 		{
1030 1020
 			ob_end_flush();
1031
-		}
1032
-		else
1021
+		} else
1033 1022
 		{
1034 1023
 			$_ci_CI->output->append_output(ob_get_contents());
1035 1024
 			@ob_end_clean();
@@ -1069,8 +1058,7 @@  discard block
 block discarded – undo
1069 1058
 
1070 1059
 			// Get the filename from the path
1071 1060
 			$class = substr($class, $last_slash);
1072
-		}
1073
-		else
1061
+		} else
1074 1062
 		{
1075 1063
 			$subdir = '';
1076 1064
 		}
@@ -1208,8 +1196,7 @@  discard block
 block discarded – undo
1208 1196
 		if (file_exists(TESTPATH.'_ci_phpunit_test/replacing/libraries/'.$file_path.$library_name.'.php'))
1209 1197
 		{
1210 1198
 			include_once(TESTPATH.'_ci_phpunit_test/replacing/libraries/'.$file_path.$library_name.'.php');
1211
-		}
1212
-		else
1199
+		} else
1213 1200
 		{
1214 1201
 			include_once(BASEPATH.'libraries/'.$file_path.$library_name.'.php');
1215 1202
 		}
@@ -1273,8 +1260,7 @@  discard block
 block discarded – undo
1273 1260
 					{
1274 1261
 						include($path.'config/'.strtolower($class).'.php');
1275 1262
 						$found = TRUE;
1276
-					}
1277
-					elseif (file_exists($path.'config/'.ucfirst(strtolower($class)).'.php'))
1263
+					} elseif (file_exists($path.'config/'.ucfirst(strtolower($class)).'.php'))
1278 1264
 					{
1279 1265
 						include($path.'config/'.ucfirst(strtolower($class)).'.php');
1280 1266
 						$found = TRUE;
@@ -1284,8 +1270,7 @@  discard block
 block discarded – undo
1284 1270
 					{
1285 1271
 						include($path.'config/'.ENVIRONMENT.'/'.strtolower($class).'.php');
1286 1272
 						$found = TRUE;
1287
-					}
1288
-					elseif (file_exists($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php'))
1273
+					} elseif (file_exists($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php'))
1289 1274
 					{
1290 1275
 						include($path.'config/'.ENVIRONMENT.'/'.ucfirst(strtolower($class)).'.php');
1291 1276
 						$found = TRUE;
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/libraries/Upload.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1354,7 +1354,7 @@
 block discarded – undo
1354 1354
 			}
1355 1355
 		}
1356 1356
 
1357
-        // Fall back to mime_content_type(), if available (still better than $_FILES[$field]['type'])
1357
+		// Fall back to mime_content_type(), if available (still better than $_FILES[$field]['type'])
1358 1358
 		if (function_exists('mime_content_type'))
1359 1359
 		{
1360 1360
 			$this->file_type = @mime_content_type($file['tmp_name']);
Please login to merge, or discard this patch.