Inspection of "Update for PHP 7.2" - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#224)

by Kenji

created 2018-01-14 11:29 UTC

Status

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -181,8 +181,7 @@  discard block
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($i == $replacement['key'])
+			} elseif ($i == $replacement['key'])
 			{
 				$new_source .= $replacement['value'];
 				$replacement['key'] = key(self::$replacement);
@@ -192,8 +191,7 @@  discard block
 block discarded – undo
 				{
 					$replacement = false;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/2.x/Patcher/ConstantPatcher.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -72,8 +72,7 @@  discard block
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($i == $replacement['key'])
+			} elseif ($i == $replacement['key'])
 			{
 				$new_source .= $replacement['value'];
 				$replacement['key'] = key(self::$replacement);
@@ -83,8 +82,7 @@  discard block
 block discarded – undo
 				{
 					$replacement = false;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/2.x/Patcher/MethodPatcher.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -10,8 +10,8 @@  discard block
 block discarded – undo
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/MethodPatcher/NodeVisitor.php';
-require __DIR__ . '/MethodPatcher/PatchManager.php';
+require __DIR__.'/MethodPatcher/NodeVisitor.php';
+require __DIR__.'/MethodPatcher/PatchManager.php';
 
 use LogicException;
 
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 			{
 				if ($start_method && $token === '{')
 				{
-					$new_source .= '{ ' . self::CODE;
+					$new_source .= '{ '.self::CODE;
 					$start_method = false;
 					$replacement['key'] = key(self::$replacement);
 					$replacement['value'] = current(self::$replacement);

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -70,13 +70,11 @@
 block discarded – undo
 					{
 						$replacement = false;
 					}
-				}
-				else
+				} else
 				{
 					$new_source .= $token;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/FunctionPatcher.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -181,8 +181,7 @@  discard block
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($i == $replacement['key'])
+			} elseif ($i == $replacement['key'])
 			{
 				$new_source .= $replacement['value'];
 				$replacement['key'] = key(self::$replacement);
@@ -192,8 +191,7 @@  discard block
 block discarded – undo
 				{
 					$replacement = false;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ConstantPatcher.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -72,8 +72,7 @@  discard block
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($i == $replacement['key'])
+			} elseif ($i == $replacement['key'])
 			{
 				$new_source .= $replacement['value'];
 				$replacement['key'] = key(self::$replacement);
@@ -83,8 +82,7 @@  discard block
 block discarded – undo
 				{
 					$replacement = false;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -10,8 +10,8 @@  discard block
 block discarded – undo
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/MethodPatcher/NodeVisitor.php';
-require __DIR__ . '/MethodPatcher/PatchManager.php';
+require __DIR__.'/MethodPatcher/NodeVisitor.php';
+require __DIR__.'/MethodPatcher/PatchManager.php';
 
 use LogicException;
 
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 			{
 				if ($start_method && $token === '{')
 				{
-					$new_source .= '{ ' . self::CODE;
+					$new_source .= '{ '.self::CODE;
 					$start_method = false;
 					$replacement['key'] = key(self::$replacement);
 					$replacement['value'] = current(self::$replacement);

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -70,13 +70,11 @@
 block discarded – undo
 					{
 						$replacement = false;
 					}
-				}
-				else
+				} else
 				{
 					$new_source .= $token;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

		@@ -181,8 +181,7 @@ discard block
		block discarded – undo
181	181	if (is_string($token))
182	182	{
183	183	$new_source .= $token;
184		- }
185		- elseif ($i == $replacement['key'])
	184	+ } elseif ($i == $replacement['key'])
186	185	{
187	186	$new_source .= $replacement['value'];
188	187	$replacement['key'] = key(self::$replacement);
		@@ -192,8 +191,7 @@ discard block
		block discarded – undo
192	191	{
193	192	$replacement = false;
194	193	}
195		- }
196		- else
	194	+ } else
197	195	{
198	196	$new_source .= $token[1];
199	197	}

		@@ -72,8 +72,7 @@ discard block
		block discarded – undo
72	72	if (is_string($token))
73	73	{
74	74	$new_source .= $token;
75		- }
76		- elseif ($i == $replacement['key'])
	75	+ } elseif ($i == $replacement['key'])
77	76	{
78	77	$new_source .= $replacement['value'];
79	78	$replacement['key'] = key(self::$replacement);
		@@ -83,8 +82,7 @@ discard block
		block discarded – undo
83	82	{
84	83	$replacement = false;
85	84	}
86		- }
87		- else
	85	+ } else
88	86	{
89	87	$new_source .= $token[1];
90	88	}

		@@ -70,13 +70,11 @@
		block discarded – undo
70	70	{
71	71	$replacement = false;
72	72	}
73		- }
74		- else
	73	+ } else
75	74	{
76	75	$new_source .= $token;
77	76	}
78		- }
79		- else
	77	+ } else
80	78	{
81	79	$new_source .= $token[1];
82	80	}

		@@ -181,8 +181,7 @@ discard block
		block discarded – undo
181	181	if (is_string($token))
182	182	{
183	183	$new_source .= $token;
184		- }
185		- elseif ($i == $replacement['key'])
	184	+ } elseif ($i == $replacement['key'])
186	185	{
187	186	$new_source .= $replacement['value'];
188	187	$replacement['key'] = key(self::$replacement);
		@@ -192,8 +191,7 @@ discard block
		block discarded – undo
192	191	{
193	192	$replacement = false;
194	193	}
195		- }
196		- else
	194	+ } else
197	195	{
198	196	$new_source .= $token[1];
199	197	}

		@@ -72,8 +72,7 @@ discard block
		block discarded – undo
72	72	if (is_string($token))
73	73	{
74	74	$new_source .= $token;
75		- }
76		- elseif ($i == $replacement['key'])
	75	+ } elseif ($i == $replacement['key'])
77	76	{
78	77	$new_source .= $replacement['value'];
79	78	$replacement['key'] = key(self::$replacement);
		@@ -83,8 +82,7 @@ discard block
		block discarded – undo
83	82	{
84	83	$replacement = false;
85	84	}
86		- }
87		- else
	85	+ } else
88	86	{
89	87	$new_source .= $token[1];
90	88	}

		@@ -10,8 +10,8 @@ discard block
		block discarded – undo
10	10
11	11	namespace Kenjis\MonkeyPatch\Patcher;
12	12
13		-require __DIR__ . '/MethodPatcher/NodeVisitor.php';
14		-require __DIR__ . '/MethodPatcher/PatchManager.php';
	13	+require __DIR__.'/MethodPatcher/NodeVisitor.php';
	14	+require __DIR__.'/MethodPatcher/PatchManager.php';
15	15
16	16	use LogicException;
17	17
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	{
62	62	if ($start_method && $token === '{')
63	63	{
64		- $new_source .= '{ ' . self::CODE;
	64	+ $new_source .= '{ '.self::CODE;
65	65	$start_method = false;
66	66	$replacement['key'] = key(self::$replacement);
67	67	$replacement['value'] = current(self::$replacement);

kenjis / ci-phpunit-test

Pull Request — master (#224)

Status

Category

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch