Inspection of "Fix CI_URI::__construct()" - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#140)

unknown

created 2016-10-05 22:28 UTC

Status

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -185,7 +185,7 @@  discard block
 block discarded – undo
  *  Start the timer... tick tock tick tock...
  * ------------------------------------------------------
  */
-	$BM =& load_class('Benchmark', 'core');
+	$BM = & load_class('Benchmark', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
 	$BM->mark('total_execution_time_start');
 	$BM->mark('loading_time:_base_classes_start');
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
  *  Instantiate the hooks class
  * ------------------------------------------------------
  */
-	$EXT =& load_class('Hooks', 'core');
+	$EXT = & load_class('Hooks', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
 
 /*
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
  * depending on another class that uses it.
  *
  */
-	$CFG =& load_class('Config', 'core');
+	$CFG = & load_class('Config', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
 
 	// Do we have any manually set config items in the index.php file?
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
  *  Instantiate the UTF-8 class
  * ------------------------------------------------------
  */
-	$UNI =& load_class('Utf8', 'core');
+	$UNI = & load_class('Utf8', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
 
 /*
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
  *  Instantiate the URI class
  * ------------------------------------------------------
  */
-	$URI =& load_class('URI', 'core', $CFG);
+	$URI = & load_class('URI', 'core', $CFG);
 	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
 
 /*
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
  *  Instantiate the routing class and set the routing
  * ------------------------------------------------------
  */
-	$RTR =& load_class('Router', 'core', isset($routing) ? $routing : NULL);
+	$RTR = & load_class('Router', 'core', isset($routing) ? $routing : NULL);
 	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
 
 /*
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
  *  Instantiate the output class
  * ------------------------------------------------------
  */
-	$OUT =& load_class('Output', 'core');
+	$OUT = & load_class('Output', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
 
 /*
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
  * Load the security class for xss and csrf support
  * -----------------------------------------------------
  */
-	$SEC =& load_class('Security', 'core');
+	$SEC = & load_class('Security', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
 
 /*
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
  *  Load the Input class and sanitize globals
  * ------------------------------------------------------
  */
-	$IN	=& load_class('Input', 'core');
+	$IN = & load_class('Input', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
 
 /*
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
  *  Load the Language class
  * ------------------------------------------------------
  */
-	$LANG =& load_class('Lang', 'core');
+	$LANG = & load_class('Lang', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
 
 /*
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
 	 */
 	function &get_instance()
 	{
-		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
+		if ( ! CIPHPUnitTest::wiredesignzHmvcInstalled())
 		{
 			return CI_Controller::get_instance();
 		}

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/functions.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@  discard block
 block discarded – undo
 	reset_config();
 
 	// Close db connection
-	$CI =& get_instance();
+	$CI = & get_instance();
 	if (isset($CI->db))
 	{
 		if (
@@ -52,25 +52,25 @@  discard block
 block discarded – undo
 	}
 
 	// Load core classes
-	$BM =& load_class('Benchmark', 'core');
+	$BM = & load_class('Benchmark', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
-	$EXT =& load_class('Hooks', 'core');
+	$EXT = & load_class('Hooks', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
-	$CFG =& load_class('Config', 'core');
+	$CFG = & load_class('Config', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
-	$UNI =& load_class('URI', 'core', $CFG);
+	$UNI = & load_class('URI', 'core', $CFG);
 	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
 //	$URI =& load_class('Utf8', 'core');
 //	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
-	$RTR =& load_class('Router', 'core');
+	$RTR = & load_class('Router', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
-	$OUT =& load_class('Output', 'core');
+	$OUT = & load_class('Output', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
-	$SEC =& load_class('Security', 'core');
+	$SEC = & load_class('Security', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
-	$IN =& load_class('Input', 'core');
+	$IN = & load_class('Input', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
-	$LANG =& load_class('Lang', 'core');
+	$LANG = & load_class('Lang', 'core');
 	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
 
 	CIPHPUnitTest::loadLoader();

Please login to merge, or discard this patch.

		@@ -185,7 +185,7 @@ discard block
		block discarded – undo
185	185	* Start the timer... tick tock tick tock...
186	186	* ------------------------------------------------------
187	187	*/
188		- $BM =& load_class('Benchmark', 'core');
	188	+ $BM = & load_class('Benchmark', 'core');
189	189	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
190	190	$BM->mark('total_execution_time_start');
191	191	$BM->mark('loading_time:_base_classes_start');
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	* Instantiate the hooks class
196	196	* ------------------------------------------------------
197	197	*/
198		- $EXT =& load_class('Hooks', 'core');
	198	+ $EXT = & load_class('Hooks', 'core');
199	199	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
200	200
201	201	/*
		@@ -215,7 +215,7 @@ discard block
		block discarded – undo
215	215	* depending on another class that uses it.
216	216	*
217	217	*/
218		- $CFG =& load_class('Config', 'core');
	218	+ $CFG = & load_class('Config', 'core');
219	219	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
220	220
221	221	// Do we have any manually set config items in the index.php file?
		@@ -294,7 +294,7 @@ discard block
		block discarded – undo
294	294	* Instantiate the UTF-8 class
295	295	* ------------------------------------------------------
296	296	*/
297		- $UNI =& load_class('Utf8', 'core');
	297	+ $UNI = & load_class('Utf8', 'core');
298	298	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
299	299
300	300	/*
		@@ -302,7 +302,7 @@ discard block
		block discarded – undo
302	302	* Instantiate the URI class
303	303	* ------------------------------------------------------
304	304	*/
305		- $URI =& load_class('URI', 'core', $CFG);
	305	+ $URI = & load_class('URI', 'core', $CFG);
306	306	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
307	307
308	308	/*
		@@ -310,7 +310,7 @@ discard block
		block discarded – undo
310	310	* Instantiate the routing class and set the routing
311	311	* ------------------------------------------------------
312	312	*/
313		- $RTR =& load_class('Router', 'core', isset($routing) ? $routing : NULL);
	313	+ $RTR = & load_class('Router', 'core', isset($routing) ? $routing : NULL);
314	314	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
315	315
316	316	/*
		@@ -318,7 +318,7 @@ discard block
		block discarded – undo
318	318	* Instantiate the output class
319	319	* ------------------------------------------------------
320	320	*/
321		- $OUT =& load_class('Output', 'core');
	321	+ $OUT = & load_class('Output', 'core');
322	322	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
323	323
324	324	/*
		@@ -336,7 +336,7 @@ discard block
		block discarded – undo
336	336	* Load the security class for xss and csrf support
337	337	* -----------------------------------------------------
338	338	*/
339		- $SEC =& load_class('Security', 'core');
	339	+ $SEC = & load_class('Security', 'core');
340	340	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
341	341
342	342	/*
		@@ -344,7 +344,7 @@ discard block
		block discarded – undo
344	344	* Load the Input class and sanitize globals
345	345	* ------------------------------------------------------
346	346	*/
347		- $IN =& load_class('Input', 'core');
	347	+ $IN = & load_class('Input', 'core');
348	348	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
349	349
350	350	/*
		@@ -352,7 +352,7 @@ discard block
		block discarded – undo
352	352	* Load the Language class
353	353	* ------------------------------------------------------
354	354	*/
355		- $LANG =& load_class('Lang', 'core');
	355	+ $LANG = & load_class('Lang', 'core');
356	356	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
357	357
358	358	/*
		@@ -375,7 +375,7 @@ discard block
		block discarded – undo
375	375	*/
376	376	function &get_instance()
377	377	{
378		- if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
	378	+ if ( ! CIPHPUnitTest::wiredesignzHmvcInstalled())
379	379	{
380	380	return CI_Controller::get_instance();
381	381	}

		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	reset_config();
33	33
34	34	// Close db connection
35		- $CI =& get_instance();
	35	+ $CI = & get_instance();
36	36	if (isset($CI->db))
37	37	{
38	38	if (
		@@ -52,25 +52,25 @@ discard block
		block discarded – undo
52	52	}
53	53
54	54	// Load core classes
55		- $BM =& load_class('Benchmark', 'core');
	55	+ $BM = & load_class('Benchmark', 'core');
56	56	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
57		- $EXT =& load_class('Hooks', 'core');
	57	+ $EXT = & load_class('Hooks', 'core');
58	58	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
59		- $CFG =& load_class('Config', 'core');
	59	+ $CFG = & load_class('Config', 'core');
60	60	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
61		- $UNI =& load_class('URI', 'core', $CFG);
	61	+ $UNI = & load_class('URI', 'core', $CFG);
62	62	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
63	63	// $URI =& load_class('Utf8', 'core');
64	64	// CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
65		- $RTR =& load_class('Router', 'core');
	65	+ $RTR = & load_class('Router', 'core');
66	66	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
67		- $OUT =& load_class('Output', 'core');
	67	+ $OUT = & load_class('Output', 'core');
68	68	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
69		- $SEC =& load_class('Security', 'core');
	69	+ $SEC = & load_class('Security', 'core');
70	70	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
71		- $IN =& load_class('Input', 'core');
	71	+ $IN = & load_class('Input', 'core');
72	72	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
73		- $LANG =& load_class('Lang', 'core');
	73	+ $LANG = & load_class('Lang', 'core');
74	74	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
75	75
76	76	CIPHPUnitTest::loadLoader();

kenjis / ci-phpunit-test

Pull Request — master (#140)

Status

Category

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch