Inspection of "Add default TESTPATH constant" - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da3f13...a1e877 )

by Kenji

created 2017-10-27 14:24 UTC

Status

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@  discard block
 block discarded – undo
 	 */
 	public static function init(array $autoload_dirs = null)
 	{
-		if (! defined('TESTPATH')) {
+		if ( ! defined('TESTPATH')) {
 			define('TESTPATH', APPPATH.DIRECTORY_SEPARATOR.'tests'.DIRECTORY_SEPARATOR);
 		}
 
@@ -37,30 +37,30 @@  discard block
 block discarded – undo
 		$cwd_backup = getcwd();
 
 		// Load autoloader for ci-phpunit-test
-		require __DIR__ . '/autoloader.php';
+		require __DIR__.'/autoloader.php';
 
-		require TESTPATH . 'TestCase.php';
+		require TESTPATH.'TestCase.php';
 
-		$db_test_case_file = TESTPATH . 'DbTestCase.php';
+		$db_test_case_file = TESTPATH.'DbTestCase.php';
 		if (is_readable($db_test_case_file))
 		{
 			require $db_test_case_file;
 		}
 
 		// Replace a few Common functions
-		require __DIR__ . '/replacing/core/Common.php';
-		require BASEPATH . 'core/Common.php';
+		require __DIR__.'/replacing/core/Common.php';
+		require BASEPATH.'core/Common.php';
 
 		// Workaround for missing CodeIgniter's error handler
 		// See https://github.com/kenjis/ci-phpunit-test/issues/37
 		set_error_handler('_error_handler');
 
 		// Load new functions of CIPHPUnitTest
-		require __DIR__ . '/functions.php';
+		require __DIR__.'/functions.php';
 		// Load ci-phpunit-test CI_Loader
-		require __DIR__ . '/replacing/core/Loader.php';
+		require __DIR__.'/replacing/core/Loader.php';
 		// Load ci-phpunit-test CI_Input
-		require __DIR__ . '/replacing/core/Input.php';
+		require __DIR__.'/replacing/core/Input.php';
 
 		// Change current directory
 		chdir(FCPATH);
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
 		 *
 		 * And away we go...
 		 */
-		require __DIR__ . '/replacing/core/CodeIgniter.php';
+		require __DIR__.'/replacing/core/CodeIgniter.php';
 
 		self::replaceHelpers();
 
 		// Create CodeIgniter instance
-		if (! self::wiredesignzHmvcInstalled())
+		if ( ! self::wiredesignzHmvcInstalled())
 		{
 			new CI_Controller();
 		}
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
 
 	public static function createCodeIgniterInstance()
 	{
-		if (! self::wiredesignzHmvcInstalled())
+		if ( ! self::wiredesignzHmvcInstalled())
 		{
 			new CI_Controller();
 		}
@@ -127,11 +127,11 @@  discard block
 block discarded – undo
 	protected static function replaceLoader()
 	{
 		$my_loader_file =
-			APPPATH . 'core/' . config_item('subclass_prefix') . 'Loader.php';
+			APPPATH.'core/'.config_item('subclass_prefix').'Loader.php';
 
 		if (file_exists($my_loader_file))
 		{
-			self::$loader_class = config_item('subclass_prefix') . 'Loader';
+			self::$loader_class = config_item('subclass_prefix').'Loader';
 			if ( ! class_exists(self::$loader_class))
 			{
 				require $my_loader_file;
@@ -150,19 +150,19 @@  discard block
 block discarded – undo
 
 	protected static function loadHelper($helper)
 	{
-		$my_helper_file = APPPATH . 'helpers/' . config_item('subclass_prefix') . $helper . '.php';
+		$my_helper_file = APPPATH.'helpers/'.config_item('subclass_prefix').$helper.'.php';
 		if (file_exists($my_helper_file))
 		{
 			require $my_helper_file;
 		}
-		require __DIR__ . '/replacing/helpers/' . $helper . '.php';
+		require __DIR__.'/replacing/helpers/'.$helper.'.php';
 	}
 
 	public static function setPatcherCacheDir($dir = null)
 	{
 		if ($dir === null)
 		{
-			$dir = TESTPATH . '_ci_phpunit_test/tmp/cache';
+			$dir = TESTPATH.'_ci_phpunit_test/tmp/cache';
 		}
 
 		MonkeyPatchManager::setCacheDir(

Please login to merge, or discard this patch.

		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	*/
21	21	public static function init(array $autoload_dirs = null)
22	22	{
23		- if (! defined('TESTPATH')) {
	23	+ if ( ! defined('TESTPATH')) {
24	24	define('TESTPATH', APPPATH.DIRECTORY_SEPARATOR.'tests'.DIRECTORY_SEPARATOR);
25	25	}
26	26
		@@ -37,30 +37,30 @@ discard block
		block discarded – undo
37	37	$cwd_backup = getcwd();
38	38
39	39	// Load autoloader for ci-phpunit-test
40		- require __DIR__ . '/autoloader.php';
	40	+ require __DIR__.'/autoloader.php';
41	41
42		- require TESTPATH . 'TestCase.php';
	42	+ require TESTPATH.'TestCase.php';
43	43
44		- $db_test_case_file = TESTPATH . 'DbTestCase.php';
	44	+ $db_test_case_file = TESTPATH.'DbTestCase.php';
45	45	if (is_readable($db_test_case_file))
46	46	{
47	47	require $db_test_case_file;
48	48	}
49	49
50	50	// Replace a few Common functions
51		- require __DIR__ . '/replacing/core/Common.php';
52		- require BASEPATH . 'core/Common.php';
	51	+ require __DIR__.'/replacing/core/Common.php';
	52	+ require BASEPATH.'core/Common.php';
53	53
54	54	// Workaround for missing CodeIgniter's error handler
55	55	// See https://github.com/kenjis/ci-phpunit-test/issues/37
56	56	set_error_handler('_error_handler');
57	57
58	58	// Load new functions of CIPHPUnitTest
59		- require __DIR__ . '/functions.php';
	59	+ require __DIR__.'/functions.php';
60	60	// Load ci-phpunit-test CI_Loader
61		- require __DIR__ . '/replacing/core/Loader.php';
	61	+ require __DIR__.'/replacing/core/Loader.php';
62	62	// Load ci-phpunit-test CI_Input
63		- require __DIR__ . '/replacing/core/Input.php';
	63	+ require __DIR__.'/replacing/core/Input.php';
64	64
65	65	// Change current directory
66	66	chdir(FCPATH);
		@@ -72,12 +72,12 @@ discard block
		block discarded – undo
72	72	*
73	73	* And away we go...
74	74	*/
75		- require __DIR__ . '/replacing/core/CodeIgniter.php';
	75	+ require __DIR__.'/replacing/core/CodeIgniter.php';
76	76
77	77	self::replaceHelpers();
78	78
79	79	// Create CodeIgniter instance
80		- if (! self::wiredesignzHmvcInstalled())
	80	+ if ( ! self::wiredesignzHmvcInstalled())
81	81	{
82	82	new CI_Controller();
83	83	}
		@@ -98,7 +98,7 @@ discard block
		block discarded – undo
98	98
99	99	public static function createCodeIgniterInstance()
100	100	{
101		- if (! self::wiredesignzHmvcInstalled())
	101	+ if ( ! self::wiredesignzHmvcInstalled())
102	102	{
103	103	new CI_Controller();
104	104	}
		@@ -127,11 +127,11 @@ discard block
		block discarded – undo
127	127	protected static function replaceLoader()
128	128	{
129	129	$my_loader_file =
130		- APPPATH . 'core/' . config_item('subclass_prefix') . 'Loader.php';
	130	+ APPPATH.'core/'.config_item('subclass_prefix').'Loader.php';
131	131
132	132	if (file_exists($my_loader_file))
133	133	{
134		- self::$loader_class = config_item('subclass_prefix') . 'Loader';
	134	+ self::$loader_class = config_item('subclass_prefix').'Loader';
135	135	if ( ! class_exists(self::$loader_class))
136	136	{
137	137	require $my_loader_file;
		@@ -150,19 +150,19 @@ discard block
		block discarded – undo
150	150
151	151	protected static function loadHelper($helper)
152	152	{
153		- $my_helper_file = APPPATH . 'helpers/' . config_item('subclass_prefix') . $helper . '.php';
	153	+ $my_helper_file = APPPATH.'helpers/'.config_item('subclass_prefix').$helper.'.php';
154	154	if (file_exists($my_helper_file))
155	155	{
156	156	require $my_helper_file;
157	157	}
158		- require __DIR__ . '/replacing/helpers/' . $helper . '.php';
	158	+ require __DIR__.'/replacing/helpers/'.$helper.'.php';
159	159	}
160	160
161	161	public static function setPatcherCacheDir($dir = null)
162	162	{
163	163	if ($dir === null)
164	164	{
165		- $dir = TESTPATH . '_ci_phpunit_test/tmp/cache';
	165	+ $dir = TESTPATH.'_ci_phpunit_test/tmp/cache';
166	166	}
167	167
168	168	MonkeyPatchManager::setCacheDir(

kenjis / ci-phpunit-test

Push — master ( da3f13...a1e877 )

Status

Category

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch