Completed
Pull Request — master (#271)
by Kenji
02:21
created
application/tests/_ci_phpunit_test/CIPHPUnitTest.php 2 patches
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 */
22 22
 	public static function init(array $autoload_dirs = null)
23 23
 	{
24
-		if (! defined('TESTPATH')) {
24
+		if ( ! defined('TESTPATH')) {
25 25
 			define('TESTPATH', APPPATH.'tests'.DIRECTORY_SEPARATOR);
26 26
 		}
27 27
 
@@ -38,38 +38,38 @@  discard block
 block discarded – undo
38 38
 		$cwd_backup = getcwd();
39 39
 
40 40
 		// Load autoloader for ci-phpunit-test
41
-		require __DIR__ . '/autoloader.php';
41
+		require __DIR__.'/autoloader.php';
42 42
 
43
-		require TESTPATH . 'TestCase.php';
43
+		require TESTPATH.'TestCase.php';
44 44
 
45
-		$db_test_case_file = TESTPATH . 'DbTestCase.php';
45
+		$db_test_case_file = TESTPATH.'DbTestCase.php';
46 46
 		if (is_readable($db_test_case_file))
47 47
 		{
48 48
 			require $db_test_case_file;
49 49
 		}
50 50
 
51
-		$unit_test_case_file = TESTPATH . 'UnitTestCase.php';
51
+		$unit_test_case_file = TESTPATH.'UnitTestCase.php';
52 52
 		if (is_readable($unit_test_case_file))
53 53
 		{
54 54
 			require $unit_test_case_file;
55 55
 		}
56 56
 
57 57
 		// Replace a few Common functions
58
-		require __DIR__ . '/replacing/core/Common.php';
59
-		require BASEPATH . 'core/Common.php';
58
+		require __DIR__.'/replacing/core/Common.php';
59
+		require BASEPATH.'core/Common.php';
60 60
 
61 61
 		// Workaround for missing CodeIgniter's error handler
62 62
 		// See https://github.com/kenjis/ci-phpunit-test/issues/37
63 63
 		set_error_handler('_error_handler');
64 64
 
65 65
 		// Load new functions of CIPHPUnitTest
66
-		require __DIR__ . '/functions.php';
66
+		require __DIR__.'/functions.php';
67 67
 		// Load ci-phpunit-test CI_Loader
68
-		require __DIR__ . '/replacing/core/Loader.php';
68
+		require __DIR__.'/replacing/core/Loader.php';
69 69
 		// Load ci-phpunit-test CI_Input
70
-		require __DIR__ . '/replacing/core/Input.php';
70
+		require __DIR__.'/replacing/core/Input.php';
71 71
 		// Load ci-phpunit-test CI_Output
72
-		require __DIR__ . '/replacing/core/Output.php';
72
+		require __DIR__.'/replacing/core/Output.php';
73 73
 
74 74
 		// Change current directory
75 75
 		chdir(FCPATH);
@@ -81,12 +81,12 @@  discard block
 block discarded – undo
81 81
 		 *
82 82
 		 * And away we go...
83 83
 		 */
84
-		require __DIR__ . '/replacing/core/CodeIgniter.php';
84
+		require __DIR__.'/replacing/core/CodeIgniter.php';
85 85
 
86 86
 		self::replaceHelpers();
87 87
 
88 88
 		// Create CodeIgniter instance
89
-		if (! self::wiredesignzHmvcInstalled())
89
+		if ( ! self::wiredesignzHmvcInstalled())
90 90
 		{
91 91
 			new CI_Controller();
92 92
 		}
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	 */
111 111
 	public static function createCodeIgniterInstance($use_my_controller = false)
112 112
 	{
113
-		if (! self::wiredesignzHmvcInstalled())
113
+		if ( ! self::wiredesignzHmvcInstalled())
114 114
 		{
115 115
 			if ($use_my_controller && self::hasMyController())
116 116
 			{
@@ -135,11 +135,11 @@  discard block
 block discarded – undo
135 135
 		}
136 136
 
137 137
 		$my_controller_file =
138
-			APPPATH . 'core/' . config_item('subclass_prefix') . 'Controller.php';
138
+			APPPATH.'core/'.config_item('subclass_prefix').'Controller.php';
139 139
 
140 140
 		if (file_exists($my_controller_file))
141 141
 		{
142
-			$controller_class = config_item('subclass_prefix') . 'Controller';
142
+			$controller_class = config_item('subclass_prefix').'Controller';
143 143
 			if ( ! class_exists($controller_class))
144 144
 			{
145 145
 				require $my_controller_file;
@@ -171,11 +171,11 @@  discard block
 block discarded – undo
171 171
 	protected static function replaceLoader()
172 172
 	{
173 173
 		$my_loader_file =
174
-			APPPATH . 'core/' . config_item('subclass_prefix') . 'Loader.php';
174
+			APPPATH.'core/'.config_item('subclass_prefix').'Loader.php';
175 175
 
176 176
 		if (file_exists($my_loader_file))
177 177
 		{
178
-			self::$loader_class = config_item('subclass_prefix') . 'Loader';
178
+			self::$loader_class = config_item('subclass_prefix').'Loader';
179 179
 			if ( ! class_exists(self::$loader_class))
180 180
 			{
181 181
 				require $my_loader_file;
@@ -194,19 +194,19 @@  discard block
 block discarded – undo
194 194
 
195 195
 	protected static function loadHelper($helper)
196 196
 	{
197
-		$my_helper_file = APPPATH . 'helpers/' . config_item('subclass_prefix') . $helper . '.php';
197
+		$my_helper_file = APPPATH.'helpers/'.config_item('subclass_prefix').$helper.'.php';
198 198
 		if (file_exists($my_helper_file))
199 199
 		{
200 200
 			require $my_helper_file;
201 201
 		}
202
-		require __DIR__ . '/replacing/helpers/' . $helper . '.php';
202
+		require __DIR__.'/replacing/helpers/'.$helper.'.php';
203 203
 	}
204 204
 
205 205
 	public static function setPatcherCacheDir($dir = null)
206 206
 	{
207 207
 		if ($dir === null)
208 208
 		{
209
-			$dir = TESTPATH . '_ci_phpunit_test/tmp/cache';
209
+			$dir = TESTPATH.'_ci_phpunit_test/tmp/cache';
210 210
 		}
211 211
 
212 212
 		MonkeyPatchManager::setCacheDir(
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -89,8 +89,7 @@  discard block
 block discarded – undo
89 89
 		if (! self::wiredesignzHmvcInstalled())
90 90
 		{
91 91
 			new CI_Controller();
92
-		}
93
-		else
92
+		} else
94 93
 		{
95 94
 			new MX_Controller();
96 95
 		}
@@ -115,13 +114,11 @@  discard block
 block discarded – undo
115 114
 			if ($use_my_controller && self::hasMyController())
116 115
 			{
117 116
 				new self::$controller_class;
118
-			}
119
-			else
117
+			} else
120 118
 			{
121 119
 				new CI_Controller();
122 120
 			}
123
-		}
124
-		else
121
+		} else
125 122
 		{
126 123
 			new CI();
127 124
 			new MX_Controller();
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/CIPHPUnitTestCase.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  */
10 10
 
11 11
 // Support PHPUnit 6.0
12
-if (! class_exists('PHPUnit_Framework_TestCase'))
12
+if ( ! class_exists('PHPUnit_Framework_TestCase'))
13 13
 {
14 14
 	class_alias('PHPUnit\Framework\TestCase', 'PHPUnit_Framework_TestCase');
15 15
 }
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 			return $this->$name;
70 70
 		}
71 71
 
72
-		throw new LogicException('No such property: ' . $name);
72
+		throw new LogicException('No such property: '.$name);
73 73
 	}
74 74
 
75 75
 	public static function setUpBeforeClass()
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 	{
100 100
 		reset_instance();
101 101
 		CIPHPUnitTest::createCodeIgniterInstance($use_my_controller);
102
-		$this->CI =& get_instance();
102
+		$this->CI = & get_instance();
103 103
 	}
104 104
 
105 105
 	protected function tearDown()
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
 		}
173 173
 
174 174
 		set_error_handler(
175
-			function ($errno, $errstr, $errfile, $errline) {
176
-				throw new RuntimeException($errstr . ' on line ' . $errline . ' in file ' . $errfile);
175
+			function($errno, $errstr, $errfile, $errline) {
176
+				throw new RuntimeException($errstr.' on line '.$errline.' in file '.$errfile);
177 177
 			}
178 178
 		);
179 179
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
 		$this->assertSame(
311 311
 			$code,
312 312
 			$actual,
313
-			'Status code is not ' . $code . ' but ' . $actual . '.'
313
+			'Status code is not '.$code.' but '.$actual.'.'
314 314
 		);
315 315
 	}
316 316
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 	 */
323 323
 	public function assertResponseHeader($name, $value)
324 324
 	{
325
-		$CI =& get_instance();
325
+		$CI = & get_instance();
326 326
 		$actual = $CI->output->get_header($name);
327 327
 
328 328
 		if ($actual === null)
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 	 */
347 347
 	public function assertResponseCookie($name, $value, $allow_duplicate = false)
348 348
 	{
349
-		$CI =& get_instance();
349
+		$CI = & get_instance();
350 350
 		$cookies = isset($CI->output->_cookies[$name])
351 351
 			? $CI->output->_cookies[$name] : null;
352 352
 
@@ -414,23 +414,23 @@  discard block
 block discarded – undo
414 414
 			$this->fail('redirect() is not called.');
415 415
 		}
416 416
 
417
-		if (! function_exists('site_url'))
417
+		if ( ! function_exists('site_url'))
418 418
 		{
419
-			$CI =& get_instance();
419
+			$CI = & get_instance();
420 420
 			$CI->load->helper('url');
421 421
 		}
422 422
 
423
-		if (! preg_match('#^(\w+:)?//#i', $uri))
423
+		if ( ! preg_match('#^(\w+:)?//#i', $uri))
424 424
 		{
425 425
 			$uri = site_url($uri);
426 426
 		}
427 427
 		$absolute_url = $uri;
428
-		$expected = 'Redirect to ' . $absolute_url;
428
+		$expected = 'Redirect to '.$absolute_url;
429 429
 
430 430
 		$this->assertSame(
431 431
 			$expected,
432 432
 			$status['redirect'],
433
-			'URL to redirect is not ' . $expected . ' but ' . $status['redirect'] . '.'
433
+			'URL to redirect is not '.$expected.' but '.$status['redirect'].'.'
434 434
 		);
435 435
 
436 436
 		if ($code !== null)
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 			$this->assertSame(
439 439
 				$code,
440 440
 				$status['code'],
441
-				'Status code is not ' . $code . ' but ' . $status['code'] . '.'
441
+				'Status code is not '.$code.' but '.$status['code'].'.'
442 442
 			);
443 443
 		}
444 444
 	}
Please login to merge, or discard this patch.