keeko / tools

src/command/GenerateActionCommand.php

Doc Comments +1 added lines, -2 removed lines

@@ -281,7 +281,6 @@ 
 	/**
 	 * Generates an action.
 	 *  
-	 * @param string $actionName
 	 * @param ActionSchema $action the action node from composer.json
 	 */
 	private function generateNamed($actionName) {
@@ -295,7 +294,7 @@ 
 	/**
 	 * Generates the action for the package
 	 * 
-	 * @param unknown $actionName
+	 * @param string $actionName
 	 * @throws \RuntimeException
 	 * @return ActionSchema
 	 */

Spacing +14 added lines, -14 removed lines

@@ -183,7 +183,7 @@ 
 	}
 
 	private function generateModel($modelName) {
-		$this->logger->info('Generate Action from Model: ' . $modelName);
+		$this->logger->info('Generate Action from Model: '.$modelName);
 		$input = $this->io->getInput();
 		$model = $this->modelService->getModel($modelName);
 		
@@ -202,7 +202,7 @@ 
 		foreach ($types as $type) {
 			$input->setOption('acl', ['admin']);
 			$input->setOption('type', $type);
-			$actionName = $modelName . '-' . $type;
+			$actionName = $modelName.'-'.$type;
 			
 			if ($model->isReadOnly() && in_array($type, ['create', 'update', 'delete'])) {
 				$this->logger->info(sprintf('Skip generate Action (%s), because Model (%s) is read-only', $actionName, $modelName));
@@ -246,13 +246,13 @@ 
 		$name = NameUtils::dasherize($modelName);
 		switch ($type) {
 			case 'list':
-				return 'List all ' . NameUtils::pluralize($name);
+				return 'List all '.NameUtils::pluralize($name);
 
 			case 'create':
 			case 'read':
 			case 'update':
 			case 'delete':
-				return ucfirst($type) . 's ' . (in_array($name[0], ['a', 'e', 'i', 'o', 'u']) ? 'an' : 'a') . ' ' . $name;
+				return ucfirst($type).'s '.(in_array($name[0], ['a', 'e', 'i', 'o', 'u']) ? 'an' : 'a').' '.$name;
 		}
 	}
 
@@ -285,7 +285,7 @@ 
 	 * @param ActionSchema $action the action node from composer.json
 	 */
 	private function generateNamed($actionName) {
-		$this->logger->info('Generate Action: ' . $actionName);
+		$this->logger->info('Generate Action: '.$actionName);
 		$action = $this->generateAction($actionName);
 		
 		// generate code
@@ -339,7 +339,7 @@ 
 	
 	private function guessClassname($name) {
 		$namespace = NamespaceResolver::getNamespace('src/action', $this->package);
-		return $namespace . '\\' . NameUtils::toStudlyCase($name) . 'Action';
+		return $namespace.'\\'.NameUtils::toStudlyCase($name).'Action';
 	}
 	
 	/**
@@ -398,14 +398,14 @@ 
 		// class
 		$class = new PhpClass($action->getClass());
 		$filename = $this->codegenService->getFilename($class);
-		$traitNs = $class->getNamespace() . '\\base';
-		$traitName = $class->getName() . 'Trait';
+		$traitNs = $class->getNamespace().'\\base';
+		$traitName = $class->getName().'Trait';
 		$overwrite = false;
 		
 		// load from file, when class exists
 		if (file_exists($filename)) {
 			// load trait
-			$trait = new PhpTrait($traitNs . '\\' . $traitName);
+			$trait = new PhpTrait($traitNs.'\\'.$traitName);
 			$traitFile = new File($this->codegenService->getFilename($trait));
 
 			if ($traitFile->exists()) {
@@ -430,7 +430,7 @@ 
 		if ($modelName !== null) {
 			$type = $this->packageService->getActionType($action->getName(), $modelName);
 			$generator = GeneratorFactory::createActionTraitGenerator($type, $this->service);
-			$trait = $generator->generate($traitNs . '\\' . $traitName, $action);
+			$trait = $generator->generate($traitNs.'\\'.$traitName, $action);
 
 			$this->codegenService->addAuthors($trait, $this->package);
 			$this->codegenService->dumpStruct($trait, true);
@@ -472,10 +472,10 @@ 
 		foreach (array_keys($generators) as $type) {
 			// generate fqcn
 			$className = sprintf('%s%s%sAction', $model->getPhpName(), $fkModelName, ucfirst($type));
-			$fqcn = $this->packageService->getNamespace() . '\\action\\' . $className;
+			$fqcn = $this->packageService->getNamespace().'\\action\\'.$className;
 	
 			// generate action
-			$action = new ActionSchema($actionNamePrefix . '-' . $type);
+			$action = new ActionSchema($actionNamePrefix.'-'.$type);
 			$action->addAcl('admin');
 			$action->setClass($fqcn);
 			$action->setTitle(str_replace(
@@ -513,10 +513,10 @@ 
 		foreach (array_keys($generators) as $type) {
 			// generate fqcn
 			$className = sprintf('%s%s%sAction', $model->getPhpName(), $fkModelName, ucfirst($type));
-			$fqcn = $this->packageService->getNamespace() . '\\action\\' . $className;
+			$fqcn = $this->packageService->getNamespace().'\\action\\'.$className;
 	
 			// generate action
-			$action = new ActionSchema($actionNamePrefix . '-' . $type);
+			$action = new ActionSchema($actionNamePrefix.'-'.$type);
 			$action->addAcl('admin');
 			$action->setClass($fqcn);
 			$action->setTitle(str_replace(

src/generator/action/AbstractModelActionGenerator.php

Doc Comments +1 added lines, -2 removed lines

@@ -11,9 +11,8 @@
 	/**
 	 * Generates an action trait with the given name as classname
 	 * 
-	 * @param string $name
 	 * @param ActionSchema $action
-	 * @return PhpTrait
+	 * @return PhpClass
 	 */
 	public function generate(ActionSchema $action) {
 		$class = PhpClass::create($action->getClass())

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 	 */
 	public function generate(ActionSchema $action) {
 		$class = PhpClass::create($action->getClass())
-			->setDescription('Action Class for ' . $action->getName())
+			->setDescription('Action Class for '.$action->getName())
 			->setLongDescription('This code is automatically created. Modifications will probably be overwritten.');
 	
 		$this->ensureBasicSetup($class);

src/generator/responder/AbstractModelJsonResponderGenerator.php

Doc Comments +4 added lines

@@ -32,6 +32,10 @@
 		);
 	}
 	
+	/**
+	 * @param string $name
+	 * @param string $body
+	 */
 	protected function generatePayloadMethod($name, $body) {
 		return PhpMethod::create($name)
 			->addParameter(PhpParameter::create('request')

Spacing +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
 			if ($rel['type'] == 'many') {
 				$typeName = NameUtils::pluralize($typeName);
 			}
-			$includes[] = (!empty($root) ? $root . '.' : '') . $typeName;
+			$includes[] = (!empty($root) ? $root.'.' : '').$typeName;
 			$includes = array_merge($includes, $this->getRelationshipIncludes($foreignModel, $typeName, $processed));
 		}
 	
@@ -98,7 +98,7 @@ 
 			if ($rel['type'] == 'many') {
 				$typeName = NameUtils::pluralize($typeName);
 			}
-			$name = (!empty($root) ? $root . '.' : '') . $typeName;
+			$name = (!empty($root) ? $root.'.' : '').$typeName;
 			
 			$fields[$name] = $foreignModel;
 			$fields = array_merge($fields, $this->getModelFields($foreignModel, $name, $processed));

src/command/GenerateDomainCommand.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
 	protected function initialize(InputInterface $input, OutputInterface $output) {
 		parent::initialize($input, $output);
 
-		$loader = new \Twig_Loader_Filesystem($this->service->getConfig()->getTemplateRoot() . '/domain');
+		$loader = new \Twig_Loader_Filesystem($this->service->getConfig()->getTemplateRoot().'/domain');
 		$this->twig = new \Twig_Environment($loader);
 	}
 
@@ -150,7 +150,7 @@ 
 	}
 
 	private function generateModel($modelName) {
-		$this->logger->info('Generate Domain from Model: ' . $modelName);
+		$this->logger->info('Generate Domain from Model: '.$modelName);
 		$model = $this->modelService->getModel($modelName);
 		
 		// generate class

src/command/GenerateResponseCommand.php

Spacing +8 added lines, -8 removed lines

@@ -140,7 +140,7 @@ 
 	}
 	
 	protected function generateResponse($actionName) {
-		$this->logger->info('Generate Response: ' . $actionName);
+		$this->logger->info('Generate Response: '.$actionName);
 		$module = $this->packageService->getModule();
 		
 		if (!$module->hasAction($actionName)) {
@@ -160,7 +160,7 @@ 
 		$modelName = $this->modelService->getModelNameByAction($action);
 
 		if (!$action->hasResponse($format)) {
-			$action->setResponse($format, str_replace(['Action', 'action'], [ucwords($format) . 'Responder', 'responder'], $action->getClass()));
+			$action->setResponse($format, str_replace(['Action', 'action'], [ucwords($format).'Responder', 'responder'], $action->getClass()));
 		}
 
 		// find generator
@@ -228,13 +228,13 @@ 
 			$foreign->getPhpName()
 		);
 		
-		$many = $module->hasAction($prefix . '-read')
-			&& $module->hasAction($prefix . '-update')
-			&& $module->hasAction($prefix . '-add')
-			&& $module->hasAction($prefix . '-remove')
+		$many = $module->hasAction($prefix.'-read')
+			&& $module->hasAction($prefix.'-update')
+			&& $module->hasAction($prefix.'-add')
+			&& $module->hasAction($prefix.'-remove')
 		;
-		$single = $module->hasAction($prefix . '-read')
-			&& $module->hasAction($prefix . '-update')
+		$single = $module->hasAction($prefix.'-read')
+			&& $module->hasAction($prefix.'-update')
 			&& !$many
 		;
 		

src/generator/action/ModelReadActionGenerator.php

Spacing +2 added lines, -2 removed lines

@@ -17,9 +17,9 @@
 		$this->addConfigureParamsMethod($class, $this->twig->render('read-configureParams.twig'));
 	
 		// method: run(Request $request)
-		$class->addUseStatement(str_replace('model', 'domain', $model->getNamespace()) . '\\' . $model->getPhpName() . 'Domain');
+		$class->addUseStatement(str_replace('model', 'domain', $model->getNamespace()).'\\'.$model->getPhpName().'Domain');
 		$class->setMethod($this->generateRunMethod($this->twig->render('read-run.twig', [
-			'domain' => $model->getPhpName() . 'Domain'
+			'domain' => $model->getPhpName().'Domain'
 		])));
 	}
 	

src/generator/action/ModelListActionGenerator.php

Spacing +2 added lines, -2 removed lines

@@ -15,9 +15,9 @@
 
 		// method: run(Request $request)
 		$class->addUseStatement('Tobscure\\JsonApi\\Parameters');
-		$class->addUseStatement(str_replace('model', 'domain', $model->getNamespace()) . '\\' . $model->getPhpName() . 'Domain');
+		$class->addUseStatement(str_replace('model', 'domain', $model->getNamespace()).'\\'.$model->getPhpName().'Domain');
 		$class->setMethod($this->generateRunMethod($this->twig->render('list-run.twig', [
-			'domain' => $model->getPhpName() . 'Domain'
+			'domain' => $model->getPhpName().'Domain'
 		])));
 			
 	}

src/generator/action/ToOneRelationshipReadActionGenerator.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 		$this->addConfigureParamsMethod($class, $this->twig->render('relationship-configureParams.twig'));
 
 		// method: run(Request $request) : Response
-		$class->addUseStatement($model->getNamespace() . '\\' . $model->getPhpName() . 'Query');
+		$class->addUseStatement($model->getNamespace().'\\'.$model->getPhpName().'Query');
 		$class->setMethod($this->generateRunMethod($this->twig->render('to-one-read-run.twig', [
 			'model' => $model->getCamelCaseName(),
 			'class' => $model->getPhpName()

src/generator/action/ToOneRelationshipUpdateActionGenerator.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 		$class->addUseStatement('keeko\\framework\\exceptions\\ValidationException'); 
 		$class->addUseStatement('Tobscure\\JsonApi\\Exception\\InvalidParameterException');
 		$class->addUseStatement('phootwork\\json\\Json');
-		$class->addUseStatement($model->getNamespace() . '\\' . $model->getPhpName() . 'Query');
+		$class->addUseStatement($model->getNamespace().'\\'.$model->getPhpName().'Query');
 		$class->setMethod($this->generateRunMethod($this->twig->render('to-one-update-run.twig', [
 			'model' => $model->getCamelCaseName(),
 			'class' => $model->getPhpName(),