Inspection of "Working generate commands" - keeko/tools - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( eadaa3...ee6db2 )

by Thomas

created 2015-12-11 16:50 UTC

Status

Switch Indentation +53 added lines, -53 removed lines patch added patch discarded remove patch

@@ -76,20 +76,20 @@  discard block
 block discarded – undo
 	
 		// find path branch
 		switch ($type) {
-			case 'list':
-			case 'create':
-				$endpoint = '/' . $modelPluralName;
-				break;
-	
-			case 'read':
-			case 'update':
-			case 'delete':
-				$endpoint = '/' . $modelPluralName . '/{id}';
-				break;
-	
-			default:
-				throw new \RuntimeException('type (%s) not found, can\'t continue.');
-				break;
+		case 'list':
+		case 'create':
+			$endpoint = '/' . $modelPluralName;
+			break;
+	
+		case 'read':
+		case 'update':
+		case 'delete':
+			$endpoint = '/' . $modelPluralName . '/{id}';
+			break;
+	
+		default:
+			throw new \RuntimeException('type (%s) not found, can\'t continue.');
+			break;
 		}
 	
 	
@@ -104,45 +104,45 @@  discard block
 block discarded – undo
 		$responses = $operation->getResponses();
 	
 		switch ($type) {
-			case 'list':
-				$ok = $responses->get('200');
-				$ok->setDescription(sprintf('Array of %s', $modelPluralName));
-				$ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
-				break;
-	
-			case 'create':
-				// params
-				$body = $params->getByName('body');
-				$body->setName('body');
-				$body->setIn('body');
-				$body->setDescription(sprintf('The new %s', $modelName));
-				$body->setRequired(true);
-				$body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
-	
-				// response
-				$ok = $responses->get('201');
-				$ok->setDescription(sprintf('%s created', $modelName));
-				break;
-	
-			case 'read':
-				// response
-				$ok = $responses->get('200');
-				$ok->setDescription(sprintf('gets the %s', $modelName));
-				$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
-				break;
-	
-			case 'update':
-				// response
-				$ok = $responses->get('200');
-				$ok->setDescription(sprintf('%s updated', $modelName));
-				$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
-				break;
-	
-			case 'delete':
-				// response
-				$ok = $responses->get('204');
-				$ok->setDescription(sprintf('%s deleted', $modelName));
-				break;
+		case 'list':
+			$ok = $responses->get('200');
+			$ok->setDescription(sprintf('Array of %s', $modelPluralName));
+			$ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
+			break;
+	
+		case 'create':
+			// params
+			$body = $params->getByName('body');
+			$body->setName('body');
+			$body->setIn('body');
+			$body->setDescription(sprintf('The new %s', $modelName));
+			$body->setRequired(true);
+			$body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
+	
+			// response
+			$ok = $responses->get('201');
+			$ok->setDescription(sprintf('%s created', $modelName));
+			break;
+	
+		case 'read':
+			// response
+			$ok = $responses->get('200');
+			$ok->setDescription(sprintf('gets the %s', $modelName));
+			$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
+			break;
+	
+		case 'update':
+			// response
+			$ok = $responses->get('200');
+			$ok->setDescription(sprintf('%s updated', $modelName));
+			$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
+			break;
+	
+		case 'delete':
+			// response
+			$ok = $responses->get('204');
+			$ok->setDescription(sprintf('%s deleted', $modelName));
+			break;
 		}
 	
 		if ($type == 'read' || $type == 'update' || $type == 'delete') {

Please login to merge, or discard this patch.

		@@ -76,20 +76,20 @@ discard block
		block discarded – undo
76	76
77	77	// find path branch
78	78	switch ($type) {
79		- case 'list':
80		- case 'create':
81		- $endpoint = '/' . $modelPluralName;
82		- break;
83		-
84		- case 'read':
85		- case 'update':
86		- case 'delete':
87		- $endpoint = '/' . $modelPluralName . '/{id}';
88		- break;
89		-
90		- default:
91		- throw new \RuntimeException('type (%s) not found, can\'t continue.');
92		- break;
	79	+ case 'list':
	80	+ case 'create':
	81	+ $endpoint = '/' . $modelPluralName;
	82	+ break;
	83	+
	84	+ case 'read':
	85	+ case 'update':
	86	+ case 'delete':
	87	+ $endpoint = '/' . $modelPluralName . '/{id}';
	88	+ break;
	89	+
	90	+ default:
	91	+ throw new \RuntimeException('type (%s) not found, can\'t continue.');
	92	+ break;
93	93	}
94	94
95	95
		@@ -104,45 +104,45 @@ discard block
		block discarded – undo
104	104	$responses = $operation->getResponses();
105	105
106	106	switch ($type) {
107		- case 'list':
108		- $ok = $responses->get('200');
109		- $ok->setDescription(sprintf('Array of %s', $modelPluralName));
110		- $ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
111		- break;
112		-
113		- case 'create':
114		- // params
115		- $body = $params->getByName('body');
116		- $body->setName('body');
117		- $body->setIn('body');
118		- $body->setDescription(sprintf('The new %s', $modelName));
119		- $body->setRequired(true);
120		- $body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
121		-
122		- // response
123		- $ok = $responses->get('201');
124		- $ok->setDescription(sprintf('%s created', $modelName));
125		- break;
126		-
127		- case 'read':
128		- // response
129		- $ok = $responses->get('200');
130		- $ok->setDescription(sprintf('gets the %s', $modelName));
131		- $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
132		- break;
133		-
134		- case 'update':
135		- // response
136		- $ok = $responses->get('200');
137		- $ok->setDescription(sprintf('%s updated', $modelName));
138		- $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
139		- break;
140		-
141		- case 'delete':
142		- // response
143		- $ok = $responses->get('204');
144		- $ok->setDescription(sprintf('%s deleted', $modelName));
145		- break;
	107	+ case 'list':
	108	+ $ok = $responses->get('200');
	109	+ $ok->setDescription(sprintf('Array of %s', $modelPluralName));
	110	+ $ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
	111	+ break;
	112	+
	113	+ case 'create':
	114	+ // params
	115	+ $body = $params->getByName('body');
	116	+ $body->setName('body');
	117	+ $body->setIn('body');
	118	+ $body->setDescription(sprintf('The new %s', $modelName));
	119	+ $body->setRequired(true);
	120	+ $body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
	121	+
	122	+ // response
	123	+ $ok = $responses->get('201');
	124	+ $ok->setDescription(sprintf('%s created', $modelName));
	125	+ break;
	126	+
	127	+ case 'read':
	128	+ // response
	129	+ $ok = $responses->get('200');
	130	+ $ok->setDescription(sprintf('gets the %s', $modelName));
	131	+ $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
	132	+ break;
	133	+
	134	+ case 'update':
	135	+ // response
	136	+ $ok = $responses->get('200');
	137	+ $ok->setDescription(sprintf('%s updated', $modelName));
	138	+ $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
	139	+ break;
	140	+
	141	+ case 'delete':
	142	+ // response
	143	+ $ok = $responses->get('204');
	144	+ $ok->setDescription(sprintf('%s deleted', $modelName));
	145	+ break;
146	146	}
147	147
148	148	if ($type == 'read' \|\| $type == 'update' \|\| $type == 'delete') {

keeko / tools

Push — master ( eadaa3...ee6db2 )

Status

Category

Switch Indentation +53 added lines, -53 removed lines patch added patch discarded remove patch