Inspection of "Update" - keeko/tools - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 17137d...17de33 )

by Thomas

created 2016-01-02 14:47 UTC

Status

Switch Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch

@@ -87,20 +87,20 @@  discard block
 block discarded – undo
 	
 		// find path branch
 		switch ($type) {
-			case 'list':
-			case 'create':
-				$endpoint = '/' . $modelPluralName;
-				break;
+		case 'list':
+		case 'create':
+			$endpoint = '/' . $modelPluralName;
+			break;
 	
-			case 'read':
-			case 'update':
-			case 'delete':
-				$endpoint = '/' . $modelPluralName . '/{id}';
-				break;
+		case 'read':
+		case 'update':
+		case 'delete':
+			$endpoint = '/' . $modelPluralName . '/{id}';
+			break;
 	
-			default:
-				throw new \RuntimeException('type (%s) not found, can\'t continue.');
-				break;
+		default:
+			throw new \RuntimeException('type (%s) not found, can\'t continue.');
+			break;
 		}
 	
 	
@@ -115,45 +115,45 @@  discard block
 block discarded – undo
 		$responses = $operation->getResponses();
 	
 		switch ($type) {
-			case 'list':
-				$ok = $responses->get('200');
-				$ok->setDescription(sprintf('Array of %s', $modelPluralName));
-				$ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
-				break;
+		case 'list':
+			$ok = $responses->get('200');
+			$ok->setDescription(sprintf('Array of %s', $modelPluralName));
+			$ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
+			break;
 	
-			case 'create':
-				// params
-				$body = $params->getByName('body');
-				$body->setName('body');
-				$body->setIn('body');
-				$body->setDescription(sprintf('The new %s', $modelName));
-				$body->setRequired(true);
-				$body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
+		case 'create':
+			// params
+			$body = $params->getByName('body');
+			$body->setName('body');
+			$body->setIn('body');
+			$body->setDescription(sprintf('The new %s', $modelName));
+			$body->setRequired(true);
+			$body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
 	
-				// response
-				$ok = $responses->get('201');
-				$ok->setDescription(sprintf('%s created', $modelName));
-				break;
+			// response
+			$ok = $responses->get('201');
+			$ok->setDescription(sprintf('%s created', $modelName));
+			break;
 	
-			case 'read':
-				// response
-				$ok = $responses->get('200');
-				$ok->setDescription(sprintf('gets the %s', $modelName));
-				$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
-				break;
+		case 'read':
+			// response
+			$ok = $responses->get('200');
+			$ok->setDescription(sprintf('gets the %s', $modelName));
+			$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
+			break;
 	
-			case 'update':
-				// response
-				$ok = $responses->get('200');
-				$ok->setDescription(sprintf('%s updated', $modelName));
-				$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
-				break;
+		case 'update':
+			// response
+			$ok = $responses->get('200');
+			$ok->setDescription(sprintf('%s updated', $modelName));
+			$ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
+			break;
 	
-			case 'delete':
-				// response
-				$ok = $responses->get('204');
-				$ok->setDescription(sprintf('%s deleted', $modelName));
-				break;
+		case 'delete':
+			// response
+			$ok = $responses->get('204');
+			$ok->setDescription(sprintf('%s deleted', $modelName));
+			break;
 		}
 	
 		if ($type == 'read' || $type == 'update' || $type == 'delete') {

Please login to merge, or discard this patch.

		@@ -87,20 +87,20 @@ discard block
		block discarded – undo
87	87
88	88	// find path branch
89	89	switch ($type) {
90		- case 'list':
91		- case 'create':
92		- $endpoint = '/' . $modelPluralName;
93		- break;
	90	+ case 'list':
	91	+ case 'create':
	92	+ $endpoint = '/' . $modelPluralName;
	93	+ break;
94	94
95		- case 'read':
96		- case 'update':
97		- case 'delete':
98		- $endpoint = '/' . $modelPluralName . '/{id}';
99		- break;
	95	+ case 'read':
	96	+ case 'update':
	97	+ case 'delete':
	98	+ $endpoint = '/' . $modelPluralName . '/{id}';
	99	+ break;
100	100
101		- default:
102		- throw new \RuntimeException('type (%s) not found, can\'t continue.');
103		- break;
	101	+ default:
	102	+ throw new \RuntimeException('type (%s) not found, can\'t continue.');
	103	+ break;
104	104	}
105	105
106	106
		@@ -115,45 +115,45 @@ discard block
		block discarded – undo
115	115	$responses = $operation->getResponses();
116	116
117	117	switch ($type) {
118		- case 'list':
119		- $ok = $responses->get('200');
120		- $ok->setDescription(sprintf('Array of %s', $modelPluralName));
121		- $ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
122		- break;
	118	+ case 'list':
	119	+ $ok = $responses->get('200');
	120	+ $ok->setDescription(sprintf('Array of %s', $modelPluralName));
	121	+ $ok->getSchema()->setRef('#/definitions/' . 'Paged' . NameUtils::pluralize($modelObjectName));
	122	+ break;
123	123
124		- case 'create':
125		- // params
126		- $body = $params->getByName('body');
127		- $body->setName('body');
128		- $body->setIn('body');
129		- $body->setDescription(sprintf('The new %s', $modelName));
130		- $body->setRequired(true);
131		- $body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
	124	+ case 'create':
	125	+ // params
	126	+ $body = $params->getByName('body');
	127	+ $body->setName('body');
	128	+ $body->setIn('body');
	129	+ $body->setDescription(sprintf('The new %s', $modelName));
	130	+ $body->setRequired(true);
	131	+ $body->getSchema()->setRef('#/definitions/Writable' . $modelObjectName);
132	132
133		- // response
134		- $ok = $responses->get('201');
135		- $ok->setDescription(sprintf('%s created', $modelName));
136		- break;
	133	+ // response
	134	+ $ok = $responses->get('201');
	135	+ $ok->setDescription(sprintf('%s created', $modelName));
	136	+ break;
137	137
138		- case 'read':
139		- // response
140		- $ok = $responses->get('200');
141		- $ok->setDescription(sprintf('gets the %s', $modelName));
142		- $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
143		- break;
	138	+ case 'read':
	139	+ // response
	140	+ $ok = $responses->get('200');
	141	+ $ok->setDescription(sprintf('gets the %s', $modelName));
	142	+ $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
	143	+ break;
144	144
145		- case 'update':
146		- // response
147		- $ok = $responses->get('200');
148		- $ok->setDescription(sprintf('%s updated', $modelName));
149		- $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
150		- break;
	145	+ case 'update':
	146	+ // response
	147	+ $ok = $responses->get('200');
	148	+ $ok->setDescription(sprintf('%s updated', $modelName));
	149	+ $ok->getSchema()->setRef('#/definitions/' . $modelObjectName);
	150	+ break;
151	151
152		- case 'delete':
153		- // response
154		- $ok = $responses->get('204');
155		- $ok->setDescription(sprintf('%s deleted', $modelName));
156		- break;
	152	+ case 'delete':
	153	+ // response
	154	+ $ok = $responses->get('204');
	155	+ $ok->setDescription(sprintf('%s deleted', $modelName));
	156	+ break;
157	157	}
158	158
159	159	if ($type == 'read' \|\| $type == 'update' \|\| $type == 'delete') {

keeko / tools

Push — master ( 17137d...17de33 )

Status

Category

Switch Indentation +46 added lines, -46 removed lines patch added patch discarded remove patch