kamilabs / api-core-bundle

RequestProcessor/Step/Common/PersistStep.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     {
         $entity = $this->getArtifact('entity');
 
-        if(true !== $this->getArtifact('validation')) {
+        if (true !== $this->getArtifact('validation')) {
             return new ArtifactCollection();
         }
 

Tests/RequestProcessor/Step/Filter/ValidateFiltersTest.php

Spacing +1 added lines, -1 removed lines

@@ -23,6 +23,6 @@
 
         $response = $step->execute($request);
         $this->assertInstanceOf(ArtifactCollection::class, $response);
-        $this->assertEquals([0 => ['type' => 'eq','property' => 'title','value' => 'test']], $response->get('filters')->getValue());
+        $this->assertEquals([0 => ['type' => 'eq', 'property' => 'title', 'value' => 'test']], $response->get('filters')->getValue());
     }
 }

Stenographer/Stenographer.php

Braces +3 added lines, -1 removed lines

@@ -216,7 +216,9 @@
                 $annotation instanceof OneToMany ||
                 $annotation instanceof ManyToOne ||
                 $annotation instanceof ManyToMany
-            ) $targetEntity = $annotation->targetEntity;
+            ) {
+                $targetEntity = $annotation->targetEntity;
+            }
         }
 
         return str_replace('_', '-', Inflector::tableize(substr($targetEntity, strripos($targetEntity, '\\') + 1)));

Spacing +7 added lines, -9 removed lines

@@ -177,7 +177,7 @@ 
     private function getReturnedParams($route, $anonymousClass, $canAccessClass)
     {
         $reflection = $this->getEntityReflection($route->getDefault('_entity'));
-        $availableParams = $reflection->getName() . "\n";
+        $availableParams = $reflection->getName()."\n";
 
         foreach ($reflection->getProperties() as $property) {
             $anonymous = $this->reader->getPropertyAnnotation($property, $anonymousClass);
@@ -189,10 +189,9 @@ 
                 $availableAccess = $access ? $access->roles : $availableAccess;
                 $availableAccess = implode(', ', $availableAccess);
 
-                $availableParams .= Inflector::tableize($property->getName()) . ':';
-                $availableParams .= $relation ? '<a href="#operations-tag-'.$this->getRelatedPropertyModelName($property).'">Related model</a>' :
-                    ($column ? $column->type : 'Unknown');
-                $availableParams .= ', Access: ' . $availableAccess . "\n";
+                $availableParams .= Inflector::tableize($property->getName()).':';
+                $availableParams .= $relation ? '<a href="#operations-tag-'.$this->getRelatedPropertyModelName($property).'">Related model</a>' : ($column ? $column->type : 'Unknown');
+                $availableParams .= ', Access: '.$availableAccess."\n";
             }
         }
 
@@ -246,8 +245,7 @@ 
 
                 $param['description'] = $relation ?
                     '<a href="#operations-tag-'.$this->getRelatedPropertyModelName($property).'">'.
-                    'Related model description</a><pre>Access: ' . $availableAccess . '</pre>' :
-                    '<pre>Access: ' . $availableAccess . '</pre>';
+                    'Related model description</a><pre>Access: '.$availableAccess.'</pre>' : '<pre>Access: '.$availableAccess.'</pre>';
 
                 $availableParams[] = $param;
             }
@@ -259,8 +257,8 @@ 
     private function getRelatedPropertyModelName($property)
     {
         $annotations = $this->reader->getPropertyAnnotations($property);
-        foreach ($annotations as $annotation){
-            if(
+        foreach ($annotations as $annotation) {
+            if (
                 $annotation instanceof OneToOne ||
                 $annotation instanceof OneToMany ||
                 $annotation instanceof ManyToOne ||

RequestProcessor/Step/Common/SortStep.php

Spacing +9 added lines, -12 removed lines

@@ -50,23 +50,20 @@
         $reflection = $this->getArtifact('reflection');
         $query = 'e.%s';
 
-        if(strripos($sort, '.')){
+        if (strripos($sort, '.')) {
             $sort = explode('.', $sort);
-            if($reflection->hasProperty(Inflector::camelize($sort[0]))){
+            if ($reflection->hasProperty(Inflector::camelize($sort[0]))) {
                 $property = $reflection->getProperty(Inflector::camelize($sort[0]));
-                $ann = $this->reader->getPropertyAnnotation($property, OneToOne::class)?:
-                    $this->reader->getPropertyAnnotation($property, OneToMany::class)?:
-                        $this->reader->getPropertyAnnotation($property, ManyToMany::class)?:
-                            $this->reader->getPropertyAnnotation($property, ManyToOne::class)?:null;
-                if($ann){
+                $ann = $this->reader->getPropertyAnnotation($property, OneToOne::class) ?: $this->reader->getPropertyAnnotation($property, OneToMany::class) ?: $this->reader->getPropertyAnnotation($property, ManyToMany::class) ?: $this->reader->getPropertyAnnotation($property, ManyToOne::class) ?: null;
+                if ($ann) {
                     $reflection = new \ReflectionClass($ann->targetEntity);
-                    $query = $sort[0] . '.%s';
+                    $query = $sort[0].'.%s';
                     $sort = Inflector::camelize(($sort[1]));
-                } else{
-                    throw new BadRequestHttpException('Related property ' . Inflector::camelize($sort[0]) . ' isn\'t related model in sort field');
+                } else {
+                    throw new BadRequestHttpException('Related property '.Inflector::camelize($sort[0]).' isn\'t related model in sort field');
                 }
-            } else{
-                throw new BadRequestHttpException('Related property ' . Inflector::camelize($sort[0]) . ' not found in sort field');
+            } else {
+                throw new BadRequestHttpException('Related property '.Inflector::camelize($sort[0]).' not found in sort field');
             }
         }
 

RequestProcessor/Step/Filter/FilterStep.php

Braces +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
                         } else {
                             throw new BadRequestHttpException('Related property ' . $filtr[1] . ' not found in related model ' . $filtr[0] . ' in filter field');
                         }
-                    }else{
+                    } else{
                         throw new BadRequestHttpException('Property ' . $filtr[0] . ' isn\'t related model in filter field');
                     }
                 } else{

Spacing +14 added lines, -17 removed lines

@@ -40,29 +40,26 @@ 
             $reflection = $this->getArtifact('reflection');
 
             $queryModel = 'e';
-            if(strripos($filter['property'], '.')){
+            if (strripos($filter['property'], '.')) {
                 $filtr = explode('.', $filter['property']);
-                if($reflection->hasProperty(Inflector::camelize($filtr[0]))){
+                if ($reflection->hasProperty(Inflector::camelize($filtr[0]))) {
                     $property = $reflection->getProperty(Inflector::camelize($filtr[0]));
-                    $ann = $this->reader->getPropertyAnnotation($property, OneToOne::class)?:
-                            $this->reader->getPropertyAnnotation($property, OneToMany::class)?:
-                            $this->reader->getPropertyAnnotation($property, ManyToMany::class)?:
-                            $this->reader->getPropertyAnnotation($property, ManyToOne::class)?:null;
-                    if($ann){
+                    $ann = $this->reader->getPropertyAnnotation($property, OneToOne::class) ?: $this->reader->getPropertyAnnotation($property, OneToMany::class) ?: $this->reader->getPropertyAnnotation($property, ManyToMany::class) ?: $this->reader->getPropertyAnnotation($property, ManyToOne::class) ?: null;
+                    if ($ann) {
                         $reflection = new \ReflectionClass($ann->targetEntity);
-                        if($reflection->hasProperty(Inflector::camelize($filtr[1]))){
+                        if ($reflection->hasProperty(Inflector::camelize($filtr[1]))) {
                             $property = $reflection->getProperty(Inflector::camelize($filtr[1]));
                             $filter['property'] = Inflector::camelize($filtr[1]);
                             $queryBuilder->leftJoin(sprintf('e.%s', $filtr[0]), $filtr[0]{0});
                             $queryModel = Inflector::camelize($filtr[0]{0});
                         } else {
-                            throw new BadRequestHttpException('Related property ' . $filtr[1] . ' not found in related model ' . $filtr[0] . ' in filter field');
+                            throw new BadRequestHttpException('Related property '.$filtr[1].' not found in related model '.$filtr[0].' in filter field');
                         }
-                    }else{
-                        throw new BadRequestHttpException('Property ' . $filtr[0] . ' isn\'t related model in filter field');
+                    } else {
+                        throw new BadRequestHttpException('Property '.$filtr[0].' isn\'t related model in filter field');
                     }
-                } else{
-                    throw new BadRequestHttpException('Related property ' . $filtr[0] . ' not found in filter field');
+                } else {
+                    throw new BadRequestHttpException('Related property '.$filtr[0].' not found in filter field');
                 }
             }
 
@@ -111,12 +108,12 @@ 
                 sprintf(
                     $queryModel.'.%s BETWEEN :%s_min_value AND :%s_max_value',
                     $filter['property'],
-                    $filter['property'].($index+10),
-                    $filter['property'].($index+11)
+                    $filter['property'].($index + 10),
+                    $filter['property'].($index + 11)
                 )
             )
-            ->setParameter(sprintf('%s_min_value', $filter['property'].($index+10)), $filter['min'])
-            ->setParameter(sprintf('%s_max_value', $filter['property'].($index+11)), $filter['max']);
+            ->setParameter(sprintf('%s_min_value', $filter['property'].($index + 10)), $filter['min'])
+            ->setParameter(sprintf('%s_max_value', $filter['property'].($index + 11)), $filter['max']);
         ;
     }
 

Tests/DependencyInjection/ConfigurationTest.php

Indentation +6 added lines, -6 removed lines

@@ -8,11 +8,11 @@
 
 class ConfigurationTest extends TestCase
 {
-   public function testCanByConstructed ()
-   {
-       $configuration = new Configuration();
-       $treeBuilder = $configuration->getConfigTreeBuilder();
+    public function testCanByConstructed ()
+    {
+        $configuration = new Configuration();
+        $treeBuilder = $configuration->getConfigTreeBuilder();
 
-       $this->assertInstanceOf(TreeBuilder::class, $treeBuilder);
-   }
+        $this->assertInstanceOf(TreeBuilder::class, $treeBuilder);
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 
 class ConfigurationTest extends TestCase
 {
-   public function testCanByConstructed ()
+   public function testCanByConstructed()
    {
        $configuration = new Configuration();
        $treeBuilder = $configuration->getConfigTreeBuilder();

Tests/Bridge/JmsSerializer/ContextFactory/ApiContextFactoryTest.php

Spacing +2 added lines, -2 removed lines

@@ -7,14 +7,14 @@
 
 class ApiContextFactoryTest extends TestCase
 {
-    public function testCanBrCreated ()
+    public function testCanBrCreated()
     {
         $accessManagermMock = $this->createMock(AccessManager::class);
         $contextFactory = new ApiContextFactory($accessManagermMock);
         $this->assertInstanceOf(ApiContextFactory::class, $contextFactory);
     }
 
-    public function testCreateSerializationContext ()
+    public function testCreateSerializationContext()
     {
         $accessManagermMock = $this->createMock(AccessManager::class);
         $contextFactory = new ApiContextFactory($accessManagermMock);

Tests/RequestProcessor/Step/Common/FetchEntityByIdStepTest.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
         $this->assertInstanceOf(MyModel::class, $response->get('entity')->getValue());
     }
 
-    public function testFailureExecuteWithoutEntity ()
+    public function testFailureExecuteWithoutEntity()
     {
         $repositoryMock = $this->createMock(TestRepository::class);
         $repositoryMock->expects($this->at(0))->method('find')->willReturn(null);
@@ -57,7 +57,7 @@ 
         $registry->expects($this->any())->method('getRepository')->willReturn($repositoryMock);
         $step = new FetchEntityByIdStep($registry);
         $step->setArtifacts(new ArtifactCollection([
-            new Artifact('reflection',  new \ReflectionClass(MyModel::class))
+            new Artifact('reflection', new \ReflectionClass(MyModel::class))
         ]));
 
         $this->expectException(NotFoundHttpException::class);

Tests/Filter/FilterValidatorTest.php

Indentation +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         $this->expectException(BadRequestHttpException::class);
         $request->attributes->set('filter', base64_encode('[{"type": "eq", "value": "test"}]'));
         $this->expectException(BadRequestHttpException::class);
-          new Validator($request);
+            new Validator($request);
     }
 
 }
\ No newline at end of file

Spacing +3 added lines, -3 removed lines

@@ -10,7 +10,7 @@ 
 class FilterValidatorTest extends TestCase
 {
 
-    public function testCanBeConstructed ()
+    public function testCanBeConstructed()
     {
         $request = new Request();
         $request->attributes->set('filter', base64_encode('[{"type": "eq", "property": "title", "value": "test"}]'));
@@ -19,7 +19,7 @@ 
         $this->assertInstanceOf(Validator::class, $filterValidator);
     }
 
-    public function testFilterRequestWithBadType ()
+    public function testFilterRequestWithBadType()
     {
         $this->expectException(BadRequestHttpException::class);
         $request = new Request();
@@ -28,7 +28,7 @@ 
 
     }
 
-    public function testFilterRequestWithoutRequiredParameter ()
+    public function testFilterRequestWithoutRequiredParameter()
     {
         $request = new Request();
         $this->expectException(BadRequestHttpException::class);