kamilabs / api-core-bundle

Security/AccessManager.php

Indentation -1 removed lines

@@ -24,7 +24,6 @@
 
     /**
      * @var Reader
-
      */
     private $annotationReader;
 

Tests/Manager/ApiManagerTest.php

Spacing +3 added lines, -3 removed lines

@@ -442,13 +442,13 @@
             ->disableOriginalClone()
             ->getMock();
 
-        if($expectedMethod){
-            if($methodParameter){
+        if ($expectedMethod) {
+            if ($methodParameter) {
                 $mock->expects($this->any())
                     ->method($expectedMethod)
                     ->with($methodParameter)
                     ->willReturn($willReturn);
-            } else{
+            } else {
                 $mock->expects($this->any())
                     ->method($expectedMethod)
                     ->willReturn($willReturn);

Tests/Security/AccessManagerTest.php

Spacing +5 added lines, -5 removed lines

@@ -197,7 +197,7 @@ 
         $reflection = $this->mock(\ReflectionProperty::class);
 
         $access = new CanBeCreatedBy();
-        $access->roles = ['ROLE_USER','ROLE_ADMIN'];
+        $access->roles = ['ROLE_USER', 'ROLE_ADMIN'];
         $annReader = $this->mock(Reader::class, 'getPropertyAnnotations', [$access], $reflection);
 
         $accessManager = new AccessManager($tokenStorageMock, $annReader);
@@ -405,7 +405,7 @@ 
         $reflection = $this->mock(\ReflectionClass::class);
 
         $access = new CanBeDeletedBy();
-        $access->roles = ['ROLE_USER','ROLE_ADMIN'];
+        $access->roles = ['ROLE_USER', 'ROLE_ADMIN'];
         $annReader = $this->mock(Reader::class, 'getClassAnnotations', [$access], $reflection);
 
         $accessManager = new AccessManager($tokenStorageMock, $annReader);
@@ -463,13 +463,13 @@ 
     {
         $mock = $this->createMock($class);
 
-        if($expectedMethod){
-            if($methodParameter){
+        if ($expectedMethod) {
+            if ($methodParameter) {
                 $mock->expects($this->any())
                     ->method($expectedMethod)
                     ->with($methodParameter)
                     ->willReturn($willReturn);
-            } else{
+            } else {
                 $mock->expects($this->any())
                     ->method($expectedMethod)
                     ->willReturn($willReturn);

Tests/Form/FactoryTest.php

Spacing +5 added lines, -5 removed lines

@@ -34,7 +34,7 @@ 
 
         $factory = new Factory($formFactory, $reader, $accessManager);
 
-        $this->assertEquals('OK',  $factory->getCreateForm($entity));
+        $this->assertEquals('OK', $factory->getCreateForm($entity));
     }
 
     public function testFactoryGetEditForm()
@@ -48,7 +48,7 @@ 
 
         $factory = new Factory($formFactory, $reader, $accessManager);
 
-        $this->assertEquals('OK',  $factory->getEditForm($entity));
+        $this->assertEquals('OK', $factory->getEditForm($entity));
     }
 
     private function mock($class, $expectedMethod = null, $willReturn = null, $methodParameter = null)
@@ -57,13 +57,13 @@ 
             ->disableOriginalConstructor()
             ->getMock();
 
-        if($expectedMethod){
-            if($methodParameter){
+        if ($expectedMethod) {
+            if ($methodParameter) {
                 $mock->expects($this->any())
                     ->method($expectedMethod)
                     ->with($methodParameter)
                     ->willReturn($willReturn);
-            } else{
+            } else {
                 $mock->expects($this->any())
                     ->method($expectedMethod)
                     ->willReturn($willReturn);

Manager/ApiManager.php

Spacing +6 added lines, -6 removed lines

@@ -107,18 +107,18 @@ 
     public function filter(Request $request)
     {
         $entity = new \ReflectionClass($request->attributes->get('_entity'));
-        if(!$this->accessManager->canAccessResource($entity)) {
+        if (!$this->accessManager->canAccessResource($entity)) {
             throw new AccessDeniedHttpException();
         }
         $builder = $this->doctrine->getRepository($entity->getName())->createQueryBuilder('e');
 
         $sort = $request->get('sort');
-        if($sort) {
-            $sort = lcfirst(implode('', array_map(function ($key) {
+        if ($sort) {
+            $sort = lcfirst(implode('', array_map(function($key) {
                 return ucfirst($key);
             }, explode('_', $sort))));
 
-            if(!$entity->hasProperty($sort)) {
+            if (!$entity->hasProperty($sort)) {
                 throw new BadRequestHttpException(sprintf('There is no such field %s', $sort));
             }
             $builder->orderBy(
@@ -127,9 +127,9 @@ 
             );
         }
 
-        foreach($entity->getProperties() as $property) {
+        foreach ($entity->getProperties() as $property) {
             $name = $property->getName();
-            if($value = $request->get($name)) {
+            if ($value = $request->get($name)) {
                 $builder->andWhere($builder->expr()->orX(
                     $builder->expr()->like('e.'.$name, ':value')
                 ));