kambo-1st / KamboRouter

examples/Request.php

Doc Comments +6 added lines

@@ -59,6 +59,9 @@ 
         return $this->_enviroment->getRequestUri();    
     }
 
+    /**
+     * @return string
+     */
     public function getQuery() {
         return $this->_enviroment->getQueryString();    
     }
@@ -100,6 +103,9 @@ 
 
 interface EnviromentProvider 
 {
+    /**
+     * @return Enviroment
+     */
     public function get();
 }
 

src/Dispatchers/DispatcherClosure.php

Doc Comments +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
      * @param mixed $matches    parameters from request
      * @param mixed $parameters expected parameters from route
 
-     * @return array parametrs in right order, if there are not any parametrs an empty array is returned
+     * @return callable parametrs in right order, if there are not any parametrs an empty array is returned
      */
     private function _getFunctionArguments($paramMap, $matches, $parameters) {
         $output  = [];

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Kambo\Router\Dispatchers;
 
 use Kambo\Router\Dispatchers\Interfaces\DispatcherInterface;
-
 use Kambo\Router\Route\Route;
 
 /**

Indentation -1 removed lines

@@ -86,7 +86,6 @@
      * @param mixed $paramMap   parameter map - that will be used for getting proper order
      * @param mixed $matches    parameters from request
      * @param mixed $parameters expected parameters from route
-
      * @return array parametrs in right order, if there are not any parametrs an empty array is returned
      */
     private function _getFunctionArguments($paramMap, $matches, $parameters) {

src/Dispatchers/DispatcherController.php

Doc Comments +3 added lines, -3 removed lines

@@ -121,7 +121,7 @@ 
      * 
      * @param mixed $matches    found matched variables
      * @param mixed $parameters route parameters  
-     * @param mixed $handler    handler that should be executed
+     * @param string $handler    handler that should be executed
      *
      * @return mixed
      */
@@ -175,7 +175,7 @@ 
      * @param mixed $handler    handler that should be executed
      * @param mixed $matches    found matched variables
 
-     * @return mixed
+     * @return string
      */
     private function _resolveNamespace($parameters, $handler, $matches) {
         if (isset($handler['module'])) {
@@ -220,7 +220,7 @@ 
      * @param mixed $paramMap   parameter map
      * @param mixed $matches    found matched variables
      * @param mixed $parameters route parameters  
-     * @param mixed $handlers   handler that should be executed
+     * @param string $handlers   handler that should be executed
 
      * @return mixed
      */

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Kambo\Router\Dispatchers;
 
 use Kambo\Router\Dispatchers\Interfaces\DispatcherInterface;
-
 use Kambo\Router\Route\Route;
 
 /**

Indentation -2 removed lines

@@ -174,7 +174,6 @@ 
      * @param mixed $parameters route parameters  
      * @param mixed $handler    handler that should be executed
      * @param mixed $matches    found matched variables
-
      * @return mixed
      */
     private function _resolveNamespace($parameters, $handler, $matches) {
@@ -221,7 +220,6 @@ 
      * @param mixed $matches    found matched variables
      * @param mixed $parameters route parameters  
      * @param mixed $handlers   handler that should be executed
-
      * @return mixed
      */
     private function _getFunctionArgumentsControlers($paramMap, $matches, $parameters, $handlers) {

Spacing +3 added lines, -3 removed lines

@@ -146,7 +146,7 @@ 
             }
 
             return [$transformed['controler'], $transformed['action']];   
-        } else if  ($this->_isPlaceholder($action)) {
+        } else if ($this->_isPlaceholder($action)) {
             $matches = array_values($matches);     
 
             $transformed = [];
@@ -162,7 +162,7 @@ 
                 }
             }
                         
-            return [$this->_resolveNamespace($parameters, $handler, $matches).'\\'.$controler, $transformed['action']];  // naive solution...    
+            return [$this->_resolveNamespace($parameters, $handler, $matches).'\\'.$controler, $transformed['action']]; // naive solution...    
         } else {
             return [$this->_resolveNamespace($parameters, $handler, $matches).'\\'.$controler, $action];
         }
@@ -180,7 +180,7 @@ 
     private function _resolveNamespace($parameters, $handler, $matches) {
         if (isset($handler['module'])) {
             $moduleName = $handler['module'];
-            if  ($this->_isPlaceholder($moduleName)) {
+            if ($this->_isPlaceholder($moduleName)) {
                 $transformed = [];
                 foreach ($handler as $target => $placeholder) {
                     foreach ($parameters as $key => $parameterName) {

src/Matcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -148,7 +148,7 @@
     /**
      * Get format for URL resolving.
      *
-     * @return boolean
+     * @return string
      */
     public function getUrlFormat() {
         return $this->_urlFormat;

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 
 use Kambo\Router\Dispatchers\Interfaces\DispatcherInterface;
 use Kambo\Router\Route\RouteCollection;
-
 use Kambo\Router\Enum\Method;
 use Kambo\Router\Enum\RouteMode;
 

Indentation +1 added lines, -1 removed lines

@@ -188,7 +188,7 @@
 
             list($routeRegex, $parameters) = $this->_transformRoute($routeUrl);
             $route->setParsed($routeRegex)
-                  ->setParameters($parameters);        
+                    ->setParameters($parameters);        
         }
 
         return $routes;

src/Enum/Enum.php

Spacing +1 added lines, -1 removed lines

@@ -53,6 +53,6 @@
      */
     public static function isInEnum($value) {
         $allItems = array_flip(self::toArray());
-        return isset($allItems[$value]) ? true:false;
+        return isset($allItems[$value]) ? true : false;
     }
 }