kaliop-uk / ezmigrationbundle

Core/Executor/ContentManager.php

Spacing +1 added lines, -1 removed lines

@@ -559,7 +559,7 @@
                     $locations = $locationService->loadLocations($content->contentInfo);
                     if (count($locations) > 1) {
                         $otherParentLocations = array();
-                        foreach($locations as $otherLocation) {
+                        foreach ($locations as $otherLocation) {
                             if ($otherLocation->id != $location->id) {
                                 $otherParentLocations[] = $otherLocation->parentLocationId;
                             }

Core/Executor/LanguageManager.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Kaliop\eZMigrationBundle\Core\Executor;
 
 use eZ\Publish\API\Repository\Values\Content\Language;
-use Kaliop\eZMigrationBundle\API\Collection\LanguageCollection;
 
 /**
  * Handles language migrations.

Core/Executor/LocationManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -270,8 +270,8 @@
      * The Location Manager currently supports setting references to location id.
      *
      * @throws \InvalidArgumentException When trying to set a reference to an unsupported attribute.
-     * @param \eZ\Publish\API\Repository\Values\Content\Location|LocationCollection $location
-     * @return boolean
+     * @param LocationCollection|null $location
+     * @return false|null
      */
     protected function setReferences($location, $step)
     {

Core/Executor/RepositoryExecutor.php

Doc Comments +4 added lines, -1 removed lines

@@ -115,7 +115,7 @@ 
      *
      * @throws \InvalidArgumentException when trying to set a reference to an unsupported attribute.
      * @param $object a sinle element to extract reference values from
-     * @param array $referencesDefinitionsthe definitions of the references to extract
+     * @param array $referencesDefinitions definitions of the references to extract
      * @return array key: the reference name (taken from $referencesDefinitions[n]['identifier'], value: the ref. value
      */
     abstract protected function getReferencesValues($object, $referencesDefinitions);
@@ -323,6 +323,9 @@ 
         return preg_replace('/(?<!^)[A-Z]/', ' $0', $className);
     }
 
+    /**
+     * @param AbstractCollection $collection
+     */
     protected function getCollectionName($collection)
     {
         $className = get_class($collection);

Spacing +3 added lines, -3 removed lines

@@ -225,7 +225,7 @@ 
             }
         }
 
-        foreach($referencesDefs as $reference) {
+        foreach ($referencesDefs as $reference) {
             $overwrite = false;
             if (isset($reference['overwrite'])) {
                 $overwrite = $reference['overwrite'];
@@ -246,7 +246,7 @@ 
     {
         // allow setting *some* refs even when we have 0 or N matches
         foreach ($referencesDefinition as $key => $reference) {
-            switch($reference['attribute']) {
+            switch ($reference['attribute']) {
 
                 case 'count':
                     $value = count($entity);
@@ -298,7 +298,7 @@ 
         if ($entity instanceof AbstractCollection) {
 
             $minOneRef = count($referencesDefinition) > 0;
-            $maxOneRef = count($referencesDefinition) > 0 && ! $this->areReferencesMultivalued($referencesDefinition);
+            $maxOneRef = count($referencesDefinition) > 0 && !$this->areReferencesMultivalued($referencesDefinition);
 
             if ($maxOneRef && count($entity) > 1) {
                 throw new \InvalidArgumentException($this->getSelfName() . ' does not support setting references for multiple ' . $this->getCollectionName($entity) . 's');

Core/Executor/SectionManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
      *
      * @param \eZ\Publish\API\Repository\Values\Content\Section|SectionCollection $section
      * @throws \InvalidArgumentException When trying to set a reference to an unsupported attribute
-     * @return boolean
+     * @return false|null
      */
     protected function setReferences($section, $step)
     {

Core/Executor/TagManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
 
     /**
      * @param $object
-     * @return bool
+     * @return false|null
      *
      * @todo add support for keyword (with language),
      */