kaliop-uk / ezmigrationbundle

Core/DefinitionParser/PHPDefinitionParser.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
         );
     }
 
+    /**
+     * @param string $fileName
+     */
     protected function getClassNameFromFile($fileName)
     {
         $parts = explode('_', pathinfo($fileName, PATHINFO_FILENAME), 2);

Core/Executor/ContentTypeManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -179,7 +179,7 @@
      * @throws \InvalidArgumentException When trying to set
      *
      * @param \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType
-     * @return boolean
+     * @return false|null
      */
     protected function setReferences($contentType)
     {

Braces +1 added lines, -2 removed lines

@@ -393,8 +393,7 @@
                     $ret[$key] = $this->referenceResolver->getReferenceValue($val);
                 }
             }
-        }
-        else {
+        } else {
             $ret = $value;
 
             if ($this->referenceResolver->isReference($value)) {

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         // Authenticate the user
         $this->loginUser();
 
-        foreach(array('identifier', 'content_type_group', 'name_pattern', 'name', 'attributes') as $key) {
+        foreach (array('identifier', 'content_type_group', 'name_pattern', 'name', 'attributes') as $key) {
             if (!array_key_exists($key, $this->dsl)) {
                 throw new \Exception("The '$key' key is missing in a content type creation definition");
             }

MigrationVersions/20100101000200_MigrateV1ToV2.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Kaliop\eZMigrationBundle\API\MigrationInterface;
-
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Kaliop\eZMigrationBundle\API\Value\Migration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
         $this->dbHandler = $this->container->get('ezpublish.connection');
 
         $this->activeBundles = array();
-        foreach($this->container->get('kernel')->getBundles() as $bundle)
+        foreach ($this->container->get('kernel')->getBundles() as $bundle)
         {
             $this->activeBundles[$bundle->getName()] = $bundle->getPath();
         }
@@ -57,7 +57,7 @@ 
 
         // we need to decide of a random time to stamp existing migrations. We use 'now - 1 minute'...
         $executionDate = time() - 60;
-        foreach($toMigrate as $legacyMigration) {
+        foreach ($toMigrate as $legacyMigration) {
             $name = $legacyMigration['version'];
 
             $path = $this->getLegacyMigrationDefinition($legacyMigration['version'], $legacyMigration['bundle']);
@@ -104,7 +104,7 @@ 
     {
         /** @var \Doctrine\DBAL\Schema\AbstractSchemaManager $sm */
         $sm = $this->dbHandler->getConnection()->getSchemaManager();
-        foreach($sm->listTables() as $table) {
+        foreach ($sm->listTables() as $table) {
             if ($table->getName() == $tableName) {
                 return true;
             }
@@ -151,7 +151,7 @@ 
             return false;
         }
 
-        foreach($versionDefinitions as $key => $versionDefinition) {
+        foreach ($versionDefinitions as $key => $versionDefinition) {
             if (!in_array(pathinfo($versionDefinition, PATHINFO_EXTENSION), array('php', 'yml', 'sql'))) {
                 unset($versionDefinitions[$key]);
             }

API/Value/MigrationDefinition.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
      * @param MigrationStep[] $steps
      * @param string $parsingError
      */
-    function __construct($name, $path, $rawDefinition, $status = 0, array $steps=array(), $parsingError = null)
+    function __construct($name, $path, $rawDefinition, $status = 0, array $steps = array(), $parsingError = null)
     {
         $this->name = $name;
         $this->path = $path;

API/Collection/AbstractCollection.php

Spacing +6 added lines, -6 removed lines

@@ -15,9 +15,9 @@ 
      * @param int $flags
      * @param string $iterator_class
      */
-    public function __construct ($input = array(), $flags = 0, $iterator_class = "ArrayIterator")
+    public function __construct($input = array(), $flags = 0, $iterator_class = "ArrayIterator")
     {
-        foreach($input as $value) {
+        foreach ($input as $value) {
             if (!is_a($value, $this->allowedClass)) {
                 $this->throwInvalid($value);
             }
@@ -27,7 +27,7 @@ 
     /**
      * @param mixed $value
      */
-    public function append ($value)
+    public function append($value)
     {
         if (!is_a($value, $this->allowedClass)) {
             $this->throwInvalid($value);
@@ -37,9 +37,9 @@ 
     /**
      * @param mixed $input
      */
-    public function exchangeArray ($input)
+    public function exchangeArray($input)
     {
-        foreach($input as $value) {
+        foreach ($input as $value) {
             if (!is_a($value, $this->allowedClass)) {
                 $this->throwInvalid($value);
             }
@@ -50,7 +50,7 @@ 
      * @param mixed $index
      * @param mixed $newval
      */
-    public function offsetSet ($index , $newval)
+    public function offsetSet($index, $newval)
     {
         if (!is_a($newval, $this->allowedClass)) {
             $this->throwInvalid($newval);

DependencyInjection/EzMigrationExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
     }
 }

Tests/phpunit/Core/ConfigurationTest.php

Spacing +121 added lines, -121 removed lines

@@ -28,27 +28,27 @@ 
     public function setUp() {
         parent::setUp();
 
-        $this->configuration = new Configuration( $this->connection, new ConsoleOutput() );
+        $this->configuration = new Configuration($this->connection, new ConsoleOutput());
 
     }
 
     public function testGetConnection() {
         $conn = $this->configuration->getConnection();
 
-        $this->assertTrue( $conn instanceof Connection );
+        $this->assertTrue($conn instanceof Connection);
     }
 
     public function testGetVersions() {
         $version = $this->configuration->getVersions();
 
-        $this->assertTrue( is_array($version ) );
+        $this->assertTrue(is_array($version));
     }
 
     public function testcreateVersionTableIfNeeded()
     {
         $result = $this->configuration->createVersionTableIfNeeded();
 
-        $this->assertTrue( $result );
+        $this->assertTrue($result);
     }
 
     /**
@@ -61,19 +61,19 @@ 
         $conn = $this->configuration->getConnection();
 
 
-        $time = date( 'YmdHis', time() );
+        $time = date('YmdHis', time());
         $bundle = 'testBundle';
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
         /** @var $versions array */
-        $versions = $this->configuration->getMigratedVersionsByBundle( $bundle );
+        $versions = $this->configuration->getMigratedVersionsByBundle($bundle);
 
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 1, count( $versions ) );
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(1, count($versions));
 
-        $this->assertEquals( $time, $versions[0] );
+        $this->assertEquals($time, $versions[0]);
     }
 
     /**
@@ -86,23 +86,23 @@ 
 
         $conn = $this->configuration->getConnection();
 
-        $time = date( 'YmdHis', time() - 3600 );
+        $time = date('YmdHis', time() - 3600);
         $bundle = 'testBundle';
 
-        $this->configuration->setVersions( array( $bundle => array() ) );
+        $this->configuration->setVersions(array($bundle => array()));
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $time = date( 'YmdHis', time() );
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle, $time );
+        $time = date('YmdHis', time());
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $version = $this->configuration->getCurrentVersionByBundle( $bundle );
+        $version = $this->configuration->getCurrentVersionByBundle($bundle);
 
-        $this->assertEquals( (int)$time, $version );
+        $this->assertEquals((int)$time, $version);
     }
 
     /**
@@ -116,37 +116,37 @@ 
 
         $conn = $this->configuration->getConnection();
 
-        $time = date( 'YmdHis', time() - 3600 );
+        $time = date('YmdHis', time() - 3600);
         $bundle1 = 'testBundle';
         $bundle2 = 'testBundle2';
 
-        $this->configuration->setVersions( array( $bundle1 => array(), $bundle2 => array() ) );
+        $this->configuration->setVersions(array($bundle1 => array(), $bundle2 => array()));
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $time = date( 'YmdHis', time() );
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time );
+        $time = date('YmdHis', time());
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $time2 = date( 'YmdHis', time() );
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time2 );
+        $time2 = date('YmdHis', time());
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time2);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
         $versions = $this->configuration->getCurrentBundleVersions();
 
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 2, count( $versions ) );
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(2, count($versions));
 
-        $this->assertEquals( (int)$time, $versions[$bundle1] );
-        $this->assertEquals( (int)$time2, $versions[$bundle2] );
+        $this->assertEquals((int)$time, $versions[$bundle1]);
+        $this->assertEquals((int)$time2, $versions[$bundle2]);
     }
 
     /**
@@ -158,46 +158,46 @@ 
 
         $conn = $this->configuration->getConnection();
 
-        $time = date( 'YmdHis', time() - 3600 );
+        $time = date('YmdHis', time() - 3600);
         $bundle1 = 'testBundle';
         $bundle2 = 'testBundle2';
 
-        $this->configuration->setVersions( array( $bundle1 => array(), $bundle2 => array() ) );
+        $this->configuration->setVersions(array($bundle1 => array(), $bundle2 => array()));
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $time1 = date( 'YmdHis', time() );
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time1 );
+        $time1 = date('YmdHis', time());
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time1);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $time2 = date( 'YmdHis', time() );
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time2 );
+        $time2 = date('YmdHis', time());
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time2);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
         $versions = $this->configuration->getMigratedVersions();
 
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 2, count( $versions ) );
-        $this->assertArrayHasKey( $bundle1, $versions );
-        $this->assertArrayHasKey( $bundle2, $versions );
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(2, count($versions));
+        $this->assertArrayHasKey($bundle1, $versions);
+        $this->assertArrayHasKey($bundle2, $versions);
 
-        $this->assertTrue( is_array( $versions[$bundle1] ) );
-        $this->assertTrue( is_array( $versions[$bundle2] ) );
-        $this->assertEquals( 2, count( $versions[$bundle1] ) );
-        $this->assertEquals( 2, count( $versions[$bundle2] ) );
+        $this->assertTrue(is_array($versions[$bundle1]));
+        $this->assertTrue(is_array($versions[$bundle2]));
+        $this->assertEquals(2, count($versions[$bundle1]));
+        $this->assertEquals(2, count($versions[$bundle2]));
 
-        $this->assertEquals( $time, $versions[$bundle1][0] );
-        $this->assertEquals( $time, $versions[$bundle2][0] );
-        $this->assertEquals( $time1, $versions[$bundle1][1] );
-        $this->assertEquals( $time2, $versions[$bundle2][1] );
+        $this->assertEquals($time, $versions[$bundle1][0]);
+        $this->assertEquals($time, $versions[$bundle2][0]);
+        $this->assertEquals($time1, $versions[$bundle1][1]);
+        $this->assertEquals($time2, $versions[$bundle2][1]);
     }
 
     /**
@@ -209,10 +209,10 @@ 
 
         $conn = $this->configuration->getConnection();
 
-        $time = date( 'YmdHis', time() - 3600 );
-        $time1 = date( 'YmdHis', time() );
-        $time2 = date( 'YmdHis', time() + 3600 );
-        $time3 = date( 'YmdHis', time() + 7200 );
+        $time = date('YmdHis', time() - 3600);
+        $time1 = date('YmdHis', time());
+        $time2 = date('YmdHis', time() + 3600);
+        $time3 = date('YmdHis', time() + 7200);
         $bundle1 = 'testBundle';
         $bundle2 = 'testBundle2';
 
@@ -229,35 +229,35 @@ 
             )
         );
 
-        $this->configuration->setVersions( $versions );
+        $this->configuration->setVersions($versions);
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time1 );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle1, $time1);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
-        $sql = sprintf( "INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time2 );
+        $sql = sprintf("INSERT INTO %s ( 'bundle', 'version' ) VALUES( '%s', '%s' )", $this->configuration->versionTableName, $bundle2, $time2);
 
-        $conn->executeQuery( $sql );
+        $conn->executeQuery($sql);
 
         $results = $this->configuration->migrationsToExecute();
 
-        $this->assertTrue( is_array( $results ) );
-        $this->assertEquals( 2, count( $results ) );
-        $this->assertArrayHasKey( $bundle1, $results );
-        $this->assertArrayHasKey( $bundle2, $results );
+        $this->assertTrue(is_array($results));
+        $this->assertEquals(2, count($results));
+        $this->assertArrayHasKey($bundle1, $results);
+        $this->assertArrayHasKey($bundle2, $results);
 
-        $this->assertEquals( 1, count( $results[$bundle1] ) );
-        $this->assertEquals( $time2, key( $results[$bundle1] ) );
-        $this->assertEquals( 1, count( $results[$bundle2] ) );
-        $this->assertEquals( $time3, key( $results[$bundle2] ) );
+        $this->assertEquals(1, count($results[$bundle1]));
+        $this->assertEquals($time2, key($results[$bundle1]));
+        $this->assertEquals(1, count($results[$bundle2]));
+        $this->assertEquals($time3, key($results[$bundle2]));
     }
 
     /**
@@ -270,16 +270,16 @@ 
         $bundle = 'testBundle';
         $version = '1';
 
-        $versions = $this->configuration->getMigratedVersionsByBundle( $bundle );
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 0, count( $versions ) );
+        $versions = $this->configuration->getMigratedVersionsByBundle($bundle);
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(0, count($versions));
 
-        $this->configuration->markVersionMigrated( $bundle, $version );
-        $versions = $this->configuration->getMigratedVersionsByBundle( $bundle );
+        $this->configuration->markVersionMigrated($bundle, $version);
+        $versions = $this->configuration->getMigratedVersionsByBundle($bundle);
 
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 1, count( $versions ) );
-        $this->assertEquals( $version, $versions[0] );
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(1, count($versions));
+        $this->assertEquals($version, $versions[0]);
     }
 
     /**
@@ -294,25 +294,25 @@ 
         $version1 = '1';
         $version2 = '2';
 
-        $versions = $this->configuration->getMigratedVersionsByBundle( $bundle );
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 0, count( $versions ) );
+        $versions = $this->configuration->getMigratedVersionsByBundle($bundle);
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(0, count($versions));
 
-        $this->configuration->markVersionMigrated( $bundle, $version1 );
-        $versions = $this->configuration->getMigratedVersionsByBundle( $bundle );
+        $this->configuration->markVersionMigrated($bundle, $version1);
+        $versions = $this->configuration->getMigratedVersionsByBundle($bundle);
 
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 1, count( $versions ) );
-        $this->assertEquals( $version1, $versions[0] );
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(1, count($versions));
+        $this->assertEquals($version1, $versions[0]);
 
-        $this->configuration->markVersionMigrated( $bundle, $version2 );
-        $this->configuration->markVersionNotMigrated( $bundle, $version1 );
+        $this->configuration->markVersionMigrated($bundle, $version2);
+        $this->configuration->markVersionNotMigrated($bundle, $version1);
 
-        $versions = $this->configuration->getMigratedVersionsByBundle( $bundle );
+        $versions = $this->configuration->getMigratedVersionsByBundle($bundle);
 
-        $this->assertTrue( is_array( $versions ) );
-        $this->assertEquals( 1, count( $versions ) );
-        $this->assertEquals( $version2, $versions[0] );
+        $this->assertTrue(is_array($versions));
+        $this->assertEquals(1, count($versions));
+        $this->assertEquals($version2, $versions[0]);
     }
 
     /**
@@ -322,21 +322,21 @@ 
     public function testRegisterVersionFromDirectories() {
         try {
             $this->setupVfsStructure();
-        } catch ( \Exception $e ) {
-            var_dump( $e->getMessage() );
-            $this->markTestSkipped( "The VfsStream bundle is not installed." );
+        } catch (\Exception $e) {
+            var_dump($e->getMessage());
+            $this->markTestSkipped("The VfsStream bundle is not installed.");
         }
 
         $paths = array(
-            'bundle1' => array( vfsStream::url( 'bundles/bundle1/MigrationVersions' ) ),
-            'bundle2' => array( vfsStream::url( 'bundles/bundle2/MigrationVersions' ) )
+            'bundle1' => array(vfsStream::url('bundles/bundle1/MigrationVersions')),
+            'bundle2' => array(vfsStream::url('bundles/bundle2/MigrationVersions'))
         );
 
         $this->configuration->createVersionTableIfNeeded();
 
-        $versions = $this->configuration->registerVersionFromDirectories( $paths );
+        $versions = $this->configuration->registerVersionFromDirectories($paths);
 
-        $this->markTestSkipped( "FIXME: figure out a way to test this" );
+        $this->markTestSkipped("FIXME: figure out a way to test this");
     }
 
     /**
@@ -344,9 +344,9 @@ 
      */
     public function testCheckDuplicateVersion()
     {
-        $this->configuration->setVersions( array( 'testBundle' => array( '1' ) ) );
+        $this->configuration->setVersions(array('testBundle' => array('1')));
 
-        $this->configuration->checkDuplicateVersion( 'testBundle', '1' );
+        $this->configuration->checkDuplicateVersion('testBundle', '1');
     }
 
     /**
@@ -356,11 +356,11 @@ 
 
         try {
         $this->setupVfsStructure();
-        } catch( \Exception $e ) {
-            $this->markTestSkipped( 'Problem with VfsStream.' );
+        } catch (\Exception $e) {
+            $this->markTestSkipped('Problem with VfsStream.');
         }
 
-        $path = vfsStream::url( 'bundles/bundle1/MigrationVersions/Version20010101010101.php' );
+        $path = vfsStream::url('bundles/bundle1/MigrationVersions/Version20010101010101.php');
     }
 
     /**
@@ -374,21 +374,21 @@ 
             $structure = array(
                 'bundle1' => array(
                     'MigrationVersions' => array(
-                        'Version20010101010101.php' => '<?php namespace MigrationVersions\bundle1;'."\n" . $this->dummyVersionContent . "\n?>",
-                        'Version20010101010102.php' => '<?php namespace MigrationVersions\bundle1;'."\n" . $this->dummyVersionContent . "\n?>",
+                        'Version20010101010101.php' => '<?php namespace MigrationVersions\bundle1;' . "\n" . $this->dummyVersionContent . "\n?>",
+                        'Version20010101010102.php' => '<?php namespace MigrationVersions\bundle1;' . "\n" . $this->dummyVersionContent . "\n?>",
                     )
                 ),
                 'bundle2' => array(
                     'MigrationVersions' => array(
-                        'Version20010101010103.php' => '<?php namespace MigrationVersions\bundle2;'."\n" . $this->dummyVersionContent . "\n?>",
+                        'Version20010101010103.php' => '<?php namespace MigrationVersions\bundle2;' . "\n" . $this->dummyVersionContent . "\n?>",
                     )
                 )
             );
-        } catch( Exception $e ) {
-            throw new \Exception( $e->getMessage() );
+        } catch (Exception $e) {
+            throw new \Exception($e->getMessage());
         }
 
-        $this->root = vfsStream::setup( 'bundles', null, $structure );
+        $this->root = vfsStream::setup('bundles', null, $structure);
     }
 
     /**

Command/StatusCommand.php

Spacing +5 added lines, -5 removed lines

@@ -41,7 +41,7 @@ 
     {
         $migrationsService = $this->getMigrationService();
 
-        $migrationDefinitions = $migrationsService->getMigrationsDefinitions($input->getOption('path')) ;
+        $migrationDefinitions = $migrationsService->getMigrationsDefinitions($input->getOption('path'));
         $migrations = $migrationsService->getMigrations();
 
         if (!count($migrationDefinitions) && !count($migrations)) {
@@ -51,10 +51,10 @@ 
 
         // create a unique ist of all migrations (coming from db) and definitions (coming from disk)
         $index = array();
-        foreach($migrationDefinitions as $migrationDefinition) {
+        foreach ($migrationDefinitions as $migrationDefinition) {
             $index[$migrationDefinition->name] = array('definition' => $migrationDefinition);
         }
-        foreach($migrations as $migration) {
+        foreach ($migrations as $migration) {
             if (isset($index[$migration->name])) {
                 $index[$migration->name]['migration'] = $migration;
             } else {
@@ -68,7 +68,7 @@ 
                         {
                             $index[$migration->name]['definition'] = reset($migrationDefinitionCollection);
                         }
-                    } catch(\Exception $e) {
+                    } catch (\Exception $e) {
                         /// @todo one day we should be able to limit the kind of exceptions we have to catch here...
                     }
                 }
@@ -80,7 +80,7 @@ 
 
         $data = array();
         $i = 1;
-        foreach($index as $name => $value) {
+        foreach ($index as $name => $value) {
             if (!isset($value['migration'])) {
                 $migrationDefinition = $migrationsService->parseMigrationDefinition($value['definition']);
                 $notes = '';

Core/Executor/UserManager.php

Spacing +4 added lines, -4 removed lines

@@ -132,7 +132,7 @@ 
                 $this->dsl['user_id'] = array($this->dsl['user_id']);
             }
             foreach ($this->dsl['user_id'] as $id) {
-                array_push($usersToDelete,$userService->loadUser($id));
+                array_push($usersToDelete, $userService->loadUser($id));
             }
         }
         if (isset($this->dsl['email'])) {
@@ -140,7 +140,7 @@ 
                 $this->dsl['email'] = array($this->dsl['email']);
             }
             foreach ($this->dsl['email'] as $email) {
-                $usersToDelete = array_merge($usersToDelete,$userService->loadUsersByEmail($email));
+                $usersToDelete = array_merge($usersToDelete, $userService->loadUsersByEmail($email));
             }
         }
         if (isset($this->dsl['username'])) {
@@ -148,11 +148,11 @@ 
                 $this->dsl['username'] = array($this->dsl['username']);
             }
             foreach ($this->dsl['username'] as $username) {
-                array_push($usersToDelete,$userService->loadUserByLogin($username));
+                array_push($usersToDelete, $userService->loadUserByLogin($username));
             }
         }
 
-        foreach($usersToDelete as $user){
+        foreach ($usersToDelete as $user) {
             $userService->deleteUser($user);
         }
     }