kaliop-uk / ezmigrationbundle

Core/DefinitionParser/PHPDefinitionParser.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
         );
     }
 
+    /**
+     * @param string $fileName
+     */
     protected function getClassNameFromFile($fileName)
     {
         $parts = explode('_', pathinfo($fileName, PATHINFO_FILENAME), 2);

Core/Executor/TagManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 
     /**
      * @param $object
-     * @return mixed
+     * @return false|null
      */
     protected function setReferences($object)
     {

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      * @param TagMatcher $tagMatcher
      * @param \Netgen\TagsBundle\Core\SignalSlot\TagsService $tagService
      */
-    public function __construct(TagMatcher $tagMatcher, $tagService=null)
+    public function __construct(TagMatcher $tagMatcher, $tagService = null)
     {
         $this->tagMatcher = $tagMatcher;
         $this->tagService = $tagService;

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Kaliop\eZMigrationBundle\Core\Executor;
 
-use Kaliop\eZMigrationBundle\Core\ReferenceResolver\ReferenceHandler;
 use Kaliop\eZMigrationBundle\Core\Matcher\TagMatcher;
 use Kaliop\eZMigrationBundle\API\Collection\TagCollection;
 

MigrationVersions/20100101000200_MigrateV1ToV2.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Kaliop\eZMigrationBundle\API\MigrationInterface;
-
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Kaliop\eZMigrationBundle\API\Value\Migration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
         $this->dbHandler = $this->container->get('ezpublish.connection');
 
         $this->activeBundles = array();
-        foreach($this->container->get('kernel')->getBundles() as $bundle)
+        foreach ($this->container->get('kernel')->getBundles() as $bundle)
         {
             $this->activeBundles[$bundle->getName()] = $bundle->getPath();
         }
@@ -57,7 +57,7 @@ 
 
         // we need to decide of a random time to stamp existing migrations. We use 'now - 1 minute'...
         $executionDate = time() - 60;
-        foreach($toMigrate as $legacyMigration) {
+        foreach ($toMigrate as $legacyMigration) {
             $name = $legacyMigration['version'];
 
             $path = $this->getLegacyMigrationDefinition($legacyMigration['version'], $legacyMigration['bundle']);
@@ -104,7 +104,7 @@ 
     {
         /** @var \Doctrine\DBAL\Schema\AbstractSchemaManager $sm */
         $sm = $this->dbHandler->getConnection()->getSchemaManager();
-        foreach($sm->listTables() as $table) {
+        foreach ($sm->listTables() as $table) {
             if ($table->getName() == $tableName) {
                 return true;
             }
@@ -151,7 +151,7 @@ 
             return false;
         }
 
-        foreach($versionDefinitions as $key => $versionDefinition) {
+        foreach ($versionDefinitions as $key => $versionDefinition) {
             if (!in_array(pathinfo($versionDefinition, PATHINFO_EXTENSION), array('php', 'yml', 'sql'))) {
                 unset($versionDefinitions[$key]);
             }

API/Value/MigrationDefinition.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
      * @param MigrationStep[] $steps
      * @param string $parsingError
      */
-    function __construct($name, $path, $rawDefinition, $status = 0, array $steps=array(), $parsingError = null)
+    function __construct($name, $path, $rawDefinition, $status = 0, array $steps = array(), $parsingError = null)
     {
         $this->name = $name;
         $this->path = $path;

DependencyInjection/EzMigrationExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
     }
 }

Command/StatusCommand.php

Spacing +5 added lines, -5 removed lines

@@ -41,7 +41,7 @@ 
     {
         $migrationsService = $this->getMigrationService();
 
-        $migrationDefinitions = $migrationsService->getMigrationsDefinitions($input->getOption('path')) ;
+        $migrationDefinitions = $migrationsService->getMigrationsDefinitions($input->getOption('path'));
         $migrations = $migrationsService->getMigrations();
 
         if (!count($migrationDefinitions) && !count($migrations)) {
@@ -51,10 +51,10 @@ 
 
         // create a unique ist of all migrations (coming from db) and definitions (coming from disk)
         $index = array();
-        foreach($migrationDefinitions as $migrationDefinition) {
+        foreach ($migrationDefinitions as $migrationDefinition) {
             $index[$migrationDefinition->name] = array('definition' => $migrationDefinition);
         }
-        foreach($migrations as $migration) {
+        foreach ($migrations as $migration) {
             if (isset($index[$migration->name])) {
                 $index[$migration->name]['migration'] = $migration;
             } else {
@@ -68,7 +68,7 @@ 
                         {
                             $index[$migration->name]['definition'] = reset($migrationDefinitionCollection);
                         }
-                    } catch(\Exception $e) {
+                    } catch (\Exception $e) {
                         /// @todo one day we should be able to limit the kind of exceptions we have to catch here...
                     }
                 }
@@ -80,7 +80,7 @@ 
 
         $data = array();
         $i = 1;
-        foreach($index as $name => $value) {
+        foreach ($index as $name => $value) {
             if (!isset($value['migration'])) {
                 $migrationDefinition = $migrationsService->parseMigrationDefinition($value['definition']);
                 $notes = '';

Core/Loader/Filesystem.php

Spacing +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
         if (empty($paths)) {
             $paths = array();
             /** @var $bundle \Symfony\Component\HttpKernel\Bundle\BundleInterface */
-            foreach($this->kernel->getBundles() as $bundle)
+            foreach ($this->kernel->getBundles() as $bundle)
             {
                 $path = $bundle->getPath() . "/" . $this->versionDirectory;
                 if (is_dir($path)) {
@@ -67,7 +67,7 @@ 
         }
 
         $definitions = array();
-        foreach($paths as $path) {
+        foreach ($paths as $path) {
             if (is_file($path)) {
                 $definitions[basename($path)] = $returnFilename ? $path : new MigrationDefinition(
                     basename($path),

Braces +1 added lines, -2 removed lines

@@ -85,8 +85,7 @@
                             );
                     }
                 }
-            }
-            else {
+            } else {
                 throw new \Exception("Path '$path' is neither a file nor directory");
             }
         }

Core/ComplexField/ComplexFieldManager.php

Braces +1 added lines, -2 removed lines

@@ -32,8 +32,7 @@
         {
             $fieldService = $this->fieldTypeMap[$fieldTypeIdentifier];
             return $fieldService->createValue($fieldValueArray, $context);
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException("Field of type '$fieldTypeIdentifier' can not be handled as it does not have a complex field class defined");
         }

Spacing +2 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
      * @param string $fieldTypeIdentifier
      * @param string $contentTypeIdentifier
      */
-    public function addComplexField(ComplexFieldInterface $complexField, $fieldTypeIdentifier, $contentTypeIdentifier=null)
+    public function addComplexField(ComplexFieldInterface $complexField, $fieldTypeIdentifier, $contentTypeIdentifier = null)
     {
         if ($contentTypeIdentifier == null) {
             $contentTypeIdentifier = '*';
@@ -52,8 +52,7 @@ 
         if (isset($this->fieldTypeMap[$contentTypeIdentifier][$fieldTypeIdentifier]) || isset($this->fieldTypeMap['*'][$fieldTypeIdentifier]))
         {
             $fieldService = isset($this->fieldTypeMap[$contentTypeIdentifier][$fieldTypeIdentifier]) ?
-                $this->fieldTypeMap[$contentTypeIdentifier][$fieldTypeIdentifier] :
-                $this->fieldTypeMap['*'][$fieldTypeIdentifier];
+                $this->fieldTypeMap[$contentTypeIdentifier][$fieldTypeIdentifier] : $this->fieldTypeMap['*'][$fieldTypeIdentifier];
             return $fieldService->createValue($fieldValue, $context);
         }
         else

Core/ReferenceResolver/ContentResolver.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     public function getReferenceValue($stringIdentifier)
     {
         $ref = $this->getReferenceIdentifierByPrefix($stringIdentifier);
-        switch($ref['prefix']) {
+        switch ($ref['prefix']) {
             case 'content_remote_id:':
                 return $this->repository->getContentService()->loadContentByRemoteId($ref['identifier'])->id;
             //case 'content_id::':