kaliop-uk / ezmigrationbundle

Core/DefinitionParser/PHPDefinitionParser.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
         );
     }
 
+    /**
+     * @param string $fileName
+     */
     protected function getClassNameFromFile($fileName)
     {
         $parts = explode('_', pathinfo($fileName, PATHINFO_FILENAME), 2);

Core/Executor/ContentTypeManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -179,7 +179,7 @@
      * @throws \InvalidArgumentException When trying to set
      *
      * @param \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType
-     * @return boolean
+     * @return false|null
      */
     protected function setReferences($contentType)
     {

Braces +1 added lines, -2 removed lines

@@ -393,8 +393,7 @@
                     $ret[$key] = $this->referenceResolver->getReferenceValue($val);
                 }
             }
-        }
-        else {
+        } else {
             $ret = $value;
 
             if ($this->referenceResolver->isReference($value)) {

Core/Executor/RoleManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -287,7 +287,7 @@
      *
      * @param \eZ\Publish\API\Repository\Values\User\Role $role
      * @param \eZ\Publish\API\Repository\RoleService $roleService
-     * @param array $policies
+     * @param array $policy
      */
     private function addPolicy(Role $role, RoleService $roleService, array $policy)
     {

Spacing +3 added lines, -3 removed lines

@@ -79,11 +79,11 @@ 
                 // Removing all policies so we can add them back.
                 // TODO: Check and update policies instead of remove and add.
                 $policies = $role->getPolicies();
-                foreach($policies as $policy) {
+                foreach ($policies as $policy) {
                     $roleService->deletePolicy($policy);
                 }
 
-                foreach($ymlPolicies as $key => $ymlPolicy) {
+                foreach ($ymlPolicies as $key => $ymlPolicy) {
                     $this->addPolicy($role, $roleService, $ymlPolicy);
                 }
             }
@@ -172,7 +172,7 @@ 
 
         $limitationValue = is_array($limitation['values']) ? $limitation['values'] : array($limitation['values']);
 
-        foreach($limitationValue as $id => $value) {
+        foreach ($limitationValue as $id => $value) {
             if ($this->referenceResolver->isReference($value)) {
                 $value = $this->geferenceResolver->getReferenceValue($value);
                 $limitationValue[$id] = $value;

Core/Executor/TagManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 
     /**
      * @param $object
-     * @return mixed
+     * @return false|null
      */
     protected function setReferences($object)
     {

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
     protected $tagService;
 
-    public function __construct(TagsService $tagService=null)
+    public function __construct(TagsService $tagService = null)
     {
         $this->tagService = $tagService;
     }

Core/ReferenceResolver/AbstractResolver.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
     /**
      * @param string $stringIdentifier
-     * @return mixed
+     * @return integer
      */
     public function isReference($stringIdentifier)
     {

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
     public function __construct()
     {
         $quotedPrefixes = [];
-        foreach($this->referencePrefixes as $prefix) {
+        foreach ($this->referencePrefixes as $prefix) {
             $quotedPrefixes[] = preg_quote($prefix, '/');
         }
         $this->prefixMatchRegexp = '/^(' . implode('|', $quotedPrefixes) . ')/';
@@ -55,7 +55,7 @@ 
      */
     protected function getReferenceIdentifierByPrefix($stringIdentifier)
     {
-        foreach($this->referencePrefixes as $prefix) {
+        foreach ($this->referencePrefixes as $prefix) {
             $regexp = '/^' . preg_quote($prefix, '/') . '/';
             if (preg_match($regexp, $stringIdentifier)) {
                 return array('prefix' => $prefix, 'identifier' => preg_replace($regexp, '', $stringIdentifier));

MigrationVersions/20100101000200_MigrateV1ToV2.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Kaliop\eZMigrationBundle\API\MigrationInterface;
-
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Kaliop\eZMigrationBundle\API\Value\Migration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;

Spacing +4 added lines, -4 removed lines

@@ -36,7 +36,7 @@ 
         $this->dbHandler = $this->container->get('ezpublish.connection');
 
         $this->activeBundles = array();
-        foreach($this->container->get('kernel')->getBundles() as $bundle)
+        foreach ($this->container->get('kernel')->getBundles() as $bundle)
         {
             $this->activeBundles[$bundle->getName()] = $bundle->getPath();
         }
@@ -57,7 +57,7 @@ 
 
         // we need to decide of a random time to stamp existing migrations. We use 'now - 1 minute'...
         $executionDate = time() - 60;
-        foreach($toMigrate as $legacyMigration) {
+        foreach ($toMigrate as $legacyMigration) {
             $name = $legacyMigration['version'];
 
             $path = $this->getLegacyMigrationDefinition($legacyMigration['version'], $legacyMigration['bundle']);
@@ -104,7 +104,7 @@ 
     {
         /** @var \Doctrine\DBAL\Schema\AbstractSchemaManager $sm */
         $sm = $this->dbHandler->getConnection()->getSchemaManager();
-        foreach($sm->listTables() as $table) {
+        foreach ($sm->listTables() as $table) {
             if ($table->getName() == $tableName) {
                 return true;
             }
@@ -151,7 +151,7 @@ 
             return false;
         }
 
-        foreach($versionDefinitions as $key => $versionDefinition) {
+        foreach ($versionDefinitions as $key => $versionDefinition) {
             if (!in_array(pathinfo($versionDefinition, PATHINFO_EXTENSION), array('php', 'yml', 'sql'))) {
                 unset($versionDefinitions[$key]);
             }

API/Value/MigrationDefinition.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
      * @param MigrationStep[] $steps
      * @param string $parsingError
      */
-    function __construct($name, $path, $rawDefinition, $status = 0, array $steps=array(), $parsingError = null)
+    function __construct($name, $path, $rawDefinition, $status = 0, array $steps = array(), $parsingError = null)
     {
         $this->name = $name;
         $this->path = $path;

API/Collection/AbstractCollection.php

Spacing +6 added lines, -6 removed lines

@@ -15,9 +15,9 @@ 
      * @param int $flags
      * @param string $iterator_class
      */
-    public function __construct ($input = array(), $flags = 0, $iterator_class = "ArrayIterator")
+    public function __construct($input = array(), $flags = 0, $iterator_class = "ArrayIterator")
     {
-        foreach($input as $value) {
+        foreach ($input as $value) {
             if (!is_a($value, $this->allowedClass)) {
                 $this->throwInvalid($value);
             }
@@ -27,7 +27,7 @@ 
     /**
      * @param mixed $value
      */
-    public function append ($value)
+    public function append($value)
     {
         if (!is_a($value, $this->allowedClass)) {
             $this->throwInvalid($value);
@@ -37,9 +37,9 @@ 
     /**
      * @param mixed $input
      */
-    public function exchangeArray ($input)
+    public function exchangeArray($input)
     {
-        foreach($input as $value) {
+        foreach ($input as $value) {
             if (!is_a($value, $this->allowedClass)) {
                 $this->throwInvalid($value);
             }
@@ -50,7 +50,7 @@ 
      * @param mixed $index
      * @param mixed $newval
      */
-    public function offsetSet ($index , $newval)
+    public function offsetSet($index, $newval)
     {
         if (!is_a($newval, $this->allowedClass)) {
             $this->throwInvalid($newval);

DependencyInjection/EzMigrationExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
     }
 }