kaliop-uk / ezmigrationbundle

Command/ResumeCommand.php

Spacing +3 added lines, -3 removed lines

@@ -99,7 +99,7 @@ 
         $forcedRefs = array();
         if ($input->getOption('set-reference') /*&& !$input->getOption('separate-process')*/) {
             $refResolver = $this->getContainer()->get('ez_migration_bundle.reference_resolver.customreference');
-            foreach($input->getOption('set-reference') as $refSpec) {
+            foreach ($input->getOption('set-reference') as $refSpec) {
                 $ref = explode(':', $refSpec, 2);
                 if (count($ref) < 2 || $ref[0] === '') {
                     throw new MigrationBundleException("Invalid reference specification: '$refSpec'");
@@ -111,7 +111,7 @@ 
         $executed = 0;
         $failed = 0;
 
-        foreach($suspendedMigrations as $suspendedMigration) {
+        foreach ($suspendedMigrations as $suspendedMigration) {
             $output->writeln("<info>Resuming {$suspendedMigration->name}</info>");
 
             try {
@@ -131,7 +131,7 @@ 
 
         $time = microtime(true) - $start;
         $output->writeln("Resumed $executed migrations, failed $failed");
-        $output->writeln("Time taken: ".sprintf('%.3f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB');
+        $output->writeln("Time taken: " . sprintf('%.3f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB');
 
         if ($failed) {
             return 2;

Command/MassMigrateCommand.php

Spacing +15 added lines, -15 removed lines

@@ -133,7 +133,7 @@ 
 
         $processes = array();
         /** @var MigrationDefinition $migrationDefinition */
-        foreach($paths as $path => $count) {
+        foreach ($paths as $path => $count) {
             $this->writeln("<info>Queueing processing of: $path ($count migrations)</info>", OutputInterface::VERBOSITY_VERBOSE);
 
             $process = $builder
@@ -180,14 +180,14 @@ 
         }
 
         $missed = $total - $this->migrationsDone[Migration::STATUS_DONE] - $this->migrationsDone[Migration::STATUS_FAILED] - $this->migrationsDone[Migration::STATUS_SKIPPED];
-        $this->writeln("\nExecuted ".$this->migrationsDone[Migration::STATUS_DONE].' migrations'.
-            ', failed '.$this->migrationsDone[Migration::STATUS_FAILED].
-            ', skipped '.$this->migrationsDone[Migration::STATUS_SKIPPED].
+        $this->writeln("\nExecuted " . $this->migrationsDone[Migration::STATUS_DONE] . ' migrations' .
+            ', failed ' . $this->migrationsDone[Migration::STATUS_FAILED] .
+            ', skipped ' . $this->migrationsDone[Migration::STATUS_SKIPPED] .
             ($missed ? ", missed $missed" : ''));
 
         $time = microtime(true) - $start;
         // since we use subprocesses, we can not measure max memory used
-        $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs</info>");
+        $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs</info>");
 
         return $subprocessesFailed + $this->migrationsDone[Migration::STATUS_FAILED] + $missed;
     }
@@ -212,7 +212,7 @@ 
                 $prefix = array($php);
 
                 if ($input->getOption('child-process-php-ini-config')) {
-                    foreach($input->getOption('child-process-php-ini-config') as $iniSpec) {
+                    foreach ($input->getOption('child-process-php-ini-config') as $iniSpec) {
                         $ini = explode(':', $iniSpec, 2);
                         if (count($ini) < 2 || $ini[0] === '') {
                             throw new MigrationBundleException("Invalid php ini specification: '$iniSpec'");
@@ -241,7 +241,7 @@ 
         foreach ($toExecute as  $name => $migrationDefinition) {
             // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
             if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
-                $this->writeln("<comment>Skipping migration (invalid definition?) Path: ".$migrationDefinition->path."</comment>", self::$VERBOSITY_CHILD);
+                $this->writeln("<comment>Skipping migration (invalid definition?) Path: " . $migrationDefinition->path . "</comment>", self::$VERBOSITY_CHILD);
                 $skipped++;
                 continue;
             }
@@ -281,7 +281,7 @@ 
                     $this->executeMigrationInProcess($migrationDefinition, $force, $migrationService, $input);
 
                     $executed++;
-                } catch(\Exception $e) {
+                } catch (\Exception $e) {
                     $failed++;
 
                     $errorMessage = $e->getMessage();
@@ -314,7 +314,7 @@ 
      * @param string $buffer
      * @param null|\Symfony\Component\Process\Process $process
      */
-    public function onChildProcessOutput($type, $buffer, $process=null)
+    public function onChildProcessOutput($type, $buffer, $process = null)
     {
         $lines = explode("\n", trim($buffer));
 
@@ -332,7 +332,7 @@ 
 
             // we tag the output with the id of the child process
             if (trim($line) !== '') {
-                $msg = '[' . ($process ? $process->getPid() : ''). '] ' . trim($line);
+                $msg = '[' . ($process ? $process->getPid() : '') . '] ' . trim($line);
                 if ($type == 'err') {
                     $this->writeErrorln($msg, OutputInterface::VERBOSITY_QUIET, OutputInterface::OUTPUT_RAW);
                 } else {
@@ -366,7 +366,7 @@ 
 
         // filter away all migrations except 'to do' ones
         $toExecute = array();
-        foreach($migrationDefinitions as $name => $migrationDefinition) {
+        foreach ($migrationDefinitions as $name => $migrationDefinition) {
             if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && in_array($migration->status, $allowedStatuses))) {
                 $toExecute[$name] = $isChild ? $migrationService->parseMigrationDefinition($migrationDefinition) : $migrationDefinition;
             }
@@ -408,7 +408,7 @@ 
     {
         $output->writeln('Found ' . count($toExecute) . ' migrations in ' . count($paths) . ' directories');
         $output->writeln('In the same directories, migrations previously executed: ' . $this->migrationsAlreadyDone[Migration::STATUS_DONE] .
-            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: '. $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
+            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: ' . $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
         if ($this->migrationsAlreadyDone[Migration::STATUS_STARTED]) {
             $output->writeln('<info>In the same directories, migrations currently executing: ' . $this->migrationsAlreadyDone[Migration::STATUS_STARTED] . '</info>');
         }
@@ -421,7 +421,7 @@ 
     protected function groupMigrationsByPath($toExecute)
     {
         $paths = array();
-        foreach($toExecute as $name => $migrationDefinition) {
+        foreach ($toExecute as $name => $migrationDefinition) {
             $path = dirname($migrationDefinition->path);
             if (!isset($paths[$path])) {
                 $paths[$path] = 1;
@@ -498,12 +498,12 @@ 
             $builderArgs[] = '--separate-process';
         }
         if ($input->getOption('set-reference')) {
-            foreach($input->getOption('set-reference') as $refSpec) {
+            foreach ($input->getOption('set-reference') as $refSpec) {
                 $builderArgs[] = '--set-reference=' . $refSpec;
             }
         }
         if ($input->getOption('child-process-php-ini-config')) {
-            foreach($input->getOption('child-process-php-ini-config') as $iniSpec) {
+            foreach ($input->getOption('child-process-php-ini-config') as $iniSpec) {
                 $builderArgs[] = '--child-process-php-ini-config=' . $iniSpec;
             }
         }

Command/MigrateCommand.php

Spacing +6 added lines, -6 removed lines

@@ -124,7 +124,7 @@ 
                 $prefix = array($php);
 
                 if ($input->getOption('child-process-php-ini-config')) {
-                    foreach($input->getOption('child-process-php-ini-config') as $iniSpec) {
+                    foreach ($input->getOption('child-process-php-ini-config') as $iniSpec) {
                         $ini = explode(':', $iniSpec, 2);
                         if (count($ini) < 2 || $ini[0] === '') {
                             throw new MigrationBundleException("Invalid php ini specification: '$iniSpec'");
@@ -150,7 +150,7 @@ 
 
         if ($input->getOption('set-reference') && !$input->getOption('separate-process')) {
             $refResolver = $this->getContainer()->get('ez_migration_bundle.reference_resolver.customreference');
-            foreach($input->getOption('set-reference') as $refSpec) {
+            foreach ($input->getOption('set-reference') as $refSpec) {
                 $ref = explode(':', $refSpec, 2);
                 if (count($ref) < 2 || $ref[0] === '') {
                     throw new MigrationBundleException("Invalid reference specification: '$refSpec'");
@@ -250,9 +250,9 @@ 
         $time = microtime(true) - $start;
         if ($input->getOption('separate-process')) {
             // in case of using subprocesses, we can not measure max memory used
-            $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs</info>");
+            $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs</info>");
         } else {
-            $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB</info>');
+            $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB</info>');
         }
 
         return $failed;
@@ -484,7 +484,7 @@ 
             $builderArgs[] = '--no-debug';
         }
         if ($input->getOption('siteaccess')) {
-            $builderArgs[] = '--siteaccess='.$input->getOption('siteaccess');
+            $builderArgs[] = '--siteaccess=' . $input->getOption('siteaccess');
         }
         switch ($this->verbosity) {
             case OutputInterface::VERBOSITY_VERBOSE:
@@ -516,7 +516,7 @@ 
             $builderArgs[] = '--no-transactions';
         }
         if ($input->getOption('set-reference')) {
-            foreach($input->getOption('set-reference') as $refSpec) {
+            foreach ($input->getOption('set-reference') as $refSpec) {
                 $builderArgs[] = '--set-reference=' . $refSpec;
             }
         }

Core/ReferenceResolver/ExpressionResolver.php

Spacing +2 added lines, -2 removed lines

@@ -45,12 +45,12 @@
         return array(
             new ExpressionFunction(
                 'resolve',
-                function ($str) {
+                function($str) {
                     /// @todo we could implement this via eg a static class var which holds a pointer to $this->referenceResolver
                     //return sprintf('(is_string(%1$s) ? FakerResolver::resolveExpressionLanguageReference(%1$s) : %1$s)', $str);
                     return "throw new MigrationBundleException('The \'resolve\' expression language operator can not be compiled, only evaluated'";
                 },
-                function ($arguments, $str) use ($resolver) {
+                function($arguments, $str) use ($resolver) {
                     if (!is_string($str)) {
                         return $str;
                     }

Core/ReferenceResolver/ChainResolver.php

Spacing +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
         $refs = array();
 
         foreach ($this->resolvers as $resolver) {
-            if (! $resolver instanceof EnumerableReferenceResolverInterface) {
+            if (!$resolver instanceof EnumerableReferenceResolverInterface) {
                 // Disabled - we now allow chaining enumerable and non-enumerable sets
                 //throw new MigrationBundleException("Could not enumerate references because of chained resolver of type: " . get_class($resolver));
                 continue;

Core/Executor/ReferenceExecutor.php

Spacing +3 added lines, -3 removed lines

@@ -163,7 +163,7 @@ 
             throw new MigrationBundleException("Invalid step definition: file '$fileName' for saving references already exists");
         }
 
-        if (! $this->referenceResolver instanceof EnumerableReferenceResolverInterface) {
+        if (!$this->referenceResolver instanceof EnumerableReferenceResolverInterface) {
             throw new MigrationBundleException("Can not save references as resolver is not enumerable");
         }
 
@@ -208,7 +208,7 @@ 
         $value = $this->dumpVar($this->referenceResolver->resolveReference($dsl['identifier']));
 
         if (isset($context['output']) && $context['output'] instanceof OutputInterface) {
-            $context['output']->write($label . $value, false, OutputInterface::OUTPUT_RAW|OutputInterface::VERBOSITY_NORMAL);
+            $context['output']->write($label . $value, false, OutputInterface::OUTPUT_RAW | OutputInterface::VERBOSITY_NORMAL);
         } else {
             echo $label . $value;
         }
@@ -230,7 +230,7 @@ 
 
         $dumper->dump(
             $cloner->cloneVar($var),
-            function ($line, $depth) use (&$output) {
+            function($line, $depth) use (&$output) {
                 // A negative depth means "end of dump"
                 if ($depth >= 0) {
                     // Adds a two spaces indentation to the line

Core/Loader/FilesystemRecursive.php

Braces +1 added lines, -2 removed lines

@@ -61,8 +61,7 @@
                         }
                     }
                 }
-            }
-            else {
+            } else {
                 throw new MigrationBundleException("Path '$path' is neither a file nor directory");
             }
         }

Core/MigrationService.php

Spacing +10 added lines, -10 removed lines

@@ -310,7 +310,7 @@ 
         }
 
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
-            throw new MigrationBundleException("Can not execute " . $this->getEntityName($migrationDefinition). " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
+            throw new MigrationBundleException("Can not execute " . $this->getEntityName($migrationDefinition) . " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
         }
 
         /// @todo add support for setting in $migrationContext a userContentType, userGroupContentType ?
@@ -344,7 +344,7 @@ 
 
         try {
 
-            $i = $stepOffset+1;
+            $i = $stepOffset + 1;
             $finalStatus = Migration::STATUS_DONE;
             $finalMessage = null;
 
@@ -481,12 +481,12 @@ 
     public function resumeMigration(Migration $migration, $useTransaction = true, array $forcedReferences = array())
     {
         if ($migration->status != Migration::STATUS_SUSPENDED) {
-            throw new MigrationBundleException("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': it is not in suspended status");
+            throw new MigrationBundleException("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': it is not in suspended status");
         }
 
         $migrationDefinitions = $this->getMigrationsDefinitions(array($migration->path));
         if (!count($migrationDefinitions)) {
-            throw new MigrationBundleException("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': its definition is missing");
+            throw new MigrationBundleException("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': its definition is missing");
         }
 
         $defs = $migrationDefinitions->getArrayCopy();
@@ -494,24 +494,24 @@ 
 
         $migrationDefinition = $this->parseMigrationDefinition($migrationDefinition);
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
-            throw new MigrationBundleException("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': {$migrationDefinition->parsingError}");
+            throw new MigrationBundleException("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': {$migrationDefinition->parsingError}");
         }
 
         // restore context
         $this->contextHandler->restoreCurrentContext($migration->name);
 
         if ($forcedReferences) {
-            foreach($forcedReferences as $name => $value) {
+            foreach ($forcedReferences as $name => $value) {
                 $this->referenceResolver->addReference($name, $value, true);
             }
         }
 
         if (!isset($this->migrationContext[$migration->name])) {
-            throw new MigrationBundleException("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is missing");
+            throw new MigrationBundleException("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is missing");
         }
         $restoredContext = $this->migrationContext[$migration->name];
-        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'] )) {
-            throw new MigrationBundleException("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is invalid");
+        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'])) {
+            throw new MigrationBundleException("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is invalid");
         }
 
         // update migration status
@@ -532,7 +532,7 @@ 
      * @param bool|null $forceSigchildEnabled
      * @return array
      */
-    protected function migrationContextFromParameters($defaultLanguageCode = null, $adminLogin = null, $forceSigchildEnabled = null )
+    protected function migrationContextFromParameters($defaultLanguageCode = null, $adminLogin = null, $forceSigchildEnabled = null)
     {
         $properties = array();
 

Core/StorageHandler/Database/Migration.php

Spacing +6 added lines, -6 removed lines

@@ -206,7 +206,7 @@ 
     public function endMigration(APIMigration $migration, $force = false)
     {
         if ($migration->status == APIMigration::STATUS_STARTED) {
-            throw new MigrationBundleException($this->getEntityName($migration)." '{$migration->name}' can not be ended as its status is 'started'...");
+            throw new MigrationBundleException($this->getEntityName($migration) . " '{$migration->name}' can not be ended as its status is 'started'...");
         }
 
         $this->createTableIfNeeded();
@@ -233,13 +233,13 @@ 
         if (!is_array($existingMigrationData)) {
             // commit to release the lock
             $conn->commit();
-            throw new MigrationBundleException($this->getEntityName($migration)." '{$migration->name}' can not be ended as it is not found");
+            throw new MigrationBundleException($this->getEntityName($migration) . " '{$migration->name}' can not be ended as it is not found");
         }
 
         if (($existingMigrationData['status'] != APIMigration::STATUS_STARTED) && !$force) {
             // commit to release the lock
             $conn->commit();
-            throw new MigrationBundleException($this->getEntityName($migration)." '{$migration->name}' can not be ended as it is not executing");
+            throw new MigrationBundleException($this->getEntityName($migration) . " '{$migration->name}' can not be ended as it is not executing");
         }
 
         $conn->update(
@@ -395,7 +395,7 @@ 
         if (!is_array($existingMigrationData)) {
             // commit immediately, to release the lock and avoid deadlocks
             $conn->commit();
-            throw new MigrationBundleException($this->getEntityName($migration)." '{$migration->name}' can not be resumed as it is not found");
+            throw new MigrationBundleException($this->getEntityName($migration) . " '{$migration->name}' can not be resumed as it is not found");
         }
 
         // migration exists
@@ -404,7 +404,7 @@ 
         if ($existingMigrationData['status'] != APIMigration::STATUS_SUSPENDED) {
             // commit to release the lock
             $conn->commit();
-            throw new MigrationBundleException($this->getEntityName($migration)." '{$migration->name}' can not be resumed as it is not suspended");
+            throw new MigrationBundleException($this->getEntityName($migration) . " '{$migration->name}' can not be resumed as it is not suspended");
         }
 
         $migration = new APIMigration(
@@ -466,7 +466,7 @@ 
         foreach ($schema->toSql($dbPlatform) as $sql) {
             try {
                 $this->dbHandler->exec($sql);
-            } catch(QueryException $e) {
+            } catch (QueryException $e) {
                 // work around limitations in both Mysql and Doctrine
                 // @see https://github.com/kaliop-uk/ezmigrationbundle/issues/176
                 if (strpos($e->getMessage(), '1071 Specified key was too long; max key length is 767 bytes') !== false &&