kaliop-uk / ezmigrationbundle

Core/MigrationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
     }
 
     /**
-     * @return string[]
+     * @return integer[]
      */
     public function listExecutors()
     {

Spacing +8 added lines, -8 removed lines

@@ -259,7 +259,7 @@ 
         }
 
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
-            throw new \Exception("Can not execute " . $this->getEntityName($migrationDefinition). " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
+            throw new \Exception("Can not execute " . $this->getEntityName($migrationDefinition) . " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
         }
 
         /// @todo add support for setting in $migrationContext a userContentType ?
@@ -293,7 +293,7 @@ 
 
         try {
 
-            $i = $stepOffset+1;
+            $i = $stepOffset + 1;
             $finalStatus = Migration::STATUS_DONE;
             $finalMessage = null;
 
@@ -418,12 +418,12 @@ 
     public function resumeMigration(Migration $migration, $useTransaction = true)
     {
         if ($migration->status != Migration::STATUS_SUSPENDED) {
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': it is not in suspended status");
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': it is not in suspended status");
         }
 
         $migrationDefinitions = $this->getMigrationsDefinitions(array($migration->path));
         if (!count($migrationDefinitions)) {
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': its definition is missing");
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': its definition is missing");
         }
 
         $defs = $migrationDefinitions->getArrayCopy();
@@ -431,18 +431,18 @@ 
 
         $migrationDefinition = $this->parseMigrationDefinition($migrationDefinition);
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': {$migrationDefinition->parsingError}");
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': {$migrationDefinition->parsingError}");
         }
 
         // restore context
         $this->contextHandler->restoreCurrentContext($migration->name);
 
         if (!isset($this->migrationContext[$migration->name])) {
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is missing");
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is missing");
         }
         $restoredContext = $this->migrationContext[$migration->name];
-        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'] )) {
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is invalid");
+        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'])) {
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is invalid");
         }
 
         // update migration status

Command/GenerateCommand.php

Spacing +2 added lines, -2 removed lines

@@ -150,7 +150,7 @@ 
         }
 
         // allow to generate migrations for many entities
-        if (strpos($matchValue, ',') !== false ) {
+        if (strpos($matchValue, ',') !== false) {
             $matchValue = explode(',', $matchValue);
         }
 
@@ -260,7 +260,7 @@ 
     {
         $migrationService = $this->getMigrationService();
         $executors = $migrationService->listExecutors();
-        foreach($executors as $key => $name) {
+        foreach ($executors as $key => $name) {
             $executor = $migrationService->getExecutor($name);
             if (!$executor instanceof MigrationGeneratorInterface) {
                 unset($executors[$key]);

Core/Executor/ContentManager.php

Spacing +1 added lines, -1 removed lines

@@ -559,7 +559,7 @@
                     $locations = $locationService->loadLocations($content->contentInfo);
                     if (count($locations) > 1) {
                         $otherParentLocations = array();
-                        foreach($locations as $otherLocation) {
+                        foreach ($locations as $otherLocation) {
                             if ($otherLocation->id != $location->id) {
                                 $otherParentLocations[] = $otherLocation->parentLocationId;
                             }

Doc Comments +1 added lines, -1 removed lines

@@ -648,7 +648,7 @@
      * @param string $contentTypeIdentifier
      * @param array $context
      * @throws \InvalidArgumentException
-     * @return mixed
+     * @return \Kaliop\eZMigrationBundle\API\Value\MigrationStep
      */
     protected function getFieldValue($value, FieldDefinition $fieldDefinition, $contentTypeIdentifier, array $context = array())
     {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use eZ\Publish\API\Repository\Values\ContentType\ContentType;
 use eZ\Publish\API\Repository\Values\ContentType\FieldDefinition;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use eZ\Publish\API\Repository\Values\Content\Content;
 use eZ\Publish\API\Repository\Values\Content\ContentCreateStruct;
 use eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct;

Core/Helper/SortConverter.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     public function sortField2Hash($value)
     {
         $ref = new \ReflectionClass('eZ\Publish\API\Repository\Values\Content\Location');
-        foreach($ref->getConstants() as $key => $val) {
+        foreach ($ref->getConstants() as $key => $val) {
             if (strpos($key, 'SORT_FIELD_') === 0 && $val == $value) {
                 return strtolower(substr($key, 11));
             }

Core/Executor/ContentTypeManager.php

Spacing +1 added lines, -1 removed lines

@@ -192,7 +192,7 @@
                 }
 
                 // Add new attributes
-                foreach($newFieldDefinitions as $newFieldDefinition) {
+                foreach ($newFieldDefinitions as $newFieldDefinition) {
                     if ($newFieldDefinition->position == 0) {
                         $newFieldDefinition->position = ++$maxFieldDefinitionPos;
                     }

Doc Comments +4 added lines, -1 removed lines

@@ -652,6 +652,9 @@ 
         return $fieldDefinitionUpdateStruct;
     }
 
+    /**
+     * @param string $contentTypeIdentifier
+     */
     protected function getFieldSettings($value, $fieldTypeIdentifier, $contentTypeIdentifier)
     {
         // 1st update any references in the value array
@@ -704,7 +707,7 @@ 
      *
      * @param string|array $newValue if passed a string, we will use $lang as its language. If passed an array, it will be used as is - expected format [ "eng-GB": "Name", "fre-FR": "Nom", ... ]
      * @param string $lang ex: eng-GB. Not used when $newValue is an array
-     * @param array $currentValue current set of values in all known languages. Will be merged with $newValue, $newValue taking precedence
+     * @param string[] $currentValue current set of values in all known languages. Will be merged with $newValue, $newValue taking precedence
      * @return array in the format [ "eng-GB": "Name", "fre-FR": "Nom", ... ]
      */
     protected function getMultilingualValue($newValue, $lang, $currentValue = array())

Core/Executor/ObjectStateGroupManager.php

Spacing +4 added lines, -4 removed lines

@@ -234,11 +234,11 @@
             if ($mode != 'delete') {
                 $names = array();
                 $descriptions = array();
-                foreach($objectStateGroup->languageCodes as $languageCode) {
-                    $names[$languageCode] =  $objectStateGroup->getName($languageCode);
+                foreach ($objectStateGroup->languageCodes as $languageCode) {
+                    $names[$languageCode] = $objectStateGroup->getName($languageCode);
                 }
-                foreach($objectStateGroup->languageCodes as $languageCode) {
-                    $descriptions[$languageCode] =  $objectStateGroup->getDescription($languageCode);
+                foreach ($objectStateGroup->languageCodes as $languageCode) {
+                    $descriptions[$languageCode] = $objectStateGroup->getDescription($languageCode);
                 }
                 $groupData = array_merge(
                     $groupData,

Core/Executor/ObjectStateManager.php

Spacing +4 added lines, -4 removed lines

@@ -248,11 +248,11 @@
             if ($mode != 'delete') {
                 $names = array();
                 $descriptions = array();
-                foreach($objectState->languageCodes as $languageCode) {
-                    $names[$languageCode] =  $objectState->getName($languageCode);
+                foreach ($objectState->languageCodes as $languageCode) {
+                    $names[$languageCode] = $objectState->getName($languageCode);
                 }
-                foreach($objectState->languageCodes as $languageCode) {
-                    $descriptions[$languageCode] =  $objectState->getDescription($languageCode);
+                foreach ($objectState->languageCodes as $languageCode) {
+                    $descriptions[$languageCode] = $objectState->getDescription($languageCode);
                 }
                 $groupData = array_merge(
                     $groupData,

Core/Executor/MigrationDefinitionExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
     {
         $migrationService = $this->migrationService;
         $executors = $migrationService->listExecutors();
-        foreach($executors as $key => $name) {
+        foreach ($executors as $key => $name) {
             $executor = $migrationService->getExecutor($name);
             if (!$executor instanceof MigrationGeneratorInterface) {
                 unset($executors[$key]);

Doc Comments +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
 
     /**
      * @todo cache this for faster access
-     * @return array
+     * @return integer[]
      */
     protected function getGeneratingExecutors()
     {

Core/Matcher/LocationMatcher.php

Spacing +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
 
         foreach ($contentIds as $contentId) {
             $content = $this->repository->getContentService()->loadContent($contentId);
-            foreach($this->repository->getLocationService()->loadLocations($content->contentInfo) as $location) {
+            foreach ($this->repository->getLocationService()->loadLocations($content->contentInfo) as $location) {
                 $locations[$location->id] = $location;
             }
         }
@@ -124,7 +124,7 @@ 
 
         foreach ($remoteContentIds as $remoteContentId) {
             $content = $this->repository->getContentService()->loadContentByRemoteId($remoteContentId);
-            foreach($this->repository->getLocationService()->loadLocations($content->contentInfo) as $location) {
+            foreach ($this->repository->getLocationService()->loadLocations($content->contentInfo) as $location) {
                 $locations[$location->id] = $location;
             }
         }

Braces +6 added lines, -2 removed lines

@@ -50,7 +50,9 @@ 
 
             $query = new LocationQuery();
             $query->limit = self::INT_MAX_16BIT;
-            if (isset($query->performCount)) $query->performCount = false;
+            if (isset($query->performCount)) {
+                $query->performCount = false;
+            }
             $query->filter = $this->getQueryCriterion($key, $values);
             $results = $this->repository->getSearchService()->findLocations($query);
 
@@ -196,7 +198,9 @@ 
     {
         $query = new LocationQuery();
         $query->limit = self::INT_MAX_16BIT;
-        if (isset($query->performCount)) $query->performCount = false;
+        if (isset($query->performCount)) {
+            $query->performCount = false;
+        }
         $query->filter = new Query\Criterion\ParentLocationId($parentLocationIds);
 
         $results = $this->repository->getSearchService()->findLocations($query);