Issues in Connection.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/Clients/XMPP/Connection.php (21 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\Clients\XMPP;

use PHPDaemon\Core\Daemon;
use PHPDaemon\Core\Timer;
use PHPDaemon\Network\ClientConnection;
use PHPDaemon\XMLStream\XMLStream;

/**
 * @package    NetworkClients
 * @subpackage XMPPClient
 * @author     Vasily Zorin <[email protected]>
 */
class Connection extends ClientConnection
{

    /**
     * @var boolean
     */
    public $use_encryption = false;

    /**
     * @var boolean
     */
    public $authorized;

    /**
     * @var integer
     */
    public $lastId = 0;

    /**
     * @var XMPPRoster
     */
    public $roster;

    /**
     * @var XMLStream
     */
    public $xml;

    /**
     * @var string
     */
    public $fulljid;

    /**
     * @var integer|string Timer ID
     */
    public $keepaliveTimer;

    /**
     * Get next ID
     * @return string
     */
    public function getId()
    {
        $id = ++$this->lastId;
        return dechex($id);
    }

    /**
     * Called when the connection is handshaked (at low-level), and peer is ready to recv. data
     * @return void
     */
    public function onReady()
    {
        $this->createXMLStream();
        $this->startXMLStream();
        $this->keepaliveTimer = setTimeout(function ($timer) {

            $this->ping();
        }, 1e6 * 30);
    }

    /**
     * Called when session finishes
     * @return void
     */
    public function onFinish()
    {
        parent::onFinish();
        $this->event('disconnect');
        if (isset($this->xml)) {
            $this->xml->finish();
        }
        unset($this->roster);
        if ($this->keepaliveTimer) {
            Timer::remove($this->keepaliveTimer);
        }
    }

    /**
     * @TODO DESCR
     * @param string $s
     */
    public function sendXML($s)
    {
        //Daemon::log(Debug::dump(['send', $s]));
        $this->write($s);
    }

    /**
     * @TODO DESCR
     */
    public function startXMLStream()
    {
        $this->sendXML(
            '<?xml version="1.0"?>' .
            '<stream:stream xmlns:stream="http://etherx.jabber.org/streams" version="1.0" xmlns="jabber:client" to="' . $this->host . '" xml:lang="en" xmlns:xml="http://www.w3.org/XML/1998/namespace">'
        );
    }

    /**
     * @TODO DESCR
     * @param  string $xml
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function iqSet($xml, $cb)

    {
        if (!isset($this->xml)) {
            return false;
        }
        $id = $this->getId();
        $this->xml->addIdHandler($id, $cb);
        $this->sendXML('<iq xmlns="jabber:client" type="set" id="' . $id . '">' . $xml . '</iq>');
        return true;
    }

    /**
     * @TODO DESCR
     * @param  string $to
     * @param  string $xml
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function iqSetTo($to, $xml, $cb)

    {
        if (!isset($this->xml)) {
            return false;
        }
        $id = $this->getId();
        $this->xml->addIdHandler($id, $cb);
        $this->sendXML('<iq xmlns="jabber:client" type="set" id="' . $id . '" to="' . htmlspecialchars($to) . '">' . $xml . '</iq>');
        return true;
    }

    /**
     * @TODO DESCR
     * @param  string $xml
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function iqGet($xml, $cb)

    {
        if (!isset($this->xml)) {
            return false;
        }
        $id = $this->getId();
        $this->xml->addIdHandler($id, $cb);
        $this->sendXML('<iq xmlns="jabber:client" type="get" id="' . $id . '">' . $xml . '</iq>');
        return true;
    }

    /**
     * @TODO DESCR
     * @param  string $to
     * @param  string $xml
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function iqGetTo($to, $xml, $cb)

    {
        if (!isset($this->xml)) {
            return false;
        }
        $id = $this->getId();
        $this->xml->addIdHandler($id, $cb);
        $this->sendXML('<iq xmlns="jabber:client" type="get" id="' . $id . '" to="' . htmlspecialchars($to) . '">' . $xml . '</iq>');
        return true;
    }

    /**
     * @TODO DESCR
     * @param  string $to

     * @param  callable $cb

     * @callback $cb ( )
     * @return boolean
     */
    public function ping($to = null, $cb = null)
    {
        if (!isset($this->xml)) {
            return false;
        }
        if ($to === null) {
            $to = $this->host;
        }
        //Daemon::log('Sending ping to '.$to);
        return $this->iqGetTo($to, '<ping xmlns="urn:xmpp:ping"/>', $cb);

    }

    /**
     * @TODO DESCR
     * @param  string $ns
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function queryGet($ns, $cb)
    {
        return $this->iqGet('<query xmlns="' . $ns . '" />', $cb);
    }

    /**
     * @TODO DESCR
     * @param  string $ns
     * @param  string $xml
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function querySet($ns, $xml, $cb)
    {
        return $this->iqSet('<query xmlns="' . $ns . '">' . $xml . '</query>', $cb);
    }

    /**
     * @TODO DESCR
     * @param  string $to
     * @param  string $ns
     * @param  string $xml
     * @param  callable $cb
     * @callback $cb ( )
     * @return boolean
     */
    public function querySetTo($to, $ns, $xml, $cb)
    {
        return $this->iqSetTo($to, '<query xmlns="' . $ns . '">' . $xml . '</query>', $cb);
    }

    /**
     * @TODO DESCR
     */
    public function createXMLStream()
    {
        $this->xml = new XMLStream;
        $this->xml->setDefaultNS('jabber:client');
        $this->xml->addXPathHandler('{http://etherx.jabber.org/streams}features', function ($xml) {
            /** @var XMLStream $xml */
            if ($xml->hasSub('starttls') and $this->use_encryption) {
                $this->sendXML("<starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'><required /></starttls>");
            } elseif ($xml->hasSub('bind') and $this->authorized) {
                $id = $this->getId();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $this->iqSet('<bind xmlns="urn:ietf:params:xml:ns:xmpp-bind"><resource>' . $this->path . '</resource></bind>',
                    function ($xml) {
                        if ($xml->attrs['type'] === 'result') {
                            $this->fulljid = $xml->sub('bind')->sub('jid')->data;
                            $jidarray = explode('/', $this->fulljid);
                            $this->jid = $jidarray[0];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        }
                        $this->iqSet('<session xmlns="urn:ietf:params:xml:ns:xmpp-session" />', function ($xml) {

                            $this->roster = new XMPPRoster($this);
                            if ($this->onConnected) {
                                $this->connected = true;
                                $this->onConnected->executeAll($this);
                                $this->onConnected = null;
                            }
                            $this->event('connected');
                        });
                    });
            } else {
                if (mb_orig_strlen($this->password)) {
                    $this->sendXML("<auth xmlns='urn:ietf:params:xml:ns:xmpp-sasl' mechanism='PLAIN'>" . base64_encode("\x00" . $this->user . "\x00" . $this->password) . "</auth>");
                } else {
                    $this->sendXML("<auth xmlns='urn:ietf:params:xml:ns:xmpp-sasl' mechanism='ANONYMOUS'/>");
                }
            }
        });
        $this->xml->addXPathHandler('{urn:ietf:params:xml:ns:xmpp-sasl}success', function ($xml) {

            $this->authorized = true;
            $this->xml->finish();
            $this->createXMLStream();
            $this->startXMLStream();
        });
        $this->xml->addXPathHandler('{urn:ietf:params:xml:ns:xmpp-sasl}failure', function ($xml) {

            if ($this->onConnected) {
                $this->connected = false;
                $func = $this->onConnected;
                $func($this);
                $this->onConnected = null;
            }
            $this->finish();
        });
        $this->xml->addXPathHandler('{urn:ietf:params:xml:ns:xmpp-tls}proceed', function ($xml) {

            Daemon::log("XMPPClient: TLS not supported.");
        });
        $this->xml->addXPathHandler('{jabber:client}message', function ($xml) {
            if (isset($xml->attrs['type'])) {
                $payload['type'] = $xml->attrs['type'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $payload['type'] = 'chat';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
            $payload['xml'] = $xml;
            $payload['from'] = $xml->attrs['from'];
            if ($xml->hasSub('body')) {
                $payload['body'] = $xml->sub('body')->data;
                $this->event('message', $payload);
            }
        });
    }

    /**
     * Send XMPP Message
     * @param string $to
     * @param string $body
     * @param string $type
     * @param string $subject

     */
    public function message($to, $body, $type = 'chat', $subject = null, $payload = null)
    {
        if ($type === null) {
            $type = 'chat';
        }

        $to = htmlspecialchars($to);
        $body = htmlspecialchars($body);
        $subject = htmlspecialchars($subject);

        $out = '<message from="' . $this->fulljid . '" to="' . $to . '" type="' . $type . '">';
        if ($subject) {
            $out .= '<subject>' . $subject . '</subject>';
        }
        $out .= '<body>' . $body . '</body>';
        if ($payload) {
            $out .= $payload;
        }
        $out .= "</message>";

        $this->sendXML($out);
    }

    /**
     * Set Presence
     * @param string $status

     * @param string $show
     * @param string $to

     * @param string $type
     * @param integer $priority
     */
    public function presence($status = null, $show = 'available', $to = null, $type = 'available', $priority = 0)
    {
        if ($type === 'available') {
            $type = '';
        }
        $to = htmlspecialchars($to);
        $status = htmlspecialchars($status);
        $show = htmlspecialchars($show);
        $type = htmlspecialchars($type);
        $priority = htmlspecialchars($priority);
        if ($show === 'unavailable') {
            $type = 'unavailable';
        }

        $out = "<presence";
        $out .= ' from="' . $this->fulljid . '"';
        if ($to) {
            $out .= ' to="' . $to . '"';
        }
        if ($type) {
            $out .= ' type="' . $type . '"';
        }
        $inner = '';
        if ($show !== 'available') {
            $inner .= "<show>$show</show>";
        }
        if ($status) {
            $inner .= "<status>$status</status>";
        }
        if ($priority) {
            $inner .= "<priority>$priority</priority>";
        }
        if ($inner === '') {
            $out .= "/>";
        } else {
            $out .= '>' . $inner . '</presence>';
        }

        $this->sendXML($out);
    }

    /**
     * @TODO DESCR
     * @param string $jid
     * @param callable $cb
     * @callback $cb ( )
     */
    public function getVCard($jid, $cb)
    {
        $id = $this->getId();
        $this->xml->addIdHandler($id, function ($xml) use ($cb) {
            $vcard = [];
            $vcardXML = $xml->sub('vcard');
            foreach ($vcardXML->subs as $sub) {
                if ($sub->subs) {
                    $vcard[$sub->name] = [];
                    foreach ($sub->subs as $sub_child) {
                        $vcard[$sub->name][$sub_child->name] = $sub_child->data;
                    }
                } else {
                    $vcard[$sub->name] = $sub->data;
                }
            }
            $vcard['from'] = $xml->attrs['from'];
            $cb($vcard);
        });
        $id = htmlspecialchars($id);

        if ($jid != null) {
            $jid = htmlspecialchars($jid);
            $this->send('<iq type="get" id="' . $id . '" to="' . $jid . '"><vCard xmlns="vcard-temp" /></iq>');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            $this->send('<iq type="get" id="' . $id . '"><vCard xmlns="vcard-temp" /></iq>');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
    }

    /**
     * Called when new data received
     * @return void
     */
    public function onRead()
    {
        Timer::setTimeout($this->keepaliveTimer);
        if (isset($this->xml)) {
            $this->xml->feed($this->readUnlimited());
        }
    }
}


1			<?php
2			namespace PHPDaemon\Clients\XMPP;
3
4			use PHPDaemon\Core\Daemon;
5			use PHPDaemon\Core\Timer;
6			use PHPDaemon\Network\ClientConnection;
7			use PHPDaemon\XMLStream\XMLStream;
8
9			/**
10			* @package NetworkClients
11			* @subpackage XMPPClient
12			* @author Vasily Zorin <[email protected]>
13			*/
14			class Connection extends ClientConnection
15			{
16
17			/**
18			* @var boolean
19			*/
20			public $use_encryption = false;
21
22			/**
23			* @var boolean
24			*/
25			public $authorized;
26
27			/**
28			* @var integer
29			*/
30			public $lastId = 0;
31
32			/**
33			* @var XMPPRoster
34			*/
35			public $roster;
36
37			/**
38			* @var XMLStream
39			*/
40			public $xml;

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/Clients/XMPP/Connection.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like