kadet1090 / nucleus

Xml/XmlParser.php

Doc Comments +3 added lines

@@ -126,6 +126,9 @@
         return [$name, $namespace];
     }
 
+    /**
+     * @param string|null $prefix
+     */
     private function _lookup($prefix, $namespaces)
     {
         if ($prefix === 'xmlns') {

Spacing +8 added lines, -8 removed lines

@@ -71,13 +71,13 @@ 
         xml_parser_set_option($this->_parser, XML_OPTION_SKIP_WHITE, 1);
         xml_parser_set_option($this->_parser, XML_OPTION_CASE_FOLDING, 0);
 
-        xml_set_element_handler($this->_parser, function ($parser, $name, $attrs) {
+        xml_set_element_handler($this->_parser, function($parser, $name, $attrs) {
             $this->handleElementStart($name, $attrs);
-        }, function ($parser, $name) {
+        }, function($parser, $name) {
             $this->handleElementEnd();
         });
 
-        xml_set_character_data_handler($this->_parser, function ($parser, $data) {
+        xml_set_character_data_handler($this->_parser, function($parser, $data) {
             $this->handleTextData($data);
         });
 
@@ -119,10 +119,10 @@ 
         list($attributes, $namespaces) = $this->_attributes($attrs);
         list($tag, $prefix)            = XmlElement::resolve($name);
 
-        $uri   = $this->_lookup($prefix, $namespaces);
+        $uri = $this->_lookup($prefix, $namespaces);
 
         /** @var XmlElement $element */
-        $element = $this->factory->create($uri, $tag, [ $name, $uri ]);
+        $element = $this->factory->create($uri, $tag, [$name, $uri]);
         foreach ($attributes as $name => $value) {
             $element->setAttribute($name, $value);
         }
@@ -137,7 +137,7 @@ 
         if (count($this->_stack) > 1) {
             end($this->_stack)->append($element);
         }
-        $this->emit('parse.begin', [ $element ]);
+        $this->emit('parse.begin', [$element]);
 
         $this->_stack[] = $element;
     }
@@ -150,10 +150,10 @@ 
 
         $element = array_pop($this->_stack);
         if (count($this->_stack) == 1) {
-            $this->emit('element', [ $element ]);
+            $this->emit('element', [$element]);
         }
 
-        $this->emit('parse.end', [ $element ]);
+        $this->emit('parse.end', [$element]);
     }
 
     private function handleTextData($data)

Exception/Protocol/StreamErrorException.php

Spacing +1 added lines, -1 removed lines

@@ -40,6 +40,6 @@
 
     private function generateMessage(Error $error) : string
     {
-        return 'Stream error: '.str_replace('-', ' ', $error->kind).($error->text ? " ({$error->text})" : null);
+        return 'Stream error: ' . str_replace('-', ' ', $error->kind) . ($error->text ? " ({$error->text})" : null);
     }
 }

Utils/BetterEmitter.php

Spacing +4 added lines, -4 removed lines

@@ -40,7 +40,7 @@ 
 
     public function removeListener($event, callable $listener)
     {
-        if(!isset($this->listeners[$event])) {
+        if (!isset($this->listeners[$event])) {
             return false;
         }
 
@@ -66,7 +66,7 @@ 
 
     private function addListener($event, callable $listener, int $priority = 0)
     {
-        if(!isset($this->listeners[$event])) {
+        if (!isset($this->listeners[$event])) {
             $this->listeners[$event] = new PriorityCollection();
         }
 
@@ -80,7 +80,7 @@ 
         }
 
         $condition = $this->emitterResolveCondition($condition);
-        return function (...$arguments) use ($listener, $condition) {
+        return function(...$arguments) use ($listener, $condition) {
             if ($condition(...$arguments)) {
                 $listener(...$arguments);
             }
@@ -89,7 +89,7 @@ 
 
     private function getOnceCallable(callable $listener, $event) : callable
     {
-        return $onceListener = function (...$arguments) use (&$onceListener, $event, $listener) {
+        return $onceListener = function(...$arguments) use (&$onceListener, $event, $listener) {
             $this->removeListener($event, $onceListener);
 
             $listener(...$arguments);

Utils/Filter.php

Spacing +5 added lines, -5 removed lines

@@ -19,28 +19,28 @@ 
 
 function xmlns($uri)
 {
-    return function (XmlElement $element) use ($uri) {
+    return function(XmlElement $element) use ($uri) {
         return $element->namespaceURI === $uri;
     };
 }
 
 function tag($name)
 {
-    return function (XmlElement $element) use ($name) {
+    return function(XmlElement $element) use ($name) {
         return $element->localName === $name;
     };
 }
 
 function ofType($class)
 {
-    return function ($object) use ($class) {
+    return function($object) use ($class) {
         return $object instanceof $class;
     };
 }
 
 function all(callable ...$functions)
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if (!$function(...$args)) {
                 return false;
@@ -53,7 +53,7 @@ 
 
 function any(callable ...$functions)
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if ($function(...$args)) {
                 return true;

Stream/Error.php

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
 
     public function getText()
     {
-        if($text = $this->query(".//xmpp:text")->with('xmpp', 'urn:ietf:params:xml:ns:xmpp-streams')->query()->item(0)) {
+        if ($text = $this->query(".//xmpp:text")->with('xmpp', 'urn:ietf:params:xml:ns:xmpp-streams')->query()->item(0)) {
             return $text;
         }
 

Xml/XmlElement.php

Doc Comments +4 added lines, -1 removed lines

@@ -220,7 +220,7 @@ 
      * Retrieves array of matching elements
      *
      * @param string $name  Requested element tag name
-     * @param null   $uri   Requested element namespace
+     * @param null|string   $uri   Requested element namespace
      *
      * @return XmlElement[] Found Elements
      */
@@ -248,6 +248,9 @@ 
         return $this->elements($name, $uri)[$index] ?? false;
     }
 
+    /**
+     * @param \Closure $predicate
+     */
     public function all($predicate) {
         $predicate = filter\predicate($predicate);
         return array_filter($this->_children, $predicate);

Spacing +20 added lines, -20 removed lines

@@ -88,18 +88,18 @@ 
 
     public function xml($clean = true): string
     {
-        if($this->namespace && $this->_prefix === null) {
+        if ($this->namespace && $this->_prefix === null) {
             $this->_prefix = $this->lookupPrefix($this->namespace);
         }
 
         $attributes = $this->attributes();
 
         $result = "<{$this->name}";
-        $result .= ' '.implode(' ', array_map(function($key, $value) {
-            return $key.'="'.htmlspecialchars($value, ENT_QUOTES).'"';
+        $result .= ' ' . implode(' ', array_map(function($key, $value) {
+            return $key . '="' . htmlspecialchars($value, ENT_QUOTES) . '"';
         }, array_keys($attributes), array_values($attributes)));
 
-        if(!empty($this->_children)) {
+        if (!empty($this->_children)) {
             $result .= ">{$this->innerXml}</{$this->name}>";
         } else {
             $result .= "/>";
@@ -111,7 +111,7 @@ 
     public function getInnerXml()
     {
         return implode('', array_map(function($element) {
-            if(is_string($element)) {
+            if (is_string($element)) {
                 return htmlspecialchars($element);
             } elseif ($element instanceof XmlElement) {
                 return $element->xml(false);
@@ -123,12 +123,12 @@ 
 
     public function setAttribute(string $attribute, $value, string $uri = null)
     {
-        if($uri === 'http://www.w3.org/2000/xmlns/') {
+        if ($uri === 'http://www.w3.org/2000/xmlns/') {
             $this->setNamespace($value, $attribute);
             return;
         }
 
-        if($uri !== null) {
+        if ($uri !== null) {
             $attribute = $this->_prefix($attribute, $uri);
         }
 
@@ -137,7 +137,7 @@ 
 
     public function getAttribute(string $attribute, string $uri = null)
     {
-        if($uri !== null) {
+        if ($uri !== null) {
             $attribute = $this->_prefix($attribute, $uri);
         }
 
@@ -154,11 +154,11 @@ 
      */
     public function getNamespaces($parent = true): array
     {
-        if(!$this->_parent) {
+        if (!$this->_parent) {
             return $this->_namespaces;
         }
 
-        if($parent) {
+        if ($parent) {
             return array_merge($this->_namespaces, $this->_parent->getNamespaces());
         } else {
             return array_diff_assoc($this->_namespaces, $this->_parent->getNamespaces());
@@ -169,7 +169,7 @@ 
     {
         $namespaces = $this->getNamespaces(false);
         $namespaces = array_map(function($prefix, $uri) {
-            return [ $prefix ? "xmlns:{$prefix}" : 'xmlns', $uri ];
+            return [$prefix ? "xmlns:{$prefix}" : 'xmlns', $uri];
         }, array_values($namespaces), array_keys($namespaces));
 
         return array_merge(
@@ -194,7 +194,7 @@ 
      */
     public function setNamespace(string $uri, $prefix = false)
     {
-        if($prefix === false) {
+        if ($prefix === false) {
             $prefix = $this->_prefix;
         }
 
@@ -213,15 +213,15 @@ 
 
     public function append($element)
     {
-        if(!is_string($element) && !$element instanceof XmlElement) {
+        if (!is_string($element) && !$element instanceof XmlElement) {
             throw new InvalidArgumentException(helper\format('$element should be either string or object of {class} class, {type} given', [
                 'class' => XmlElement::class,
                 'type'  => helper\typeof($element)
             ]));
         }
 
-        if($element instanceof XmlElement) {
-            $element->parent  = $this;
+        if ($element instanceof XmlElement) {
+            $element->parent = $this;
         }
 
         return $this->_children[] = $element;
@@ -229,7 +229,7 @@ 
 
     public function getName()
     {
-        return ($this->_prefix ? $this->prefix.':' : null).$this->localName;
+        return ($this->_prefix ? $this->prefix . ':' : null) . $this->localName;
     }
 
     public function getPrefix()
@@ -244,17 +244,17 @@ 
 
     protected function setParent(XmlElement $parent)
     {
-        if(!$this->_prefix && ($prefix = $parent->lookupPrefix($this->namespace)) !== false) {
+        if (!$this->_prefix && ($prefix = $parent->lookupPrefix($this->namespace)) !== false) {
             $this->_namespaces[$this->namespace] = $prefix;
             $this->_prefix = $prefix;
         }
 
         $this->_parent = $parent;
-        if($this->namespace === false) {
+        if ($this->namespace === false) {
             $this->namespace = $parent->namespace;
         }
 
-        if(!$this->_prefix) {
+        if (!$this->_prefix) {
             $this->_prefix = $this->lookupPrefix($this->namespace);
         }
     }
@@ -270,7 +270,7 @@ 
     public function elements($name, $uri = null) : array
     {
         $predicate = filter\tag($name);
-        if($uri !== null) {
+        if ($uri !== null) {
             $predicate = filter\all($predicate, filter\xmlns($uri));
         }
 

Xml/XPathQuery.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
     public function query(string $query = null)
     {
         /** @var \DOMNode $element */
-        foreach($this->_xpath->query($query ?: $this->_query) as $element) {
+        foreach ($this->_xpath->query($query ?: $this->_query) as $element) {
             yield $this->getElementFromPath($element->getNodePath());
         }
     }
@@ -70,14 +70,14 @@ 
         array_shift($path);
 
         $current = $this->_context;
-        foreach($path as $chunk) {
+        foreach ($path as $chunk) {
             // Chunk is in format node-name[index], parse it with regex
             preg_match('/([\w\*]+)(?:\[([0-9]+)\])?/', $chunk, $matches);
 
             $name  = $matches[1];
             $index = isset($matches[2]) ? $matches[2] - 1 : 0;
 
-            if($name == '*') {
+            if ($name == '*') {
                 // Path returns * if namespace occurs so we need to obtain index-th child
                 $current = $current->children[$index];
             } else {

Xml/XmlStream.php

Spacing +10 added lines, -10 removed lines

@@ -76,25 +76,25 @@ 
 
         $this->_parser = $parser;
 
-        $this->on('element', function (Error $element) {
+        $this->on('element', function(Error $element) {
             $this->handleError($element);
         }, with\ofType(Error::class));
 
-        $this->_parser->on('parse.begin', function (XmlElement $stream) {
+        $this->_parser->on('parse.begin', function(XmlElement $stream) {
             $this->_stream = $stream;
-            $this->emit('stream.open', [ $stream ]);
+            $this->emit('stream.open', [$stream]);
         }, with\all(with\tag('stream'), with\xmlns(self::NAMESPACE_URI)));
 
-        $this->_parser->on('parse.end', function (XmlElement $stream) {
-            $this->emit('stream.close', [ $stream ]);
+        $this->_parser->on('parse.end', function(XmlElement $stream) {
+            $this->emit('stream.close', [$stream]);
             $this->_stream = null;
         }, with\all(with\tag('stream'), with\xmlns(self::NAMESPACE_URI)));
 
         $this->on('data', [$this->_parser, 'parse']);
-        $this->_parser->on('element', function (...$arguments) {
+        $this->_parser->on('element', function(...$arguments) {
             $this->emit('element', $arguments);
         });
-        $this->on('close', function () { $this->_isOpened = false; });
+        $this->on('close', function() { $this->_isOpened = false; });
     }
 
     /**
@@ -106,7 +106,7 @@ 
      */
     public function write($data)
     {
-        $this->emit('send.'.($data instanceof XmlElement ? 'element' : 'text'), [ $data ]);
+        $this->emit('send.' . ($data instanceof XmlElement ? 'element' : 'text'), [$data]);
 
         return parent::write($data);
     }
@@ -136,7 +136,7 @@ 
      */
     public function close()
     {
-        if($this->isOpened()) {
+        if ($this->isOpened()) {
             $this->write('</stream:stream>');
             $this->_isOpened = false;
         }
@@ -171,7 +171,7 @@ 
 
     private function handleError(Error $element)
     {
-        if($this->emit('stream.error', [ $element ])) {
+        if ($this->emit('stream.error', [$element])) {
             throw new StreamErrorException($element);
         }
 

Network/Connector/TcpXmppConnector.php

Spacing +3 added lines, -3 removed lines

@@ -41,14 +41,14 @@
                 'port' => $port
             ]);
 
-            if($stream = @stream_socket_client("tcp://$ip:$port")) {
+            if ($stream = @stream_socket_client("tcp://$ip:$port")) {
                 $stream = new TcpStream($stream, $this->_loop);
-                $this->emit('connect', [ $stream ]);
+                $this->emit('connect', [$stream]);
                 return $stream;
             }
         }
 
-        throw new \RuntimeException('Cannot connect to '.$this->_host);
+        throw new \RuntimeException('Cannot connect to ' . $this->_host);
     }
 
     public function __construct(string $host, LoopInterface $loop)