kadet1090 / nucleus

Xml/XmlElement.php

Doc Comments +1 added lines, -1 removed lines

@@ -258,7 +258,7 @@
      *
      * @param string      $attribute Attribute name, optionally with prefix
      * @param string|null $uri       XML Namespace URI of attribute, prefix will be automatically looked up
-     * @return bool|mixed
+     * @return string
      */
     public function getAttribute(string $attribute, string $uri = null)
     {

Spacing +15 added lines, -15 removed lines

@@ -136,7 +136,7 @@ 
      */
     public function getInnerXml()
     {
-        return implode('', array_map(function ($element) {
+        return implode('', array_map(function($element) {
             if (is_string($element)) {
                 return htmlspecialchars($element);
             } elseif ($element instanceof XmlElement) {
@@ -181,7 +181,7 @@ 
         $attributes = $this->attributes();
 
         $result = "<{$this->fullName}";
-        $result .= ' ' . implode(' ', array_map(function ($key, $value) {
+        $result .= ' ' . implode(' ', array_map(function($key, $value) {
             return $key . '="' . htmlspecialchars($value, ENT_QUOTES) . '"';
         }, array_keys($attributes), array_values($attributes)));
 
@@ -202,7 +202,7 @@ 
      */
     public function lookupPrefix(string $uri = null)
     {
-        return $this->getNamespaces()[ $uri ] ?? false;
+        return $this->getNamespaces()[$uri] ?? false;
     }
 
     /**
@@ -246,12 +246,12 @@ 
     {
         $attribute = $this->_prefix($attribute, $uri);
         if ($value === null) {
-            unset($this->_attributes[ $attribute ]);
+            unset($this->_attributes[$attribute]);
 
             return;
         }
 
-        $this->_attributes[ $attribute ] = $value;
+        $this->_attributes[$attribute] = $value;
     }
 
     /**
@@ -263,7 +263,7 @@ 
      */
     public function getAttribute(string $attribute, string $uri = null)
     {
-        return $this->_attributes[ $this->_prefix($attribute, $uri) ] ?? false;
+        return $this->_attributes[$this->_prefix($attribute, $uri)] ?? false;
     }
 
     /**
@@ -276,7 +276,7 @@ 
      */
     public function hasAttribute(string $attribute, string $uri = null)
     {
-        return isset($this->_attributes[ $this->_prefix($attribute, $uri) ]);
+        return isset($this->_attributes[$this->_prefix($attribute, $uri)]);
     }
 
     /**
@@ -285,7 +285,7 @@ 
      */
     public function getParents()
     {
-        return $this->_parent ? array_merge([ $this->_parent ], $this->_parent->getParents()) : [];
+        return $this->_parent ? array_merge([$this->_parent], $this->_parent->getParents()) : [];
     }
 
     /**
@@ -304,7 +304,7 @@ 
     protected function setParent(XmlElement $parent)
     {
         if (!$this->_prefix && ($prefix = $parent->lookupPrefix($this->namespace)) !== false) {
-            $this->_namespaces[ $this->namespace ] = $prefix;
+            $this->_namespaces[$this->namespace] = $prefix;
             $this->_prefix                         = $prefix;
         }
 
@@ -327,7 +327,7 @@ 
             return false;
         }
 
-        if(is_array($element)) {
+        if (is_array($element)) {
             array_walk($element, [$this, 'appendChild']);
             return $element;
         }
@@ -337,14 +337,14 @@ 
 
     public function remove($element)
     {
-        if(!$element instanceof \Closure) {
+        if (!$element instanceof \Closure) {
             $element = is_array($element) ? filter\in($element) : filter\same($element);
         }
         $old = $this->_children;
         $this->_children = array_filter($this->_children, not($element));
 
         foreach (array_diff($old, $this->_children) as $removed) {
-            if($removed instanceof XmlElement) {
+            if ($removed instanceof XmlElement) {
                 $removed->_parent = null;
             }
         }
@@ -395,7 +395,7 @@ 
             $prefix = $this->_prefix;
         }
 
-        $this->_namespaces[ $uri ] = $prefix;
+        $this->_namespaces[$uri] = $prefix;
     }
 
     public function getFullName()
@@ -443,7 +443,7 @@ 
      */
     public function element(string $name, string $uri = null, int $index = 0)
     {
-        return array_values($this->elements($name, $uri))[ $index ] ?? false;
+        return array_values($this->elements($name, $uri))[$index] ?? false;
     }
 
     /**
@@ -524,7 +524,7 @@ 
     private function attributes(): array
     {
         $namespaces = $this->getNamespaces(false);
-        $namespaces = array_map(function ($prefix, $uri) {
+        $namespaces = array_map(function($prefix, $uri) {
             return [$prefix ? "xmlns:{$prefix}" : 'xmlns', $uri];
         }, array_values($namespaces), array_keys($namespaces));
 

Component/Roster.php

Doc Comments -1 removed lines

@@ -184,7 +184,6 @@
     }
 
     /**
-     * @param callable(Item $item) $mapper
      * @return array
      */
     public function map(callable $mapper)

Spacing +4 added lines, -4 removed lines

@@ -62,7 +62,7 @@ 
     private function handleSet(Iq\Query\Roster $query)
     {
         foreach ($query->items as $item) {
-            if($item->subscription == 'remove') {
+            if ($item->subscription == 'remove') {
                 $this->removeItem($item->jid);
             } else {
                 $this->setItem($item);
@@ -151,7 +151,7 @@ 
 
         $iq = new Iq('remove', ['query' => new Iq\Query\Roster()]);
         /** @var Iq\Query\Roster\Item $item */
-        foreach($remove as $item) {
+        foreach ($remove as $item) {
             $iq->query->append(new Iq\Query\Roster\Item($item->jid, ['subscription' => 'remove']));
         }
 
@@ -228,7 +228,7 @@ 
 
     private function setItem(Iq\Query\Roster\Item $item)
     {
-        $this->emit('item', [ $item ]);
+        $this->emit('item', [$item]);
         $this->_items[(string)$item->jid] = $item;
     }
 
@@ -241,7 +241,7 @@ 
             return;
         }
 
-        $this->emit('remove', [ $this->_items[(string)$jid] ]);
+        $this->emit('remove', [$this->_items[(string)$jid]]);
         unset($this->_items[(string)$jid]);
     }
 }

Stanza/Iq.php

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use Kadet\Xmpp\Jid;
 use Kadet\Xmpp\Stanza\Iq\Query;
 use function Kadet\Xmpp\Utils\filter\pass;
-use Kadet\Xmpp\Xml\XmlElement;
 
 /**
  * Represents IQ Stanza

Stanza/Iq/Query/Roster.php

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
 
     protected function appendChild($element)
     {
-        if(!$element instanceof Item) {
+        if (!$element instanceof Item) {
             throw new InvalidArgumentException(format('Only instances of roster item ({expected}) can be added into roster, tried to add {actual}', [
                 'expected' => Item::class,
                 'actual'   => get_class($element)
@@ -99,7 +99,7 @@ 
     public static function getXmlCollocations() : array
     {
         return [
-            [ Item::class, 'name' => 'item', 'uri' => 'jabber:iq:roster' ]
+            [Item::class, 'name' => 'item', 'uri' => 'jabber:iq:roster']
         ];
     }
 }

XmppClient.php

Spacing +11 added lines, -11 removed lines

@@ -148,17 +148,17 @@ 
 
         $this->applyOptions($options);
 
-        $this->on('element', function (Features $element) {
+        $this->on('element', function(Features $element) {
             $this->_features = $element;
             $this->emit('features', [$element]);
         }, Features::class);
 
-        $this->on('element', function (Stanza $stanza) {
-            $this->emit('stanza', [ $stanza ]);
-            $this->emit($stanza->localName, [ $stanza ]);
+        $this->on('element', function(Stanza $stanza) {
+            $this->emit('stanza', [$stanza]);
+            $this->emit($stanza->localName, [$stanza]);
         }, Stanza::class);
 
-        $this->on('close', function () {
+        $this->on('close', function() {
             $this->state = 'disconnected';
         });
     }
@@ -211,7 +211,7 @@ 
         $this->state = 'bound';
 
         $queue = new \SplQueue();
-        $this->emit('init', [ $queue ]);
+        $this->emit('init', [$queue]);
 
         \React\Promise\all(iterator_to_array($queue))->then(function() {
             $this->state = 'ready';
@@ -235,10 +235,10 @@ 
 
         if ($alias === true) {
             $this->_addToContainer($module, array_merge(class_implements($module), array_slice(class_parents($module), 1)));
-        } elseif(is_array($alias)) {
+        } elseif (is_array($alias)) {
             $this->_addToContainer($module, $alias);
         } else {
-            $this->_addToContainer($module, [ $alias === false ? get_class($module) : $alias ]);
+            $this->_addToContainer($module, [$alias === false ? get_class($module) : $alias]);
         }
     }
 
@@ -261,7 +261,7 @@ 
         $deferred = new Deferred();
 
         $this->once('element', function(Stanza $stanza) use ($deferred) {
-            if($stanza->type === "error") {
+            if ($stanza->type === "error") {
                 $deferred->reject($stanza);
             } else {
                 $deferred->resolve($stanza);
@@ -297,7 +297,7 @@ 
     //region Parser
     public function setParser(XmlParser $parser)
     {
-        if($this->state !== "disconnected") {
+        if ($this->state !== "disconnected") {
             throw new \BadMethodCallException('Parser can be changed only when client is disconnected.');
         }
 
@@ -325,7 +325,7 @@ 
             ));
         }
 
-        $this->_connector->on('connect', function ($stream) {
+        $this->_connector->on('connect', function($stream) {
             return $this->handleConnect($stream);
         });
     }

Sasl/DigestMD5.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public function createResponse($challenge = null)
     {
-        if(strpos($challenge, 'rspauth=') !== false) {
+        if (strpos($challenge, 'rspauth=') !== false) {
             return '';
         }
 

Utils/filter.php

Spacing +19 added lines, -19 removed lines

@@ -34,7 +34,7 @@ 
  */
 function equals($value) : \Closure
 {
-    return function ($argument) use ($value) {
+    return function($argument) use ($value) {
         return $argument == $value;
     };
 }
@@ -55,7 +55,7 @@ 
  */
 function same($value) : \Closure
 {
-    return function ($argument) use ($value) {
+    return function($argument) use ($value) {
         return $argument === $value;
     };
 }
@@ -77,7 +77,7 @@ 
  */
 function instance($expected) : \Closure
 {
-    return function ($object) use ($expected) {
+    return function($object) use ($expected) {
         return $expected instanceof \Closure ? $expected(get_class($object)) : $object instanceof $expected;
     };
 }
@@ -103,7 +103,7 @@ 
  */
 function matches($regex, ...$options) : \Closure
 {
-    return function ($value) use ($regex, $options) {
+    return function($value) use ($regex, $options) {
         return preg_match($regex, $value, $null, ...$options) > 0;
     };
 }
@@ -122,7 +122,7 @@ 
  * @return \Closure
  */
 function in(...$options) {
-    return function ($value) use ($options) {
+    return function($value) use ($options) {
         return in_array($value, $options);
     };
 }
@@ -142,10 +142,10 @@ 
  */
 function contains($value)
 {
-    if($value instanceof \Closure) {
-        return function (array $array) use ($value) {
+    if ($value instanceof \Closure) {
+        return function(array $array) use ($value) {
             foreach ($array as $item) {
-                if($value($item)) {
+                if ($value($item)) {
                     return true;
                 }
             }
@@ -154,7 +154,7 @@ 
         };
     }
 
-    return function (array $array) use ($value) {
+    return function(array $array) use ($value) {
         return array_search($value, $array) !== false;
     };
 }
@@ -174,7 +174,7 @@ 
  */
 function has($key)
 {
-    return function (array $array) use ($key) {
+    return function(array $array) use ($key) {
         return (contains($key))(array_keys($array));
     };
 }
@@ -248,7 +248,7 @@ 
  */
 function all(callable ...$functions) : \Closure
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if (!$function(...$args)) {
                 return false;
@@ -277,7 +277,7 @@ 
  */
 function any(callable ...$functions) : \Closure
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if ($function(...$args)) {
                 return true;
@@ -321,7 +321,7 @@ 
  */
 function not(callable $predicate) : \Closure
 {
-    return function (...$arguments) use ($predicate) {
+    return function(...$arguments) use ($predicate) {
         return !$predicate(...$arguments);
     };
 }
@@ -349,13 +349,13 @@ 
  */
 function argument(int $offset, callable $predicate, $length = true) : \Closure
 {
-    if($length === true) {
+    if ($length === true) {
         $length = 1;
-    } elseif($length === false) {
+    } elseif ($length === false) {
         $length = null;
     }
 
-    return function (...$arguments) use ($predicate, $offset, $length) {
+    return function(...$arguments) use ($predicate, $offset, $length) {
         return $predicate(...array_slice($arguments, $offset, $length, false));
     };
 }
@@ -378,9 +378,9 @@ 
  */
 function consecutive(callable ...$predicates)
 {
-    return function (...$arguments) use ($predicates) {
+    return function(...$arguments) use ($predicates) {
         foreach ($arguments as $index => $value) {
-            if(!$predicates[$index]($value)) {
+            if (!$predicates[$index]($value)) {
                 return false;
             }
         }
@@ -392,7 +392,7 @@ 
 function property($name, $value) {
     $predicate = $value instanceof \Closure ? $value : \Kadet\Xmpp\Utils\filter\equals($value);
 
-    return function ($element) use ($name, $predicate) {
+    return function($element) use ($name, $predicate) {
         return $predicate($element->$name);
     };
 }

Utils/helper.php

Spacing +8 added lines, -8 removed lines

@@ -26,9 +26,9 @@ 
 function typeof($value) : string
 {
     if (is_object($value)) {
-        return "object of type ".get_class($value);
+        return "object of type " . get_class($value);
     } elseif (is_resource($value)) {
-        return get_resource_type($value).' resource';
+        return get_resource_type($value) . ' resource';
     }
 
     return gettype($value);
@@ -36,10 +36,10 @@ 
 
 function partial(callable $callable, $argument, int $position = 0) : callable
 {
-    return function (...$arguments) use ($callable, $argument, $position) {
+    return function(...$arguments) use ($callable, $argument, $position) {
         $arguments = array_merge(
             array_slice($arguments, 0, $position),
-            [ $argument ],
+            [$argument],
             array_slice($arguments, $position)
         );
 
@@ -49,12 +49,12 @@ 
 
 function dd($value)
 {
-    echo Dumper::get()->dump($value).PHP_EOL.PHP_EOL;
+    echo Dumper::get()->dump($value) . PHP_EOL . PHP_EOL;
 }
 
 function format($string, array $arguments = [])
 {
-    return str_replace(array_map(function ($e) { return "{{$e}}"; }, array_keys($arguments)), $arguments, $string);
+    return str_replace(array_map(function($e) { return "{{$e}}"; }, array_keys($arguments)), $arguments, $string);
 }
 
 function rearrange(array $array, array $keys) : array
@@ -69,9 +69,9 @@ 
 function copy(array $array)
 {
     return array_map(function($element) {
-        if(is_array($element)) {
+        if (is_array($element)) {
             return copy($element);
-        } elseif(is_object($element)) {
+        } elseif (is_object($element)) {
             return clone $element;
         }