kadet1090 / nucleus

Stanza/Stanza.php

Spacing +5 added lines, -5 removed lines

@@ -53,7 +53,7 @@ 
 
     public function getFrom()
     {
-        if((string)$this->_from !== $this->hasAttribute('from')) {
+        if ((string)$this->_from !== $this->hasAttribute('from')) {
             $this->_from = $this->hasAttribute('from') ? new Jid($this->_from) : null;
         }
 
@@ -62,7 +62,7 @@ 
 
     public function getTo()
     {
-        if((string)$this->_to !== $this->hasAttribute('to')) {
+        if ((string)$this->_to !== $this->hasAttribute('to')) {
             $this->_to = $this->hasAttribute('to') ? new Jid($this->_to) : null;
         }
 
@@ -86,7 +86,7 @@ 
 
     public function setFrom($from)
     {
-        if($from instanceof Jid) {
+        if ($from instanceof Jid) {
             $this->_from = $from instanceof Jid ? $from : new Jid($from);
         }
 
@@ -95,7 +95,7 @@ 
 
     public function setTo($to)
     {
-        if($to instanceof Jid) {
+        if ($to instanceof Jid) {
             $this->_to = $to instanceof Jid ? $to : new Jid($to);
         }
 
@@ -131,7 +131,7 @@ 
     public static function getXmlCollocations() : array
     {
         return [
-            [ Error::class, 'name' => 'error', 'uri' => 'jabber:client' ],
+            [Error::class, 'name' => 'error', 'uri' => 'jabber:client'],
         ];
     }
 }

Xml/XmlParser.php

Spacing +11 added lines, -11 removed lines

@@ -71,13 +71,13 @@ 
         xml_parser_set_option($this->_parser, XML_OPTION_SKIP_WHITE, 1);
         xml_parser_set_option($this->_parser, XML_OPTION_CASE_FOLDING, 0);
 
-        xml_set_element_handler($this->_parser, function ($parser, $name, $attrs) {
+        xml_set_element_handler($this->_parser, function($parser, $name, $attrs) {
             $this->handleElementStart($name, $attrs);
-        }, function () {
+        }, function() {
             $this->handleElementEnd();
         });
 
-        xml_set_character_data_handler($this->_parser, function ($parser, $data) {
+        xml_set_character_data_handler($this->_parser, function($parser, $data) {
             $this->handleTextData($data);
         });
 
@@ -111,8 +111,8 @@ 
             return 'http://www.w3.org/2000/xmlns/';
         }
 
-        if (isset($namespaces[ $prefix ])) {
-            return $namespaces[ $prefix ];
+        if (isset($namespaces[$prefix])) {
+            return $namespaces[$prefix];
         }
 
         return !empty($this->_stack) ? end($this->_stack)->lookupUri($prefix) : null;
@@ -123,10 +123,10 @@ 
         list($attributes, $namespaces) = $this->_attributes($attrs);
         list($tag, $prefix)            = XmlElement::resolve($name);
 
-        $uri   = $this->_lookup($prefix, $namespaces);
+        $uri = $this->_lookup($prefix, $namespaces);
 
         /** @var XmlElement $element */
-        $element = $this->factory->create($uri, $tag, [ $name, $uri ], $this->_getCollocations());
+        $element = $this->factory->create($uri, $tag, [$name, $uri], $this->_getCollocations());
 
         foreach ($namespaces as $prefix => $uri) {
             $element->setNamespace($uri, $prefix);
@@ -140,7 +140,7 @@ 
 
     private function _getCollocations()
     {
-        if(empty($this->_stack)) {
+        if (empty($this->_stack)) {
             return [];
         }
 
@@ -159,7 +159,7 @@ 
         if (count($this->_stack) > 0) {
             end($this->_stack)->append($element);
         }
-        $this->emit('parse.begin', [ $element, count($this->_stack) ]);
+        $this->emit('parse.begin', [$element, count($this->_stack)]);
 
         $this->_stack[] = $element;
     }
@@ -172,10 +172,10 @@ 
 
         $element = array_pop($this->_stack);
         if (count($this->_stack) == 1) {
-            $this->emit('element', [ $element, count($this->_stack) ]);
+            $this->emit('element', [$element, count($this->_stack)]);
         }
 
-        $this->emit('parse.end', [ $element, count($this->_stack) ]);
+        $this->emit('parse.end', [$element, count($this->_stack)]);
     }
 
     private function handleTextData($data)

Xml/XmlStream.php

Spacing +13 added lines, -13 removed lines

@@ -91,35 +91,35 @@ 
         parent::__construct($transport);
         $this->setParser($parser);
 
-        $this->on('close', function () { $this->_isOpened = false; });
-        $this->on('element', function (Error $element) {
+        $this->on('close', function() { $this->_isOpened = false; });
+        $this->on('element', function(Error $element) {
             $this->handleError($element);
         }, with\instance(Error::class));
     }
 
     public function setParser(XmlParser $parser)
     {
-        if($this->_parser) {
-            $this->removeListener('data', [ $this->_parser, 'parse' ]);
+        if ($this->_parser) {
+            $this->removeListener('data', [$this->_parser, 'parse']);
         }
 
         $this->_parser = $parser;
 
-        $this->_parser->on('parse.begin', function (XmlElement $stream) {
+        $this->_parser->on('parse.begin', function(XmlElement $stream) {
             $this->_inbound = $stream;
-            $this->emit('stream.open', [ $stream ]);
+            $this->emit('stream.open', [$stream]);
         }, with\argument(1, with\equals(0)));
 
-        $this->_parser->on('parse.end', function (XmlElement $stream) {
-            $this->emit('stream.close', [ $stream ]);
+        $this->_parser->on('parse.end', function(XmlElement $stream) {
+            $this->emit('stream.close', [$stream]);
             $this->_inbound = null;
         }, with\argument(1, with\equals(0)));
 
-        $this->_parser->on('element', function (...$arguments) {
+        $this->_parser->on('element', function(...$arguments) {
             $this->emit('element', $arguments);
         });
 
-        $this->on('data', [ $this->_parser, 'parse' ]);
+        $this->on('data', [$this->_parser, 'parse']);
     }
 
     /**
@@ -130,11 +130,11 @@ 
      */
     public function write($data)
     {
-        if($data instanceof XmlElement) {
+        if ($data instanceof XmlElement) {
             $this->_outbound->append($data);
         }
 
-        $this->emit('send.'.($data instanceof XmlElement ? 'element' : 'text'), [ $data ]);
+        $this->emit('send.' . ($data instanceof XmlElement ? 'element' : 'text'), [$data]);
 
         return parent::write($data);
     }
@@ -195,7 +195,7 @@ 
 
     private function handleError(Error $element)
     {
-        if ($this->emit('stream.error', [ $element ])) {
+        if ($this->emit('stream.error', [$element])) {
             throw new StreamErrorException($element);
         }
 

Xml/XmlElement.php

Doc Comments +1 added lines, -1 removed lines

@@ -258,7 +258,7 @@
      *
      * @param string      $attribute Attribute name, optionally with prefix
      * @param string|null $uri       XML Namespace URI of attribute, prefix will be automatically looked up
-     * @return bool|mixed
+     * @return string
      */
     public function getAttribute(string $attribute, string $uri = null)
     {

Spacing +15 added lines, -15 removed lines

@@ -136,7 +136,7 @@ 
      */
     public function getInnerXml()
     {
-        return implode('', array_map(function ($element) {
+        return implode('', array_map(function($element) {
             if (is_string($element)) {
                 return htmlspecialchars($element);
             } elseif ($element instanceof XmlElement) {
@@ -181,7 +181,7 @@ 
         $attributes = $this->attributes();
 
         $result = "<{$this->fullName}";
-        $result .= ' ' . implode(' ', array_map(function ($key, $value) {
+        $result .= ' ' . implode(' ', array_map(function($key, $value) {
             return $key . '="' . htmlspecialchars($value, ENT_QUOTES) . '"';
         }, array_keys($attributes), array_values($attributes)));
 
@@ -202,7 +202,7 @@ 
      */
     public function lookupPrefix(string $uri = null)
     {
-        return $this->getNamespaces()[ $uri ] ?? false;
+        return $this->getNamespaces()[$uri] ?? false;
     }
 
     /**
@@ -246,12 +246,12 @@ 
     {
         $attribute = $this->_prefix($attribute, $uri);
         if ($value === null) {
-            unset($this->_attributes[ $attribute ]);
+            unset($this->_attributes[$attribute]);
 
             return;
         }
 
-        $this->_attributes[ $attribute ] = $value;
+        $this->_attributes[$attribute] = $value;
     }
 
     /**
@@ -263,7 +263,7 @@ 
      */
     public function getAttribute(string $attribute, string $uri = null)
     {
-        return $this->_attributes[ $this->_prefix($attribute, $uri) ] ?? false;
+        return $this->_attributes[$this->_prefix($attribute, $uri)] ?? false;
     }
 
     /**
@@ -276,7 +276,7 @@ 
      */
     public function hasAttribute(string $attribute, string $uri = null)
     {
-        return isset($this->_attributes[ $this->_prefix($attribute, $uri) ]);
+        return isset($this->_attributes[$this->_prefix($attribute, $uri)]);
     }
 
     /**
@@ -285,7 +285,7 @@ 
      */
     public function getParents()
     {
-        return $this->_parent ? array_merge([ $this->_parent ], $this->_parent->getParents()) : [];
+        return $this->_parent ? array_merge([$this->_parent], $this->_parent->getParents()) : [];
     }
 
     /**
@@ -304,7 +304,7 @@ 
     protected function setParent(XmlElement $parent)
     {
         if (!$this->_prefix && ($prefix = $parent->lookupPrefix($this->namespace)) !== false) {
-            $this->_namespaces[ $this->namespace ] = $prefix;
+            $this->_namespaces[$this->namespace] = $prefix;
             $this->_prefix                         = $prefix;
         }
 
@@ -327,7 +327,7 @@ 
             return false;
         }
 
-        if(is_array($element)) {
+        if (is_array($element)) {
             array_walk($element, [$this, 'appendChild']);
             return $element;
         }
@@ -337,14 +337,14 @@ 
 
     public function remove($element)
     {
-        if(!$element instanceof \Closure) {
+        if (!$element instanceof \Closure) {
             $element = is_array($element) ? filter\in($element) : filter\same($element);
         }
         $old = $this->_children;
         $this->_children = array_filter($this->_children, not($element));
 
         foreach (array_diff($old, $this->_children) as $removed) {
-            if($removed instanceof XmlElement) {
+            if ($removed instanceof XmlElement) {
                 $removed->_parent = null;
             }
         }
@@ -395,7 +395,7 @@ 
             $prefix = $this->_prefix;
         }
 
-        $this->_namespaces[ $uri ] = $prefix;
+        $this->_namespaces[$uri] = $prefix;
     }
 
     public function getFullName()
@@ -443,7 +443,7 @@ 
      */
     public function element(string $name, string $uri = null, int $index = 0)
     {
-        return array_values($this->elements($name, $uri))[ $index ] ?? false;
+        return array_values($this->elements($name, $uri))[$index] ?? false;
     }
 
     /**
@@ -524,7 +524,7 @@ 
     private function attributes(): array
     {
         $namespaces = $this->getNamespaces(false);
-        $namespaces = array_map(function ($prefix, $uri) {
+        $namespaces = array_map(function($prefix, $uri) {
             return [$prefix ? "xmlns:{$prefix}" : 'xmlns', $uri];
         }, array_values($namespaces), array_keys($namespaces));
 

Xml/XmlElementFactory.php

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
         }
 
         foreach ($lookup['<predicate>'] as list($class, $predicate)) {
-            if($predicate($tag, $namespace)) {
+            if ($predicate($tag, $namespace)) {
                 return $class;
             }
         }
@@ -64,7 +64,7 @@ 
     {
         $result = ['<predicate>' => []];
         foreach ($dictionary as $element) {
-            if($element['name'] instanceof \Closure || $element['uri'] instanceof \Closure) {
+            if ($element['name'] instanceof \Closure || $element['uri'] instanceof \Closure) {
                 $result['<predicate>'][] = [$element[0], \Kadet\Xmpp\Utils\filter\consecutive(
                     \Kadet\Xmpp\Utils\filter\predicate($element['name']),
                     \Kadet\Xmpp\Utils\filter\predicate($element['uri'])

Component/Binding.php

Spacing +4 added lines, -4 removed lines

@@ -31,18 +31,18 @@ 
     {
         parent::setClient($client);
 
-        $client->on('features', function (Features $features) {
+        $client->on('features', function(Features $features) {
             return !$this->bind($features);
         });
     }
 
     public function bind(Features $features)
     {
-        if($features->has(with\element('bind', self::XMLNS))) {
+        if ($features->has(with\element('bind', self::XMLNS))) {
             $stanza = new Stanza('iq', ['attributes' => ['type' => 'set']]);
             $bind = $stanza->append(new XmlElement('bind', self::XMLNS));
 
-            if(!$this->_client->jid->isBare()) {
+            if (!$this->_client->jid->isBare()) {
                 $bind->append(new XmlElement('resource', null, ['content' => $this->_client->jid->resource]));
             }
 
@@ -59,7 +59,7 @@ 
 
     public function handleResult(Stanza $stanza)
     {
-        if($stanza->type === 'error') {
+        if ($stanza->type === 'error') {
             throw BindingException::fromError($this->_client->jid, $stanza->error);
         }
 

Component/TlsEnabler.php

Spacing +2 added lines, -2 removed lines

@@ -29,11 +29,11 @@
     {
         parent::setClient($client);
 
-        $client->on('features', function (Features $features) {
+        $client->on('features', function(Features $features) {
             return $this->handleFeatures($features);
         }, null, 10);
 
-        $client->on('element', function (XmlElement $element) {
+        $client->on('element', function(XmlElement $element) {
             $this->handleTls($element);
         }, with\xmlns(Features\StartTls::XMLNS));
     }

Component/SaslAuthenticator.php

Spacing +6 added lines, -6 removed lines

@@ -59,7 +59,7 @@ 
     {
         parent::setClient($client);
 
-        $client->on('features', function (Features $features) {
+        $client->on('features', function(Features $features) {
             return !$this->auth($features);
         });
     }
@@ -68,7 +68,7 @@ 
     {
         if (!empty($features->mechanisms)) {
             foreach ($features->mechanisms as $name) {
-                if($this->tryMechanism($name)) {
+                if ($this->tryMechanism($name)) {
                     return true;
                 }
             }
@@ -112,11 +112,11 @@ 
             $response = '=';
         }
 
-        $callback = $this->_client->on('element', function (XmlElement $challenge) use ($mechanism) {
+        $callback = $this->_client->on('element', function(XmlElement $challenge) use ($mechanism) {
             $this->handleChallenge($challenge, $mechanism);
         }, with\all(with\tag('challenge'), with\xmlns(self::XMLNS)));
 
-        $this->_client->once('element', function (XmlElement $result) use ($callback) {
+        $this->_client->once('element', function(XmlElement $result) use ($callback) {
             $this->_client->removeListener('element', $callback);
             $this->handleAuthResult($result);
         }, with\all(with\any(with\tag('success'), with\tag('failure')), with\xmlns(self::XMLNS)));
@@ -126,7 +126,7 @@ 
 
     private function mechanismWithoutChallenge(AuthenticationInterface $mechanism)
     {
-        $this->_client->once('element', function (XmlElement $result) {
+        $this->_client->once('element', function(XmlElement $result) {
             $this->handleAuthResult($result);
         }, with\all(with\any(with\tag('success'), with\tag('failure')), with\xmlns(self::XMLNS)));
 
@@ -144,7 +144,7 @@ 
     private function handleAuthResult(XmlElement $result)
     {
         if ($result->localName === 'failure') {
-            throw new AuthenticationException('Unable to auth. '.trim($result->innerXml));
+            throw new AuthenticationException('Unable to auth. ' . trim($result->innerXml));
         }
 
         $this->_client->getLogger()->info('Successfully authorized as {name}.', ['name' => (string)$this->_client->jid]);

Stanza/Iq.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
 
     protected function appendChild($element)
     {
-        if(count($this->children) > 0) {
+        if (count($this->children) > 0) {
             throw new \RuntimeException('Iq stanzas cannot have more than one child.');
         }
 
@@ -77,7 +77,7 @@ 
     public static function getXmlCollocations() : array
     {
         return array_merge(
-            [[ Query::class, 'name' => pass(), 'uri' => pass() ]],
+            [[Query::class, 'name' => pass(), 'uri' => pass()]],
             parent::getXmlCollocations()
         );
     }

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use Kadet\Xmpp\Jid;
 use Kadet\Xmpp\Stanza\Iq\Query;
 use function Kadet\Xmpp\Utils\filter\pass;
-use Kadet\Xmpp\Xml\XmlElement;
 
 /**
  * Represents IQ Stanza